Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-04-07
08:23:04 bauzas gibi: just by adding the property and then just modifying the tests to no longer call init_host()
08:23:11 bauzas it will simplify the testrs
08:23:34 bauzas (and I'll clarify the comment to explain that we don't call placement so we're all fine)
08:24:46 gibi thanks
08:34:14 jkulik gibi, you've given your +2 on https://review.opendev.org/#/c/713863/ and after some discussion the -1 is gone, too. Is there anything left to do? Do we wait for other reviewers?
08:35:37 gibi jkulik: I hope melwitt will have time to get back to it as in general we need two +2 votes to merge a patch.
08:36:08 jkulik Ah, didn't know that. Thank you.
08:36:11 openstackgerrit xulei proposed openstack/nova master: Add unit test for nova-api _check_metadata_properties_quota https://review.opendev.org/717981
08:38:10 gibi jkulik: this week is feature freeze so most of the reviews are busy finishing up feature reviews so it might take time to get the another +2 on your bug. I suggest to ping melwitt early next week
08:42:54 jkulik Sure, thanks. Just wanted to know what's the holdup and if I can do anything.
08:44:28 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Integrate mypy https://review.opendev.org/676208
08:44:29 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Update and correct typing information https://review.opendev.org/714694
08:44:29 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Add typing information https://review.opendev.org/714695
08:44:30 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Split instance NUMA object tests https://review.opendev.org/714696
08:44:30 openstackgerrit Stephen Finucane proposed openstack/nova master: objects: Replace 'cpu_pinning_requested' helper https://review.opendev.org/714697
08:44:31 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Don't consider overhead CPUs for unpinned instances https://review.opendev.org/714698
08:44:31 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Remove handling of pre-Train compute nodes https://review.opendev.org/714699
08:44:32 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Add validation for 'cpu_realtime_mask' https://review.opendev.org/468203
08:44:32 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Tweak the 'cpu_realtime_mask' handling slightly https://review.opendev.org/461456
08:44:33 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Rework 'get_realtime_constraint' https://review.opendev.org/714700
08:44:33 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Invert order of NUMA topology generation https://review.opendev.org/714701
08:44:34 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Remove '_numa_fit_instance_cell_with_pinning' https://review.opendev.org/714703
08:44:34 openstackgerrit Stephen Finucane proposed openstack/nova master: Introduce 'pcpuset' field for InstanceNUMACell https://review.opendev.org/714658
08:51:45 openstackgerrit Sylvain Bauza proposed openstack/nova master: Provide the parent pGPU when creating a new vGPU https://review.opendev.org/715489
08:51:46 openstackgerrit Sylvain Bauza proposed openstack/nova master: Support different vGPU types per pGPU https://review.opendev.org/715490
08:51:46 openstackgerrit Sylvain Bauza proposed openstack/nova master: DNM: Functional test with pGPUs https://review.opendev.org/717975
08:51:53 bauzas gibi: updated based on your remarks ^
08:52:41 gibi bauzas: ack
08:52:59 bauzas gibi: had to change a few unittests, you helped me to fix a few details
08:53:07 gibi cool
08:53:38 bauzas TIL init_host() is not really called when initing the host :p
08:56:34 gibi I alway have to look up the code to see what is the init order
09:13:44 openstackgerrit Stephen Finucane proposed openstack/nova master: Drop concept of '?validation' parameter https://review.opendev.org/717789
09:13:44 openstackgerrit Stephen Finucane proposed openstack/nova master: api: Add microversion for extra spec validation https://review.opendev.org/708436
09:13:45 openstackgerrit Stephen Finucane proposed openstack/nova master: docs: Add documentation for flavor extra specs https://review.opendev.org/710037
09:34:01 openstackgerrit Guo Jingyu proposed openstack/nova master: WIP: nova supports password encrypted VNC https://review.opendev.org/622336
09:38:05 nightmare_unreal hello can someone review this : https://review.opendev.org/#/c/715395/ . Not sure why Zuul verification is failing
09:38:06 nightmare_unreal thanks
09:42:58 gibi nightmare_unreal: the zuul failure seems to be unrelated.
09:43:53 nightmare_unreal Yeah, I was not sure why it is failing. It had merge conflict. I resolved it and since then it's -1 from zuul
09:44:09 nightmare_unreal I did checked before submitting, ( pre-commit, pep8 and others)
09:58:14 nightmare_unreal thanks for the review
09:59:23 huaqiang stephenfin: can you have a look for this ? url:https://review.opendev.org/#/c/714658/4/nova/objects/instance_numa.py@87
09:59:37 huaqiang and do you agree with my reply for your comments?
10:01:13 stephenfin huaqiang: I need to dig into it, to be honest. I think you should just include a summary of what you said as a note for now. We can bring it up again if needed
10:02:04 huaqiang sure, I'll provide a note.
10:02:51 lyarwood stephenfin: not sure if you saw my ping re https://review.opendev.org/#/c/708436/ earlier?
10:02:56 stephenfin I did not
10:03:01 lyarwood stephenfin: https://review.opendev.org/#/c/708436/17 - Stupid question, so this doesn't need doc/api_samples and nova/tests/functional/api_sample_tests/api_samples/ updates as you're not changing request/responses in this microversion right?
10:03:06 lyarwood stephenfin: asking as I've added them in https://review.opendev.org/#/c/701430/ assuming we needed to do this regardless, if we don't I can rm -rf this from that change.
10:03:29 lyarwood stephenfin: just about to rebase on your change and take the next microversion btw
10:03:36 stephenfin lyarwood: I'd assumed not, but tbh I'm not certain. Maybe gibi would know?
10:03:56 stephenfin I'm not sure why you'd need them if you're not changing the request or response
10:05:25 lyarwood stephenfin: yeah right, I can't recall why I added these originally tbh, I assume something was failing but that clearly isn't the case in your change
10:05:28 gibi stephenfin, lyarwood: did query param removed too?
10:05:49 stephenfin gibi: In my change? Yeah
10:06:15 gibi I guess I mixing changes
10:06:28 openstackgerrit jayaditya gupta proposed openstack/nova master: Support for --overwrite flag for nova-manage placement heal_allocations command Closes-Bug:#1868997 https://review.opendev.org/715395
10:06:36 lyarwood yeah that isn't part of the microversion change
10:06:49 lyarwood nothing changes in the request or response for that change
10:07:14 lyarwood I'm just going to rm -rf my samples changes from mine while I rebase
10:07:28 gibi so neither lyarwood nor stephenfin's change introduce any request or response or query string change
10:07:41 gibi so both patch is OK without api sample
10:07:49 lyarwood ack, thanks for clearing that up
10:08:15 openstackgerrit Stephen Finucane proposed openstack/nova master: Correct server shelve policy check_str https://review.opendev.org/717542
10:14:21 openstackgerrit Stephen Finucane proposed openstack/nova master: Correct server topology policy check_str https://review.opendev.org/717525
10:16:40 lyarwood stephenfin: ah, you didn't fetch and rebase on origin/master, any chance you could so I can rebase on https://review.opendev.org/#/c/708436/ ?
10:17:27 lyarwood stephenfin: otherwise I end up pulling in loads of stuff that has already merged between your HEAD and origin/master when I rebase on your change
10:18:07 stephenfin lyarwood: If I do, the bottom patch will get kicked out of the gate queue :( Do you depend on any of that additional stuff being pulled in from master? If not, can you just delete it?
10:18:43 lyarwood stephenfin: ah sorry didn't see that was in the gate, assumed it hadn't been picked up in the check queue yet
10:18:51 lyarwood stephenfin: yeah I can trim things down for now
10:18:57 nightmare_unreal is there a devstack specific channel ?
10:19:20 sean-k-mooney its #openstack-qa
10:19:47 sean-k-mooney nightmare_unreal: ^
10:19:56 nightmare_unreal thanks sean-k-mooney
10:50:04 openstackgerrit Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811
10:50:04 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812
10:50:05 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429
10:50:05 openstackgerrit Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.87 allowing boot from volume rescue https://review.opendev.org/701430
10:50:06 openstackgerrit Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212
10:50:06 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431
10:51:42 openstackgerrit Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.84 - action event fault details https://review.opendev.org/714561
10:51:50 openstackgerrit Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651
10:51:59 openstackgerrit Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.86 - Stable device boot from volume rescue https://review.opendev.org/714956
10:52:55 lyarwood stephenfin: I was about to move these around
10:53:20 stephenfin oh, sorry. I just rebased them
10:53:35 lyarwood np do you have a change for 2.86?
10:53:53 lyarwood I'll create one now if not
10:54:02 stephenfin Not yet, no
10:54:17 lyarwood kk 2 secs
10:58:10 gibi bauzas: feedback in https://review.opendev.org/#/c/715490 (I have to go back and review the test later)
10:59:46 openstackgerrit Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956
10:59:46 openstackgerrit Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057
10:59:49 lyarwood stephenfin: ^ there you go
11:00:22 stephenfin thanks :)
11:02:39 bauzas gibi: thanks, I'll look at them after lunching
11:03:40 openstackgerrit John Garbutt proposed openstack/nova master: Fix configure() called after DatabaseAtVersion fixture https://review.opendev.org/619723
11:06:30 sean-k-mooney given the recet conversations on the topic stephenfin lyarwood do you have osc changes for the same? if those are noops just bumping the max version in novaclinet i guess they are not needed but if actully added something osc might want to be extended too
11:10:10 huaqiang stephenfin: I prepared a summary and a detail analysis in this link:https://etherpad.openstack.org/p/versioned_object-obj_from_primitive-behavior
11:10:32 huaqiang please have a look when you have time.

Earlier   Later