| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-07 | |||
| 11:03:40 | openstackgerrit | John Garbutt proposed openstack/nova master: Fix configure() called after DatabaseAtVersion fixture https://review.opendev.org/619723 | |
| 11:06:30 | sean-k-mooney | given the recet conversations on the topic stephenfin lyarwood do you have osc changes for the same? if those are noops just bumping the max version in novaclinet i guess they are not needed but if actully added something osc might want to be extended too | |
| 11:10:10 | huaqiang | stephenfin: I prepared a summary and a detail analysis in this link:https://etherpad.openstack.org/p/versioned_object-obj_from_primitive-behavior | |
| 11:10:32 | huaqiang | please have a look when you have time. | |
| 11:11:06 | huaqiang | and the content is in RST format, it will have a better look if you check it in a RST reader. | |
| 11:14:13 | sean-k-mooney | stephenfin: by the way any chance we could land this https://review.opendev.org/#/c/700894/ we both kind of forgot about it but noticed it on lee's review dashboard yesterday | |
| 11:14:59 | lyarwood | sean-k-mooney: no I didn't have anything for osc | |
| 11:15:21 | sean-k-mooney | lyarwood: cool just said i would ask. | |
| 11:17:34 | lyarwood | kk np | |
| 11:52:14 | lyarwood | stephenfin: https://review.opendev.org/#/q/status:open+topic:workaround_native_luksv1+project:openstack/nova - would you mind hitting these today if you have any time? | |
| 12:09:56 | brinzhang | lyarwood: https://review.opendev.org/#/c/712651/13/novaclient/tests/unit/v2/test_shell.py@4006 I think this test is ok, I replied your comment | |
| 12:12:00 | brinzhang | lyarwood: because we changed the PUT API, I think we should add the older feature test, and ensure it runs ok, do you think so? | |
| 12:13:55 | bauzas | gibi: no worries about looking at the func test, it's just a WIP now | |
| 12:14:02 | brinzhang | lyarwood: https://review.opendev.org/#/c/711194/ this policy change patch, I dont think I got dansmith want to say, so I was not rebased on, | |
| 12:14:18 | bauzas | gibi: I provided it because you could look at why it wasn't working for you | |
| 12:15:15 | brinzhang | lyarwood: I also agree with you, that can change the depends-on to the policy sparate patch, that we can better control the microversion 2.85 | |
| 12:15:22 | gibi | bauzas: ack. I also did not look at the unit test on the main patch. but will at some point | |
| 12:34:39 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: DNM: (WIP) Functional test with pGPUs https://review.opendev.org/717975 | |
| 12:40:41 | lyarwood | brinzhang: replied in the change, I just wanted to assert that the same call is made if --delete-on-termination isn't provided from 2.85 | |
| 12:41:03 | lyarwood | brinzhang: your other tests didn't check this | |
| 12:42:16 | brinzhang | lyarwood: ok, Got it, I will update it. | |
| 12:42:55 | brinzhang | lyarwood: thanks | |
| 12:44:12 | lyarwood | brinzhang: thanks :) | |
| 12:49:18 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | |
| 12:49:43 | brinzhang | lyarwood: update done ^^ | |
| 12:54:20 | stephenfin | lyarwood: any chance of getting a TODO for https://review.opendev.org/#/c/708030/8, per comment? | |
| 12:55:19 | lyarwood | brinzhang: ack thanks | |
| 12:55:22 | lyarwood | stephenfin: looking | |
| 12:55:46 | lyarwood | stephenfin: yeah sure | |
| 12:56:06 | stephenfin | A follow-up is fine, btw | |
| 12:56:33 | lyarwood | stephenfin: that would be easier yeah thanks | |
| 12:59:07 | stephenfin | lyarwood: As for the second one, is there any reason someone would set disable_native_luksv1 but not rbd_volume_local_attach ? | |
| 12:59:56 | lyarwood | stephenfin: Yes, if they are using a non-RBD Cinder Volume backend and LUKSv1 encrypted volumes. | |
| 13:00:04 | lyarwood | stephenfin: like LVM/iSCSI etc. | |
| 13:00:22 | stephenfin | Ah, of course /o\ Fair fair | |
| 13:02:37 | brinzhang | lyarwood: thanks | |
| 13:08:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add removal TODOs for disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/718099 | |
| 13:08:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Fix [workarounds]/rbd_volume_local_attach config docs https://review.opendev.org/718100 | |
| 13:08:37 | lyarwood | stephenfin: ^ thanks again | |
| 13:08:44 | hrw | morning | |
| 13:09:38 | hrw | lyarwood: you commented https://review.opendev.org/#/c/714311/3/nova/virt/libvirt/driver.py@5323 with 'supernit - return'. I do not understand. What do you mean there? | |
| 13:11:49 | lyarwood | hrw: morning, by supernit I mean something that is beyond a normal nit (a small issue with a change) and as such not something I'd actually ask someone to respin the change to correct. | |
| 13:12:18 | lyarwood | hrw: here I was just suggesting that you could just return instead of using support_uefi | |
| 13:12:29 | hrw | lyarwood: ok | |
| 13:13:14 | hrw | lyarwood: I see now. | |
| 13:13:34 | lyarwood | hrw: yeah apologies if it wasn't clear, +1 on the change anyway. | |
| 13:13:35 | hrw | lyarwood: it was copied from one place, adapted and reused. | |
| 13:13:38 | sean-k-mooney | hrw by convention in python if a varible is not used in the same function and is just returned we should just retrun the expression | |
| 13:14:02 | hrw | yeah | |
| 13:14:25 | sean-k-mooney | but its not important enough to actully repin a patch over as lyarwood said | |
| 13:14:40 | openstackgerrit | Luyao Zhong proposed openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | |
| 13:14:41 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Support live migration with vpmem https://review.opendev.org/687856 | |
| 13:14:41 | hrw | just with amount of comments around that comment took me a while to notice which part of line it applied to ;D | |
| 13:15:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add removal TODOs for disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/718099 | |
| 13:16:48 | luyao | stephenfin: Thanks for review :), your comments are addressed. https://review.opendev.org/687856 | |
| 13:25:02 | stephenfin | cool | |
| 13:26:17 | stephenfin | lyarwood: could you take a look at https://review.opendev.org/715406 and its predecessor to close that out? | |
| 13:26:53 | lyarwood | stephenfin: yup looking | |
| 13:35:01 | stephenfin | sean-k-mooney: replied on https://review.opendev.org/#/c/700894/ | |
| 13:36:30 | sean-k-mooney | ok. ill take a look at it sortly. that said i tried doing it a few different ways and without a significant rewrite this was the cleanest way i could do it | |
| 13:40:22 | dansmith | brinzhang: are you able to work on that policy patch? | |
| 13:45:16 | sean-k-mooney | stephenfin: in anycase ill take a look again and rebase it ontop of your mock lib removal patch | |
| 13:45:46 | stephenfin | sean-k-mooney: don't rebase it - that mock removal patch is having teething issues and won't be finished this week | |
| 13:46:11 | stephenfin | specifically I'm hitting bugs in the stdlib mock libraries that I'm having to work around :( | |
| 13:46:39 | sean-k-mooney | stephenfin: ok | |
| 13:46:44 | sean-k-mooney | i didnt want it to conflict | |
| 13:46:58 | sean-k-mooney | stephenfin: or bugs in mock the lib | |
| 13:47:34 | sean-k-mooney | stephenfin: i have hit bugs with the mock lib before so its proably that we work around those initally now we need to return to the normal behavior | |
| 13:47:41 | stephenfin | afaict, mock the lib is a straight backport of the stdlib library | |
| 13:48:00 | stephenfin | so we'd presumably see the same issues if we downgraded to e.g. mock 2.0 | |
| 13:48:16 | sean-k-mooney | stephenfin: it is ment to be yes but im not sure that is always true | |
| 14:37:00 | gibi | nova api experts, how can I specify a config_drive filter of GET /server/details to get the servers that does not have a config drive | |
| 14:37:03 | gibi | ? | |
| 14:37:48 | gibi | GET /servers/detail?config_drive=& is rejected by the schema | |
| 14:38:19 | gibi | GET /servers/detail?config_drive=False returns empty list even if I have servers without config drive | |
| 14:39:21 | gibi | config_drive in the response is defined like | |
| 14:39:23 | gibi | "Indicates whether or not a config drive was used for this server. The value is True or an empty string. An empty string stands for False." | |
| 14:41:31 | gibi | https://bugs.launchpad.net/nova/+bug/1871409 | |
| 14:41:32 | openstack | Launchpad bug 1871409 in OpenStack Compute (nova) "cannot filter the list servers to show only those that does not have config drive" [Undecided,New] | |
| 14:51:22 | openstackgerrit | Arthur Dayne proposed openstack/nova master: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/682772 | |
| 15:02:40 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: WIP: fix config_drive filter in GET /servers/details https://review.opendev.org/718140 | |
| 15:10:32 | gibi | stephenfin: in https://review.opendev.org/682772 do you mean accepting boolean like values or do you also mean defaulting config_drive to False if not present? | |
| 15:10:42 | stephenfin | just the former | |
| 15:10:48 | stephenfin | sorry, that wasn't clear | |
| 15:11:31 | gibi | stephenfin: no worries. I just discovered this bug while trying to make the 2.83 client patch to work | |
| 15:13:10 | gibi | stephenfin: so for boolean like True value we should translate the filter to True and for a boolean like False value translate it to empty string? or keep the empty string as False semantic as in the response today? | |
| 15:15:01 | stephenfin | so 'GET /servers/details?config_drive=' will get us servers without a config drive? We probably need to retain that behavior, if so | |
| 15:15:22 | gibi | stephenfin: currently 'GET /servers/details?config_drive=' is not accepted by the schema | |
| 15:15:42 | stephenfin | what do you mean by the empty string, in that case? | |
| 15:15:46 | gibi | stephenfin: the respons of GET servers/details use empty value in the config_drive field to indicate no config drive (crazy) | |
| 15:16:04 | stephenfin | Ah | |
| 15:16:21 | gibi | https://docs.openstack.org/api-ref/compute/?expanded=list-servers-detailed-detail#id21 | |
| 15:16:23 | stephenfin | I guess we've to keep that the same, but I don't think the filter needs to work like that | |
| 15:17:09 | stephenfin | We could change that API response in a future clean up microversion | |
| 15:17:22 | gibi | so the API response will keep using True or "", the filter in the query will use truelike or falselike values | |
| 15:17:44 | stephenfin | Yeah, that's sensible IMO | |
| 15:17:47 | gibi | OK, thanks | |
| 15:17:53 | gibi | I will do that then | |
| 15:18:04 | stephenfin | No point letting the crazy spread into the query string too | |
| 15:18:24 | gibi | gmann: Do we alredy have an API cleanup item for the crazy config drive value in https://docs.openstack.org/api-ref/compute/?expanded=list-servers-detailed-detail#id21 | |