| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2020-04-07 | |||
| 10:06:28 | openstackgerrit | jayaditya gupta proposed openstack/nova master: Support for --overwrite flag for nova-manage placement heal_allocations command Closes-Bug:#1868997 https://review.opendev.org/715395 | |
| 10:06:36 | lyarwood | yeah that isn't part of the microversion change | |
| 10:06:49 | lyarwood | nothing changes in the request or response for that change | |
| 10:07:14 | lyarwood | I'm just going to rm -rf my samples changes from mine while I rebase | |
| 10:07:28 | gibi | so neither lyarwood nor stephenfin's change introduce any request or response or query string change | |
| 10:07:41 | gibi | so both patch is OK without api sample | |
| 10:07:49 | lyarwood | ack, thanks for clearing that up | |
| 10:08:15 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Correct server shelve policy check_str https://review.opendev.org/717542 | |
| 10:14:21 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Correct server topology policy check_str https://review.opendev.org/717525 | |
| 10:16:40 | lyarwood | stephenfin: ah, you didn't fetch and rebase on origin/master, any chance you could so I can rebase on https://review.opendev.org/#/c/708436/ ? | |
| 10:17:27 | lyarwood | stephenfin: otherwise I end up pulling in loads of stuff that has already merged between your HEAD and origin/master when I rebase on your change | |
| 10:18:07 | stephenfin | lyarwood: If I do, the bottom patch will get kicked out of the gate queue :( Do you depend on any of that additional stuff being pulled in from master? If not, can you just delete it? | |
| 10:18:43 | lyarwood | stephenfin: ah sorry didn't see that was in the gate, assumed it hadn't been picked up in the check queue yet | |
| 10:18:51 | lyarwood | stephenfin: yeah I can trim things down for now | |
| 10:18:57 | nightmare_unreal | is there a devstack specific channel ? | |
| 10:19:20 | sean-k-mooney | its #openstack-qa | |
| 10:19:47 | sean-k-mooney | nightmare_unreal: ^ | |
| 10:19:56 | nightmare_unreal | thanks sean-k-mooney | |
| 10:50:04 | openstackgerrit | Lee Yarwood proposed openstack/nova master: virt: Provide block_device_info during rescue https://review.opendev.org/700811 | |
| 10:50:04 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add support for stable device rescue https://review.opendev.org/700812 | |
| 10:50:05 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Report COMPUTE_RESCUE_BFV and check during rescue https://review.opendev.org/701429 | |
| 10:50:05 | openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Introduce microverion 2.87 allowing boot from volume rescue https://review.opendev.org/701430 | |
| 10:50:06 | openstackgerrit | Lee Yarwood proposed openstack/nova master: compute: Extract _get_bdm_image_metadata into nova.utils https://review.opendev.org/705212 | |
| 10:50:06 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Support boot from volume stable device instance rescue https://review.opendev.org/701431 | |
| 10:51:42 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.84 - action event fault details https://review.opendev.org/714561 | |
| 10:51:50 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | |
| 10:51:59 | openstackgerrit | Stephen Finucane proposed openstack/python-novaclient master: Microversion 2.86 - Stable device boot from volume rescue https://review.opendev.org/714956 | |
| 10:52:55 | lyarwood | stephenfin: I was about to move these around | |
| 10:53:20 | stephenfin | oh, sorry. I just rebased them | |
| 10:53:35 | lyarwood | np do you have a change for 2.86? | |
| 10:53:53 | lyarwood | I'll create one now if not | |
| 10:54:02 | stephenfin | Not yet, no | |
| 10:54:17 | lyarwood | kk 2 secs | |
| 10:58:10 | gibi | bauzas: feedback in https://review.opendev.org/#/c/715490 (I have to go back and review the test later) | |
| 10:59:46 | openstackgerrit | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.87 - Stable device boot from volume rescue https://review.opendev.org/714956 | |
| 10:59:46 | openstackgerrit | Lee Yarwood proposed openstack/python-novaclient master: Microversion 2.86 - Extra spec validation https://review.opendev.org/718057 | |
| 10:59:49 | lyarwood | stephenfin: ^ there you go | |
| 11:00:22 | stephenfin | thanks :) | |
| 11:02:39 | bauzas | gibi: thanks, I'll look at them after lunching | |
| 11:03:40 | openstackgerrit | John Garbutt proposed openstack/nova master: Fix configure() called after DatabaseAtVersion fixture https://review.opendev.org/619723 | |
| 11:06:30 | sean-k-mooney | given the recet conversations on the topic stephenfin lyarwood do you have osc changes for the same? if those are noops just bumping the max version in novaclinet i guess they are not needed but if actully added something osc might want to be extended too | |
| 11:10:10 | huaqiang | stephenfin: I prepared a summary and a detail analysis in this link:https://etherpad.openstack.org/p/versioned_object-obj_from_primitive-behavior | |
| 11:10:32 | huaqiang | please have a look when you have time. | |
| 11:11:06 | huaqiang | and the content is in RST format, it will have a better look if you check it in a RST reader. | |
| 11:14:13 | sean-k-mooney | stephenfin: by the way any chance we could land this https://review.opendev.org/#/c/700894/ we both kind of forgot about it but noticed it on lee's review dashboard yesterday | |
| 11:14:59 | lyarwood | sean-k-mooney: no I didn't have anything for osc | |
| 11:15:21 | sean-k-mooney | lyarwood: cool just said i would ask. | |
| 11:17:34 | lyarwood | kk np | |
| 11:52:14 | lyarwood | stephenfin: https://review.opendev.org/#/q/status:open+topic:workaround_native_luksv1+project:openstack/nova - would you mind hitting these today if you have any time? | |
| 12:09:56 | brinzhang | lyarwood: https://review.opendev.org/#/c/712651/13/novaclient/tests/unit/v2/test_shell.py@4006 I think this test is ok, I replied your comment | |
| 12:12:00 | brinzhang | lyarwood: because we changed the PUT API, I think we should add the older feature test, and ensure it runs ok, do you think so? | |
| 12:13:55 | bauzas | gibi: no worries about looking at the func test, it's just a WIP now | |
| 12:14:02 | brinzhang | lyarwood: https://review.opendev.org/#/c/711194/ this policy change patch, I dont think I got dansmith want to say, so I was not rebased on, | |
| 12:14:18 | bauzas | gibi: I provided it because you could look at why it wasn't working for you | |
| 12:15:15 | brinzhang | lyarwood: I also agree with you, that can change the depends-on to the policy sparate patch, that we can better control the microversion 2.85 | |
| 12:15:22 | gibi | bauzas: ack. I also did not look at the unit test on the main patch. but will at some point | |
| 12:34:39 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: DNM: (WIP) Functional test with pGPUs https://review.opendev.org/717975 | |
| 12:40:41 | lyarwood | brinzhang: replied in the change, I just wanted to assert that the same call is made if --delete-on-termination isn't provided from 2.85 | |
| 12:41:03 | lyarwood | brinzhang: your other tests didn't check this | |
| 12:42:16 | brinzhang | lyarwood: ok, Got it, I will update it. | |
| 12:42:55 | brinzhang | lyarwood: thanks | |
| 12:44:12 | lyarwood | brinzhang: thanks :) | |
| 12:49:18 | openstackgerrit | Brin Zhang proposed openstack/python-novaclient master: Microversion 2.85: Change volume-update CLI https://review.opendev.org/712651 | |
| 12:49:43 | brinzhang | lyarwood: update done ^^ | |
| 12:54:20 | stephenfin | lyarwood: any chance of getting a TODO for https://review.opendev.org/#/c/708030/8, per comment? | |
| 12:55:19 | lyarwood | brinzhang: ack thanks | |
| 12:55:22 | lyarwood | stephenfin: looking | |
| 12:55:46 | lyarwood | stephenfin: yeah sure | |
| 12:56:06 | stephenfin | A follow-up is fine, btw | |
| 12:56:33 | lyarwood | stephenfin: that would be easier yeah thanks | |
| 12:59:07 | stephenfin | lyarwood: As for the second one, is there any reason someone would set disable_native_luksv1 but not rbd_volume_local_attach ? | |
| 12:59:56 | lyarwood | stephenfin: Yes, if they are using a non-RBD Cinder Volume backend and LUKSv1 encrypted volumes. | |
| 13:00:04 | lyarwood | stephenfin: like LVM/iSCSI etc. | |
| 13:00:22 | stephenfin | Ah, of course /o\ Fair fair | |
| 13:02:37 | brinzhang | lyarwood: thanks | |
| 13:08:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add removal TODOs for disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/718099 | |
| 13:08:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Fix [workarounds]/rbd_volume_local_attach config docs https://review.opendev.org/718100 | |
| 13:08:37 | lyarwood | stephenfin: ^ thanks again | |
| 13:08:44 | hrw | morning | |
| 13:09:38 | hrw | lyarwood: you commented https://review.opendev.org/#/c/714311/3/nova/virt/libvirt/driver.py@5323 with 'supernit - return'. I do not understand. What do you mean there? | |
| 13:11:49 | lyarwood | hrw: morning, by supernit I mean something that is beyond a normal nit (a small issue with a change) and as such not something I'd actually ask someone to respin the change to correct. | |
| 13:12:18 | lyarwood | hrw: here I was just suggesting that you could just return instead of using support_uefi | |
| 13:12:29 | hrw | lyarwood: ok | |
| 13:13:14 | hrw | lyarwood: I see now. | |
| 13:13:34 | lyarwood | hrw: yeah apologies if it wasn't clear, +1 on the change anyway. | |
| 13:13:35 | hrw | lyarwood: it was copied from one place, adapted and reused. | |
| 13:13:38 | sean-k-mooney | hrw by convention in python if a varible is not used in the same function and is just returned we should just retrun the expression | |
| 13:14:02 | hrw | yeah | |
| 13:14:25 | sean-k-mooney | but its not important enough to actully repin a patch over as lyarwood said | |
| 13:14:40 | openstackgerrit | Luyao Zhong proposed openstack/nova master: partial support for live migration with specific resources https://review.opendev.org/715362 | |
| 13:14:41 | openstackgerrit | Luyao Zhong proposed openstack/nova master: Support live migration with vpmem https://review.opendev.org/687856 | |
| 13:14:41 | hrw | just with amount of comments around that comment took me a while to notice which part of line it applied to ;D | |
| 13:15:19 | openstackgerrit | Lee Yarwood proposed openstack/nova master: fup: Add removal TODOs for disable_native_luksv1 and rbd_volume_local_attach https://review.opendev.org/718099 | |
| 13:16:48 | luyao | stephenfin: Thanks for review :), your comments are addressed. https://review.opendev.org/687856 | |
| 13:25:02 | stephenfin | cool | |
| 13:26:17 | stephenfin | lyarwood: could you take a look at https://review.opendev.org/715406 and its predecessor to close that out? | |
| 13:26:53 | lyarwood | stephenfin: yup looking | |
| 13:35:01 | stephenfin | sean-k-mooney: replied on https://review.opendev.org/#/c/700894/ | |
| 13:36:30 | sean-k-mooney | ok. ill take a look at it sortly. that said i tried doing it a few different ways and without a significant rewrite this was the cleanest way i could do it | |
| 13:40:22 | dansmith | brinzhang: are you able to work on that policy patch? | |