| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-11-17 | |||
| 08:13:58 | gtema | you just take this full message as the new commit | |
| 08:14:11 | thomasb06 | understood | |
| 08:21:36 | thomasb06 | Here it is: https://review.opendev.org/c/openstack/openstacksdk/+/818202 | |
| 08:39:42 | thomasb06 | Is it ok, it looks weird to have two ChangeIds in the UI? | |
| 08:39:52 | gtema | you should have only one | |
| 08:40:36 | gtema | you produced new change. I think your hook has not properly identified change-id in the commit (maybe missing line break) | |
| 08:41:01 | gtema | in this case just drop the original id in the new change and abandon the old one | |
| 08:46:20 | thomasb06 | you were right, it was just a newline missing. The old one is fine now: https://review.opendev.org/c/openstack/openstacksdk/+/816785 | |
| 08:46:44 | thomasb06 | If it's ok for you, I can delete the new commit? | |
| 08:47:40 | thomasb06 | (which is 818202) | |
| 08:50:34 | gtema | yupp, can be | |
| 08:58:54 | thomasb06 | Unless I forgot some _proxy.py files, this it is. Would you have other docstrings to fix, my script is ready? | |
| 11:42:17 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: image: Remove dead test helper methods https://review.opendev.org/c/openstack/python-openstackclient/+/818223 | |
| 11:42:17 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: image: Remove FakeImage test helper https://review.opendev.org/c/openstack/python-openstackclient/+/818224 | |
| 11:42:18 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Update fake image client in tests https://review.opendev.org/c/openstack/python-openstackclient/+/818225 | |
| 11:42:18 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: image: Sanity check the 'SetImage' command https://review.opendev.org/c/openstack/python-openstackclient/+/818226 | |
| 14:08:28 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | |
| 19:21:11 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | |
| #openstack-sdks - 2021-11-18 | |||
| 01:55:26 | opendevreview | melanie witt proposed openstack/python-openstackclient master: Add 'Host Status' to 'server list --long' with >= v2.16 https://review.opendev.org/c/openstack/python-openstackclient/+/818306 | |
| 03:23:57 | opendevreview | melanie witt proposed openstack/python-openstackclient master: Add 'Host Status' to 'server list --long' with >= v2.16 https://review.opendev.org/c/openstack/python-openstackclient/+/818306 | |
| 05:22:39 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 06:46:53 | isabek | gtema: Good morning! This patches ready for review: https://review.opendev.org/c/openstack/openstacksdk/+/814765 and https://review.opendev.org/c/openstack/python-openstackclient/+/805618 . depends-on patch was merged | |
| 06:47:45 | isabek | Can you please take a look? Thanks a lot! | |
| 16:32:34 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 17:11:23 | opendevreview | Rodolfo Alonso proposed openstack/openstacksdk master: Add "check_limit" to network Quota class https://review.opendev.org/c/openstack/openstacksdk/+/806254 | |
| #openstack-sdks - 2021-11-19 | |||
| 00:34:44 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 03:25:20 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 12:58:09 | opendevreview | Jiri Podivin proposed openstack/cliff master: Removing modindex link from docs https://review.opendev.org/c/openstack/cliff/+/818547 | |
| 14:24:58 | opendevreview | Merged openstack/cliff master: Removing modindex link from docs https://review.opendev.org/c/openstack/cliff/+/818547 | |
| 20:35:14 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 21:34:29 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 21:37:33 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 21:38:02 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 22:07:44 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server pause and server unpause to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817853 | |
| 22:12:32 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | |
| 22:41:31 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | |
| #openstack-sdks - 2021-11-21 | |||
| 04:44:53 | opendevreview | SaeBom Lee proposed openstack/python-openstackclient master: Fix bug that image creation with volume https://review.opendev.org/c/openstack/python-openstackclient/+/818683 | |
| 05:07:57 | opendevreview | Jieon Lee proposed openstack/python-openstackclient master: Add missing command mapping in nova https://review.opendev.org/c/openstack/python-openstackclient/+/818684 | |
| #openstack-sdks - 2021-11-22 | |||
| 15:54:59 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | |
| 16:01:40 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | |
| 16:07:17 | opendevreview | Daniel Speichert proposed openstack/openstacksdk master: fix: improperly encoded object names https://review.opendev.org/c/openstack/openstacksdk/+/818795 | |
| 16:09:47 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 18:14:07 | ivan__ | Hello everyone. I am trying to use an admin account to create a server instance for a given user by supplying user_id. This seems to work unless I also supply the user's ssh key (through argument key_name). The SDK is trying to look that key_name up under the admin’s account rather than under user’s account. Can I tell the create_server functions to use the user’s key? Or, is there a workaround that I can use?. | |
| 18:17:58 | gtema | I guess workaround is to use the plain SDK/create_server call, it doesn't do such validation | |
| 18:20:51 | gtema | I mean conn.compute.create_server | |
| 18:49:17 | ivan__ | gtema: I just tried that, but the same happened... To elaborate a bit, I am using connect_as_project() to try to 'impersonate' the user, but the key_name lookup still happens under admin user (I know this since, if I use a key_name that exists under admin, the server creation succeeds). | |
| 18:57:21 | gtema | Ha, do you mean nova itself does this? | |
| 19:00:26 | gtema | Well, in this case you have no other choice as to physically reconnect as user, alternate you import same key under admin user - it's anyway just a pub key | |
| 19:01:47 | ivan__ | Is there a way to connect as the user without knowing their password? | |
| 19:05:33 | gtema | Depending on particular cloud, but natively no | |
| 19:35:54 | frickler | the connect_as_project() only overrides project_id, but keypairs are user-based ressources in nova. with "openstack keypair list --user demo --debug" you can see the public key though, not sure if the sdk exposes that | |
| 19:55:17 | ivan__ | frickler: SDK exposes the keypair commands for a given user_id, but it does not seem to allow specifying user_id when creating a server for the purposes of looking up the key_name. | |
| 19:56:37 | frickler | ivan__: yes, you would have to fetch the users pubkey and create a keypair with that as your admin user | |
| #openstack-sdks - 2021-11-23 | |||
| 13:53:22 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 15:36:08 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 17:03:53 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 18:24:09 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 21:16:22 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Allow unset port's host_id https://review.opendev.org/c/openstack/python-openstackclient/+/819024 | |
| #openstack-sdks - 2021-11-24 | |||
| 00:14:29 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 00:15:41 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/819036 | |
| 00:17:11 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 00:23:46 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 00:28:32 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 00:31:26 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 05:51:20 | opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Temporarily drop aodhclient from doc build https://review.opendev.org/c/openstack/python-openstackclient/+/819055 | |
| 08:46:39 | przszc | Hi. Can any of the core reviewers take a look at https://review.opendev.org/c/openstack/openstacksdk/+/810364? I was hoping to get it included in Yoga-1 milestone release. | |
| 08:57:35 | frickler | gtema: ^^ how big are chances for r1 making it into yoga? also it seems that the osc-tips job doesn't work with patches for that branch https://zuul.opendev.org/t/openstack/build/ff1ea63b9b4e4368afc72cf5eab866ab | |
| 08:58:15 | gtema | frickler, I was going to spend December on finishing work there (have PTO which I will spend for that) | |
| 08:58:34 | gtema | then r1 can land approx end of Dec or January | |
| 09:00:16 | gtema | and yeah, osc-tips and as such func test seem to have some issues which I was not able to find so far | |
| 09:06:41 | frickler | gtema: o.k., so that would mean yoga-2 if things go well. I'll try to do some testing and reviews, too | |
| 09:07:00 | gtema | this is my current target | |
| 12:09:46 | opendevreview | Merged openstack/python-openstackclient master: Temporarily drop aodhclient from doc build https://review.opendev.org/c/openstack/python-openstackclient/+/819055 | |
| 21:28:37 | slaweq | gtema: hi, can You take a look at https://review.opendev.org/c/openstack/python-openstackclient/+/819024 when You will have few minutes? thx in advance | |
| #openstack-sdks - 2021-11-25 | |||
| 08:30:43 | thomasb06 | gtema: Hello. The Compute docstring stays in error, but it doesn't seem related with my modifications: https://review.opendev.org/c/openstack/openstacksdk/+/816785 | |
| 08:31:58 | thomasb06 | By the way, would you have something else to give to me? | |
| 08:32:29 | gtema | it does - line 776 - you have 2 odd spaces | |
| 08:34:45 | gtema | actually since you are already on the docstrings there are some more things to fix - in some proxy methods apparently type of the return is not really being accepted properly what results in broken link | |
| 08:34:58 | gtema | i.e. https://docs.openstack.org/openstacksdk/latest/user/proxies/network.html - remove_gateway_from_router method | |
| 08:35:20 | gtema | I assume this is due to the line break in the rtype macro | |
| 08:35:49 | gtema | so it would be great if you can do another walk through proxies and have a look where those are broken | |
| 08:36:22 | thomasb06 | line 776, fixed | |
| 08:41:24 | thomasb06 | Regarding the remove_gateway_from_router method, the docstrings has ":rtype: :class: `~openstack.network.v2.router.Router`" without line break (after executing `git pull origin feature/r1`) | |
| 08:42:46 | gtema | yeah, but there is space in between ":class: `~openstack.network.v2.router.Router`" | |
| 08:43:00 | gtema | between :class: and the `~...` | |
| 08:43:10 | thomasb06 | understood | |
| 08:43:35 | thomasb06 | Let me take care of it | |
| 08:43:42 | gtema | cool, thks | |
| 08:44:09 | thomasb06 | (my CV says 'thanks you guys', hehe...) | |
| 08:44:25 | gtema | i.e. https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/network/v2/_proxy.py#L780 the line is broken (find_local_ip_association method) | |
| 08:46:09 | gtema | same stuff for validate_auto_allocated_topology - I assume it can be in multiple places (you can verify in the rendered docs (i.e. on https://cf484ceb1edd89d30dfe-675a54f2682a71ce0a87525368caccbf.ssl.cf5.rackcdn.com/816785/2/check/openstack-tox-docs/14f9fb4/docs/user/index.html#api-documentation | |
| 08:46:29 | gtema | that is the link to built artifacts from your last change | |
| 08:46:47 | gtema | there you go under "Service Proxies" | |
| 08:47:00 | thomasb06 | so it should be :class:`openstack.service.version.variable`, with no space, and on it's own line if a line break splits it? | |
| 08:47:15 | gtema | yes | |
| 08:47:34 | gtema | basically :class:`whatever` - this all must be on the same line | |
| 08:50:14 | thomasb06 | ok, I track them down | |
| 08:50:24 | gtema | awesome | |
| 08:55:29 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 09:38:39 | isabek | gtema: Hi! Can you please take a look [1] when you have a time. Thanks! 1) https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |