| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-11-22 | |||
| 16:07:17 | opendevreview | Daniel Speichert proposed openstack/openstacksdk master: fix: improperly encoded object names https://review.opendev.org/c/openstack/openstacksdk/+/818795 | |
| 16:09:47 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 18:14:07 | ivan__ | Hello everyone. I am trying to use an admin account to create a server instance for a given user by supplying user_id. This seems to work unless I also supply the user's ssh key (through argument key_name). The SDK is trying to look that key_name up under the admin’s account rather than under user’s account. Can I tell the create_server functions to use the user’s key? Or, is there a workaround that I can use?. | |
| 18:17:58 | gtema | I guess workaround is to use the plain SDK/create_server call, it doesn't do such validation | |
| 18:20:51 | gtema | I mean conn.compute.create_server | |
| 18:49:17 | ivan__ | gtema: I just tried that, but the same happened... To elaborate a bit, I am using connect_as_project() to try to 'impersonate' the user, but the key_name lookup still happens under admin user (I know this since, if I use a key_name that exists under admin, the server creation succeeds). | |
| 18:57:21 | gtema | Ha, do you mean nova itself does this? | |
| 19:00:26 | gtema | Well, in this case you have no other choice as to physically reconnect as user, alternate you import same key under admin user - it's anyway just a pub key | |
| 19:01:47 | ivan__ | Is there a way to connect as the user without knowing their password? | |
| 19:05:33 | gtema | Depending on particular cloud, but natively no | |
| 19:35:54 | frickler | the connect_as_project() only overrides project_id, but keypairs are user-based ressources in nova. with "openstack keypair list --user demo --debug" you can see the public key though, not sure if the sdk exposes that | |
| 19:55:17 | ivan__ | frickler: SDK exposes the keypair commands for a given user_id, but it does not seem to allow specifying user_id when creating a server for the purposes of looking up the key_name. | |
| 19:56:37 | frickler | ivan__: yes, you would have to fetch the users pubkey and create a keypair with that as your admin user | |
| #openstack-sdks - 2021-11-23 | |||
| 13:53:22 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 15:36:08 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 17:03:53 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 18:24:09 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 21:16:22 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Allow unset port's host_id https://review.opendev.org/c/openstack/python-openstackclient/+/819024 | |
| #openstack-sdks - 2021-11-24 | |||
| 00:14:29 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 00:15:41 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/819036 | |
| 00:17:11 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 00:23:46 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 00:28:32 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 00:31:26 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 05:51:20 | opendevreview | Dr. Jens Harbott proposed openstack/python-openstackclient master: Temporarily drop aodhclient from doc build https://review.opendev.org/c/openstack/python-openstackclient/+/819055 | |
| 08:46:39 | przszc | Hi. Can any of the core reviewers take a look at https://review.opendev.org/c/openstack/openstacksdk/+/810364? I was hoping to get it included in Yoga-1 milestone release. | |
| 08:57:35 | frickler | gtema: ^^ how big are chances for r1 making it into yoga? also it seems that the osc-tips job doesn't work with patches for that branch https://zuul.opendev.org/t/openstack/build/ff1ea63b9b4e4368afc72cf5eab866ab | |
| 08:58:15 | gtema | frickler, I was going to spend December on finishing work there (have PTO which I will spend for that) | |
| 08:58:34 | gtema | then r1 can land approx end of Dec or January | |
| 09:00:16 | gtema | and yeah, osc-tips and as such func test seem to have some issues which I was not able to find so far | |
| 09:06:41 | frickler | gtema: o.k., so that would mean yoga-2 if things go well. I'll try to do some testing and reviews, too | |
| 09:07:00 | gtema | this is my current target | |
| 12:09:46 | opendevreview | Merged openstack/python-openstackclient master: Temporarily drop aodhclient from doc build https://review.opendev.org/c/openstack/python-openstackclient/+/819055 | |
| 21:28:37 | slaweq | gtema: hi, can You take a look at https://review.opendev.org/c/openstack/python-openstackclient/+/819024 when You will have few minutes? thx in advance | |
| #openstack-sdks - 2021-11-25 | |||
| 08:30:43 | thomasb06 | gtema: Hello. The Compute docstring stays in error, but it doesn't seem related with my modifications: https://review.opendev.org/c/openstack/openstacksdk/+/816785 | |
| 08:31:58 | thomasb06 | By the way, would you have something else to give to me? | |
| 08:32:29 | gtema | it does - line 776 - you have 2 odd spaces | |
| 08:34:45 | gtema | actually since you are already on the docstrings there are some more things to fix - in some proxy methods apparently type of the return is not really being accepted properly what results in broken link | |
| 08:34:58 | gtema | i.e. https://docs.openstack.org/openstacksdk/latest/user/proxies/network.html - remove_gateway_from_router method | |
| 08:35:20 | gtema | I assume this is due to the line break in the rtype macro | |
| 08:35:49 | gtema | so it would be great if you can do another walk through proxies and have a look where those are broken | |
| 08:36:22 | thomasb06 | line 776, fixed | |
| 08:41:24 | thomasb06 | Regarding the remove_gateway_from_router method, the docstrings has ":rtype: :class: `~openstack.network.v2.router.Router`" without line break (after executing `git pull origin feature/r1`) | |
| 08:42:46 | gtema | yeah, but there is space in between ":class: `~openstack.network.v2.router.Router`" | |
| 08:43:00 | gtema | between :class: and the `~...` | |
| 08:43:10 | thomasb06 | understood | |
| 08:43:35 | thomasb06 | Let me take care of it | |
| 08:43:42 | gtema | cool, thks | |
| 08:44:09 | thomasb06 | (my CV says 'thanks you guys', hehe...) | |
| 08:44:25 | gtema | i.e. https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/network/v2/_proxy.py#L780 the line is broken (find_local_ip_association method) | |
| 08:46:09 | gtema | same stuff for validate_auto_allocated_topology - I assume it can be in multiple places (you can verify in the rendered docs (i.e. on https://cf484ceb1edd89d30dfe-675a54f2682a71ce0a87525368caccbf.ssl.cf5.rackcdn.com/816785/2/check/openstack-tox-docs/14f9fb4/docs/user/index.html#api-documentation | |
| 08:46:29 | gtema | that is the link to built artifacts from your last change | |
| 08:46:47 | gtema | there you go under "Service Proxies" | |
| 08:47:00 | thomasb06 | so it should be :class:`openstack.service.version.variable`, with no space, and on it's own line if a line break splits it? | |
| 08:47:15 | gtema | yes | |
| 08:47:34 | gtema | basically :class:`whatever` - this all must be on the same line | |
| 08:50:14 | thomasb06 | ok, I track them down | |
| 08:50:24 | gtema | awesome | |
| 08:55:29 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 09:38:39 | isabek | gtema: Hi! Can you please take a look [1] when you have a time. Thanks! 1) https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 11:22:17 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for server lock reason https://review.opendev.org/c/openstack/openstacksdk/+/819293 | |
| 16:52:47 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for server lock reason https://review.opendev.org/c/openstack/openstacksdk/+/819293 | |
| 17:19:33 | stephenfin | gtema: Is the neutron stuff in OSC using neutronclient or SDK now? | |
| 17:19:43 | gtema | sdk | |
| 17:19:45 | stephenfin | I can figure it out but just in case you know off the top of your head | |
| 17:19:46 | stephenfin | Sweet | |
| 17:20:00 | stephenfin | Okay, all our tests need to be fixed. They're using FakeResource everywhere /o\ | |
| 17:20:01 | gtema | and glance also | |
| 17:20:08 | stephenfin | Fun! | |
| 17:20:23 | stephenfin | (rather than "fake" SDK objects) | |
| 17:20:28 | stephenfin | *SDK resource objects | |
| 17:20:29 | gtema | yes, I wanted to start on that after we complete with moving compute - there's plenty of improvements possible | |
| 17:20:45 | stephenfin | Okay, cool, once you know. I'll make sure we don't add any new usage of this | |
| 17:21:00 | gtema | :) | |
| 17:46:45 | opendevreview | Merged openstack/python-openstackclient master: Add --subnet-pool to subnet list https://review.opendev.org/c/openstack/python-openstackclient/+/778521 | |
| 17:46:48 | opendevreview | Merged openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | |
| 17:50:03 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add network update quota "limit_check" parameter https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | |
| 19:24:07 | opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | |
| 23:39:46 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 23:49:13 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 23:58:11 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| #openstack-sdks - 2021-11-26 | |||
| 01:12:20 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 11:13:28 | isabek | stephenfin: Hi! Thank you very much for review. About using sdk part here https://review.opendev.org/c/openstack/python-openstackclient/+/805618/15/openstackclient/tests/unit/network/v2/fakes.py#420 . My sdk patch is now on feature/r1 branch. | |
| 11:14:16 | isabek | Should I wait for when is landed to master? Than upload patch for openstackclient? Or It will be fine with depends-on? | |
| 11:32:08 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add --security-group to port list https://review.opendev.org/c/openstack/python-openstackclient/+/815506 | |
| 12:46:14 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add --security-group to port list https://review.opendev.org/c/openstack/python-openstackclient/+/815506 | |
| 14:11:31 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Add functional test for server add/remove volume. https://review.opendev.org/c/openstack/python-openstackclient/+/819473 | |
| 14:27:33 | przszc | gtema: I addressed your review comments for https://review.opendev.org/c/openstack/openstacksdk/+/810364. Let me know if it needs further improvements | |
| 14:28:11 | gtema | ok, putting on the todo list ;-) | |
| 14:38:45 | przszc | Thanks :) | |
| 14:43:57 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 14:53:42 | opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | |
| 16:11:22 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 18:08:01 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add --security-group to port list https://review.opendev.org/c/openstack/python-openstackclient/+/815506 | |
| 19:50:57 | opendevreview | Merged openstack/python-openstackclient master: Add functional test for server add/remove volume. https://review.opendev.org/c/openstack/python-openstackclient/+/819473 | |
| 19:51:00 | opendevreview | Merged openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 20:08:29 | opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | |
| #openstack-sdks - 2021-11-28 | |||
| 05:21:24 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server pause and server unpause to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817853 | |
| 05:22:08 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | |
| 18:55:03 | opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | |