| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-11-24 | |||
| 21:28:37 | slaweq | gtema: hi, can You take a look at https://review.opendev.org/c/openstack/python-openstackclient/+/819024 when You will have few minutes? thx in advance | |
| #openstack-sdks - 2021-11-25 | |||
| 08:30:43 | thomasb06 | gtema: Hello. The Compute docstring stays in error, but it doesn't seem related with my modifications: https://review.opendev.org/c/openstack/openstacksdk/+/816785 | |
| 08:31:58 | thomasb06 | By the way, would you have something else to give to me? | |
| 08:32:29 | gtema | it does - line 776 - you have 2 odd spaces | |
| 08:34:45 | gtema | actually since you are already on the docstrings there are some more things to fix - in some proxy methods apparently type of the return is not really being accepted properly what results in broken link | |
| 08:34:58 | gtema | i.e. https://docs.openstack.org/openstacksdk/latest/user/proxies/network.html - remove_gateway_from_router method | |
| 08:35:20 | gtema | I assume this is due to the line break in the rtype macro | |
| 08:35:49 | gtema | so it would be great if you can do another walk through proxies and have a look where those are broken | |
| 08:36:22 | thomasb06 | line 776, fixed | |
| 08:41:24 | thomasb06 | Regarding the remove_gateway_from_router method, the docstrings has ":rtype: :class: `~openstack.network.v2.router.Router`" without line break (after executing `git pull origin feature/r1`) | |
| 08:42:46 | gtema | yeah, but there is space in between ":class: `~openstack.network.v2.router.Router`" | |
| 08:43:00 | gtema | between :class: and the `~...` | |
| 08:43:10 | thomasb06 | understood | |
| 08:43:35 | thomasb06 | Let me take care of it | |
| 08:43:42 | gtema | cool, thks | |
| 08:44:09 | thomasb06 | (my CV says 'thanks you guys', hehe...) | |
| 08:44:25 | gtema | i.e. https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/network/v2/_proxy.py#L780 the line is broken (find_local_ip_association method) | |
| 08:46:09 | gtema | same stuff for validate_auto_allocated_topology - I assume it can be in multiple places (you can verify in the rendered docs (i.e. on https://cf484ceb1edd89d30dfe-675a54f2682a71ce0a87525368caccbf.ssl.cf5.rackcdn.com/816785/2/check/openstack-tox-docs/14f9fb4/docs/user/index.html#api-documentation | |
| 08:46:29 | gtema | that is the link to built artifacts from your last change | |
| 08:46:47 | gtema | there you go under "Service Proxies" | |
| 08:47:00 | thomasb06 | so it should be :class:`openstack.service.version.variable`, with no space, and on it's own line if a line break splits it? | |
| 08:47:15 | gtema | yes | |
| 08:47:34 | gtema | basically :class:`whatever` - this all must be on the same line | |
| 08:50:14 | thomasb06 | ok, I track them down | |
| 08:50:24 | gtema | awesome | |
| 08:55:29 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 09:38:39 | isabek | gtema: Hi! Can you please take a look [1] when you have a time. Thanks! 1) https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 11:22:17 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for server lock reason https://review.opendev.org/c/openstack/openstacksdk/+/819293 | |
| 16:52:47 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: compute: Add support for server lock reason https://review.opendev.org/c/openstack/openstacksdk/+/819293 | |
| 17:19:33 | stephenfin | gtema: Is the neutron stuff in OSC using neutronclient or SDK now? | |
| 17:19:43 | gtema | sdk | |
| 17:19:45 | stephenfin | I can figure it out but just in case you know off the top of your head | |
| 17:19:46 | stephenfin | Sweet | |
| 17:20:00 | stephenfin | Okay, all our tests need to be fixed. They're using FakeResource everywhere /o\ | |
| 17:20:01 | gtema | and glance also | |
| 17:20:08 | stephenfin | Fun! | |
| 17:20:23 | stephenfin | (rather than "fake" SDK objects) | |
| 17:20:28 | stephenfin | *SDK resource objects | |
| 17:20:29 | gtema | yes, I wanted to start on that after we complete with moving compute - there's plenty of improvements possible | |
| 17:20:45 | stephenfin | Okay, cool, once you know. I'll make sure we don't add any new usage of this | |
| 17:21:00 | gtema | :) | |
| 17:46:45 | opendevreview | Merged openstack/python-openstackclient master: Add --subnet-pool to subnet list https://review.opendev.org/c/openstack/python-openstackclient/+/778521 | |
| 17:46:48 | opendevreview | Merged openstack/python-openstackclient master: Switch command server add volume to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/815919 | |
| 17:50:03 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add network update quota "limit_check" parameter https://review.opendev.org/c/openstack/python-openstackclient/+/806016 | |
| 19:24:07 | opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | |
| 23:39:46 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 23:49:13 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| 23:58:11 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch list server volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/816716 | |
| #openstack-sdks - 2021-11-26 | |||
| 01:12:20 | opendevreview | Ritvik Vinodkumar proposed openstack/python-openstackclient master: Switch compute service list, delete and set to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/818434 | |
| 11:13:28 | isabek | stephenfin: Hi! Thank you very much for review. About using sdk part here https://review.opendev.org/c/openstack/python-openstackclient/+/805618/15/openstackclient/tests/unit/network/v2/fakes.py#420 . My sdk patch is now on feature/r1 branch. | |
| 11:14:16 | isabek | Should I wait for when is landed to master? Than upload patch for openstackclient? Or It will be fine with depends-on? | |
| 11:32:08 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add --security-group to port list https://review.opendev.org/c/openstack/python-openstackclient/+/815506 | |
| 12:46:14 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add --security-group to port list https://review.opendev.org/c/openstack/python-openstackclient/+/815506 | |
| 14:11:31 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Add functional test for server add/remove volume. https://review.opendev.org/c/openstack/python-openstackclient/+/819473 | |
| 14:27:33 | przszc | gtema: I addressed your review comments for https://review.opendev.org/c/openstack/openstacksdk/+/810364. Let me know if it needs further improvements | |
| 14:28:11 | gtema | ok, putting on the todo list ;-) | |
| 14:38:45 | przszc | Thanks :) | |
| 14:43:57 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 14:53:42 | opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | |
| 16:11:22 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 18:08:01 | opendevreview | Rodolfo Alonso proposed openstack/python-openstackclient master: Add --security-group to port list https://review.opendev.org/c/openstack/python-openstackclient/+/815506 | |
| 19:50:57 | opendevreview | Merged openstack/python-openstackclient master: Add functional test for server add/remove volume. https://review.opendev.org/c/openstack/python-openstackclient/+/819473 | |
| 19:51:00 | opendevreview | Merged openstack/python-openstackclient master: Switch command server remove volume to sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817989 | |
| 20:08:29 | opendevreview | Thobias Trevisan proposed openstack/python-openstackclient master: compute: Add 'Security Groups' for 'server list' https://review.opendev.org/c/openstack/python-openstackclient/+/819368 | |
| #openstack-sdks - 2021-11-28 | |||
| 05:21:24 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server pause and server unpause to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817853 | |
| 05:22:08 | opendevreview | Thrivikram Mudunuri proposed openstack/python-openstackclient master: Switch server suspend and server resume to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/817860 | |
| 18:55:03 | opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | |
| 18:59:03 | opendevreview | Slawek Kaplonski proposed openstack/python-openstackclient master: Allow unset port's host_id https://review.opendev.org/c/openstack/python-openstackclient/+/819024 | |
| 19:01:42 | opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | |
| #openstack-sdks - 2021-11-29 | |||
| 01:38:01 | opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | |
| 02:59:43 | opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | |
| 11:13:27 | stephenfin | gtema: Got a few +W opportunities for you https://review.opendev.org/c/openstack/python-openstackclient/+/815913 https://review.opendev.org/c/openstack/python-openstackclient/+/817860 https://review.opendev.org/c/openstack/python-openstackclient/+/817853 | |
| 11:13:43 | gtema | ack | |
| 11:13:52 | gtema | thks | |
| 11:30:41 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: DNM: Deprecate "force" behavior for network quotas https://review.opendev.org/c/openstack/python-openstackclient/+/819627 | |
| 11:31:38 | stephenfin | ralonsoh: wdyt? ^ If you agree with that approach, feel free to squash it into your patch. If not, that's fine also 0:) I just think it would be nice to _eventually_ harmonize behaviour, even if that takes a year or two | |
| 11:32:25 | ralonsoh | stephenfin, I'm Ok but not the community | |
| 11:32:32 | ralonsoh | I don't think Neutron will accept this | |
| 11:32:56 | ralonsoh | the want the current behaviour ("force" implicitly specified) | |
| 11:33:15 | ralonsoh | in any case, I can propose it | |
| 11:33:27 | ralonsoh | but I already had this conversation several times | |
| 11:34:10 | stephenfin | Oh, really? That seems odd considering the server behaviour isn't changed and there's going to be a long deprecation period proposed for the OSC change | |
| 11:34:43 | stephenfin | Ack, yeah I'm aware you've been through the wars on this and am reluctant to bikeshed too much, but once an option is there it's very hard to remove it again so I want to be _really_ sure :) | |
| 11:34:50 | ralonsoh | I can propose this change in the Neutron drivers meeting | |
| 11:35:12 | stephenfin | cool, let me know if you need anything from me | |
| 13:38:52 | opendevreview | Merged openstack/python-openstackclient master: Switch server image create to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/815913 | |
| 13:46:57 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 14:07:40 | isabek | Hi stephenfin ! I have updated my patch. Should I wait for sdk patch when it will be landed to master branch? or first leave what was before? https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 14:31:18 | opendevreview | Diwei Zhu proposed openstack/python-openstackclient master: Switch openstack server remove port/network to using sdk https://review.opendev.org/c/openstack/python-openstackclient/+/817838 | |
| 14:58:28 | opendevreview | Suneeth Ravi proposed openstack/python-openstackclient master: Switch server lock to sdk. https://review.opendev.org/c/openstack/python-openstackclient/+/819517 | |
| 15:05:02 | stephenfin | isabek: Yeah, you'll have to wait for that patch to land on master and a new release be cut before you can merge that, I'm afraid | |
| 15:08:32 | isabek | stephenfin: Thanks! When it planned to land r1 to master? | |
| 15:15:05 | stephenfin | isabek: I'm not sure. Does that patch cherry-pick cleanly to master? | |
| 15:17:09 | isabek | stephenfin: Patch on master is abandoned. Now patch is now on feature r1 branch https://review.opendev.org/c/openstack/openstacksdk/+/814765 | |
| 15:21:27 | stephenfin | isabek: Right, yes. My question is once it's landed on feature/r1, you can cherry-pick back to master to get it released faster | |
| 15:24:42 | stephenfin | isabek: You can cherry-pick the following three changes to get it released sooner: 1909df1f4219fbf2a1bb0f9ba087ef39758ffded 93f69e42f125fb87c3269881509b3913b9374f34 f5b60d2b03e611854822f17bd5487d322ca0b71f | |
| 15:25:18 | stephenfin | isabek: cherry-pick those and propose them to master and we can merge and cut a new release (cc gtema) | |
| 15:25:44 | isabek | stephenfin: Thank you! I will do it right now | |
| 15:26:13 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Vpn ike policy resource https://review.opendev.org/c/openstack/openstacksdk/+/819585 | |
| 15:28:16 | stephenfin | isabek: Maybe drop the '-x' option | |