Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-01-12
14:10:28 RuiChen sure, here you go, sorry
14:10:29 dtroyer right. this is a case where I do think we need to step back a bit and make sure we build the right UI
14:10:39 dtroyer ok, thanks guys
14:11:03 huanxuan RuiChen: thanks
14:11:10 dtroyer RuiChen: the current OSC will always have features that an older cloud can not use, but that does not make it unusable on older clouds
14:11:53 stevemar if someone comes up with a nice UI, they can build it. the two options can co-exist. just like git checkout -b new_branch; and git branch -d <new_branch>
14:11:55 dtroyer if that idea is a problem for your downstream, then it will always be a problem during every release
14:12:12 huanxuan stevemar: sounds good
14:13:02 huanxuan stevemar: so we are going to add manange and unmanage commands now, right?
14:13:12 stevemar huanxuan: not now, whenever :P
14:13:19 dtroyer the cases where matching stable OSC to a cloud release are usually due to distributions that can not co-install multiple python bits from different releases due to dependency conflicts
14:13:58 huanxuan stevemar: OK, get it! :)
14:14:53 dtroyer RuiChen: so what specifically is blocking your use of the current OSc releases?
14:16:52 RuiChen our user confused about why some osc commands raise error in stable openstack, they don't know openstack too much
14:17:21 RuiChen i means latest osc run against old version openstack cloud
14:18:11 dtroyer are those due to differences in the API or due to deployment choices?
14:18:15 RuiChen and the dependency conflicts is other reason too
14:19:24 RuiChen for example, that SSL bug, we deploy all openstack services in SSL
14:19:42 dtroyer and I agree that is one that probably should be backported
14:20:27 dtroyer can you prepare that one for a backport?
14:20:42 RuiChen thank you, I will
14:21:12 RuiChen I saw the backport patch is abandoned, so ask these
14:22:19 dtroyer fortunately, stable releases will not be stuck in our upcoming freeze so there is not a time pressure from our side for that
14:23:19 RuiChen \o/, I will prepare the patch
14:23:55 RuiChen just make sure, will we release a stable osc version for it?
14:24:21 dtroyer yes
14:24:48 RuiChen thank you :)
14:32:29 stevemar RuiChen: thanks for your help with osc :)
14:33:05 dtroyer huanxuan: that image test is still racy, failed py35 but passed py27
14:33:33 huanxuan dtroyer: yes, I saw it
14:33:49 dtroyer I'm having a hard time reproducing it locally, can you?
14:34:20 huanxuan dtroyer: I am working on it
14:35:07 dtroyer I am wondering if we need to reset the mock inside the for loop
14:35:27 dtroyer well, reset is at the bottom, I mean re-initialize it
14:37:22 huanxuan dtroyer: re-initialize?
14:38:00 dtroyer move lines 855-857 below 859
14:40:13 huanxuan dtroyer: Oh! get your point!
14:43:13 dtroyer stevemar, huanxuan: https://review.openstack.org/#/c/419461/ looks ready to go
14:43:50 openstackgerrit Huanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test https://review.openstack.org/419445
14:44:12 huanxuan dtroyer: +A
15:06:03 openstackgerrit Huanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test https://review.openstack.org/419445
15:08:20 stevemar dtroyer: i dont understand the if statements in the tests
15:08:28 reedip ralonsoh : hehe, gate did it :D
15:11:35 dtroyer stevemar: Where? are you talking about test_image_set_membership_option()?
15:11:52 stevemar dtroyer: commented
15:11:55 stevemar https://review.openstack.org/#/c/419461/1
15:14:00 openstackgerrit Steve Martinelli proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test https://review.openstack.org/419445
15:14:34 dtroyer ok… ugh, more parallel testing side effects maybe?
15:14:37 stevemar dtroyer: rebased https://review.openstack.org/#/c/419445/4 on top of the qos fix
15:15:03 stevemar dtroyer: yeah, i was wondering if we're just opening ourselves up to more racey tests
15:16:28 dtroyer totally. am I off base for just wanting unrolled multiple tests that don't try to share too much?
15:17:13 dtroyer my gut says the for loop in the image test is part of our pain
15:17:18 dtroyer too
15:18:14 dtroyer I'm going to do an unroll of the qos tests and see how bad it looks
15:18:44 dtroyer although not gettgin them to fail locally makes it hard to prove it is worth the effort
15:20:29 openstackgerrit Reedip proposed openstack/python-openstackclient: Fix quota show output https://review.openstack.org/419067
15:20:33 stevemar hehe
15:21:27 dtroyer so I'm going to go find it, but I had to do a lot of deepcopy() in the past to avoid this sort of thing with shared mock return values, I think we've forgotten that
15:25:39 huanxuan dtroyer: failed again :(
15:40:16 dtroyer so I'm trying a simple unrolling of that loop and making it into 3 tests
15:43:16 openstackgerrit Dean Troyer proposed openstack/python-openstackclient: Fix image member unit tests occasional failures https://review.openstack.org/419528
15:43:25 dtroyer let's see what that does ^^^
15:45:58 huanxuan dtroyer: good idea, thank you!
15:47:07 huanxuan I am also trying in other ways
15:48:00 etoews cdent elmiko edleafe i have a conflicting meeting today and won't be able to attend the api wg meeting
15:49:05 etoews edleafe: you hoser
15:49:06 edleafe :)
15:49:17 openstackgerrit Huanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test https://review.openstack.org/419445
15:49:38 openstackgerrit Ed Leafe proposed openstack/api-wg: Add guidelines for boolean names https://review.openstack.org/411529
15:52:22 elmiko edleafe: ack
15:52:36 elmiko er etoews lol
15:52:59 edleafe elmiko: that's ok. etoews and I are practically indistinguishable
15:53:45 elmiko hehe =)
15:55:59 mordred edleafe: when is the api wg meeting?
15:56:14 edleafe mordred: 5 minutes
15:56:28 edleafe mordred: in #openstack-meeting-3
15:57:00 mordred edleafe: neat
16:02:13 openstackgerrit Merged openstack/python-openstackclient: Fix Network QoS rule CLI attrs parsing https://review.openstack.org/419461
16:07:49 waj334 dtroyer: What's the verdict on this patch? https://review.openstack.org/#/c/412614/
16:09:16 stevemar waj334: probably wait til after client freeze to push that one
16:09:37 stevemar waj334: meaning it won't go into "ocata"
16:09:50 stevemar waj334: we made the call at the last osc meeting i believe
16:09:59 dtroyer waj334: nothing really, we're just not ready to merge it yet right before we do the stable release in a week or two. I don't think there is any advantage to having a very incomplete v3 in stable that will never get brought up to spec
16:10:50 waj334 Cool. I was just following up
16:12:16 waj334 I'm gonna proceed with the implementation of Cinder v3.3 (implements messages api) and maybe I'll be able to tackle this microversion problem
16:12:55 dtroyer waj334: cool. I think it is safe to use 412614 as the base for that now
16:14:12 stevemar waj334: dtroyer not sure if you guys saw this, but diana_clarke pushed https://review.openstack.org/#/c/419108/ which starts microversion support for nova stuff
16:14:25 stevemar mriedem was saying they'll be looking at it in pike, i think
16:14:35 dtroyer saw but have not really read it yet
16:16:27 waj334 stevemar: It doesn't seem to do much of anything
16:18:39 mordred dtroyer, stevemar: do we have any time at the PTG that we can sit down together and talk through / work through where we want the osc/occ config ownership and handoff to be? I think we keep wanting to talk about it and never quite getting to it ...
16:19:50 dtroyer mordred: we have a room mon/tues, it's just a matter of arranging the schedule
16:20:48 mordred dtroyer: woot
16:21:22 openstackgerrit Pavlo Shchelokovskyy proposed openstack/python-openstackclient: Fix flavor create help re swap size units https://review.openstack.org/419549
16:23:47 openstackgerrit Dean Troyer proposed openstack/python-openstackclient: Fix image member unit tests occasional failures https://review.openstack.org/419528
16:27:25 waj334 The microversion issue is gonna be a bigger problem than I thought. Any ideas on how to handle 2 versions of the same function, but with different parameters? lol
16:27:39 waj334 * not so lol *
16:28:02 openstackgerrit Pavlo Shchelokovskyy proposed openstack/python-openstackclient: Fix flavor create help re swap size units https://review.openstack.org/419549
16:29:24 dtroyer waj334: we've talked about a couple of strategies for handling those. #1 is user-breaking changes are bad and we have to abide by semver at the CLI level so if you're talking about CLi-visible differences we need to consider that and time it properly
16:30:05 dtroyer most of what we've talked about though is handling the differences internally, which is basically writing multiple versions and branching as required. No magic, copying code is not bad here

Earlier   Later