Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2017-01-12
15:20:33 stevemar hehe
15:21:27 dtroyer so I'm going to go find it, but I had to do a lot of deepcopy() in the past to avoid this sort of thing with shared mock return values, I think we've forgotten that
15:25:39 huanxuan dtroyer: failed again :(
15:40:16 dtroyer so I'm trying a simple unrolling of that loop and making it into 3 tests
15:43:16 openstackgerrit Dean Troyer proposed openstack/python-openstackclient: Fix image member unit tests occasional failures https://review.openstack.org/419528
15:43:25 dtroyer let's see what that does ^^^
15:45:58 huanxuan dtroyer: good idea, thank you!
15:47:07 huanxuan I am also trying in other ways
15:48:00 etoews cdent elmiko edleafe i have a conflicting meeting today and won't be able to attend the api wg meeting
15:49:05 etoews edleafe: you hoser
15:49:06 edleafe :)
15:49:17 openstackgerrit Huanxuan Ao proposed openstack/python-openstackclient: Fix gate broken by auth_ref in image unit test https://review.openstack.org/419445
15:49:38 openstackgerrit Ed Leafe proposed openstack/api-wg: Add guidelines for boolean names https://review.openstack.org/411529
15:52:22 elmiko edleafe: ack
15:52:36 elmiko er etoews lol
15:52:59 edleafe elmiko: that's ok. etoews and I are practically indistinguishable
15:53:45 elmiko hehe =)
15:55:59 mordred edleafe: when is the api wg meeting?
15:56:14 edleafe mordred: 5 minutes
15:56:28 edleafe mordred: in #openstack-meeting-3
15:57:00 mordred edleafe: neat
16:02:13 openstackgerrit Merged openstack/python-openstackclient: Fix Network QoS rule CLI attrs parsing https://review.openstack.org/419461
16:07:49 waj334 dtroyer: What's the verdict on this patch? https://review.openstack.org/#/c/412614/
16:09:16 stevemar waj334: probably wait til after client freeze to push that one
16:09:37 stevemar waj334: meaning it won't go into "ocata"
16:09:50 stevemar waj334: we made the call at the last osc meeting i believe
16:09:59 dtroyer waj334: nothing really, we're just not ready to merge it yet right before we do the stable release in a week or two. I don't think there is any advantage to having a very incomplete v3 in stable that will never get brought up to spec
16:10:50 waj334 Cool. I was just following up
16:12:16 waj334 I'm gonna proceed with the implementation of Cinder v3.3 (implements messages api) and maybe I'll be able to tackle this microversion problem
16:12:55 dtroyer waj334: cool. I think it is safe to use 412614 as the base for that now
16:14:12 stevemar waj334: dtroyer not sure if you guys saw this, but diana_clarke pushed https://review.openstack.org/#/c/419108/ which starts microversion support for nova stuff
16:14:25 stevemar mriedem was saying they'll be looking at it in pike, i think
16:14:35 dtroyer saw but have not really read it yet
16:16:27 waj334 stevemar: It doesn't seem to do much of anything
16:18:39 mordred dtroyer, stevemar: do we have any time at the PTG that we can sit down together and talk through / work through where we want the osc/occ config ownership and handoff to be? I think we keep wanting to talk about it and never quite getting to it ...
16:19:50 dtroyer mordred: we have a room mon/tues, it's just a matter of arranging the schedule
16:20:48 mordred dtroyer: woot
16:21:22 openstackgerrit Pavlo Shchelokovskyy proposed openstack/python-openstackclient: Fix flavor create help re swap size units https://review.openstack.org/419549
16:23:47 openstackgerrit Dean Troyer proposed openstack/python-openstackclient: Fix image member unit tests occasional failures https://review.openstack.org/419528
16:27:25 waj334 The microversion issue is gonna be a bigger problem than I thought. Any ideas on how to handle 2 versions of the same function, but with different parameters? lol
16:27:39 waj334 * not so lol *
16:28:02 openstackgerrit Pavlo Shchelokovskyy proposed openstack/python-openstackclient: Fix flavor create help re swap size units https://review.openstack.org/419549
16:29:24 dtroyer waj334: we've talked about a couple of strategies for handling those. #1 is user-breaking changes are bad and we have to abide by semver at the CLI level so if you're talking about CLi-visible differences we need to consider that and time it properly
16:30:05 dtroyer most of what we've talked about though is handling the differences internally, which is basically writing multiple versions and branching as required. No magic, copying code is not bad here
16:36:47 waj334 dtroyer: So, with the messages api in Cinder v3.3 and v3.5 I'll end up with 2 separate files is what you're saying? Like messages_3_3.py, messages_3_5.py? Or, just different versions of various methods, just named slightly different?
16:39:14 waj334 I may be overthinking this
16:41:44 dtroyer we only split fies by major version so far, I suppose if it's a huge change that might be easier, but there is no mechanism to handle minor version changes at the stevedore/entry-point level
16:42:02 dtroyer so we'll still wind up with a common entry point.
16:42:22 dtroyer my thinking is of a microversion is so different that it's a total re-work, then something went wrong somewhere
16:46:17 waj334 Well, luckily what I'm seeing in this messages api is where optional params were added in v3.5 so that's easier to deal with. How important is maintaining consistency of command parameters if they are allowed to change between versions?
16:47:01 Serlex Hi, can someone post an example of "add_gateway_to_router(router, **body)" cheers
16:50:17 openstackgerrit Dean Troyer proposed openstack/python-openstackclient: Fix image member unit tests occasional failures https://review.openstack.org/419528
16:56:08 waj334 dtroyer: Would it be wise to check the client version first before adding arguments? That way I could set up the command properly for that specific microversion by just a few if statements.
16:56:46 waj334 Provided that I know about the client before commands are set up that is
16:59:04 dtroyer we don't do version discovery until the very last minute, ie the first actual API call to the service. So we'll only know the specific API version if the user has specified it.
16:59:22 dtroyer otherwise we have to make multiple calls (auth, discovery) to even build help
17:00:13 dtroyer for that, and the fact that we don't want incompatible changes to begin with, we should go to a good bit of work internally to not expose unnecessary changes to the user
17:01:25 elmiko LOL
17:06:38 waj334 It seems that I'm defeated
17:13:17 stevemar mordred: handoff? you ditching occ and leaving it on our laps? :)
17:14:33 Serlex sooo
17:15:23 stevemar Serlex: you're using openstacksdk?
17:16:02 Serlex yes
17:16:25 Serlex I want to add external network to a router
17:16:44 Serlex "add_gateway_to_router(router, **body)", got my router...how do I apply the body bit
17:17:57 stevemar Serlex: -- briancurtin huanxuan or reedip might be able to help you out, i'm not familiar with that command and my googling hasn't turned up anything
17:18:28 briancurtin Serlex: apply the body bit?
17:21:50 cdent elmiko, edleafe I forgot to mention I can't run the meeting next week, can one of you?
17:22:06 elmiko cdent: i should be able to
17:22:14 elmiko i'll be out the following week though
17:22:18 briancurtin Serlex: i don’t see that in the neutron API docs so i don’t know what’s expected there. hopefully someone who worked on it is in here because as usual things are undocumented
17:22:19 cdent cool, thanks, it's the last day my parents are in country
17:22:29 elmiko ooh nice, say hi for me =)
17:24:48 edleafe cdent: elmiko: I'll be around too
17:24:52 Serlex briancurtin: thanks, complete noob, hoping example will set me off
17:25:01 elmiko edleafe: cool
17:25:12 stevemar Serlex: briancurtin sounds like it's this API? http://developer.openstack.org/api-ref/networking/v2/?expanded=add-interface-to-router-detail#add-interface-to-router
17:25:28 briancurtin Serlex: looking at https://github.com/openstack/python-openstacksdk/blob/master/openstack/tests/unit/network/v2/test_router.py#L177 you would just pass kwargs that correspond with what’s expected by the server. they pass network_id=3, enable_snat=True there
17:25:36 dtroyer stevemar: my hacky-test for the image bits passed unit tests: https://review.openstack.org/419528 want to go with that (unrolled 1 test into 3) or shall I fix up huanxuan's? I know what bit we both missed the first time thought, just not why it is inconsistent
17:25:59 stevemar briancurtin: Serlex sounds like you need to pass one of subnet_id or port_id as kwargs
17:26:18 briancurtin Serlex: it might be similar but it’s not the same. the method you asked about isn’t listed there in the API docs
17:26:24 cdent edleafe, elmiko: proof please: https://etherpad.openstack.org/p/api-wg-newsletter
17:26:34 briancurtin it’s an interface-to-router not gateway-to-router
17:27:39 Serlex ok thanks
17:27:43 Serlex this what I was looking at http://developer.openstack.org/sdks/python/openstacksdk/users/proxies/network.html
17:27:52 elmiko cdent: +1 from me
17:29:51 edleafe cdent: looks good, except I'm not sure how moral my support can be :)
17:30:29 cdent how's that edleafe ?
17:31:08 edleafe heehee
17:31:23 edleafe I think the earlier version would be clearer to the masses
17:31:45 elmiko lol
17:34:05 cdent damn
17:34:18 cdent hoisted on my typos, again and again
17:37:41 ankur-gupta-f1 dtroyer: stevemar: link for todays meetings agenda etherpad?
17:41:13 dtroyer ankur-gupta-f1: the etherpad is at https://etherpad.openstack.org/p/osc-weekly-meeting, but the meeting was a few hours ago…it an even week
17:41:32 ankur-gupta-f1 well shit. k thanks
18:46:29 mordred stevemar: oh good golly no - I mean working through a plan for dealing with the duplication of concerns between osc and occ that we're all happy with
18:53:23 mordred cdent, johnthetubaguy sorry I missed the second half of the api meeting - had to run to the airport
18:53:59 cdent as ya do
18:54:38 mordred cdent: in answer to your question, the sorts of things that would be useful from an occ/shade perspective as discoverable capabilities are the "Does this cloud support volume deletion" sorts of things

Earlier   Later