| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2026-08-21 | |||
| 15:22:09 | dansmith | Uggla: AFAIK we're now just waiting for you to circle back on the exception handling comment here: https://review.opendev.org/c/openstack/nova/+/999349 | |
| 15:22:23 | sean-k-mooney | well sylvain is the release liason so they would have been teh one to propeose it normally but they are also on pto | |
| 15:22:28 | sean-k-mooney | rather then elod | |
| 15:22:30 | dansmith | otherwise I think I'm +2 on both assuming gouthamr will propose a followup for a periodic resync of the share access rules | |
| 15:24:50 | gmaan | antia: this one https://review.opendev.org/c/openstack/nova/+/999249/3..5/nova/virt/libvirt/driver.py#b7976 | |
| 15:25:25 | gmaan | i was expecting we reject the request when we find os_secure_boot is required and tdx-requested otherwise it still ignore it. no? | |
| 15:26:04 | Uggla | dansmith, thanks I'm gonna answer. Did you test with nfs or cephfs ? | |
| 15:26:14 | dansmith | nfs | |
| 15:27:39 | dansmith | Uggla: I put notes in the comments about the things I tested (although notably left out which driver I was using) | |
| 15:27:39 | antia | gmaan: There is a follow up patch, which I now moved to be in front, which solves the secure boot interaction with TDX | |
| 15:27:43 | Uggla | ok I have just setup a cephfs devstack for testing it. That should not fundamentally change. But it will be another check. | |
| 15:28:17 | dansmith | very good | |
| 15:28:20 | antia | https://review.opendev.org/c/openstack/nova/+/1000472 with this it shouldn't be required to reject on os_secure_boot=required for TDX | |
| 15:29:32 | gmaan | antia: ok, let me go through the whole series again, will do after sometime. btw which TZ you are in? | |
| 15:29:33 | sean-k-mooney | did gibi or you have time to test that secure boot actully worked in that version | |
| 15:30:06 | antia | gmaan: UTC+2, so just about to head off for the weekend :) | |
| 15:30:09 | Uggla | dansmith, I would have progressed more without yesterday escalation. | |
| 15:30:14 | gmaan | i did not have HW access, gibi had. i asked him about it but we will get to know on monday. | |
| 15:30:28 | gmaan | antia: ack | |
| 15:30:38 | gmaan | or antia may have tested? | |
| 15:30:42 | sean-k-mooney | gmaan: sorry that question was to antia | |
| 15:30:47 | antia | both me and gibi tested it | |
| 15:30:52 | gmaan | yeah, i know. just saying | |
| 15:31:55 | sean-k-mooney | ack we can stage thigns ready for gibi to +w on monday if we think its otehrwse ready adn he can do a final test if they have time | |
| 15:32:11 | gmaan | i asked gibi also but can we publish the testing results (if you can upload yours) somewhere, as we will not be testing it in upstream, it will be good ref to know what is tested and working fine | |
| 15:32:23 | sean-k-mooney | im almost done with the cybrog things i need to do today so ill be starting on the tdx review again in a bit | |
| 15:32:38 | antia | logs of my tests (but this is before the most recent changes): https://paste.openstack.org/show/bdbleKLLworBpma70kXB/ | |
| 15:32:48 | gmaan | not sure where we can share as permanent doc | |
| 15:33:07 | sean-k-mooney | antia: but that does not actully should you checkign theat secure boot was enabled in the guest os image | |
| 15:33:14 | sean-k-mooney | and tha tit booted with that | |
| 15:33:24 | gmaan | i was thinking to have some doc existing in Nova repo with all testing you did. not detail maybe | |
| 15:33:52 | sean-k-mooney | we proably shoud nto merge that | |
| 15:33:56 | antia | sean-k-mooney: Ah that is true! I can do some more testing after the weekend | |
| 15:34:06 | sean-k-mooney | unless it written as a guide to testing | |
| 15:34:25 | sean-k-mooney | gmaan: we have similar guide for some numa stuff | |
| 15:34:59 | sean-k-mooney | gmaan: so somethign like https://github.com/openstack/nova/tree/master/doc/source/contributor/testing | |
| 15:35:01 | gmaan | sean-k-mooney: ++ yeah. i did not check numa one but yes guide to test/results | |
| 15:35:23 | sean-k-mooney | well i dont thinik we should comemit one off results | |
| 15:35:23 | gmaan | yup, kind of this | |
| 15:35:39 | sean-k-mooney | but we can commit docs of how to test it manually properly | |
| 15:35:40 | gmaan | at least, which one worked or not | |
| 15:36:22 | sean-k-mooney | so of this is going to end up automated later in whitebox/tempest too | |
| 15:37:00 | sean-k-mooney | the system gibi borrowed may eventully end up geting used to test this perodicily downstream | |
| 15:37:11 | gmaan | ++ for tempest/whitebox testing but if we have some 3rd party CI to run them somewhere | |
| 15:37:54 | sean-k-mooney | we kind of do. righ tnow we are not allwoe do report reuslt publicly because of infra info discustore risks | |
| 15:38:21 | sean-k-mooney | gmaan: we have internal nightly master job for cybrog | |
| 15:38:22 | gmaan | anyways, let's start with similar doc first, antia are you ok to push something next week. I am saying that is blocker for series to merge but good to have when we are merging it | |
| 15:38:38 | sean-k-mooney | we shoudl be able to do the saem for TDX in the coming weeks | |
| 15:38:42 | sean-k-mooney | not a blocker for the feature | |
| 15:38:46 | gmaan | yeah | |
| 15:39:03 | sean-k-mooney | jsut fyi that we hope to have that in place proably before the year is up | |
| 15:39:47 | sean-k-mooney | we are still exploring options for public third party ci bu thats complicated | |
| 15:39:53 | antia | would it be a document about TDX testing in https://github.com/openstack/nova/tree/master/doc/source/contributor/testing? | |
| 15:41:24 | sean-k-mooney | yes so like https://github.com/openstack/nova/blob/master/doc/source/contributor/testing/serial-console.rst | |
| 15:41:30 | sean-k-mooney | or the numa one | |
| 15:41:46 | antia | something like that I can fix | |
| 15:41:46 | sean-k-mooney | basiclly it woudl explain how to verify the feature is workign corectly | |
| 15:42:13 | sean-k-mooney | antia: i would keep that as a follwup patch provided that works for gmaan | |
| 15:42:36 | gmaan | yeah, works for me at the end of series. do not change existing series | |
| 15:42:46 | antia | sounds good | |
| 15:42:53 | gmaan | thanks | |
| 15:43:06 | antia | have a nice weekend all, and thanks for reviewing! | |
| 15:43:21 | gmaan | have a nice weekend antia | |
| 15:43:22 | gmaan | sean-k-mooney: I am not sure you are planning to go through series today but I will be able to do during end of my day. I will leave the merge things until gibi or you recheck. we still have 1 week before FF | |
| 15:44:27 | sean-k-mooney | im going to be aound for another hour or two | |
| 15:44:37 | sean-k-mooney | im trying to complete the cybrog nvme serise first | |
| 15:44:43 | sean-k-mooney | then loop back to this after | |
| 15:44:54 | gmaan | ack | |
| 15:45:05 | sean-k-mooney | the os-triats question above was we have a depency on the new os-trait release in that | |
| 15:45:33 | gmaan | we released that right? i thought changes was done in advanbce and released | |
| 15:45:44 | sean-k-mooney | they were don but not released | |
| 15:45:49 | sean-k-mooney | https://review.opendev.org/c/openstack/releases/+/1001835/1/deliverables/_independent/os-traits.yaml | |
| 15:45:54 | sean-k-mooney | i just created that | |
| 15:46:09 | sean-k-mooney | im going to raise it in the release channel shortly | |
| 15:46:17 | gmaan | sean-k-mooney: humm, tdx series added 3.8.0 in requirement.txt | |
| 15:46:34 | sean-k-mooney | yep that was done 2 months ago | |
| 15:46:52 | sean-k-mooney | the cyborg traits for nvme secure erase modes | |
| 15:46:55 | sean-k-mooney | merge last week | |
| 15:46:56 | gmaan | sean-k-mooney: its there https://github.com/openstack/os-traits/blob/3.8.0/os_traits/hw/cpu/x86/intel.py#L28 | |
| 15:47:10 | gmaan | yeah, os-traits updates was done long back | |
| 15:47:15 | sean-k-mooney | gmaan: right but we need a new release for a differnt feature | |
| 15:47:44 | sean-k-mooney | this isnt needed in nova but is needed in placment and cybrog | |
| 15:48:18 | gmaan | ohk, i thought you are saying TDX part is not released yet | |
| 15:48:31 | sean-k-mooney | no that is there | |
| 15:48:35 | gmaan | yeah | |
| 15:48:49 | sean-k-mooney | but i need to complete the nvme feature review before going back to the tdx series | |
| 15:49:32 | gmaan | got it | |
| 15:49:33 | sean-k-mooney | im trying to see if i can get os-traits 3.9.0 released so we can fully supprot requeting nvme devices based on tehre secure erase capabliteis | |
| 15:49:37 | gmaan | maybe we need more people here https://github.com/openstack/governance/blob/master/reference/projects.yaml#L1039 | |
| 15:50:02 | sean-k-mooney | Uggla if you can appove https://review.opendev.org/c/openstack/releases/+/1001835 that woudl help | |
| 15:50:25 | gmaan | Uggla: ^^ idea to add a few more as release will stuck if you and bauzas both are on PTO | |
| 15:50:32 | sean-k-mooney | having more then one is nice for pto coverage but the ptl can alwasy approve as well | |
| 15:51:05 | gmaan | yeah, just thinking to have 1 or 2 more along with PTL | |
| 15:51:31 | sean-k-mooney | for cybrog and watcher we have 2 release liasons seperate form teh ptl with 3 possbel aprpovers we are genneraly pretty PTO resitent | |
| 15:54:18 | Uggla | sean-k-mooney, done. Tbh I was here this week but forget about it. | |
| 15:54:52 | sean-k-mooney | no worries am we shoudl check os-vif and os-resouce classees for pendign release as well | |
| 15:55:06 | sean-k-mooney | but im not aware of any critial patches in those | |
| 15:56:09 | sean-k-mooney | os vif was milestone 2 | |
| 15:56:46 | sean-k-mooney | we actuul;y do have a few fixes we shoudl include in 2026.2 | |
| 15:56:51 | sean-k-mooney | ill also prospoe that now | |