| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2024-02-27 | |||
| 10:59:22 | bauzas | sean-k-mooney: can you please swing https://review.opendev.org/c/openstack/nova/+/907516 again , | |
| 10:59:24 | bauzas | ? | |
| 11:05:56 | opendevreview | sean mooney proposed openstack/nova master: [DNM] poc nova-ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | |
| 11:06:06 | sean-k-mooney | bauzas: sure | |
| 11:06:39 | sean-k-mooney | i saw it come in but wanted to wait for you to see if your happy | |
| 11:08:18 | sean-k-mooney | bauzas: based on the delta form v3 it looks ok to me | |
| 11:10:30 | opendevreview | sean mooney proposed openstack/nova master: [DNM] poc nova-ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | |
| 12:33:32 | auniyal | hi bauzas, regarding comment "LOG.info(_("foo %s", something))" on sonsole patch - on using "_(" pre-commit says - N319 Don't translate logs | |
| 12:34:38 | auniyal | and with fstring in logs we get like this https://paste.opendev.org/show/bM1D6nY1sxuHibnpHEax/ | |
| 12:57:41 | sean-k-mooney | auniyal: yes just remove _( ) | |
| 12:57:56 | sean-k-mooney | LOG.info("foo %s", something) | |
| 12:58:34 | auniyal | ack | |
| 12:58:44 | auniyal | sean-k-mooney, regarding other 2 comments ? | |
| 12:59:24 | sean-k-mooney | i do not have the review open, link? | |
| 12:59:44 | auniyal | https://review.opendev.org/c/openstack/nova/+/901824 | |
| 13:00:30 | sean-k-mooney | so the fstrings are rendered before being passed to the log fuction | |
| 13:00:39 | sean-k-mooney | so the log function get the rendered string | |
| 13:02:58 | auniyal | as suggested above will go with this for logging? - LOG.info("foo %s", something) | |
| 13:06:51 | sean-k-mooney | bauzas: im still +2 on https://review.opendev.org/c/openstack/nova/+/901824 i replied to yoru comments but we dont striclty need to change anything IMO | |
| 13:07:15 | sean-k-mooney | im ok with fixing the nits too | |
| 13:15:28 | auniyal | sean-k-mooney, I think bauzas is away for now, I have updated the cahgnes, running quick tests locally will respin once done | |
| 13:24:52 | opendevreview | Amit Uniyal proposed openstack/nova master: enforce remote console shutdown https://review.opendev.org/c/openstack/nova/+/901824 | |
| 13:34:27 | bauzas | auniyal: I'll lookup | |
| 13:35:20 | bauzas | auniyal: and sorry about the translations, I forgot that now only the exceptions should be translated | |
| 13:35:48 | bauzas | (before, the logs with levels >= info were needed to be translating) | |
| 13:39:29 | elodilles | bauzas: sorry for pinging, could you please double check this release patch? https://review.opendev.org/c/openstack/releases/+/909402 | |
| 13:40:05 | bauzas | elodilles: done :) | |
| 13:40:13 | bauzas | thanks for pinging me :) | |
| 13:40:25 | elodilles | thanks too o/ | |
| 13:40:42 | bauzas | (I have a lot of Gerrit emails :) | |
| 13:41:35 | sean-k-mooney | elodilles: minor issue in commit message | |
| 13:41:52 | sean-k-mooney | prior to the lib freeze for 2024.1 Bobcat going into effect | |
| 13:43:14 | sean-k-mooney | elodilles: the patch is correct in general | |
| 13:45:07 | elodilles | sean-k-mooney: oh, nice :/ all the generated patches were merged with that wrong release name :/ | |
| 13:45:17 | elodilles | sean-k-mooney: thanks for checking | |
| 13:45:37 | sean-k-mooney | well we dont need to break the patteren then | |
| 13:45:52 | bauzas | sean-k-mooney: +2d https://review.opendev.org/c/openstack/nova/+/901824 | |
| 13:46:37 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/901824/19..20/nova/objects/console_auth_token.py ... | |
| 13:46:52 | sean-k-mooney | fine it does not matter but we dont need to check and provide None | |
| 14:36:40 | opendevreview | sean mooney proposed openstack/nova master: [DNM] poc nova-ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | |
| 14:37:52 | opendevreview | sean mooney proposed openstack/nova master: [DNM] poc nova-ironic shard job https://review.opendev.org/c/openstack/nova/+/910333 | |
| 14:47:13 | dansmith | bauzas: quick question on https://review.opendev.org/c/openstack/nova/+/904258 | |
| 15:03:24 | bauzas | dansmith: shoot | |
| 15:06:19 | bauzas | dansmith: OK, I'll provide another revision for ^ | |
| 15:16:32 | bauzas | dansmith: about https://review.opendev.org/c/openstack/nova/+/909598/1/nova/virt/libvirt/driver.py#12756 | |
| 15:16:38 | bauzas | do you have time for discussing it ? | |
| 15:30:56 | dansmith | bauzas: yep | |
| 15:32:07 | bauzas | dansmith: just replied | |
| 15:32:12 | dansmith | bauzas: sorry was on a call | |
| 15:32:32 | bauzas | np at all (and yeah actually I remember your call :p ) | |
| 15:32:32 | dansmith | bauzas: quick gmeet? | |
| 15:32:39 | bauzas | if you want | |
| 15:32:55 | bauzas | we have upstream meeting in 28 mins | |
| 15:32:56 | dansmith | meet.google.com/mkb-cxhg-qkh | |
| 15:33:00 | dansmith | we'll be quick | |
| 16:00:41 | bauzas | #startmeeting nova | |
| 16:00:41 | opendevmeet | Meeting started Tue Feb 27 16:00:41 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 16:00:41 | opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 16:00:41 | opendevmeet | The meeting name has been set to 'nova' | |
| 16:00:44 | bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | |
| 16:00:48 | bauzas | hey folks | |
| 16:00:55 | bauzas | let's have a quick meetingb | |
| 16:01:10 | elodilles | o/ | |
| 16:01:29 | fwiesel | o/ | |
| 16:01:32 | kgube | o/ | |
| 16:02:07 | bauzas | okay, moving on | |
| 16:02:30 | bauzas | #topic Bugs (stuck/critical) | |
| 16:02:34 | dansmith | o/ | |
| 16:02:35 | bauzas | #info One Critical bug | |
| 16:02:39 | bauzas | #link https://bugs.launchpad.net/nova/+bug/2052937 | |
| 16:02:51 | bauzas | sean-k-mooney: do you want to discuss it now? | |
| 16:04:09 | auniyal | o/ | |
| 16:04:32 | bauzas | looks he's not around | |
| 16:05:15 | bauzas | I wonder what we need to do related to thaty | |
| 16:05:54 | gibi | o/ | |
| 16:06:13 | sean-k-mooney | o/ | |
| 16:06:19 | sean-k-mooney | sorry was double booked | |
| 16:06:38 | sean-k-mooney | am im not sure what there is to say really for that bug | |
| 16:06:55 | sean-k-mooney | im a littel concerned | |
| 16:07:05 | sean-k-mooney | that our heal allocation code might actully be broken by it | |
| 16:07:16 | sean-k-mooney | on the otehr hand with a quick look at the code | |
| 16:07:17 | bauzas | why is it in Critical state for nova ? | |
| 16:07:28 | sean-k-mooney | it was a gate blocker | |
| 16:07:35 | sean-k-mooney | that is what broke nova-next last week | |
| 16:08:15 | sean-k-mooney | when i looked at the nova manage code i belive its using a neutron client with both a service token and admin token | |
| 16:08:20 | sean-k-mooney | so it should be fine | |
| 16:08:44 | sean-k-mooney | but when i we removing the check in post it looks like heal allcoations was not properly healing the port resouce resuets | |
| 16:09:00 | bauzas | can we then move it to High ? | |
| 16:09:07 | sean-k-mooney | sure | |
| 16:09:26 | bauzas | ack | |
| 16:09:40 | bauzas | if you want, we can continue to discuss the bug next week | |
| 16:10:20 | sean-k-mooney | we should likely at least spotcheck that heal allcotions works | |
| 16:10:29 | sean-k-mooney | otherwize we might need to fix it in the RC period | |
| 16:11:43 | bauzas | ack | |
| 16:11:56 | sean-k-mooney | https://zuul.opendev.org/t/openstack/build/3c2c7955a4b34112a377a857623d6a73/log/job-output.txt#37642-37669 | |
| 16:12:14 | sean-k-mooney | the heal there looks like its broken | |
| 16:13:12 | sean-k-mooney | lets move on for now | |
| 16:13:32 | bauzas | cool | |
| 16:13:41 | bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 70 new untriaged bugs (+4 since the last meeting) | |
| 16:13:54 | bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | |