| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-01-31 | |||
| 18:41:42 | sean-k-mooney | and if you need to test it then you would set MOCK_STABLE_UUID=False | |
| 18:41:51 | sean-k-mooney | where you are explictly testing something that cares | |
| 18:42:22 | sean-k-mooney | following this pattern https://github.com/openstack/nova/blob/master/nova/test.py#L158-L173 | |
| 18:43:08 | dansmith | what I'm saying is, even with the mock disabled for one test, the virt node mock always returns None, so testing this in a full stack is kinda difficult without *also* making that parameterized | |
| 18:43:28 | sean-k-mooney | oh ok | |
| 18:43:39 | dansmith | but perhaps if I put them both behind that flag I'll get what I need, I'll have to see | |
| 18:44:10 | sean-k-mooney | this is just needed for the last patch correct? | |
| 18:44:28 | sean-k-mooney | as in you already worked though the other test isseus in the previous ones | |
| 18:45:27 | dansmith | yeah | |
| 18:46:01 | sean-k-mooney | so do you want to go up one level and just mock out _ensure_existing_node_identity and the check function for host and hypervisor hostname | |
| 18:46:53 | dansmith | that's what I was going to do, after two hours of trying to mock only the second call to it, | |
| 18:47:03 | dansmith | but there are just too many permutations of start, restart, stop, start, etc | |
| 18:47:36 | dansmith | but let me try to the flag for both the node mock and that one and see if i think it results in something meaningful | |
| 18:48:18 | dansmith | I feel like it will probably end up with 10,000 tests having that set, just so one can have it unset, but still need mocks to make it not very useful, vs. just unit testing it in isolation | |
| 18:48:23 | dansmith | but I'll see | |
| 18:49:06 | dansmith | tbh I wasn't thinking about tying the node mock to the compute _ensure one, so will try that first | |
| 19:05:34 | dansmith | actually, maybe this will be better anyway and then I can write some dedicated lifecycle tests to simulate the manual testing we've been doing with devstack | |
| 19:16:37 | opendevreview | Merged openstack/nova master: Fixup patch for stable-compute-uuid series https://review.opendev.org/c/openstack/nova/+/871848 | |
| 19:31:52 | opendevreview | Dan Smith proposed openstack/nova master: Check our nodes for hypervisor_hostname changes https://review.opendev.org/c/openstack/nova/+/872220 | |
| 19:31:53 | opendevreview | Dan Smith proposed openstack/nova master: Protect against a deleted node id file https://review.opendev.org/c/openstack/nova/+/872204 | |
| 19:31:53 | opendevreview | Dan Smith proposed openstack/nova master: Move comment about _destroy_evacuated_instances() https://review.opendev.org/c/openstack/nova/+/872348 | |
| 19:55:33 | opendevreview | Dan Smith proposed openstack/nova master: Protect against a deleted node id file https://review.opendev.org/c/openstack/nova/+/872204 | |
| 19:55:33 | opendevreview | Dan Smith proposed openstack/nova master: Move comment about _destroy_evacuated_instances() https://review.opendev.org/c/openstack/nova/+/872348 | |
| 20:11:28 | opendevreview | Dan Smith proposed openstack/nova master: Protect against a deleted node id file https://review.opendev.org/c/openstack/nova/+/872204 | |
| 20:11:28 | opendevreview | Dan Smith proposed openstack/nova master: Move comment about _destroy_evacuated_instances() https://review.opendev.org/c/openstack/nova/+/872348 | |
| 23:07:45 | opendevreview | Merged openstack/nova master: Add further workaround features for qemu_monitor_announce_self https://review.opendev.org/c/openstack/nova/+/867324 | |
| #openstack-nova - 2023-02-01 | |||
| 07:12:50 | opendevreview | Merged openstack/nova master: Detect host renames and abort startup https://review.opendev.org/c/openstack/nova/+/863920 | |
| 08:33:11 | dvo-plv | Hello, All. Could you please review our new changes in the next blueprint https://review.opendev.org/c/openstack/nova-specs/+/859290 | |
| 08:33:57 | opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if basew image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | |
| 08:41:02 | sean-k-mooney | hum ^ is expected if you dont pass an image to use instead | |
| 08:41:50 | sean-k-mooney | dvo-plv: we are well after spec freeze specs wont reopen until ~march | |
| 08:50:43 | dvo-plv | Okay, I see, we told about our approach to add NT NIC support. So we made some poc and I have pushed new code to simplify understating of our approach | |
| 08:51:56 | sean-k-mooney | ok so Feature Feeze is in 2 week RC 1 will be about 2 week after that and the master branch will reopen for the 2023.2 release | |
| 08:52:48 | sean-k-mooney | in the interim you can rebase you spec to the 2023.2 folder on when that is created and it can be reviewd | |
| 08:53:03 | sean-k-mooney | has the neutron work been accpeted yet | |
| 08:53:20 | sean-k-mooney | and if so is it implemtned/reviewd or pending | |
| 09:11:04 | opendevreview | ribaudr proposed openstack/os-traits master: Add 'COMPUTE_SHARE_LOCAL_FS' https://review.opendev.org/c/openstack/os-traits/+/872185 | |
| 09:31:11 | sean-k-mooney | bauzas: gibi im happy with both sahid's seriese and dans at this point and think we can proceed with merging both if ye can rereview them again this morning that would be great | |
| 09:32:17 | bauzas | sean-k-mooney: yup I wanted to look at it yesterday, will do it this morning | |
| 09:33:19 | sahid | o/ ++ guys, I will be around if you want me to change or add something | |
| 09:33:50 | sean-k-mooney | there were some trivial nits but i was fine with a followup patch for those | |
| 09:34:06 | sahid | sure I will do that | |
| 09:34:56 | sean-k-mooney | at this point i would prefer to land the changes so that the sdk/osc changes can merge ectra and so you can avoid any conflicts on api ro compute service verison | |
| 09:35:07 | sahid | ++ | |
| 09:53:49 | opendevreview | Rodolfo Alonso proposed openstack/os-vif master: Implement "BaseCommand" result property https://review.opendev.org/c/openstack/os-vif/+/872391 | |
| 09:55:48 | sean-k-mooney | ralonsoh: ok so that is a premtive mesure to allow the ovsdbapp to be updated when its relased. | |
| 09:56:03 | ralonsoh | sean-k-mooney, yes | |
| 09:56:17 | sean-k-mooney | your cutting it kind of close | |
| 09:56:36 | ralonsoh | sean-k-mooney, I know that, that's why I'm speeding it | |
| 09:57:13 | sean-k-mooney | well more that the non clien lib free is thurday week | |
| 09:57:25 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/xena: libvirt: Add a workaround to skip compareCPU() on destination https://review.opendev.org/c/openstack/nova/+/871975 | |
| 09:57:26 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/xena: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851205 | |
| 09:57:27 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/xena: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/872011 | |
| 09:57:29 | ralonsoh | sean-k-mooney, is in two weeks | |
| 09:57:36 | sean-k-mooney | so both os-vif and ovsdbapp need to have this merged by then | |
| 09:57:42 | sean-k-mooney | ralonsoh: no that is feature freeze | |
| 09:57:49 | sean-k-mooney | not the non-client lib freeze | |
| 09:58:13 | sean-k-mooney | the non-clint lib freeze is the 9th | |
| 09:58:26 | sean-k-mooney | https://releases.openstack.org/antelope/schedule.html | |
| 09:58:56 | bauzas | sahid: sean-k-mooney: series sent to the gate with an ask for a FUP for 2 nits | |
| 09:59:33 | sean-k-mooney | thanks if you still have energy to review i tested dans serise this morning | |
| 10:00:00 | sean-k-mooney | it worked as expect although one error could be better | |
| 10:00:16 | sean-k-mooney | again i think thats fixable in a follow up too | |
| 10:00:24 | sean-k-mooney | so i dont think we need to wait for that | |
| 10:01:20 | sean-k-mooney | ralonsoh: ill try an loop back to the os-vif change once ci has run | |
| 10:01:30 | ralonsoh | sean-k-mooney, thanks a lot | |
| 10:01:49 | sean-k-mooney | i know its not actully used really right now so it cant break just want to make sure everythign else is fine with it | |
| 10:02:59 | opendevreview | Jorge San Emeterio proposed openstack/nova master: Dividing global privsep profile https://review.opendev.org/c/openstack/nova/+/871729 | |
| 10:05:46 | bauzas | sean-k-mooney: working hard on cutting the fake sysfs dir btw. for my own series | |
| 10:05:54 | bauzas | definitely too large for our gate | |
| 10:06:34 | sean-k-mooney | you only need a small subset of it currently | |
| 10:07:13 | sean-k-mooney | if you need me to generate new data i can | |
| 10:32:36 | bauzas | sean-k-mooney: yeah, I need to cut some numbers, unless you have another smaller sysfs, my proposal is just to drop a few cpus and related info | |
| 10:36:36 | sean-k-mooney | you can drop entires trees in the fake file system | |
| 10:36:46 | sean-k-mooney | like the numa nodes and memory | |
| 10:37:31 | opendevreview | Merged openstack/nova stable/zed: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871413 | |
| 10:38:35 | bauzas | once I'm done with downstream stuff, I'll cut | |
| 10:48:33 | opendevreview | Jorge San Emeterio proposed openstack/nova master: WIP: Moving privsep profiles to nova/__init__.py https://review.opendev.org/c/openstack/nova/+/872010 | |
| 10:55:52 | gibi | dansmith sean-k-mooney: I've approved the rest of the stable compute uuid series. | |
| 10:56:05 | sean-k-mooney | cool | |
| 10:56:11 | bauzas | ditto | |
| 10:56:17 | sean-k-mooney | did you have any issues or concerns | |
| 10:56:19 | bauzas | even the top patch which was WIP yesterday ? | |
| 10:56:39 | gibi | I dont see any wip patches | |
| 10:56:40 | sean-k-mooney | dan pushed stuff yesterday evening | |
| 10:56:47 | sean-k-mooney | after you signed off | |
| 10:56:59 | gibi | https://review.opendev.org/q/topic:bp%252Fstable-compute-uuid | |
| 10:57:10 | sean-k-mooney | i woke up at 5 am today so i reviewd and tested all the new patches this morning | |
| 10:57:36 | gibi | I think we are in good shape here | |
| 10:58:44 | sean-k-mooney | bauzas: dansmith took the suggestion of adding a STUB_COMPUTE_ID class property | |
| 10:58:47 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/872204/5/nova/test.py#178 | |
| 10:58:57 | sean-k-mooney | and that allwoed them to get the final tests working | |
| 10:59:21 | sean-k-mooney | by sutubing _ensure_existing_node_identity by default expect in tests that are testin git | |
| 11:00:17 | sean-k-mooney | bauzas: if your interested in the extra manual tests i did my notes are here https://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L382 | |
| 11:01:15 | gibi | sean-k-mooney: yeah I saw that, make sense | |
| 11:01:33 | gibi | our compute start / restart logic in func test is a but messy | |
| 11:02:19 | sean-k-mooney | ya but its a useful mess most of the time :) | |
| 11:03:49 | sean-k-mooney | gibi: did you intend to +w https://review.opendev.org/c/openstack/nova/+/872220 bauzas do you want ot have a look or will i send it into the gate | |
| 11:04:21 | sean-k-mooney | gibi: you set review priorty +2 which you may or may not have intneded :) | |
| 11:10:23 | gibi | sean-k-mooney: my bad, fixed it | |