| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-01 | |||
| 08:53:03 | sean-k-mooney | has the neutron work been accpeted yet | |
| 08:53:20 | sean-k-mooney | and if so is it implemtned/reviewd or pending | |
| 09:11:04 | opendevreview | ribaudr proposed openstack/os-traits master: Add 'COMPUTE_SHARE_LOCAL_FS' https://review.opendev.org/c/openstack/os-traits/+/872185 | |
| 09:31:11 | sean-k-mooney | bauzas: gibi im happy with both sahid's seriese and dans at this point and think we can proceed with merging both if ye can rereview them again this morning that would be great | |
| 09:32:17 | bauzas | sean-k-mooney: yup I wanted to look at it yesterday, will do it this morning | |
| 09:33:19 | sahid | o/ ++ guys, I will be around if you want me to change or add something | |
| 09:33:50 | sean-k-mooney | there were some trivial nits but i was fine with a followup patch for those | |
| 09:34:06 | sahid | sure I will do that | |
| 09:34:56 | sean-k-mooney | at this point i would prefer to land the changes so that the sdk/osc changes can merge ectra and so you can avoid any conflicts on api ro compute service verison | |
| 09:35:07 | sahid | ++ | |
| 09:53:49 | opendevreview | Rodolfo Alonso proposed openstack/os-vif master: Implement "BaseCommand" result property https://review.opendev.org/c/openstack/os-vif/+/872391 | |
| 09:55:48 | sean-k-mooney | ralonsoh: ok so that is a premtive mesure to allow the ovsdbapp to be updated when its relased. | |
| 09:56:03 | ralonsoh | sean-k-mooney, yes | |
| 09:56:17 | sean-k-mooney | your cutting it kind of close | |
| 09:56:36 | ralonsoh | sean-k-mooney, I know that, that's why I'm speeding it | |
| 09:57:13 | sean-k-mooney | well more that the non clien lib free is thurday week | |
| 09:57:25 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/xena: libvirt: Add a workaround to skip compareCPU() on destination https://review.opendev.org/c/openstack/nova/+/871975 | |
| 09:57:26 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/xena: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851205 | |
| 09:57:27 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/xena: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/872011 | |
| 09:57:29 | ralonsoh | sean-k-mooney, is in two weeks | |
| 09:57:36 | sean-k-mooney | so both os-vif and ovsdbapp need to have this merged by then | |
| 09:57:42 | sean-k-mooney | ralonsoh: no that is feature freeze | |
| 09:57:49 | sean-k-mooney | not the non-client lib freeze | |
| 09:58:13 | sean-k-mooney | the non-clint lib freeze is the 9th | |
| 09:58:26 | sean-k-mooney | https://releases.openstack.org/antelope/schedule.html | |
| 09:58:56 | bauzas | sahid: sean-k-mooney: series sent to the gate with an ask for a FUP for 2 nits | |
| 09:59:33 | sean-k-mooney | thanks if you still have energy to review i tested dans serise this morning | |
| 10:00:00 | sean-k-mooney | it worked as expect although one error could be better | |
| 10:00:16 | sean-k-mooney | again i think thats fixable in a follow up too | |
| 10:00:24 | sean-k-mooney | so i dont think we need to wait for that | |
| 10:01:20 | sean-k-mooney | ralonsoh: ill try an loop back to the os-vif change once ci has run | |
| 10:01:30 | ralonsoh | sean-k-mooney, thanks a lot | |
| 10:01:49 | sean-k-mooney | i know its not actully used really right now so it cant break just want to make sure everythign else is fine with it | |
| 10:02:59 | opendevreview | Jorge San Emeterio proposed openstack/nova master: Dividing global privsep profile https://review.opendev.org/c/openstack/nova/+/871729 | |
| 10:05:46 | bauzas | sean-k-mooney: working hard on cutting the fake sysfs dir btw. for my own series | |
| 10:05:54 | bauzas | definitely too large for our gate | |
| 10:06:34 | sean-k-mooney | you only need a small subset of it currently | |
| 10:07:13 | sean-k-mooney | if you need me to generate new data i can | |
| 10:32:36 | bauzas | sean-k-mooney: yeah, I need to cut some numbers, unless you have another smaller sysfs, my proposal is just to drop a few cpus and related info | |
| 10:36:36 | sean-k-mooney | you can drop entires trees in the fake file system | |
| 10:36:46 | sean-k-mooney | like the numa nodes and memory | |
| 10:37:31 | opendevreview | Merged openstack/nova stable/zed: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871413 | |
| 10:38:35 | bauzas | once I'm done with downstream stuff, I'll cut | |
| 10:48:33 | opendevreview | Jorge San Emeterio proposed openstack/nova master: WIP: Moving privsep profiles to nova/__init__.py https://review.opendev.org/c/openstack/nova/+/872010 | |
| 10:55:52 | gibi | dansmith sean-k-mooney: I've approved the rest of the stable compute uuid series. | |
| 10:56:05 | sean-k-mooney | cool | |
| 10:56:11 | bauzas | ditto | |
| 10:56:17 | sean-k-mooney | did you have any issues or concerns | |
| 10:56:19 | bauzas | even the top patch which was WIP yesterday ? | |
| 10:56:39 | gibi | I dont see any wip patches | |
| 10:56:40 | sean-k-mooney | dan pushed stuff yesterday evening | |
| 10:56:47 | sean-k-mooney | after you signed off | |
| 10:56:59 | gibi | https://review.opendev.org/q/topic:bp%252Fstable-compute-uuid | |
| 10:57:10 | sean-k-mooney | i woke up at 5 am today so i reviewd and tested all the new patches this morning | |
| 10:57:36 | gibi | I think we are in good shape here | |
| 10:58:44 | sean-k-mooney | bauzas: dansmith took the suggestion of adding a STUB_COMPUTE_ID class property | |
| 10:58:47 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/872204/5/nova/test.py#178 | |
| 10:58:57 | sean-k-mooney | and that allwoed them to get the final tests working | |
| 10:59:21 | sean-k-mooney | by sutubing _ensure_existing_node_identity by default expect in tests that are testin git | |
| 11:00:17 | sean-k-mooney | bauzas: if your interested in the extra manual tests i did my notes are here https://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L382 | |
| 11:01:15 | gibi | sean-k-mooney: yeah I saw that, make sense | |
| 11:01:33 | gibi | our compute start / restart logic in func test is a but messy | |
| 11:02:19 | sean-k-mooney | ya but its a useful mess most of the time :) | |
| 11:03:49 | sean-k-mooney | gibi: did you intend to +w https://review.opendev.org/c/openstack/nova/+/872220 bauzas do you want ot have a look or will i send it into the gate | |
| 11:04:21 | sean-k-mooney | gibi: you set review priorty +2 which you may or may not have intneded :) | |
| 11:10:23 | gibi | sean-k-mooney: my bad, fixed it | |
| 11:10:53 | gibi | sean-k-mooney, sahid: Am I correct here https://review.opendev.org/c/openstack/nova/+/858384/41/doc/api_samples/os-evacuate/v2.95/server-evacuate-find-host-req.json ? | |
| 11:11:40 | gibi | I think targetState only part of the RPC API but not the REST API | |
| 11:13:34 | bauzas | sean-k-mooney: gibi: sorry my internal brain concurrency mechanism is currently locked with a downstream semaphore | |
| 11:16:20 | sean-k-mooney | gibi: correct only RPC not RestAPI | |
| 11:16:40 | sean-k-mooney | gibi it used to be in the rest api but we remvoed it | |
| 11:17:05 | sean-k-mooney | that tells me our api sample tests are not validating extra fields | |
| 11:17:47 | gibi | sean-k-mooney: OK, then lets fix that sample in a FUP. other than that I have no issue with the evacuate series, but I only skimmed it as it was already approved | |
| 11:27:46 | bauzas | gibi: ++ and thanks for the spot | |
| 11:30:19 | sahid | thank you guys I'm building a patch to fix all the points that you noticed | |
| 11:47:32 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/wallaby: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851206 | |
| 11:47:33 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/wallaby: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/872402 | |
| 11:49:40 | opendevreview | Merged openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 11:49:48 | opendevreview | Merged openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 12:19:26 | sahid | i'm not sure about what should be changed for openstacksdk and python-openstackclient? | |
| 12:19:41 | sahid | a release note would be enough? | |
| 12:20:53 | sean-k-mooney | you need to bump the max microversion | |
| 12:20:57 | sean-k-mooney | thats about it | |
| 12:21:17 | sean-k-mooney | you could add help text for evacuate | |
| 12:21:26 | sean-k-mooney | to explian the new bahaivor in osc | |
| 12:21:33 | sean-k-mooney | that would also be a good addtion | |
| 12:21:48 | sahid | yes i was thinking about that too | |
| 12:38:25 | opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if base image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | |
| 13:05:29 | artom | sahid, I think I'll need to add the 2.94 bump before yours though (for the FQDN hostname) | |
| 13:05:46 | artom | Don't think I need to do anything else, since we don't appear to validate the hostname anywhere in the client, so it can already be an FQDN | |
| 13:05:59 | artom | sahid, actually, I suspect you can just bump directly to 2.95 and be done with it | |
| 13:07:54 | artom | Yeah, we don't do anything clientside | |
| 13:51:02 | sahid | artom: thank you ! | |
| 13:56:56 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: fup: support evacuate target state https://review.opendev.org/c/openstack/nova/+/872413 | |
| 13:58:17 | sahid | artom: i think i don't get where we should bump this version ? | |
| 14:12:25 | opendevreview | Jean-Sébastien Bevilacqua proposed openstack/nova master: Add Lustre support to nova https://review.opendev.org/c/openstack/nova/+/853786 | |
| 14:24:52 | artom | sahid, I don't know off the top of my head either, maybe I'll do both when I find it | |
| 14:49:18 | artom | sahid, so 2.95 doesn't actually change anything in the API itself, there's just a new default instance state? | |
| 14:49:25 | artom | after evacuation? | |
| 15:03:38 | opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if base image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | |