| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2023-02-01 | |||
| 10:01:49 | sean-k-mooney | i know its not actully used really right now so it cant break just want to make sure everythign else is fine with it | |
| 10:02:59 | opendevreview | Jorge San Emeterio proposed openstack/nova master: Dividing global privsep profile https://review.opendev.org/c/openstack/nova/+/871729 | |
| 10:05:46 | bauzas | sean-k-mooney: working hard on cutting the fake sysfs dir btw. for my own series | |
| 10:05:54 | bauzas | definitely too large for our gate | |
| 10:06:34 | sean-k-mooney | you only need a small subset of it currently | |
| 10:07:13 | sean-k-mooney | if you need me to generate new data i can | |
| 10:32:36 | bauzas | sean-k-mooney: yeah, I need to cut some numbers, unless you have another smaller sysfs, my proposal is just to drop a few cpus and related info | |
| 10:36:36 | sean-k-mooney | you can drop entires trees in the fake file system | |
| 10:36:46 | sean-k-mooney | like the numa nodes and memory | |
| 10:37:31 | opendevreview | Merged openstack/nova stable/zed: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/871413 | |
| 10:38:35 | bauzas | once I'm done with downstream stuff, I'll cut | |
| 10:48:33 | opendevreview | Jorge San Emeterio proposed openstack/nova master: WIP: Moving privsep profiles to nova/__init__.py https://review.opendev.org/c/openstack/nova/+/872010 | |
| 10:55:52 | gibi | dansmith sean-k-mooney: I've approved the rest of the stable compute uuid series. | |
| 10:56:05 | sean-k-mooney | cool | |
| 10:56:11 | bauzas | ditto | |
| 10:56:17 | sean-k-mooney | did you have any issues or concerns | |
| 10:56:19 | bauzas | even the top patch which was WIP yesterday ? | |
| 10:56:39 | gibi | I dont see any wip patches | |
| 10:56:40 | sean-k-mooney | dan pushed stuff yesterday evening | |
| 10:56:47 | sean-k-mooney | after you signed off | |
| 10:56:59 | gibi | https://review.opendev.org/q/topic:bp%252Fstable-compute-uuid | |
| 10:57:10 | sean-k-mooney | i woke up at 5 am today so i reviewd and tested all the new patches this morning | |
| 10:57:36 | gibi | I think we are in good shape here | |
| 10:58:44 | sean-k-mooney | bauzas: dansmith took the suggestion of adding a STUB_COMPUTE_ID class property | |
| 10:58:47 | sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/872204/5/nova/test.py#178 | |
| 10:58:57 | sean-k-mooney | and that allwoed them to get the final tests working | |
| 10:59:21 | sean-k-mooney | by sutubing _ensure_existing_node_identity by default expect in tests that are testin git | |
| 11:00:17 | sean-k-mooney | bauzas: if your interested in the extra manual tests i did my notes are here https://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L382 | |
| 11:01:15 | gibi | sean-k-mooney: yeah I saw that, make sense | |
| 11:01:33 | gibi | our compute start / restart logic in func test is a but messy | |
| 11:02:19 | sean-k-mooney | ya but its a useful mess most of the time :) | |
| 11:03:49 | sean-k-mooney | gibi: did you intend to +w https://review.opendev.org/c/openstack/nova/+/872220 bauzas do you want ot have a look or will i send it into the gate | |
| 11:04:21 | sean-k-mooney | gibi: you set review priorty +2 which you may or may not have intneded :) | |
| 11:10:23 | gibi | sean-k-mooney: my bad, fixed it | |
| 11:10:53 | gibi | sean-k-mooney, sahid: Am I correct here https://review.opendev.org/c/openstack/nova/+/858384/41/doc/api_samples/os-evacuate/v2.95/server-evacuate-find-host-req.json ? | |
| 11:11:40 | gibi | I think targetState only part of the RPC API but not the REST API | |
| 11:13:34 | bauzas | sean-k-mooney: gibi: sorry my internal brain concurrency mechanism is currently locked with a downstream semaphore | |
| 11:16:20 | sean-k-mooney | gibi: correct only RPC not RestAPI | |
| 11:16:40 | sean-k-mooney | gibi it used to be in the rest api but we remvoed it | |
| 11:17:05 | sean-k-mooney | that tells me our api sample tests are not validating extra fields | |
| 11:17:47 | gibi | sean-k-mooney: OK, then lets fix that sample in a FUP. other than that I have no issue with the evacuate series, but I only skimmed it as it was already approved | |
| 11:27:46 | bauzas | gibi: ++ and thanks for the spot | |
| 11:30:19 | sahid | thank you guys I'm building a patch to fix all the points that you noticed | |
| 11:47:32 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/wallaby: Add a workaround to skip hypervisor version check on LM https://review.opendev.org/c/openstack/nova/+/851206 | |
| 11:47:33 | opendevreview | Kashyap Chamarthy proposed openstack/nova stable/wallaby: libvirt: At start-up rework compareCPU() usage with a workaround https://review.opendev.org/c/openstack/nova/+/872402 | |
| 11:49:40 | opendevreview | Merged openstack/nova master: compute: enhance compute evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858383 | |
| 11:49:48 | opendevreview | Merged openstack/nova master: api: extend evacuate instance to support target state https://review.opendev.org/c/openstack/nova/+/858384 | |
| 12:19:26 | sahid | i'm not sure about what should be changed for openstacksdk and python-openstackclient? | |
| 12:19:41 | sahid | a release note would be enough? | |
| 12:20:53 | sean-k-mooney | you need to bump the max microversion | |
| 12:20:57 | sean-k-mooney | thats about it | |
| 12:21:17 | sean-k-mooney | you could add help text for evacuate | |
| 12:21:26 | sean-k-mooney | to explian the new bahaivor in osc | |
| 12:21:33 | sean-k-mooney | that would also be a good addtion | |
| 12:21:48 | sahid | yes i was thinking about that too | |
| 12:38:25 | opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if base image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | |
| 13:05:29 | artom | sahid, I think I'll need to add the 2.94 bump before yours though (for the FQDN hostname) | |
| 13:05:46 | artom | Don't think I need to do anything else, since we don't appear to validate the hostname anywhere in the client, so it can already be an FQDN | |
| 13:05:59 | artom | sahid, actually, I suspect you can just bump directly to 2.95 and be done with it | |
| 13:07:54 | artom | Yeah, we don't do anything clientside | |
| 13:51:02 | sahid | artom: thank you ! | |
| 13:56:56 | opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: fup: support evacuate target state https://review.opendev.org/c/openstack/nova/+/872413 | |
| 13:58:17 | sahid | artom: i think i don't get where we should bump this version ? | |
| 14:12:25 | opendevreview | Jean-Sébastien Bevilacqua proposed openstack/nova master: Add Lustre support to nova https://review.opendev.org/c/openstack/nova/+/853786 | |
| 14:24:52 | artom | sahid, I don't know off the top of my head either, maybe I'll do both when I find it | |
| 14:49:18 | artom | sahid, so 2.95 doesn't actually change anything in the API itself, there's just a new default instance state? | |
| 14:49:25 | artom | after evacuation? | |
| 15:03:38 | opendevreview | Maxim Monin proposed openstack/nova master: Server Rescue leads to Server ERROR state if base image is deleted https://review.opendev.org/c/openstack/nova/+/872385 | |
| 15:09:18 | opendevreview | Artom Lifshitz proposed openstack/python-novaclient master: Bump microversion to 2.95 https://review.opendev.org/c/openstack/python-novaclient/+/872418 | |
| 15:09:28 | artom | sahid ^^ | |
| 15:11:51 | artom | Hrmm, so how do we make this work for openstackclient? AFAICT there is no max microversion declaration anywhere | |
| 15:12:11 | artom | Does it just magically work if users pass --os-compute-api-version=2.95? | |
| 15:15:46 | artom | Oh, and we have no multinode functional tests for osc | |
| 15:15:51 | artom | So we can't even test 2.95 | |
| 15:26:48 | opendevreview | Artom Lifshitz proposed openstack/nova-specs master: Amend FQDN in hostname spec to reflect implementation https://review.opendev.org/c/openstack/nova-specs/+/872422 | |
| 16:47:08 | opendevreview | Dan Smith proposed openstack/nova master: Protect against a deleted node id file https://review.opendev.org/c/openstack/nova/+/872204 | |
| 16:47:08 | opendevreview | Dan Smith proposed openstack/nova master: Move comment about _destroy_evacuated_instances() https://review.opendev.org/c/openstack/nova/+/872348 | |
| 16:55:31 | opendevreview | Artom Lifshitz proposed openstack/python-novaclient master: Bump microversion to 2.95 https://review.opendev.org/c/openstack/python-novaclient/+/872418 | |
| 17:08:30 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove legacy migrations https://review.opendev.org/c/openstack/nova/+/872428 | |
| 17:08:31 | opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove the legacy 'migration_version' table https://review.opendev.org/c/openstack/nova/+/872429 | |
| 17:08:42 | stephenfin | sean-k-mooney: gibi: that should fix SQLA 2.0 compat ^ | |
| 17:19:41 | stephenfin | I think it's okay to drop them completely. We've supported automatic migration to alembic since Wallaby. Antelope will be 5 releases later which spans even the biggest fast-forward upgrade interval. Also, even with FFU we expect folks to run DB upgrades on each version so | |
| 17:23:44 | opendevreview | Dan Smith proposed openstack/nova master: Check our nodes for hypervisor_hostname changes https://review.opendev.org/c/openstack/nova/+/872220 | |
| 17:23:45 | opendevreview | Dan Smith proposed openstack/nova master: Protect against a deleted node id file https://review.opendev.org/c/openstack/nova/+/872204 | |
| 17:23:45 | opendevreview | Dan Smith proposed openstack/nova master: Move comment about _destroy_evacuated_instances() https://review.opendev.org/c/openstack/nova/+/872348 | |
| 17:23:46 | opendevreview | Dan Smith proposed openstack/nova master: Abort startup if nodename conflict is detected https://review.opendev.org/c/openstack/nova/+/872432 | |
| 17:23:52 | dansmith | gdi | |
| 18:11:05 | sean-k-mooney | stephenfin: ill take a look shortly | |
| 18:37:01 | opendevreview | Sylvain Bauza proposed openstack/nova master: cpu: interfaces for managing state and governor https://review.opendev.org/c/openstack/nova/+/868236 | |
| 18:37:02 | opendevreview | Sylvain Bauza proposed openstack/nova master: libvirt: let CPUs be power managed https://review.opendev.org/c/openstack/nova/+/821228 | |
| 18:37:02 | opendevreview | Sylvain Bauza proposed openstack/nova master: WIP: enable cpus when an instance is spawning https://review.opendev.org/c/openstack/nova/+/868237 | |
| 18:37:27 | bauzas | sean-k-mooney: looks like there is a discrepancy between the guest pcpu and the numa topology blob : | |
| 18:37:33 | bauzas | https://paste.opendev.org/show/bcAxuCSeroU2VHjfqpUx/ | |
| 18:40:31 | sean-k-mooney | thats the bug i reported last week | |
| 18:40:53 | sean-k-mooney | oh the power seriese | |
| 18:41:31 | sean-k-mooney | bauzas: let me check if you are usign the right data set | |
| 18:41:32 | bauzas | nevermind, I found the rootcase | |
| 18:41:37 | sean-k-mooney | ok | |
| 18:41:50 | sean-k-mooney | by the way just so you are aware | |
| 18:42:02 | sean-k-mooney | core 0 cant generally be turnned off | |