Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2022-12-16
15:20:35 ykarel will send a mail
15:23:33 kashyap ykarel: A quick tip: Ask them to keep you explicitly in Cc you on responses, as you're not subscribed to that list (I guess)
15:24:00 opendevreview Balazs Gibizer proposed openstack/nova master: Split ignored_tags in stats.py https://review.opendev.org/c/openstack/nova/+/867978
15:24:14 gibi sean-k-mooney: I did the split as we discussed ^^
15:24:37 ykarel Thanks kashyap, yes right /me not subscribed
16:17:46 ykarel kashyap, gibi sent https://listman.redhat.com/archives/libvirt-users/2022-December/013844.html
16:26:29 rloo hi sean-k-mooney, these should be ready to approve (zuul is happy anyway!): https://review.opendev.org/c/openstack/nova/+/867912, https://review.opendev.org/c/openstack/nova/+/867913 & https://review.opendev.org/c/openstack/nova/+/867914 (thanks!)
17:18:17 sean-k-mooney rloo: ack
17:29:16 opendevreview Edward Hope-Morley proposed openstack/nova stable/yoga: ignore deleted server groups in validation https://review.opendev.org/c/openstack/nova/+/867989
17:31:50 sean-k-mooney rloo: the older backports are not quite right
17:32:14 rloo sean-k-mooney: gahhhh. did you comment? I'll take a look.
17:32:15 sean-k-mooney the content is fine but it looks like you cherry picked form master in all cases instead of form the previous cherry pick
17:32:29 sean-k-mooney yep its pretty minor
17:32:38 rloo yes, i cherry picked from master. do you want to do it from previous cherry pick?
17:32:39 sean-k-mooney just the commit is wrong
17:33:05 sean-k-mooney rloo: yep you should cherry pick form the previous cherry prick
17:33:35 sean-k-mooney i think ironic does this slightly differntly due to how ye do bugfix branches
17:33:47 rloo geez. i thought if i used the UI to do the cherry pick, it'd do the right thing. the reason i didn't do from previous, was cuz things looked messier, heh.
17:33:57 sean-k-mooney for nova the backport go form newest to oldest branch and you cherry pick form the previosu branch
17:34:25 rloo i haven't been doing upstream stuff, so i don't even recall how ironic does it... i did try to find doc about it but gave up.
17:34:46 sean-k-mooney rloo: i acttully care about the cherry-pick lines less then other but i knwo melwitt and elodilles do like them to be done a specific way
17:35:41 sean-k-mooney for me i just do a git reset --hard origin/stable/<whatever> then git review -X <previous version>
17:35:51 rloo no worries. should i create new PRs, the 'right' way?
17:36:39 sean-k-mooney well they dont have to be new reviews just need to fix the commit message with the cherry pick lines
17:38:12 rloo well, if i manually do that -- there won't be a conflict in the wallaby one (if i recall) cuz the change was similar to the xena one. but i didn't tell you that, i'll fix the commit messages...
17:39:06 sean-k-mooney right so i do not normllay remove the confit bit in that case although i know other do
17:39:16 sean-k-mooney i do if others ask
17:39:27 rloo (and if someone had time to fix that UI so it doesn't allow cherry picking from master to n-2+ stable branches, heh)
17:39:58 sean-k-mooney one thing i have not tested is if the behvior change if the patch is merged
17:40:03 rloo sean-k-mooney: ahh, yes, you're right. if i had cherry picked from xena (which mentions the conflict), the wallaby one would have the same commit msg so.
17:40:04 sean-k-mooney i think it does
17:41:02 sean-k-mooney basically if its merged and you cherry pick it i think it addes the line properly
17:41:26 sean-k-mooney i think it only doesnt if you do it to an open reivew. this has changed in differnt gerrit versions
17:57:03 opendevreview Ruby Loo proposed openstack/nova stable/yoga: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867912
17:58:41 opendevreview Ruby Loo proposed openstack/nova stable/xena: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867913
18:00:29 opendevreview Ruby Loo proposed openstack/nova stable/wallaby: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867914
18:06:05 opendevreview Ruby Loo proposed openstack/nova stable/xena: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867913
18:07:48 opendevreview Ruby Loo proposed openstack/nova stable/wallaby: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867914
18:10:09 sean-k-mooney those all look good bauzas if you are around the next few days can you review them and babysit those through the gate
18:12:04 rloo sean-k-mooney: thx for reviewing them. now i feel like i should do more upstream stuff before i forget. ha ha. (I might backport https://review.opendev.org/c/openstack/nova/+/842478 just for fun, we don't have a need for that. yet.)
18:12:57 sean-k-mooney so my understandign is taht should not be needed with the fix you have backported
18:13:18 sean-k-mooney rloo: well it would be good to have if you disable the fix you backported
18:13:30 sean-k-mooney so i guess if you dont have cleaning and dont want the extra time
18:13:37 sean-k-mooney then having both might make sense
18:14:26 sean-k-mooney so looking at it quikly it shoudl be backportable too so if you want too go for it
18:15:06 rloo we have cleaning and we don't put nodes in maint often. but i could see that being useful for others, and who knows, we might want it. The trick is getting my downstream stuff done so I have time to do some upstream stuff ;)
18:16:04 sean-k-mooney i know that feeling right now my upstream time is 99% reviews currently
18:16:06 sean-k-mooney well and irc
18:16:48 rloo wow, i appreciate that and I'm sure others do to sean-k-mooney! Just don't burn out on that.
18:17:29 sean-k-mooney well its how i can best supprot the rest of the team
18:17:44 rloo ++++
18:18:09 sean-k-mooney i could write a bunch of code but i know it wont get reviewed quickly so while my upstream time is limited im puting it to reviews to enabel other to land there fixes
18:19:44 sean-k-mooney rloo: by the way if the ironic folks ever want to turn there json rpc impl into an oslo messaging dirver so we can deploy nova without rabbit... i would not be upset
18:22:13 sean-k-mooney zigo: are you still persuing ^
18:22:40 sean-k-mooney i ocationally look at https://review.opendev.org/q/topic:asyncio-nats but you know time
19:14:43 rloo sean-k-mooney: that is a great idea, might be good if you mentioned it in the ironic channel. problem is so few people, so many things we'd like to do. but worth it if we can get rid of rabbit....
19:32:44 opendevreview Ruby Loo proposed openstack/nova stable/zed: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/867924
21:27:45 opendevreview Ruby Loo proposed openstack/nova stable/yoga: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/868010
21:30:13 opendevreview Ruby Loo proposed openstack/nova stable/yoga: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/868010
21:30:53 opendevreview Ruby Loo proposed openstack/nova stable/xena: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/868011
21:33:04 opendevreview Ruby Loo proposed openstack/nova stable/xena: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/868011
21:33:33 opendevreview Ruby Loo proposed openstack/nova stable/wallaby: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/868012
21:36:15 opendevreview Ruby Loo proposed openstack/nova stable/wallaby: Ironic: retry when node not available https://review.opendev.org/c/openstack/nova/+/868012
#openstack-nova - 2022-12-17
17:01:30 opendevreview Merged openstack/nova stable/zed: Ironic nodes with instance reserved in placement https://review.opendev.org/c/openstack/nova/+/867642
17:12:33 opendevreview Merged openstack/nova master: Make allocation candidates available for scheduler filters https://review.opendev.org/c/openstack/nova/+/854119
#openstack-nova - 2022-12-19
02:26:44 congnt sean-k-mooney: Hi, what libvirt version fixed issue about Icelake without flag mpx? Thanks
02:40:22 congnt And what file xml in new libvirt version I can use for Icelake no mpx? I saw in libvirt 8.0, x86_Icelake-Server-noTSX.xml still have mpx flags. Thank you
08:43:30 opendevreview Nobuhiro MIKI proposed openstack/nova-specs master: Add maxphysaddr support for Libvirt https://review.opendev.org/c/openstack/nova-specs/+/861033
11:24:32 opendevreview Jorge San Emeterio proposed openstack/nova-specs master: Review usage of oslo-privsep library on Nova https://review.opendev.org/c/openstack/nova-specs/+/865432
12:22:44 sean-k-mooney i said this downstream but if im needed ping my matirx accout here sean-k-mooney[m] ill be disconencting my irc client until the new year when im back form pto
12:41:42 opendevreview Jan Hartkopf proposed openstack/nova-specs master: Repropose spec for updating user data https://review.opendev.org/c/openstack/nova-specs/+/863884
14:03:44 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
14:03:44 opendevreview ribaudr proposed openstack/nova master: Fix bug ... https://review.opendev.org/c/openstack/nova/+/868089
14:05:37 Uggla Hi gibi, could you have a look at the above patches ^
14:22:22 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
14:22:23 opendevreview ribaudr proposed openstack/nova master: Fix bug 2000069 https://review.opendev.org/c/openstack/nova/+/868089
14:32:48 gibi Uggla: you were faster, I've just left comment in the fix https://review.opendev.org/c/openstack/nova/+/868089
14:33:06 gibi but for the previous ps
14:33:24 Uggla gibi, yep I have seen them. And realize how dumb I am.
14:33:58 gibi Uggla: you are not dump, I think your reproducer and fix is correct. I only have minor nits
14:34:28 gibi I will be off after today, so if you can respin it still today then I can +2 it
14:35:05 gibi and then we can pull in bauzas to +A it :)
14:36:14 Uggla yep fixing it ASAP. Note: I have opened a nova bug on launchpad as well and assigned it to me. I think it is what is expected in this case.
14:39:54 gibi yepp
14:40:17 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
14:40:17 opendevreview ribaudr proposed openstack/nova master: Fix bug 2000069 https://review.opendev.org/c/openstack/nova/+/868089
14:56:05 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
14:56:05 opendevreview ribaudr proposed openstack/nova master: Fix bug 2000069 https://review.opendev.org/c/openstack/nova/+/868089
15:00:10 Uggla gibi, that should be ok now.
15:02:16 gibi Uggla: I'm +2 on both
15:04:39 Uggla gibi, cool ! hoping it will be ok for bauzas, but it is easier I can give him a chocolate bribe. :D
15:05:18 gibi :)
15:11:32 bauzas Uggla: gibi: sorry, focusing on finishing the cpu impl series
15:11:42 bauzas but I can try to look
15:14:08 bauzas Uggla: hmmm, I'm a bit torn about using an existing regression test
15:15:21 bauzas because if you want to backport a bugfix, it's simplier to have a specific regression test file
15:15:37 Uggla bauzas, I thought to create a new file, but it is more or less the same subject. That's the reason why I appended to the existing one.
15:16:12 bauzas Uggla: the problem is about backporting
15:16:44 Uggla bauzas, I understand if you wish I can split in another file.
15:17:50 bauzas Uggla: https://review.opendev.org/c/openstack/nova/+/868088

Earlier   Later