Earlier  
Posted Nick Remark
#openstack-nova - 2022-12-19
14:33:58 gibi Uggla: you are not dump, I think your reproducer and fix is correct. I only have minor nits
14:34:28 gibi I will be off after today, so if you can respin it still today then I can +2 it
14:35:05 gibi and then we can pull in bauzas to +A it :)
14:36:14 Uggla yep fixing it ASAP. Note: I have opened a nova bug on launchpad as well and assigned it to me. I think it is what is expected in this case.
14:39:54 gibi yepp
14:40:17 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
14:40:17 opendevreview ribaudr proposed openstack/nova master: Fix bug 2000069 https://review.opendev.org/c/openstack/nova/+/868089
14:56:05 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
14:56:05 opendevreview ribaudr proposed openstack/nova master: Fix bug 2000069 https://review.opendev.org/c/openstack/nova/+/868089
15:00:10 Uggla gibi, that should be ok now.
15:02:16 gibi Uggla: I'm +2 on both
15:04:39 Uggla gibi, cool ! hoping it will be ok for bauzas, but it is easier I can give him a chocolate bribe. :D
15:05:18 gibi :)
15:11:32 bauzas Uggla: gibi: sorry, focusing on finishing the cpu impl series
15:11:42 bauzas but I can try to look
15:14:08 bauzas Uggla: hmmm, I'm a bit torn about using an existing regression test
15:15:21 bauzas because if you want to backport a bugfix, it's simplier to have a specific regression test file
15:15:37 Uggla bauzas, I thought to create a new file, but it is more or less the same subject. That's the reason why I appended to the existing one.
15:16:12 bauzas Uggla: the problem is about backporting
15:16:44 Uggla bauzas, I understand if you wish I can split in another file.
15:17:50 bauzas Uggla: https://review.opendev.org/c/openstack/nova/+/868088
15:18:46 bauzas Uggla: I don't know if you want to backport the fix down to Train or if the existing regression file is on Train (for example), but here my concern is not really about *this* fix but rather about the usage
15:19:20 bauzas because as a reminder, people sometimes just looks at code and copy/paste what they want without thinking about any reason why we do or we don't this
15:20:10 Uggla ok, I guess it can be backported down to train as soon as Amit patch will be merged.
#openstack-nova - 2022-12-20
01:26:18 opendevreview Lin Yang proposed openstack/os-traits master: setuptools: Disable auto discovery https://review.opendev.org/c/openstack/os-traits/+/868148
01:26:19 opendevreview Lin Yang proposed openstack/os-traits master: CPU: add traits for new X86 feature "AMX" https://review.opendev.org/c/openstack/os-traits/+/868149
12:55:07 opendevreview Merged openstack/os-traits master: Update python classifier for python 3.10 https://review.opendev.org/c/openstack/os-traits/+/861466
13:13:17 opendevreview Merged openstack/osc-placement master: Update gate jobs as per the 2023.1 cycle testing runtime https://review.opendev.org/c/openstack/osc-placement/+/861470
15:03:12 opendevreview Merged openstack/nova master: add header alingment for PrettyTable 3.4.0 https://review.opendev.org/c/openstack/nova/+/855658
15:03:20 opendevreview Merged openstack/nova master: Add os_vif in nova-config-generator https://review.opendev.org/c/openstack/nova/+/863891
15:03:30 opendevreview Merged openstack/nova master: Fix link to Cyborg device profiles API https://review.opendev.org/c/openstack/nova/+/859578
15:03:38 opendevreview Merged openstack/nova master: fix typo in architecture document https://review.opendev.org/c/openstack/nova/+/859201
15:05:29 opendevreview Merged openstack/nova master: Correct reST markup in config help string https://review.opendev.org/c/openstack/nova/+/859010
15:05:38 opendevreview Merged openstack/nova master: Modify the command of getting serial console https://review.opendev.org/c/openstack/nova/+/850729
16:07:02 opendevreview Merged openstack/nova master: db: Drop redundant indexes on instances and console_auth_tokens tables https://review.opendev.org/c/openstack/nova/+/856757
16:07:18 opendevreview Merged openstack/nova master: libvirt: fix typo in test_config https://review.opendev.org/c/openstack/nova/+/864641
16:07:26 opendevreview Merged openstack/nova master: Doc: Fix list servers detailed response param https://review.opendev.org/c/openstack/nova/+/862963
16:24:48 opendevreview Merged openstack/nova master: Update gate jobs as per the 2023.1 cycle testing runtime https://review.opendev.org/c/openstack/nova/+/861111
16:24:57 opendevreview Merged openstack/nova master: Improving logging at '_allocate_mdevs'. https://review.opendev.org/c/openstack/nova/+/861146
16:25:05 opendevreview Merged openstack/nova master: Add a hacking rule for the setDaemon method https://review.opendev.org/c/openstack/nova/+/854653
16:25:13 opendevreview Merged openstack/nova stable/yoga: Adapt websocketproxy tests for SimpleHTTPServer fix https://review.opendev.org/c/openstack/nova/+/866192
16:25:19 opendevreview Merged openstack/nova stable/yoga: Handle "no RAM info was set" migration case https://review.opendev.org/c/openstack/nova/+/860733
16:25:23 opendevreview Merged openstack/placement stable/wallaby: placement-status: check only consumers in allocation table https://review.opendev.org/c/openstack/placement/+/840701
16:25:26 opendevreview Merged openstack/placement stable/victoria: placement-status: check only consumers in allocation table https://review.opendev.org/c/openstack/placement/+/840702
16:32:46 opendevreview Stephen Finucane proposed openstack/nova master: Remove use of removeprefix https://review.opendev.org/c/openstack/nova/+/867788
16:32:46 opendevreview Stephen Finucane proposed openstack/nova master: Remove unused mocks https://review.opendev.org/c/openstack/nova/+/867789
16:32:47 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for add/remove instance info from node https://review.opendev.org/c/openstack/nova/+/659691
16:32:47 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/c/openstack/nova/+/670213
16:32:48 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for volume_target.* https://review.opendev.org/c/openstack/nova/+/867790
16:32:48 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for node.set_provision_state https://review.opendev.org/c/openstack/nova/+/867791
16:32:49 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for node.set_power_state https://review.opendev.org/c/openstack/nova/+/867792
16:32:50 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for node.vif* https://review.opendev.org/c/openstack/nova/+/867793
16:32:50 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for remaining network operations https://review.opendev.org/c/openstack/nova/+/867794
16:32:52 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for remaining ironic driver calls https://review.opendev.org/c/openstack/nova/+/867795
16:32:52 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for deprecated baremetal proxy API https://review.opendev.org/c/openstack/nova/+/867796
16:32:54 opendevreview Stephen Finucane proposed openstack/nova master: Remove Ironic client wrapper https://review.opendev.org/c/openstack/nova/+/867797
16:32:54 opendevreview Stephen Finucane proposed openstack/nova master: Remove unnecessary aliasing https://review.opendev.org/c/openstack/nova/+/867798
16:32:56 opendevreview Stephen Finucane proposed openstack/nova master: Use real SDK objects in tests https://review.opendev.org/c/openstack/nova/+/867799
16:51:06 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
16:51:06 opendevreview ribaudr proposed openstack/nova master: Fix bug 2000069 https://review.opendev.org/c/openstack/nova/+/868089
17:41:42 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
17:41:43 opendevreview ribaudr proposed openstack/nova master: Fix bug 2000069 https://review.opendev.org/c/openstack/nova/+/868089
18:39:48 opendevreview Sylvain Bauza proposed openstack/nova master: libvirt: let CPUs be power managed https://review.opendev.org/c/openstack/nova/+/821228
18:39:49 opendevreview Sylvain Bauza proposed openstack/nova master: cpu: interfaces for managing state and governor https://review.opendev.org/c/openstack/nova/+/868236
18:39:49 opendevreview Sylvain Bauza proposed openstack/nova master: WIP: enable cpus when an instance is spawning https://review.opendev.org/c/openstack/nova/+/868237
19:00:25 opendevreview Sylvain Bauza proposed openstack/nova master: cpu: interfaces for managing state and governor https://review.opendev.org/c/openstack/nova/+/868236
19:00:26 opendevreview Sylvain Bauza proposed openstack/nova master: libvirt: let CPUs be power managed https://review.opendev.org/c/openstack/nova/+/821228
19:00:26 opendevreview Sylvain Bauza proposed openstack/nova master: WIP: enable cpus when an instance is spawning https://review.opendev.org/c/openstack/nova/+/868237
19:00:32 opendevreview Sylvain Bauza proposed openstack/nova master: Add a fake sys filesystem for the next patch https://review.opendev.org/c/openstack/nova/+/868238
19:05:01 opendevreview Merged openstack/nova master: Filter PCI pools based on Placement allocation https://review.opendev.org/c/openstack/nova/+/854120
19:25:33 opendevreview Merged openstack/nova stable/train: Reproduce bug 1896463 in func env https://review.opendev.org/c/openstack/nova/+/841288
20:16:48 opendevreview Merged openstack/nova stable/train: Set instance host and drop migration under lock https://review.opendev.org/c/openstack/nova/+/841444
#openstack-nova - 2022-12-21
09:18:01 Uggla Hello bauzas, if you have a moment to look at: https://review.opendev.org/c/openstack/nova/+/868088 although there is no hurry.
10:19:14 bauzas Uggla: sure
10:32:42 bauzas Uggla: done https://review.opendev.org/c/openstack/nova/+/868088
10:48:52 Uggla bauzas, thx I'm gonna have a look
10:49:13 bauzas Uggla: if you need help, I have a few hours left before end of my working year :)
10:49:44 bauzas Uggla: IIRC, we maybe also have this pattern in the unittests
10:58:50 opendevreview Stephen Finucane proposed openstack/nova master: DNM: Identify why internal_info' isn't being set. https://review.opendev.org/c/openstack/nova/+/868306
14:16:05 opendevreview ribaudr proposed openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures https://review.opendev.org/c/openstack/nova/+/868088
14:16:06 opendevreview ribaudr proposed openstack/nova master: Fix bug 2000069 https://review.opendev.org/c/openstack/nova/+/868089
14:24:00 Uggla bauzas, if you can have a look ^ before leaving.
14:26:13 frickler lp broke the 2M mark? cool
14:38:52 opendevreview Jean-Sébastien Bevilacqua proposed openstack/nova master: Add Lustre support to nova https://review.opendev.org/c/openstack/nova/+/853786
15:03:48 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for getting network metadata from node https://review.opendev.org/c/openstack/nova/+/670213
15:03:49 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for volume_target.* https://review.opendev.org/c/openstack/nova/+/867790
15:03:49 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for node.set_provision_state https://review.opendev.org/c/openstack/nova/+/867791
15:03:50 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for node.set_power_state https://review.opendev.org/c/openstack/nova/+/867792
15:03:50 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for node.vif* https://review.opendev.org/c/openstack/nova/+/867793
15:03:51 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for remaining network operations https://review.opendev.org/c/openstack/nova/+/867794
15:03:51 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for remaining ironic driver calls https://review.opendev.org/c/openstack/nova/+/867795
15:03:52 opendevreview Stephen Finucane proposed openstack/nova master: Use SDK for deprecated baremetal proxy API https://review.opendev.org/c/openstack/nova/+/867796
15:03:52 opendevreview Stephen Finucane proposed openstack/nova master: Remove Ironic client wrapper https://review.opendev.org/c/openstack/nova/+/867797
15:03:54 opendevreview Stephen Finucane proposed openstack/nova master: Remove unnecessary aliasing https://review.opendev.org/c/openstack/nova/+/867798
15:03:54 opendevreview Stephen Finucane proposed openstack/nova master: Use real SDK objects in tests https://review.opendev.org/c/openstack/nova/+/867799
15:07:27 stephenfin gibi: Not sure you're still around but if you are, did I get to everything PCI-in-placement related yesterday?
15:10:50 gibi stephenfin: I'm off officially, but here right now
15:10:58 gibi I saw your feedback on the PCI series
15:11:05 gibi thanks for the review
15:11:42 gibi and yes you covered the whole thing

Earlier   Later