Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-27
17:58:48 gmann yeah. it is better way
18:00:10 gmann and this warning in doc still valid for option2 also - https://review.opendev.org/#/c/748059/1/doc/source/configuration/policy-concepts.rst
18:00:29 gmann or we should add default value things also here?
18:01:03 dansmith warning applies to either for sure, I wouldn't add the json fallback here
18:01:16 gmann ok
18:01:18 dansmith I would only mention the fallback in the reno
18:02:19 gmann will update patch with option2 once oslo.policy is released. thanks dansmith sean-k-mooney .
18:08:15 dansmith cool, thanks gmann !
18:08:27 gmann dansmith: but i will add "elif CONF.policy_file == OLD_POLICY_FILE:" for case - policy.json exist but an old, not supposed to be used file and CONF.policy_file =nova_policy.* means overridden file
18:09:07 dansmith gmann: then I will -1 it :)
18:09:13 gmann so that we do not pick not-supposed-to-use but existing policy.json
18:09:15 gmann :)
18:09:30 dansmith if CONF.policy_file is set to anything, then we should do what they ask
18:10:04 dansmith but go ahead and propose what you want and let sean-k-mooney and I have a chance to -1 with discussion and we can do it there, which might be easier since we can reference actual code and lines
18:10:59 gmann but where you are checking override file?
18:11:04 gmann ok
18:13:12 dansmith bnemec: apologize for asking this again, but.. there's some oslo_config method for determining if the conf option has been set or not right?
18:13:59 mriedem set vs the value coming from a default?
18:14:00 dansmith bnemec: is it just opt.value == opt.default ?
18:14:06 dansmith mriedem: yeah
18:14:12 mriedem there is some location thing i thought
18:14:19 mriedem which says where the value comes from
18:14:48 mriedem https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L57
18:14:58 bnemec Yes
18:15:06 dansmith okay, perfect
18:15:34 bnemec Docs are here: https://docs.openstack.org/oslo.config/latest/reference/locations.html
18:15:41 dansmith gmann: for sean-k-mooney and my desired behavior, the *only* thing you need to check is if CONF.policy_file's location == opt_default :)
18:15:43 gmann +1, that can save any accidental pick of file if both extensions exist
18:15:52 dansmith right
18:16:49 gmann +1. CONF.policy_file's location in [opt_default, set_default ] as nova will do set_default to change the default.
18:18:59 dansmith ack
18:39:06 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Improve CinderFixtureNewAttachFlow https://review.opendev.org/748509
18:39:07 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Robustify attachment tracking in CinderFixtureNewAttachFlow https://review.opendev.org/748510
18:39:08 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: compute: Use source_bdms to reset attachment_ids during LM rollback https://review.opendev.org/748511
18:39:09 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: compute: refactor volume bdm rollback error handling https://review.opendev.org/748512
18:39:11 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: WIP Add regression tests for bug #1889108 https://review.opendev.org/748513
18:39:11 openstack bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
18:39:12 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748514
18:54:30 lyarwood melwitt: https://review.opendev.org/#/c/742415/ - can you look at this if you get time, it's holding up the CVE on stable/train
18:54:49 lyarwood melwitt: well the release at least
19:03:29 ganso hello Nova folks! I just logged bug: https://bugs.launchpad.net/nova/+bug/1893263 after reproducing the issue on master. I am planning to work on the fix myself, however, I am curious to know if anyone here knows the reason why plug_tap() needs to run, as if the instance is ever being rebooted, the tap device goes away and is re-created by libvirt instead (therefore plug_tap() seems to have never needed to run at all)
19:03:29 openstack Launchpad bug 1893263 in OpenStack Compute (nova) "Cannot create instance with multiqueue image and vif_type=tap (calico)" [Undecided,New]
19:04:08 ganso because one of the possible fixes is just to remove plug_tap() and be happy
19:07:49 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: Add regression tests for bug #1889108 https://review.opendev.org/748494
19:07:49 openstack bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
19:07:50 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: compute: refactor volume bdm rollback error handling https://review.opendev.org/748495
19:07:50 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748496
19:11:33 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Add regression tests for bug #1889108 https://review.opendev.org/748513
19:11:33 openstack bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
19:11:34 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748514
19:26:05 melwitt lyarwood: ack will do
19:30:22 lyarwood melwitt: thanks! :)
19:31:32 lyarwood artom: https://review.opendev.org/#/c/747451/ - LGTM, I've got a few questions but I'm not comfortable +2+W'ing networking stuff so even with these answered I'm going to defer to other cores on this one
19:31:55 melwitt sean-k-mooney: fyi I added you to review https://review.opendev.org/747451 please. iirc you have said using the cache is fine but it would be good if you could ack it
19:32:14 lyarwood ah there we go \o/
20:16:57 openstackgerrit melanie witt proposed openstack/nova master: Change default num_retries for glance to 3 https://review.opendev.org/740389
20:37:26 openstackgerrit Rodrigo Barbieri proposed openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533
21:57:54 sean-k-mooney melwitt: yes, when using multiple port bindings the ports are still active on the source host at this point and when not using multiple portbining we update the neutron port later in post_live_migration_at_destination
21:59:22 sean-k-mooney melwitt: there are other point in pre live migration where it would also be valid to use the cache for the same reason
22:00:05 gmann stephenfin: you forgot to update this test - https://review.opendev.org/#/c/745906/4/nova/tests/functional/api_sample_tests/test_servers.py@978
22:00:54 sean-k-mooney i can note as much in the review
22:01:51 melwitt sean-k-mooney: yes, it would be ideal if you could review the change as you're expert on the network stuff
22:17:39 sean-k-mooney melwitt: actully if you dont mind ill review artoms change tomorrow. but ill leave it open to remind me.
22:18:02 melwitt sure, thanks
22:26:40 sean-k-mooney sorry brain has alreay turned off. we had tunder today so have had a headache all enving. cam back to check something quickly but dont have the brain power to review something properly
22:29:28 melwitt np at all, take some rest
23:19:26 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547
23:30:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547
23:39:38 openstackgerrit melanie witt proposed openstack/nova master: Default user_id when not specified in check_num_instances_quota https://review.opendev.org/748550
#openstack-nova - 2020-08-28
00:38:45 openstackgerrit renminmin proposed openstack/nova master: SRIOV: Fix instance with macvtap port live migration failed https://review.opendev.org/738432
00:46:25 openstackgerrit renminmin proposed openstack/nova master: Fix instance booted with snapshot image and bdms https://review.opendev.org/745821
01:10:03 openstackgerrit Merged openstack/nova stable/ussuri: Add checks for volume status when rebuilding https://review.opendev.org/747122
01:23:05 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
01:38:08 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
01:43:05 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
01:53:04 openstackgerrit Brin Zhang proposed openstack/nova master: Remove `TODO` as we have already supported the decorator https://review.opendev.org/748560
03:10:22 openstackgerrit Merged openstack/nova stable/ussuri: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747609
03:20:58 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
03:23:57 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
03:34:47 openstackgerrit Merged openstack/nova master: Add generic reproducer for bug #1879878 https://review.opendev.org/747744
03:34:47 openstack bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane)
03:34:58 openstackgerrit Merged openstack/nova stable/ussuri: tests: Add reproducer for bug #1889633 https://review.opendev.org/748251
03:34:58 openstack bug 1889633 in OpenStack Compute (nova) ussuri "Pinned instance with thread policy can consume VCPU" [High,In progress] https://launchpad.net/bugs/1889633 - Assigned to Stephen Finucane (stephenfinucane)
03:35:04 openstackgerrit Merged openstack/nova stable/ussuri: hardware: Reject requests for no hyperthreads on hosts with HT https://review.opendev.org/748252
03:53:13 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
03:55:39 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
06:21:35 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
06:43:35 openstackgerrit Xinran WANG proposed openstack/nova-specs master: SRIOV Enabled Nic Support Specification https://review.opendev.org/742785
07:48:06 openstackgerrit Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957
08:09:27 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326
08:20:26 bauzas good Friday Nova
08:21:45 stephenfin morning
08:22:09 aarents morning
08:25:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906
08:25:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907
08:25:19 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908
08:25:59 stephenfin gmann: Fixed up https://review.opendev.org/#/c/745906/ and the next two patches but lost your +2s in the process. Could you revisit today?
08:28:32 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
08:29:08 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
08:29:34 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777

Earlier   Later