Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-27
18:39:09 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: compute: refactor volume bdm rollback error handling https://review.opendev.org/748512
18:39:11 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: WIP Add regression tests for bug #1889108 https://review.opendev.org/748513
18:39:11 openstack bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
18:39:12 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748514
18:54:30 lyarwood melwitt: https://review.opendev.org/#/c/742415/ - can you look at this if you get time, it's holding up the CVE on stable/train
18:54:49 lyarwood melwitt: well the release at least
19:03:29 ganso hello Nova folks! I just logged bug: https://bugs.launchpad.net/nova/+bug/1893263 after reproducing the issue on master. I am planning to work on the fix myself, however, I am curious to know if anyone here knows the reason why plug_tap() needs to run, as if the instance is ever being rebooted, the tap device goes away and is re-created by libvirt instead (therefore plug_tap() seems to have never needed to run at all)
19:03:29 openstack Launchpad bug 1893263 in OpenStack Compute (nova) "Cannot create instance with multiqueue image and vif_type=tap (calico)" [Undecided,New]
19:04:08 ganso because one of the possible fixes is just to remove plug_tap() and be happy
19:07:49 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: Add regression tests for bug #1889108 https://review.opendev.org/748494
19:07:49 openstack bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
19:07:50 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: compute: refactor volume bdm rollback error handling https://review.opendev.org/748495
19:07:50 openstackgerrit Lee Yarwood proposed openstack/nova stable/train: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748496
19:11:33 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: Add regression tests for bug #1889108 https://review.opendev.org/748513
19:11:33 openstack bug 1889108 in OpenStack Compute (nova) train "failures during driver.pre_live_migration remove source attachments during rollback" [Undecided,In progress] https://launchpad.net/bugs/1889108 - Assigned to Lee Yarwood (lyarwood)
19:11:34 openstackgerrit Lee Yarwood proposed openstack/nova stable/stein: compute: Don't delete the original attachment during pre LM rollback https://review.opendev.org/748514
19:26:05 melwitt lyarwood: ack will do
19:30:22 lyarwood melwitt: thanks! :)
19:31:32 lyarwood artom: https://review.opendev.org/#/c/747451/ - LGTM, I've got a few questions but I'm not comfortable +2+W'ing networking stuff so even with these answered I'm going to defer to other cores on this one
19:31:55 melwitt sean-k-mooney: fyi I added you to review https://review.opendev.org/747451 please. iirc you have said using the cache is fine but it would be good if you could ack it
19:32:14 lyarwood ah there we go \o/
20:16:57 openstackgerrit melanie witt proposed openstack/nova master: Change default num_retries for glance to 3 https://review.opendev.org/740389
20:37:26 openstackgerrit Rodrigo Barbieri proposed openstack/nova master: Allow tap interface with multiqueue https://review.opendev.org/748533
21:57:54 sean-k-mooney melwitt: yes, when using multiple port bindings the ports are still active on the source host at this point and when not using multiple portbining we update the neutron port later in post_live_migration_at_destination
21:59:22 sean-k-mooney melwitt: there are other point in pre live migration where it would also be valid to use the cache for the same reason
22:00:05 gmann stephenfin: you forgot to update this test - https://review.opendev.org/#/c/745906/4/nova/tests/functional/api_sample_tests/test_servers.py@978
22:00:54 sean-k-mooney i can note as much in the review
22:01:51 melwitt sean-k-mooney: yes, it would be ideal if you could review the change as you're expert on the network stuff
22:17:39 sean-k-mooney melwitt: actully if you dont mind ill review artoms change tomorrow. but ill leave it open to remind me.
22:18:02 melwitt sure, thanks
22:26:40 sean-k-mooney sorry brain has alreay turned off. we had tunder today so have had a headache all enving. cam back to check something quickly but dont have the brain power to review something properly
22:29:28 melwitt np at all, take some rest
23:19:26 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547
23:30:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547
23:39:38 openstackgerrit melanie witt proposed openstack/nova master: Default user_id when not specified in check_num_instances_quota https://review.opendev.org/748550
#openstack-nova - 2020-08-28
00:38:45 openstackgerrit renminmin proposed openstack/nova master: SRIOV: Fix instance with macvtap port live migration failed https://review.opendev.org/738432
00:46:25 openstackgerrit renminmin proposed openstack/nova master: Fix instance booted with snapshot image and bdms https://review.opendev.org/745821
01:10:03 openstackgerrit Merged openstack/nova stable/ussuri: Add checks for volume status when rebuilding https://review.opendev.org/747122
01:23:05 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
01:38:08 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
01:43:05 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
01:53:04 openstackgerrit Brin Zhang proposed openstack/nova master: Remove `TODO` as we have already supported the decorator https://review.opendev.org/748560
03:10:22 openstackgerrit Merged openstack/nova stable/ussuri: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747609
03:20:58 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
03:23:57 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
03:34:47 openstackgerrit Merged openstack/nova master: Add generic reproducer for bug #1879878 https://review.opendev.org/747744
03:34:47 openstack bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane)
03:34:58 openstackgerrit Merged openstack/nova stable/ussuri: tests: Add reproducer for bug #1889633 https://review.opendev.org/748251
03:34:58 openstack bug 1889633 in OpenStack Compute (nova) ussuri "Pinned instance with thread policy can consume VCPU" [High,In progress] https://launchpad.net/bugs/1889633 - Assigned to Stephen Finucane (stephenfinucane)
03:35:04 openstackgerrit Merged openstack/nova stable/ussuri: hardware: Reject requests for no hyperthreads on hosts with HT https://review.opendev.org/748252
03:53:13 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
03:55:39 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
06:21:35 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
06:43:35 openstackgerrit Xinran WANG proposed openstack/nova-specs master: SRIOV Enabled Nic Support Specification https://review.opendev.org/742785
07:48:06 openstackgerrit Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957
08:09:27 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326
08:20:26 bauzas good Friday Nova
08:21:45 stephenfin morning
08:22:09 aarents morning
08:25:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906
08:25:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907
08:25:19 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908
08:25:59 stephenfin gmann: Fixed up https://review.opendev.org/#/c/745906/ and the next two patches but lost your +2s in the process. Could you revisit today?
08:28:32 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
08:29:08 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
08:29:34 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
08:29:44 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
08:29:56 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
08:35:18 openstackgerrit Brin Zhang proposed openstack/nova master: Remove `TODO` as we have already supported the decorator https://review.opendev.org/748560
08:49:46 brinzhang0 stephenfin: https://review.opendev.org/#/c/715326/22/nova/compute/api.py@3907
08:50:17 stephenfin brinzhang0: I've already replied
08:51:18 brinzhang0 stephenfin: I think I missed your mean, you mean we should add the new flavor_id(target flavor_id) to check the flavor whether contain the dp_name, then dicide to resize or reject
08:51:24 brinzhang0 right?
08:51:32 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
08:52:27 brinzhang0 stephenfin: I got your comment in the new patch, later we will consider to deal with that patch
08:53:13 brinzhang0 the cyborg evacuate support patch was updated, pls review if you are free today, thanks
08:53:22 stephenfin brinzhang0: Yes, I'm saying we need to check whether the new flavor contains dp_name also. Currently we are only checking the existing flavor
08:53:30 stephenfin brinzhang0: This is what I did for vTPM https://github.com/openstack/nova/blob/75b5535e3448335cb26972b5ca37afbd24dba01d/nova/compute/api.py#L3997-L4020
08:53:56 stephenfin But yes, this should be dealt with separately in a follow-up
08:56:43 brinzhang0 stephenfin: yeah, may we should add same_instance_type=False as the request parameter in the block_accelerators(), while we do resize, it shuold be set same_instance_type=True
09:09:45 brinzhang0 stephenfin: https://github.com/openstack/nova/blob/75b5535e3448335cb26972b5ca37afbd24dba01d/nova/compute/api.py#L3994-L3995
09:11:10 brinzhang0 if same_instance_type and flavor_id: raise(), if the same_flavor_type is True, the flavor_id must be true, do we need this judgement?
09:12:34 brinzhang0 sorry, if the this is a migrate operation, it will be fine \o
09:18:04 openstackgerrit Wenping Song proposed openstack/nova master: Process exception of delete resource provider https://review.opendev.org/748339
09:22:03 stephenfin brinzhang0: Yes. If you're cold migrating, then the flavor_id parameter should be unset. It should only be set if resizing
09:23:01 stephenfin and if it's set and is set to the ID of the same flavor as the existing instance flavor, that's an error
09:23:29 brinzhang0 stephenfin: yeah, short-circuited of my brain \o/
09:28:14 openstackgerrit Takashi Natsume proposed openstack/nova-specs master: Make 'Feature Liaison' optional in test https://review.opendev.org/748591
09:30:18 openstackgerrit Merged openstack/nova stable/train: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742415
09:37:12 jkulik Did we ever think of bubbling down a rename of an Instance to the actual driver? At least the vmwareapi driver names the VMs in the vCenter "{display_name} ({uuid})", which doesn't match after a rename anymore.
09:37:56 openstackgerrit Takashi Natsume proposed openstack/nova-specs master: Make 'Feature Liaison' optional in test https://review.opendev.org/748591
09:40:13 openstackgerrit Merged openstack/nova stable/train: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747358
09:40:20 openstackgerrit Merged openstack/nova stable/stein: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747974
09:40:28 openstackgerrit Merged openstack/nova master: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/711604
09:40:45 gibi o/
09:44:24 openstackgerrit Wenping Song proposed openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748593
10:10:18 jsuchome stephenfin gibi lyarwood: could you please agree on a way https://review.opendev.org/#/c/574301/ should be treated? I already said that I think it's better to follow what was decided in blueprint, but if you all agree it should be different, let's do it differently
10:14:35 gibi so as far as I see artom and stephen on the side of a new config. I have no hard oppionon on either side so I will fall in line with the rest and support the new config then
11:04:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Provide default 'host_info' for '_get_connection' https://review.opendev.org/746942
11:04:19 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943

Earlier   Later