Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-08-28
03:10:22 openstackgerrit Merged openstack/nova stable/ussuri: libvirt:driver:Disallow AIO=native when 'O_DIRECT' is not available https://review.opendev.org/747609
03:20:58 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
03:23:57 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
03:34:47 openstackgerrit Merged openstack/nova master: Add generic reproducer for bug #1879878 https://review.opendev.org/747744
03:34:47 openstack bug 1879878 in OpenStack Compute (nova) "VM become Error after confirming resize with Error info CPUUnpinningInvalid on source node " [Medium,In progress] https://launchpad.net/bugs/1879878 - Assigned to Stephen Finucane (stephenfinucane)
03:34:58 openstackgerrit Merged openstack/nova stable/ussuri: tests: Add reproducer for bug #1889633 https://review.opendev.org/748251
03:34:58 openstack bug 1889633 in OpenStack Compute (nova) ussuri "Pinned instance with thread policy can consume VCPU" [High,In progress] https://launchpad.net/bugs/1889633 - Assigned to Stephen Finucane (stephenfinucane)
03:35:04 openstackgerrit Merged openstack/nova stable/ussuri: hardware: Reject requests for no hyperthreads on hosts with HT https://review.opendev.org/748252
03:53:13 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
03:55:39 openstackgerrit Hao Sun proposed openstack/nova stable/train: Add checks for volume status when rebuilding https://review.opendev.org/748558
06:21:35 openstackgerrit Hao Sun proposed openstack/nova stable/stein: Add checks for volume status when rebuilding https://review.opendev.org/748559
06:43:35 openstackgerrit Xinran WANG proposed openstack/nova-specs master: SRIOV Enabled Nic Support Specification https://review.opendev.org/742785
07:48:06 openstackgerrit Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957
08:09:27 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326
08:20:26 bauzas good Friday Nova
08:21:45 stephenfin morning
08:22:09 aarents morning
08:25:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Enable real policy fixture by default https://review.opendev.org/745906
08:25:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add and use 'GlanceFixture' https://review.opendev.org/745907
08:25:19 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Remove '_FakeImageService' https://review.opendev.org/745908
08:25:59 stephenfin gmann: Fixed up https://review.opendev.org/#/c/745906/ and the next two patches but lost your +2s in the process. Could you revisit today?
08:28:32 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.moves https://review.opendev.org/727224
08:29:08 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.iteritems/itervalues/iterkeys https://review.opendev.org/727757
08:29:34 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.byte2int/int2byte https://review.opendev.org/727777
08:29:44 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.binary_type/integer_types/string_types https://review.opendev.org/728094
08:29:56 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (1/2) https://review.opendev.org/728109
08:35:18 openstackgerrit Brin Zhang proposed openstack/nova master: Remove `TODO` as we have already supported the decorator https://review.opendev.org/748560
08:49:46 brinzhang0 stephenfin: https://review.opendev.org/#/c/715326/22/nova/compute/api.py@3907
08:50:17 stephenfin brinzhang0: I've already replied
08:51:18 brinzhang0 stephenfin: I think I missed your mean, you mean we should add the new flavor_id(target flavor_id) to check the flavor whether contain the dp_name, then dicide to resize or reject
08:51:24 brinzhang0 right?
08:51:32 openstackgerrit Takashi Natsume proposed openstack/nova master: Remove six.text_type (2/2) https://review.opendev.org/728117
08:52:27 brinzhang0 stephenfin: I got your comment in the new patch, later we will consider to deal with that patch
08:53:13 brinzhang0 the cyborg evacuate support patch was updated, pls review if you are free today, thanks
08:53:22 stephenfin brinzhang0: Yes, I'm saying we need to check whether the new flavor contains dp_name also. Currently we are only checking the existing flavor
08:53:30 stephenfin brinzhang0: This is what I did for vTPM https://github.com/openstack/nova/blob/75b5535e3448335cb26972b5ca37afbd24dba01d/nova/compute/api.py#L3997-L4020
08:53:56 stephenfin But yes, this should be dealt with separately in a follow-up
08:56:43 brinzhang0 stephenfin: yeah, may we should add same_instance_type=False as the request parameter in the block_accelerators(), while we do resize, it shuold be set same_instance_type=True
09:09:45 brinzhang0 stephenfin: https://github.com/openstack/nova/blob/75b5535e3448335cb26972b5ca37afbd24dba01d/nova/compute/api.py#L3994-L3995
09:11:10 brinzhang0 if same_instance_type and flavor_id: raise(), if the same_flavor_type is True, the flavor_id must be true, do we need this judgement?
09:12:34 brinzhang0 sorry, if the this is a migrate operation, it will be fine \o
09:18:04 openstackgerrit Wenping Song proposed openstack/nova master: Process exception of delete resource provider https://review.opendev.org/748339
09:22:03 stephenfin brinzhang0: Yes. If you're cold migrating, then the flavor_id parameter should be unset. It should only be set if resizing
09:23:01 stephenfin and if it's set and is set to the ID of the same flavor as the existing instance flavor, that's an error
09:23:29 brinzhang0 stephenfin: yeah, short-circuited of my brain \o/
09:28:14 openstackgerrit Takashi Natsume proposed openstack/nova-specs master: Make 'Feature Liaison' optional in test https://review.opendev.org/748591
09:30:18 openstackgerrit Merged openstack/nova stable/train: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742415
09:37:12 jkulik Did we ever think of bubbling down a rename of an Instance to the actual driver? At least the vmwareapi driver names the VMs in the vCenter "{display_name} ({uuid})", which doesn't match after a rename anymore.
09:37:56 openstackgerrit Takashi Natsume proposed openstack/nova-specs master: Make 'Feature Liaison' optional in test https://review.opendev.org/748591
09:40:13 openstackgerrit Merged openstack/nova stable/train: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747358
09:40:20 openstackgerrit Merged openstack/nova stable/stein: libvirt: Provide VIR_MIGRATE_PARAM_PERSIST_XML during live migration https://review.opendev.org/747974
09:40:28 openstackgerrit Merged openstack/nova master: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/711604
09:40:45 gibi o/
09:44:24 openstackgerrit Wenping Song proposed openstack/nova master: Reject resize operation for accelerator https://review.opendev.org/748593
10:10:18 jsuchome stephenfin gibi lyarwood: could you please agree on a way https://review.opendev.org/#/c/574301/ should be treated? I already said that I think it's better to follow what was decided in blueprint, but if you all agree it should be different, let's do it differently
10:14:35 gibi so as far as I see artom and stephen on the side of a new config. I have no hard oppionon on either side so I will fall in line with the rest and support the new config then
11:04:18 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Provide default 'host_info' for '_get_connection' https://review.opendev.org/746942
11:04:19 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943
11:04:19 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944
11:04:20 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945
11:04:20 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add resize tests for PCI servers https://review.opendev.org/746946
11:04:21 openstackgerrit Stephen Finucane proposed openstack/nova master: conductor: Don't use setattr https://review.opendev.org/746947
11:04:21 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports https://review.opendev.org/746948
11:04:22 openstackgerrit Stephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949
11:04:22 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/746950
11:12:24 openstackgerrit Merged openstack/nova master: Change default num_retries for glance to 3 https://review.opendev.org/740389
11:20:13 elod lyarwood gibi : Train release patch, if you'll have time: https://review.opendev.org/#/c/748383/
11:27:30 gibi elod: +1
11:27:58 elod thx \o/
11:33:23 swp20 Stephenin: hi, when i run `python3 -m unittest nova.tests.unit.compute.test_api._ComputeAPIUnitTestMixIn.test_resize__with_vtpm`, it raise `TypeError: test_resize__with_vtpm() missing 1 required positional argument: 'mock_get_flavor'`, what's wrong?
11:34:09 swp20 stephenfin: hi, when i run `python3 -m unittest nova.tests.unit.compute.test_api._ComputeAPIUnitTestMixIn.test_resize__with_vtpm`, it raise `TypeError: test_resize__with_vtpm() missing 1 required positional argument: 'mock_get_flavor'`, what's wrong?
11:37:35 elod lyarwood: btw, do you want to wait with Stein release until these get merged: https://review.opendev.org/#/q/topic:bug/1887946+branch:stable/stein ?
11:40:12 openstackgerrit Balazs Gibizer proposed openstack/nova master: Make PCI claim NUMA aware during live migration https://review.opendev.org/748453
11:40:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995
11:40:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: DNM: tracing the PCI allocation code path https://review.opendev.org/748454
11:45:56 openstackgerrit Elod Illes proposed openstack/nova stable/stein: libvirt: Handle VIR_ERR_DEVICE_MISSING when detaching devices https://review.opendev.org/742416
11:45:57 openstackgerrit Elod Illes proposed openstack/nova stable/stein: libvirt: Do not reference VIR_ERR_DEVICE_MISSING when libvirt is < v4.1.0 https://review.opendev.org/747360
12:29:44 openstackgerrit Brin Zhang proposed openstack/nova master: Cyborg evacuate support https://review.opendev.org/715326
12:48:47 openstackgerrit Luyao Zhong proposed openstack/nova master: Introduce a new driver interface 'cleanup_instance' https://review.opendev.org/714653
12:48:48 openstackgerrit Luyao Zhong proposed openstack/nova master: Track error migrations in resource tracker https://review.opendev.org/745281
12:48:48 openstackgerrit Luyao Zhong proposed openstack/nova master: Improve orphans tracking in resource tracker https://review.opendev.org/745282
12:48:49 openstackgerrit Luyao Zhong proposed openstack/nova master: Rollback when reset running live migration https://review.opendev.org/747899
13:16:39 openstackgerrit Alexandre Arents proposed openstack/nova master: Add a lock to prevent race during detach/attach of interface https://review.opendev.org/747957
13:18:06 aarents Hum commit message edit re-trigger all the stuff.. Now I now
13:18:17 aarents know
13:21:15 sean-k-mooney yes but i dont think it clears +2
13:21:23 sean-k-mooney i do think it clears +w
13:21:49 sean-k-mooney assuming you only edit the comit and not the code
13:22:24 sean-k-mooney its treated like a rebase in that way
13:40:25 aarents sean-k-mooney: it seems in my case to have drop +2, NVM
13:48:49 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add 'start_compute' helper https://review.opendev.org/746943
13:48:50 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Use tempdir for CONF.instances_path https://review.opendev.org/746944
13:48:50 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Clean up PCI tests https://review.opendev.org/746945
13:48:51 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add resize tests for PCI servers https://review.opendev.org/746946
13:48:51 openstackgerrit Stephen Finucane proposed openstack/nova master: conductor: Don't use setattr https://review.opendev.org/746947
13:48:52 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add test for SR-IOV neutron ports https://review.opendev.org/746948
13:48:52 openstackgerrit Stephen Finucane proposed openstack/nova master: fixtures: Handle binding of first port https://review.opendev.org/746949
13:48:53 openstackgerrit Stephen Finucane proposed openstack/nova master: functional: Add live migration tests for PCI, SR-IOV servers https://review.opendev.org/746950
13:50:45 gmann stephenfin: done
14:08:53 stephenfin aarents: Could I get the comment here and I can fast approve, seeing as gibi was +2 before? https://review.opendev.org/#/c/747957/

Earlier   Later