Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-23
09:50:05 openstackgerrit Merged openstack/nova master: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/729261
09:50:23 stephenfin bauzas: What's the chances of having you work the vTPM stuff with lyarwood? I can handle the 'provider.yaml' stuff (and anything else) since I didn't write it, but not vTPM
09:50:47 bauzas stephenfin: by 'work', you mean 'reviews' ?
09:50:55 stephenfin Correct
09:50:57 bauzas I surely could for next week
09:51:17 bauzas that being said, I'm not an expert, but I guess this is not a drama.
09:51:25 stephenfin \o/
09:51:57 stephenfin It's not complicated. libvirt does all the work for us. Very much just wiring up
10:05:22 gibi stephenfin: sure, I will re-review the bottom of vtpm today
10:06:17 gibi bauzas: ack. have a nice vacation
10:08:49 openstackgerrit Jiri Suchomel proposed openstack/nova master: Add ability to download Glance images into the libvirt image cache via RBD https://review.opendev.org/574301
10:10:23 jsuchome Hi gibi, thanks for the review, I've just updated those whitespaces ^
10:13:56 gibi jsuchome: cool. I plugged my +2 back
10:14:01 gibi thanks
10:34:08 openstackgerrit Merged openstack/nova stable/stein: libvirt: Mark e1000e VIF as supported https://review.opendev.org/742390
10:47:54 openstackgerrit Merged openstack/nova stable/pike: libvirt: Do not reraise DiskNotFound exceptions during resize https://review.opendev.org/742181
10:48:00 openstackgerrit Merged openstack/nova master: test: add some notes and new tests for mixed instance https://review.opendev.org/741395
11:17:10 gibi stephenfin: there is small test thing is https://review.opendev.org/#/c/739210/5/nova/tests/unit/objects/test_image_meta.py@424 if you have time to respin the I will re-review, but it is also OK to fix it in a FUP
11:25:00 lyarwood stephenfin: FWIW I have the series open as well
12:07:05 openstackgerrit Stephen Finucane proposed openstack/nova master: trivial: Test object backporting against correct version https://review.opendev.org/742650
12:07:05 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Default request group to None https://review.opendev.org/742651
12:07:12 stephenfin lyarwood, gibi: ^
12:07:57 stephenfin The latter one is in merge conflict for now, but I'm hoping bauzas can review https://review.opendev.org/#/c/739210/ today (since he understands this stuff) and I can rebase it then :)
12:11:35 stephenfin gibi: Are versioned notifications the best solution for the race you identified in https://review.opendev.org/#/c/741285/ ?
12:12:05 gibi stephenfin: that could be a good one yes. you can also wait for instance actions
12:12:27 gibi I like notifications better for obvious reasons
12:12:37 gibi I know them better
12:13:00 stephenfin ack
12:28:50 gibi stephenfin: I'm +2 on the unsuffixed group defaulting
12:29:46 gibi also I executed a bunch of test runs on the top of your test refactoring patches to tease out any race but I can report that the tests are solid
12:29:59 gibi so good stuff! thanks!
12:38:07 bauzas stephenfin: ack, will look at the vTPM stuff today then
13:09:21 openstackgerrit Merged openstack/nova master: libvirt: Track blockjob status in DEBUG when polling for completion https://review.opendev.org/729595
13:17:36 openstackgerrit Merged openstack/nova stable/rocky: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/742258
13:29:14 dansmith gibi: yeah, I have one doc patch left that I haven't finished, but otherwise it's done IMHO
13:31:59 gibi dansmith: thanks. then I'll wait for the doc patch to land before I mark the bp implemented
13:34:42 dansmith gibi: ack
13:35:28 openstackgerrit Luigi Toscano proposed openstack/nova stable/queens: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/742668
14:42:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547
15:38:10 openstackgerrit Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285
15:42:08 bauzas stephenfin: fwiw, reviewing hard your https://review.opendev.org/#/c/739210/5 to see whether making vTPM types be an Enum is safe
15:42:25 stephenfin bauzas: Just replying. tl;dr: Look at https://github.com/openstack/nova/blob/da155cb495979726943806630eff1bed146b8605/nova/objects/instance_numa.py#L47-L52
15:43:51 stephenfin If we changed the field, we would be forced to bump the version number of any object that contained that object. We would also most likely add something like a service check that prevented use of the new TPM model/version until all computes were updated and could handle it
15:44:38 bauzas yup, I'm just saying it's a decision I need to evaluate
15:44:43 bauzas not saying it's bad
15:44:49 bauzas like,
15:45:04 bauzas you decided to enforce those types at the API level, which prevents a bit of issues
15:45:09 stephenfin ...which is similar to what huaquiang did for the introduction of the MIXED CPU policy. See commit 9ddc60539f53e24bb92ef711674f5be4c7c0bcc3
15:46:17 bauzas stephenfin: all the vTPM workflow is top-down (or northbound if you prefer), right?
15:46:43 bauzas ie. we just leave operators to define which model/version they want to expose
15:46:55 bauzas and then we pass this info down to libvirt eventually, right?
15:47:35 bauzas and we just make traits exposing those vTPM capabilities, right?
15:48:07 stephenfin Within reason. We check to make sure that (a) libvirt is new enough to support the feature, (b) the swtpm executable is available and (c) a key manager service is configured
15:48:18 bauzas so, per say, someone messes up and defines a flavor with a model that none of the computes know, then eventually it could have got a NoValidHost but we enforce the knowledge by an API verification
15:48:24 stephenfin Assuming all those are configured, we report the trait on the libvirt driver
15:48:33 bauzas amirite ?
15:48:40 stephenfin The API would reject that request outright
15:49:09 bauzas so, the main concern would be a new compute with a new model, we would need to wait a release ideally to bump the API
15:49:13 bauzas schema*
15:49:14 stephenfin Either when attempting to set the extra spec on the flavor if using a recent microversion with the flavor validation work
15:49:15 bauzas right?
15:49:31 stephenfin or when creating the server, since we verify all these stuff there now
15:50:14 gibi nova meeting starts in 10 minutes on #openstack-meeting-3
15:50:21 stephenfin No, we don't currently consider new/modified flavor extra specs or image metadata properties as warranting a new API microversion
15:50:24 stephenfin If that's what you mean
15:50:35 stephenfin We would need to introduce a new service version
15:50:46 stephenfin and wait until all compute nodes have been updated to that service version
15:51:14 stephenfin Like commit 9ddc60539f53e24bb92ef711674f5be4c7c0bcc3 I mentioned above
15:52:46 bauzas stephenfin: I need to review the approved spec
15:57:17 bauzas heh, https://specs.openstack.org/openstack/nova-specs/specs/victoria/approved/add-emulated-virtual-tpm.html#upgrade-impact
16:00:09 gibi lyarwood: ack
16:33:11 bauzas stephenfin: I'll name you John Dorian
16:33:24 bauzas and I'm just your Dr Cox
16:36:18 gibi aaaan beertime
16:36:21 gibi see you tomorrow
16:36:43 bauzas ++ me too (well, I also need to go to my beer shop actually)
16:38:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995
16:39:02 openstackgerrit Lee Yarwood proposed openstack/nova stable/ussuri: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/742706
16:49:32 openstackgerrit Stephen Finucane proposed openstack/nova stable/train: objects: Update keypairs when saving an instance https://review.opendev.org/742709
17:01:07 elod lyarwood: thanks for the release patch update, I've also updated it as I guess the latest stein patch was just accidentally missed (or am I wrong?) >>> https://review.opendev.org/#/c/741760/
17:04:31 lyarwood ah did I forget to fetch before I checked
17:04:36 lyarwood yeah I did
17:04:39 lyarwood sorry!
17:04:41 lyarwood elod: thanks for doing that
17:09:29 elod no problem, thanks for looking it :) tomorrow we'll get a PTL+1 as well \o/ (I added that to gibi's TODO list o:))
18:38:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of security_groups policies https://review.opendev.org/742726
20:03:52 openstackgerrit Merged openstack/nova master: libvirt: Use better variable names, types for '_create_guest' https://review.opendev.org/740945
22:13:00 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in security_groups policy https://review.opendev.org/742757
23:28:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in security_groups policies https://review.opendev.org/742763
23:34:27 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in security_groups policy https://review.opendev.org/742764
23:40:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of networks policies https://review.opendev.org/742558
23:40:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in networks policy https://review.opendev.org/742561
23:46:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765
23:52:45 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in networks policies https://review.opendev.org/742566
23:53:31 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in networks policy https://review.opendev.org/742568
23:58:11 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766
#openstack-nova - 2020-07-24
00:15:12 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771
00:18:49 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765
00:19:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766
00:19:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771

Earlier   Later