Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2020-07-23
23:40:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in networks policy https://review.opendev.org/742561
23:46:18 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765
23:52:45 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in networks policies https://review.opendev.org/742566
23:53:31 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in networks policy https://review.opendev.org/742568
23:58:11 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766
#openstack-nova - 2020-07-24
00:15:12 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771
00:18:49 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765
00:19:36 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766
00:19:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771
00:23:53 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in tenant networks policy https://review.opendev.org/742772
01:15:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add test coverage of volumes policies https://review.opendev.org/742773
01:22:14 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in volumes policy https://review.opendev.org/742774
01:23:24 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in security_groups policies https://review.opendev.org/742763
01:23:31 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in security_groups policy https://review.opendev.org/742764
01:38:41 openstackgerrit Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
01:57:33 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Add new default roles in volumes policies https://review.opendev.org/742777
02:07:31 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Pass the actual target in volumes policy https://review.opendev.org/742779
02:28:45 alex_xu stephenfin: gibi, I saw you mentioned the upgrade issue for provider config yaml. I didn't follow the spec discussion in the beginning, could you remind me what is about? then I think I can help tony_su go through the problem.
02:30:14 openstackgerrit Merged openstack/nova stable/stein: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729176
02:50:43 openstackgerrit Merged openstack/nova stable/ussuri: objects: Update keypairs when saving an instance https://review.opendev.org/742631
03:15:58 openstackgerrit Xinran WANG proposed openstack/nova-specs master: SRIOV SmartNic Support Specification https://review.opendev.org/742785
03:26:45 tony_su gibi: stephenfin: A status update for provider-config-file patches. I am handling your comments which are all valuable. Most of them are easy and okay to simply upgrade patches. But a few like refactor schema into code or add new test coverage require more consideration and more days ...
03:27:07 tony_su gibi: stephenfin: A status update for provider-config-file patches. I am handling your comments which are all valuable. Most of them are easy and okay to simply upgrade patches. But a few like refactor schema into code or add new test coverage require more consideration and more days ...
03:32:47 openstackgerrit Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
04:16:02 openstackgerrit Xinran WANG proposed openstack/nova-specs master: SRIOV SmartNic Support Specification https://review.opendev.org/742785
07:29:58 gibi tony_su: don't worry. I appreciate your work on that series and I will look at it when you are ready
07:31:03 gibi alex_xu: I'm not sure I can recall an upgrade issue in the provider config series (but it is Friday so my brain is already slow) do you have a reference?
07:32:30 bauzas gibi: do you know the answer of https://review.opendev.org/#/c/739211/5/nova/tests/unit/test_crypto.py@21
07:32:31 bauzas ?
07:32:44 bauzas that's an horrible import
07:32:44 gibi bauzas: looking...
07:34:25 bauzas hmmm, can't find a castellanclient kind of thing
07:34:40 gibi bauzas: does castellan just an interface and by having castellen we don't have to pull in whole key manager backend like barbican
07:34:43 gibi ?
07:35:02 bauzas I'm not a specialist of any OpenStack key manager
07:35:16 bauzas but if you're right, that explains my readings
07:36:02 bauzas mmmm https://docs.openstack.org/castellan/latest/user/index.html#basic-usage
07:36:07 bauzas looks you're right indeed
08:41:06 stephenfin bauzas, gibi: The fix for that o.vo version issue is here, btw https://review.opendev.org/#/c/742650/1
08:41:16 gibi stephenfin: thanks
08:42:09 stephenfin alex_xu: As gibi said, I don't think anyone noted any upgrade issues with provider.yaml. Perhaps you're confusing it with the investigation of upgrade issues bauzas was doing for the vTPM series?
08:43:24 gibi stephenfin: ahh, that was the upgrade discussion yesterday ^^
08:43:42 gibi I knew there was something
08:43:49 gibi I just did not remember what
08:45:14 openstackgerrit Stephen Finucane proposed openstack/nova master: Use compression by default for 'SshDriver' https://review.opendev.org/684393
08:46:16 alex_xu stephenfin: ah, thanks :)
09:23:55 openstackgerrit Merged openstack/nova master: scheduler: Request vTPM trait based on flavor or image https://review.opendev.org/739210
09:24:03 openstackgerrit Merged openstack/nova master: crypto: Add support for creating, destroying vTPM secrets https://review.opendev.org/739211
09:24:16 openstackgerrit Merged openstack/nova master: manager: Prevent compute startup on invalid vTPM config https://review.opendev.org/739212
09:24:27 openstackgerrit Merged openstack/nova master: tests: Rename tests for '_create_guest_with_network' https://review.opendev.org/740464
09:24:37 openstackgerrit Merged openstack/nova master: tests: Move single use constants to their callers https://review.opendev.org/741280
09:24:46 openstackgerrit Merged openstack/nova master: tests: Define constants in '_IntegratedTestBase' https://review.opendev.org/741281
09:24:55 openstackgerrit Merged openstack/nova master: tests: Remove 'test_servers.ServersTestBase' https://review.opendev.org/741282
09:25:02 openstackgerrit Merged openstack/nova master: tests: Add 'PlacementHelperMixin', 'PlacementInstanceHelperMixin' https://review.opendev.org/741283
09:25:13 openstackgerrit Merged openstack/nova master: tests: Make '_IntegratedTestBase' subclass 'PlacementInstanceHelperMixin' https://review.opendev.org/741284
09:31:04 stephenfin Holy s***, they all merged in one go. No CI failures :O
09:31:11 openstackgerrit Stephen Finucane proposed openstack/nova master: Use compression by default for 'SshDriver' https://review.opendev.org/684393
09:31:54 gibi stephenfin: that was a nice set
09:31:58 stephenfin bauzas, gibi: Can you look at ^ again real quick? Turns out 'scp' cares about the order of arguments. CI caught it for us and will catch it again if it's wrong
09:32:10 gibi stephenfin: looking
09:32:10 stephenfin (from https://zuul.opendev.org/t/openstack/build/7e8c6c6ddaba44e09a90a847dfe6ee46/log/logs/screen-n-cpu.txt)
09:32:14 stephenfin Thanks
09:32:14 bauzas ack
09:32:49 stephenfin It did
09:33:05 bauzas hah
09:33:09 bauzas fwiw https://linux.die.net/man/1/scp
09:33:32 stephenfin I just thought it was intermittent failures and wasn't looking at it often enough to spot the trend :)
09:33:39 stephenfin zuul++
09:34:04 bauzas stephenfin: i don't see any required ordering with scp manpage
09:34:37 stephenfin bauzas: neither did I, but the CI failure is fairly unambiguous
09:34:54 stephenfin probably the implementation of getopt they're using is borked
09:35:04 bauzas in theory, you could also scp -rC
09:35:32 gibi I can reproduce the ordering requirement of scp locally
09:35:50 gibi so the manpage is incomplete :)
09:35:54 bauzas gibi: I honesly never used the -C flag
09:36:14 bauzas like I said, I tend to use tar over nc when I wanted to transfer large files
09:36:23 stephenfin tbf, parsing command line arguments is hard work
09:36:25 bauzas waaaaay more efficient
09:36:40 gibi scp is secure tar + nc is fast, it is a tradeoff :)
09:36:46 stephenfin so broken :-(
09:37:51 stephenfin to the point that click (which is actually awesome) uses the deprecated optparse. Less magical and more reliable, apparently
09:42:17 gibi stephenfin: btw https://that.guru/blog/the-numa-scheduling-story-in-nova/ is a great article that made me think about where and when nova selects the resources to consume
09:42:51 bauzas stephenfin: gibi: that's an argparse bug http://paste.openstack.org/show/796277/
09:42:59 bauzas definitely not scp-related
09:43:04 stephenfin gibi: You can thank sean-k-mooney for most of that. I just spell checked and reorganized :)
09:43:29 stephenfin bauzas: Put '-C' at the end
09:43:36 bauzas oh that
09:43:43 stephenfin the issue isn't with the order of the positionals
09:43:44 bauzas of course, it won't work then
09:43:47 stephenfin options
09:43:55 stephenfin it's with options coming after positionals
09:44:01 bauzas you shock me if you thought it would work :p
09:44:13 stephenfin but it does in many applications!
09:44:21 bauzas but I honestly haven't paid attention at the argparse result :)
09:44:27 openstackgerrit Merged openstack/nova master: trivial: Test object backporting against correct version https://review.opendev.org/742650
09:44:29 bauzas it NEVER worked with scp then :)
09:44:41 bauzas and many BSD commands
09:44:48 bauzas (many many)
09:46:19 stephenfin bauzas: http://paste.openstack.org/show/796278/
09:46:31 stephenfin run that with e.g. 'python test.py 123 MB -b test'

Earlier   Later