Posted	Nick	Remark
#openstack-nova - 2020-07-23
13:35:28	openstackgerrit	Luigi Toscano proposed openstack/nova stable/queens: zuul: remove legacy-tempest-dsvm-neutron-dvr-multinode-full https://review.opendev.org/742668
14:42:53	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: DNM: testing tempest copy-image test https://review.opendev.org/742547
15:38:10	openstackgerrit	Stephen Finucane proposed openstack/nova master: tests: Add helpers for suspend, resume and reboot of server https://review.opendev.org/741285
15:42:08	bauzas	stephenfin: fwiw, reviewing hard your https://review.opendev.org/#/c/739210/5 to see whether making vTPM types be an Enum is safe
15:42:25	stephenfin	bauzas: Just replying. tl;dr: Look at https://github.com/openstack/nova/blob/da155cb495979726943806630eff1bed146b8605/nova/objects/instance_numa.py#L47-L52
15:43:51	stephenfin	If we changed the field, we would be forced to bump the version number of any object that contained that object. We would also most likely add something like a service check that prevented use of the new TPM model/version until all computes were updated and could handle it
15:44:38	bauzas	yup, I'm just saying it's a decision I need to evaluate
15:44:43	bauzas	not saying it's bad
15:44:49	bauzas	like,
15:45:04	bauzas	you decided to enforce those types at the API level, which prevents a bit of issues
15:45:09	stephenfin	...which is similar to what huaquiang did for the introduction of the MIXED CPU policy. See commit 9ddc60539f53e24bb92ef711674f5be4c7c0bcc3
15:46:17	bauzas	stephenfin: all the vTPM workflow is top-down (or northbound if you prefer), right?
15:46:43	bauzas	ie. we just leave operators to define which model/version they want to expose
15:46:55	bauzas	and then we pass this info down to libvirt eventually, right?
15:47:35	bauzas	and we just make traits exposing those vTPM capabilities, right?
15:48:07	stephenfin	Within reason. We check to make sure that (a) libvirt is new enough to support the feature, (b) the swtpm executable is available and (c) a key manager service is configured
15:48:18	bauzas	so, per say, someone messes up and defines a flavor with a model that none of the computes know, then eventually it could have got a NoValidHost but we enforce the knowledge by an API verification
15:48:24	stephenfin	Assuming all those are configured, we report the trait on the libvirt driver
15:48:33	bauzas	amirite ?
15:48:40	stephenfin	The API would reject that request outright
15:49:09	bauzas	so, the main concern would be a new compute with a new model, we would need to wait a release ideally to bump the API
15:49:13	bauzas	schema*
15:49:14	stephenfin	Either when attempting to set the extra spec on the flavor if using a recent microversion with the flavor validation work
15:49:15	bauzas	right?
15:49:31	stephenfin	or when creating the server, since we verify all these stuff there now
15:50:14	gibi	nova meeting starts in 10 minutes on #openstack-meeting-3
15:50:21	stephenfin	No, we don't currently consider new/modified flavor extra specs or image metadata properties as warranting a new API microversion
15:50:24	stephenfin	If that's what you mean
15:50:35	stephenfin	We would need to introduce a new service version
15:50:46	stephenfin	and wait until all compute nodes have been updated to that service version
15:51:14	stephenfin	Like commit 9ddc60539f53e24bb92ef711674f5be4c7c0bcc3 I mentioned above
15:52:46	bauzas	stephenfin: I need to review the approved spec
15:57:17	bauzas	heh, https://specs.openstack.org/openstack/nova-specs/specs/victoria/approved/add-emulated-virtual-tpm.html#upgrade-impact
16:00:09	gibi	lyarwood: ack
16:33:11	bauzas	stephenfin: I'll name you John Dorian
16:33:24	bauzas	and I'm just your Dr Cox
16:36:18	gibi	aaaan beertime
16:36:21	gibi	see you tomorrow
16:36:43	bauzas	++ me too (well, I also need to go to my beer shop actually)
16:38:11	openstackgerrit	Balazs Gibizer proposed openstack/nova master: [WIP] Support SRIOV interface attach and detach https://review.opendev.org/740995
16:39:02	openstackgerrit	Lee Yarwood proposed openstack/nova stable/ussuri: compute: Do not allow rescue attempts using volume snapshot images https://review.opendev.org/742706
16:49:32	openstackgerrit	Stephen Finucane proposed openstack/nova stable/train: objects: Update keypairs when saving an instance https://review.opendev.org/742709
17:01:07	elod	lyarwood: thanks for the release patch update, I've also updated it as I guess the latest stein patch was just accidentally missed (or am I wrong?) >>> https://review.opendev.org/#/c/741760/
17:04:31	lyarwood	ah did I forget to fetch before I checked
17:04:36	lyarwood	yeah I did
17:04:39	lyarwood	sorry!
17:04:41	lyarwood	elod: thanks for doing that
17:09:29	elod	no problem, thanks for looking it :) tomorrow we'll get a PTL+1 as well \o/ (I added that to gibi's TODO list o:))
18:38:21	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of security_groups policies https://review.opendev.org/742726
20:03:52	openstackgerrit	Merged openstack/nova master: libvirt: Use better variable names, types for '_create_guest' https://review.opendev.org/740945
22:13:00	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in security_groups policy https://review.opendev.org/742757
23:28:18	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in security_groups policies https://review.opendev.org/742763
23:34:27	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in security_groups policy https://review.opendev.org/742764
23:40:21	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of networks policies https://review.opendev.org/742558
23:40:33	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in networks policy https://review.opendev.org/742561
23:46:18	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765
23:52:45	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in networks policies https://review.opendev.org/742566
23:53:31	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in networks policy https://review.opendev.org/742568
23:58:11	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766
#openstack-nova - 2020-07-24
00:15:12	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771
00:18:49	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of tenant networks policies https://review.opendev.org/742765
00:19:36	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in tenant networks policy https://review.opendev.org/742766
00:19:44	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in tenant networks policies https://review.opendev.org/742771
00:23:53	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in tenant networks policy https://review.opendev.org/742772
01:15:33	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add test coverage of volumes policies https://review.opendev.org/742773
01:22:14	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Introduce scope_types in volumes policy https://review.opendev.org/742774
01:23:24	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in security_groups policies https://review.opendev.org/742763
01:23:31	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in security_groups policy https://review.opendev.org/742764
01:38:41	openstackgerrit	Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
01:57:33	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add new default roles in volumes policies https://review.opendev.org/742777
02:07:31	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Pass the actual target in volumes policy https://review.opendev.org/742779
02:28:45	alex_xu	stephenfin: gibi, I saw you mentioned the upgrade issue for provider config yaml. I didn't follow the spec discussion in the beginning, could you remind me what is about? then I think I can help tony_su go through the problem.
02:30:14	openstackgerrit	Merged openstack/nova stable/stein: compute: Allow snapshots to be created from PAUSED volume backed instances https://review.opendev.org/729176
02:50:43	openstackgerrit	Merged openstack/nova stable/ussuri: objects: Update keypairs when saving an instance https://review.opendev.org/742631
03:15:58	openstackgerrit	Xinran WANG proposed openstack/nova-specs master: SRIOV SmartNic Support Specification https://review.opendev.org/742785
03:26:45	tony_su	gibi: stephenfin: A status update for provider-config-file patches. I am handling your comments which are all valuable. Most of them are easy and okay to simply upgrade patches. But a few like refactor schema into code or add new test coverage require more consideration and more days ...
03:27:07	tony_su	gibi: stephenfin: A status update for provider-config-file patches. I am handling your comments which are all valuable. Most of them are easy and okay to simply upgrade patches. But a few like refactor schema into code or add new test coverage require more consideration and more days ...
03:32:47	openstackgerrit	Yingji Sun proposed openstack/nova master: Set different VirtualDevice.key https://review.opendev.org/713565
04:16:02	openstackgerrit	Xinran WANG proposed openstack/nova-specs master: SRIOV SmartNic Support Specification https://review.opendev.org/742785
07:29:58	gibi	tony_su: don't worry. I appreciate your work on that series and I will look at it when you are ready
07:31:03	gibi	alex_xu: I'm not sure I can recall an upgrade issue in the provider config series (but it is Friday so my brain is already slow) do you have a reference?
07:32:30	bauzas	gibi: do you know the answer of https://review.opendev.org/#/c/739211/5/nova/tests/unit/test_crypto.py@21
07:32:31	bauzas	?
07:32:44	bauzas	that's an horrible import
07:32:44	gibi	bauzas: looking...
07:34:25	bauzas	hmmm, can't find a castellanclient kind of thing
07:34:40	gibi	bauzas: does castellan just an interface and by having castellen we don't have to pull in whole key manager backend like barbican
07:34:43	gibi	?
07:35:02	bauzas	I'm not a specialist of any OpenStack key manager
07:35:16	bauzas	but if you're right, that explains my readings
07:36:02	bauzas	mmmm https://docs.openstack.org/castellan/latest/user/index.html#basic-usage
07:36:07	bauzas	looks you're right indeed
08:41:06	stephenfin	bauzas, gibi: The fix for that o.vo version issue is here, btw https://review.opendev.org/#/c/742650/1
08:41:16	gibi	stephenfin: thanks
08:42:09	stephenfin	alex_xu: As gibi said, I don't think anyone noted any upgrade issues with provider.yaml. Perhaps you're confusing it with the investigation of upgrade issues bauzas was doing for the vTPM series?
08:43:24	gibi	stephenfin: ahh, that was the upgrade discussion yesterday ^^
08:43:42	gibi	I knew there was something
08:43:49	gibi	I just did not remember what
08:45:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: Use compression by default for 'SshDriver' https://review.opendev.org/684393
08:46:16	alex_xu	stephenfin: ah, thanks :)

Earlier   Later