Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-01
00:32:07 dansmith artom: we have useful functional tests for other things that depend on global state
00:32:18 dansmith it's not trivial to do, but it's doable
00:32:34 artom dansmith, can I have an example? I'll use that as inspiration :)
00:33:12 dansmith artom: the cells stuff all depends on a completely global DB state
00:33:58 dansmith it's been a challenge to get that stuff working because it's so global, but like numa, it's hard to test multiple cells for real, so they're quite useful
00:34:32 artom dansmith, NUMA is a matter of hardware
00:34:46 dansmith what's your point
00:34:47 dansmith ?
00:34:54 artom Err, good question :)
00:35:12 dansmith it still requires a non-trivial environment to test for real, as does multiple cells
00:35:12 artom I guess you only need 1 (or 2, for migrations) NUMA machines
00:35:23 artom For real multi-cell you'd need... how much, actually?
00:35:42 dansmith you can do it all in one box, but it's not trivial to set up
00:35:43 dansmith either way,
00:36:24 dansmith you're drawing parallels that don't matter... it's a complicated thing that is hard to test for real, so extra work in making more-than-unit tests are worthwhile.. It all depends on some unfortunately turbo-global state, which make those hard
00:36:33 dansmith none of that points to "meh, it's hard, so just punt on tests" to me
00:37:42 artom That wasn't really the thinking
00:38:16 artom If func tests are super hard, I'd rather invest time and effort into setting up a real CI
00:38:22 dansmith I was going on this: [16:27:04] <artom>Reason I'm asking is - without this, I don't see a way to func test NUMA LM meaningfully
00:38:29 dansmith and
00:38:30 dansmith [16:30:21] <artom>dansmith, so, we can follow up on ML, but I think that rules out NUMA LM func testing?
00:40:20 artom dansmith, more in the sense of "I won't bother attempting it"
00:40:34 artom I spoke to the openlab guys a bit this morning
00:40:45 artom My request seemed to make sense for them
00:40:51 artom So I'd rather push on that
00:41:01 artom And if that turns out to be impossible, we can revisit func tests
00:52:22 alex_xu mriedem_away: thanks, let me go through the last around today
01:21:43 Kevin_Zheng dansmith: OK, I will check it now
01:53:57 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104
01:54:07 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106
01:54:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110
01:54:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113
01:54:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974
02:40:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640181
02:40:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Make nova-grenade-live-migration voting and gating https://review.openstack.org/640182
03:24:20 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311
03:24:34 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581
03:24:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017
03:25:10 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018
03:25:26 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019
04:00:15 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020
04:00:56 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027
04:01:10 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031
04:01:42 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299
04:02:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344
04:02:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673
04:55:07 openstackgerrit sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432
05:24:09 yonglihe mriedem: thanks.
05:32:20 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676
05:32:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689
05:32:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709
05:33:05 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712
06:09:02 openstackgerrit Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
06:54:12 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Remove unnecessary if statement https://review.openstack.org/640266
07:12:10 openstackgerrit Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363
07:12:10 openstackgerrit Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934
08:26:12 openstackgerrit Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271
08:32:57 kashyap gibi: Morning, when you get a quick minute: on something 'cosmetic': do you think my comment makes sense here: https://review.openstack.org/#/c/637834/4/nova/conf/libvirt.py
08:45:09 openstackgerrit Merged openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
08:47:56 tssurya yonglihe: ^^ finally :)
09:03:57 gibi kashyap: I agree with you and alex_xu on that review.
09:04:26 kashyap gibi: Also, afraid that patch is wrong on several levels
09:04:34 kashyap I'll review and comment with suggestions
09:04:54 gibi kashyap: thanks for helping that patch
09:05:46 kashyap gibi: Also, related is this important (IMHO) blueprint that needs to be addressed: https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration
09:06:00 kashyap I added it to the Train Etherpad.
09:07:30 gibi kashyap: is it something that is available for us as we bumped min libvirt and qemu versions?
09:07:50 gibi stephenfin: you might missed my ping yestarday about https://review.openstack.org/#/c/625311/25/doc/source/admin/networking.rst@266 and I'll be on and off this morning but I'd like to make progress on that patch
09:08:04 kashyap gibi: Afraid, no. Those two newer APIs need newer version constants.
09:08:31 kashyap gibi: When you get a moment, can you tell if that requires a specification?
09:08:55 kashyap Maybe I'll just write a short one, it helps to write out background, motivation and why this matters in a spec
09:09:12 gibi kashyap: does it affect any config option or nova API?
09:09:27 gibi as far as I understand it is a libvirt driver only change
09:09:31 kashyap Yes
09:09:41 kashyap gibi: No, doesn't affect config options. At its core: it rips out two older, ineffective APIs, in Nova
09:09:53 kashyap And adds in 'better' and sensible equivalent replacements
09:10:53 gibi if there is no config or REST API change then I think we don't need a spec. Still if you think that a sort spec would help then go ahead with that
09:11:22 gibi the more interesting thing is that we cannot rip out the old code before we bump the min versions again
09:11:26 kashyap Yep, noted. Doesn't affect REST API. Nor config.
09:13:53 openstackgerrit Merged openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653
09:35:41 mdbooth cfriesen: Apologies for being obtusely British ;) Seems you managed to decode it.
09:54:54 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750
09:54:54 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
09:56:59 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311
09:57:42 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311
10:10:44 openstackgerrit Surya Seetharaman proposed openstack/nova master: Add "links" in the response of GET /servers/{server_id} for a down-cell instance https://review.openstack.org/640302
10:15:29 openstackgerrit Surya Seetharaman proposed openstack/nova master: Add "links" in the response of "nova show" for a down-cell instance https://review.openstack.org/640302
10:34:07 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201
10:34:08 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203
10:34:54 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473
10:34:54 openstackgerrit Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585
10:35:20 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
11:01:14 openstackgerrit Matthew Booth proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692
11:21:54 stephenfin mdbooth: Could you test something real quick for me?
11:21:58 stephenfin $ tox -e functional -- -n nova/tests/functional/libvirt/test_pci_sriov_servers.py
11:22:05 stephenfin Does that fail? ^
11:23:07 mdbooth stephenfin: Sec
11:23:30 mdbooth stephenfin: Do you mean to have .py on the end, there?
11:23:36 mdbooth Seems like that wouldn't match anything?
11:23:52 stephenfin mdbooth: Never mind. I used '--recreate' and it now works. I was seeing privsep warnings previously

Earlier   Later