Posted	Nick	Remark
#openstack-nova - 2019-03-01
04:02:30	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673
04:55:07	openstackgerrit	sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432
05:24:09	yonglihe	mriedem: thanks.
05:32:20	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676
05:32:33	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689
05:32:51	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709
05:33:05	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712
06:09:02	openstackgerrit	Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
06:54:12	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Remove unnecessary if statement https://review.openstack.org/640266
07:12:10	openstackgerrit	Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363
07:12:10	openstackgerrit	Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934
08:26:12	openstackgerrit	Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271
08:32:57	kashyap	gibi: Morning, when you get a quick minute: on something 'cosmetic': do you think my comment makes sense here: https://review.openstack.org/#/c/637834/4/nova/conf/libvirt.py
08:45:09	openstackgerrit	Merged openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
08:47:56	tssurya	yonglihe: ^^ finally :)
09:03:57	gibi	kashyap: I agree with you and alex_xu on that review.
09:04:26	kashyap	gibi: Also, afraid that patch is wrong on several levels
09:04:34	kashyap	I'll review and comment with suggestions
09:04:54	gibi	kashyap: thanks for helping that patch
09:05:46	kashyap	gibi: Also, related is this important (IMHO) blueprint that needs to be addressed: https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration
09:06:00	kashyap	I added it to the Train Etherpad.
09:07:30	gibi	kashyap: is it something that is available for us as we bumped min libvirt and qemu versions?
09:07:50	gibi	stephenfin: you might missed my ping yestarday about https://review.openstack.org/#/c/625311/25/doc/source/admin/networking.rst@266 and I'll be on and off this morning but I'd like to make progress on that patch
09:08:04	kashyap	gibi: Afraid, no. Those two newer APIs need newer version constants.
09:08:31	kashyap	gibi: When you get a moment, can you tell if that requires a specification?
09:08:55	kashyap	Maybe I'll just write a short one, it helps to write out background, motivation and why this matters in a spec
09:09:12	gibi	kashyap: does it affect any config option or nova API?
09:09:27	gibi	as far as I understand it is a libvirt driver only change
09:09:31	kashyap	Yes
09:09:41	kashyap	gibi: No, doesn't affect config options. At its core: it rips out two older, ineffective APIs, in Nova
09:09:53	kashyap	And adds in 'better' and sensible equivalent replacements
09:10:53	gibi	if there is no config or REST API change then I think we don't need a spec. Still if you think that a sort spec would help then go ahead with that
09:11:22	gibi	the more interesting thing is that we cannot rip out the old code before we bump the min versions again
09:11:26	kashyap	Yep, noted. Doesn't affect REST API. Nor config.
09:13:53	openstackgerrit	Merged openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653
09:35:41	mdbooth	cfriesen: Apologies for being obtusely British ;) Seems you managed to decode it.
09:54:54	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750
09:54:54	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
09:56:59	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311
09:57:42	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311
10:10:44	openstackgerrit	Surya Seetharaman proposed openstack/nova master: Add "links" in the response of GET /servers/{server_id} for a down-cell instance https://review.openstack.org/640302
10:15:29	openstackgerrit	Surya Seetharaman proposed openstack/nova master: Add "links" in the response of "nova show" for a down-cell instance https://review.openstack.org/640302
10:34:07	openstackgerrit	Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201
10:34:08	openstackgerrit	Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203
10:34:54	openstackgerrit	Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473
10:34:54	openstackgerrit	Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585
10:35:20	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981
11:01:14	openstackgerrit	Matthew Booth proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692
11:21:54	stephenfin	mdbooth: Could you test something real quick for me?
11:21:58	stephenfin	$ tox -e functional -- -n nova/tests/functional/libvirt/test_pci_sriov_servers.py
11:22:05	stephenfin	Does that fail? ^
11:23:07	mdbooth	stephenfin: Sec
11:23:30	mdbooth	stephenfin: Do you mean to have .py on the end, there?
11:23:36	mdbooth	Seems like that wouldn't match anything?
11:23:52	stephenfin	mdbooth: Never mind. I used '--recreate' and it now works. I was seeing privsep warnings previously
11:23:58	stephenfin	mdbooth: Yeah, I'm using the '-n' flag
11:24:10	stephenfin	Let's me give a path to a file instead of a module path. Makes test runs waaay faster
11:24:13	mdbooth	Not familiar with that
11:24:16	mdbooth	Nice
11:24:20	mdbooth	Sounds super useful
11:24:37	mdbooth	stephenfin: Also lets you find import ordering bugs :)
11:24:48	stephenfin	You can also do nova/tests/functional/libvirt/test_pci_sriov_servers.py::SRIOVServersTest.test_create_server_with_PF
11:24:55	stephenfin	Indeed
11:31:27	yonglihe	tssurya: thanks. gonna to rebase another one.
11:39:49	sean-k-mooney	stephenfin: why not just use -- SRIOVServersTest.test_create_server_with_PF
11:40:15	stephenfin	sean-k-mooney: You could, but if there are overlapping test names, that lets you be more specific
11:40:33	stephenfin	without needing to convert the entire thing to a Python module path
11:40:39	sean-k-mooney	wll you cant have overlaping test names in the same module
11:40:52	stephenfin	nope, but you can between different modules
11:41:04	stephenfin	of different classes, if you didn't specify that
11:41:06	openstackgerrit	Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
11:41:14	mdbooth	Also you lose the speed advantage, because stestr still has to load everything and then filter for your test
11:41:24	mdbooth	Loading everything is what takes such a long time
11:41:38	sean-k-mooney	yes SRIOVServersTest is ca class and test_create_server_with_PF is a test function you can add one level o module to make it unique
11:41:47	sean-k-mooney	anyway -n is still useful
11:42:00	sean-k-mooney	so is --failing
11:42:13	stephenfin	I was literally just about to point that out :)
11:42:21	mdbooth	Avoiding loading everything is why I have my trivial 'testone' bash alias
11:42:52	mdbooth	I can run a single test in a couple of seconds, rather than waiting 20 seconds for stestr to load all tests before filtering to find my 1 test
11:43:34	sean-k-mooney	mdbooth: not that long in the grand schme of things a full unit test run takes 8 minues event with the dest discovery running a monudes tests is less then a minute much less typically
11:44:07	mdbooth	But super useful when you're iterating on 1 test.
11:44:21	sean-k-mooney	mdbooth: ya if i use vscode to click on a test it runs instantly
11:44:28	sean-k-mooney	and i can debug it :)
11:45:31	stephenfin	sean-k-mooney: Sounds like a blog :)
11:46:15	sean-k-mooney	but i typically do most of my deve with nano or emacs and run the test by had out of habit
11:46:34	sean-k-mooney	stephenfin: how about i raise you os-vif docs https://review.openstack.org/#/c/638058/4/doc/source/devref/vs-code.rst
11:47:28	sean-k-mooney	i need to test that htis works properly for nova and ill write up somthing similar. i have mainly been using it on os-vif lately to debug the functional tests
12:27:51	aspiers	hi folks, I found a bug in assertXMLEqual
12:28:14	aspiers	I'm fixing it ... hopefully it won't show up other bugs in our tests
12:30:34	sean-k-mooney	oh ? what was broken
12:40:36	aspiers	sean-k-mooney: hard to explain briefly but will make sense when you see the review
12:40:39	aspiers	(hopefully ;-)
12:41:07	aspiers	of course I meant assertXmlEqual() - typo
12:53:54	aspiers	I wonder why we invented our own xml differ
12:54:05	aspiers	https://xmldiff.readthedocs.io/en/stable/api.html#main-diffing-api looks good to me
12:54:27	cdent	<sparta>
12:55:06	aspiers	maybe xmldiff didn't exist in 2012 when Kevin Mitchell wrote ours
12:55:51	sean-k-mooney	aspiers: https://pypi.org/project/xmldiff/#history
12:56:22	sean-k-mooney	it did but did not have its 1.0.0 release until 2018
12:56:48	sean-k-mooney	it also did not have any release between 2005 and 2015

Earlier   Later