| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-03-01 | |||
| 09:11:22 | gibi | the more interesting thing is that we cannot rip out the old code before we bump the min versions again | |
| 09:11:26 | kashyap | Yep, noted. Doesn't affect REST API. Nor config. | |
| 09:13:53 | openstackgerrit | Merged openstack/nova master: Add remove_resources_from_instance_allocation to report client https://review.openstack.org/639653 | |
| 09:35:41 | mdbooth | cfriesen: Apologies for being obtusely British ;) Seems you managed to decode it. | |
| 09:54:54 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add compute service support for attach/detach root volume https://review.openstack.org/614750 | |
| 09:54:54 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | |
| 09:56:59 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | |
| 09:57:42 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add pf_interface_name tag to passthrough_whitelist https://review.openstack.org/625311 | |
| 10:10:44 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add "links" in the response of GET /servers/{server_id} for a down-cell instance https://review.openstack.org/640302 | |
| 10:15:29 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add "links" in the response of "nova show" for a down-cell instance https://review.openstack.org/640302 | |
| 10:34:07 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Add requested_networks to RequestSpec https://review.openstack.org/570201 | |
| 10:34:08 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Enable rebuild for instances in cell0 https://review.openstack.org/570203 | |
| 10:34:54 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Introduce the PENDING instance state https://review.openstack.org/566473 | |
| 10:34:54 | openstackgerrit | Theodoros Tsioutsias proposed openstack/nova master: Allow rebuild for instances in PENDING state https://review.openstack.org/637585 | |
| 10:35:20 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Detach/Attach root volume API changes https://review.openstack.org/623981 | |
| 11:01:14 | openstackgerrit | Matthew Booth proposed openstack/nova master: Improve libvirt image and snapshot handling https://review.openstack.org/616692 | |
| 11:21:54 | stephenfin | mdbooth: Could you test something real quick for me? | |
| 11:21:58 | stephenfin | $ tox -e functional -- -n nova/tests/functional/libvirt/test_pci_sriov_servers.py | |
| 11:22:05 | stephenfin | Does that fail? ^ | |
| 11:23:07 | mdbooth | stephenfin: Sec | |
| 11:23:30 | mdbooth | stephenfin: Do you mean to have .py on the end, there? | |
| 11:23:36 | mdbooth | Seems like that wouldn't match anything? | |
| 11:23:52 | stephenfin | mdbooth: Never mind. I used '--recreate' and it now works. I was seeing privsep warnings previously | |
| 11:23:58 | stephenfin | mdbooth: Yeah, I'm using the '-n' flag | |
| 11:24:10 | stephenfin | Let's me give a path to a file instead of a module path. Makes test runs waaay faster | |
| 11:24:13 | mdbooth | Not familiar with that | |
| 11:24:16 | mdbooth | Nice | |
| 11:24:20 | mdbooth | Sounds super useful | |
| 11:24:37 | mdbooth | stephenfin: Also lets you find import ordering bugs :) | |
| 11:24:48 | stephenfin | You can also do nova/tests/functional/libvirt/test_pci_sriov_servers.py::SRIOVServersTest.test_create_server_with_PF | |
| 11:24:55 | stephenfin | Indeed | |
| 11:31:27 | yonglihe | tssurya: thanks. gonna to rebase another one. | |
| 11:39:49 | sean-k-mooney | stephenfin: why not just use -- SRIOVServersTest.test_create_server_with_PF | |
| 11:40:15 | stephenfin | sean-k-mooney: You could, but if there are overlapping test names, that lets you be more specific | |
| 11:40:33 | stephenfin | without needing to convert the entire thing to a Python module path | |
| 11:40:39 | sean-k-mooney | wll you cant have overlaping test names in the same module | |
| 11:40:52 | stephenfin | nope, but you can between different modules | |
| 11:41:04 | stephenfin | of different classes, if you didn't specify that | |
| 11:41:06 | openstackgerrit | Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476 | |
| 11:41:14 | mdbooth | Also you lose the speed advantage, because stestr still has to load everything and then filter for your test | |
| 11:41:24 | mdbooth | Loading everything is what takes such a long time | |
| 11:41:38 | sean-k-mooney | yes SRIOVServersTest is ca class and test_create_server_with_PF is a test function you can add one level o module to make it unique | |
| 11:41:47 | sean-k-mooney | anyway -n is still useful | |
| 11:42:00 | sean-k-mooney | so is --failing | |
| 11:42:13 | stephenfin | I was literally just about to point that out :) | |
| 11:42:21 | mdbooth | Avoiding loading everything is why I have my trivial 'testone' bash alias | |
| 11:42:52 | mdbooth | I can run a single test in a couple of seconds, rather than waiting 20 seconds for stestr to load all tests before filtering to find my 1 test | |
| 11:43:34 | sean-k-mooney | mdbooth: not that long in the grand schme of things a full unit test run takes 8 minues event with the dest discovery running a monudes tests is less then a minute much less typically | |
| 11:44:07 | mdbooth | But super useful when you're iterating on 1 test. | |
| 11:44:21 | sean-k-mooney | mdbooth: ya if i use vscode to click on a test it runs instantly | |
| 11:44:28 | sean-k-mooney | and i can debug it :) | |
| 11:45:31 | stephenfin | sean-k-mooney: Sounds like a blog :) | |
| 11:46:15 | sean-k-mooney | but i typically do most of my deve with nano or emacs and run the test by had out of habit | |
| 11:46:34 | sean-k-mooney | stephenfin: how about i raise you os-vif docs https://review.openstack.org/#/c/638058/4/doc/source/devref/vs-code.rst | |
| 11:47:28 | sean-k-mooney | i need to test that htis works properly for nova and ill write up somthing similar. i have mainly been using it on os-vif lately to debug the functional tests | |
| 12:27:51 | aspiers | hi folks, I found a bug in assertXMLEqual | |
| 12:28:14 | aspiers | I'm fixing it ... hopefully it won't show up other bugs in our tests | |
| 12:30:34 | sean-k-mooney | oh ? what was broken | |
| 12:40:36 | aspiers | sean-k-mooney: hard to explain briefly but will make sense when you see the review | |
| 12:40:39 | aspiers | (hopefully ;-) | |
| 12:41:07 | aspiers | of course I meant assertXmlEqual() - typo | |
| 12:53:54 | aspiers | I wonder why we invented our own xml differ | |
| 12:54:05 | aspiers | https://xmldiff.readthedocs.io/en/stable/api.html#main-diffing-api looks good to me | |
| 12:54:27 | cdent | <sparta> | |
| 12:55:06 | aspiers | maybe xmldiff didn't exist in 2012 when Kevin Mitchell wrote ours | |
| 12:55:51 | sean-k-mooney | aspiers: https://pypi.org/project/xmldiff/#history | |
| 12:56:22 | sean-k-mooney | it did but did not have its 1.0.0 release until 2018 | |
| 12:56:48 | sean-k-mooney | it also did not have any release between 2005 and 2015 | |
| 12:57:08 | sean-k-mooney | so it had been unmaintianed for 7 years at that point | |
| 12:57:51 | aspiers | ahah | |
| 12:58:24 | aspiers | Still a generic xml differ never really belonged in nova. I'm sure other projects could use one | |
| 12:58:28 | sean-k-mooney | ah it also looks like they did a complete rewrite form c to python between 0.6 and 1.0 so it an entirely different code base | |
| 12:58:33 | aspiers | Yes | |
| 12:58:36 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add "links" in the response of GET /servers/{server_id} for a down-cell instance https://review.openstack.org/640302 | |
| 12:58:38 | aspiers | Maybe we should switch to that in the future | |
| 12:59:39 | tssurya | stephenfin: I fixed the nit in https://review.openstack.org/640302, but the +2 went off :( , | |
| 13:00:07 | tssurya | thanks for the review | |
| 13:00:09 | sean-k-mooney | aspiers: yes perhaps. am i the only one who gets suspices of project with 100% test coverage | |
| 13:00:19 | aspiers | haha no you are not ;-) | |
| 13:00:27 | sean-k-mooney | for some reason it always make me trust them less | |
| 13:00:39 | aspiers | xmldiff has been around since 2001 https://github.com/Shoobx/xmldiff/blob/272300bb29b8c2d444971e8051aae7bf513cdb98/ChangeLog | |
| 13:00:53 | aspiers | although as you say it might not have been very palatable for many years | |
| 13:01:33 | sean-k-mooney | ya in anycase if its maintained and it works we could use it | |
| 13:01:55 | sean-k-mooney | that said i dont think the code is overly big ofr assertXmlEquals either | |
| 13:02:19 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add "links" in the response of "nova show" for a down-cell instance https://review.openstack.org/640302 | |
| 13:03:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | |
| 13:04:41 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ensure that bandwidth and VF are from the same PF https://review.openstack.org/623543 | |
| 13:11:18 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Support server create with ports having resource request https://review.openstack.org/636360 | |
| 13:13:35 | giblet | jaypipes: Hi! I've replied in https://review.openstack.org/#/c/625310/31/nova/objects/instance_pci_requests.py@39 If you still think we should rename then let me know and I will jump on it | |
| 13:15:01 | jroll | efried: alex_xu: this was rebased, want to re-approve? https://review.openstack.org/#/c/636326/ | |
| 13:30:04 | bauzas | efried: alex_xu: jaypipes: others, I finally removed my -W because I'm not sure I can provide the fix for the problem I saw by this week | |
| 13:30:14 | bauzas | instead, I'll provide a documentation | |
| 13:35:45 | efried | jroll: done | |
| 13:36:01 | efried | bauzas: ack. My +2 is still on there... for now :P | |
| 13:36:02 | jroll | thanks | |
| 13:36:26 | bauzas | efried: heh thanks | |
| 13:36:31 | efried | jroll: you knew there was no way you were going to merge a patch at PS1. | |
| 13:37:02 | jroll | efried: so close though | |
| 13:46:20 | yonglihe | hope this would in reviewing queue -:) https://review.openstack.org/#/c/621476/ | |
| 13:46:21 | openstackgerrit | Merged openstack/nova master: fix up numa-topology live migration hypervisor check https://review.openstack.org/635350 | |