Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2019-03-01
00:22:02 melwitt :D
00:23:57 mriedem trump told us we can't trust those huawei guys
00:24:03 artom Out of curiosity, do we have a way to scope CONF objects (fixtures?) to a single service in func tests - specifically, I want 2 computes with different vcpu_pin_set (for example)
00:24:28 mriedem dansmith: Kevin_Zheng: replied with some questions for clarification - i know it's getting late so probably have to pick this up tomorrow
00:24:46 mriedem Kevin_Zheng: regardless of the tag decision, my comments on the functional tests are probably enough to keep you busy for a bit
00:25:28 mriedem artom: since CONF is global changes are no
00:25:39 mriedem *chances
00:25:48 melwitt artom: I _think_ you can do that by self.flags(value for compute 1) start compute service 1, self.flags(value for compute 2), start compute service 2
00:25:51 mriedem there is a ConfFixture, and fixtures are context managers,
00:26:02 mriedem so it's possible you could temporarily set config via context
00:26:11 melwitt but maybe it won't stick, if it's going to look at it after startup
00:26:42 mriedem i'm going to be in big trouble for not getting dinner started so i have to run
00:26:47 melwitt yeah, maybe what I said would only work if it's a conf value only considered during init_host
00:27:04 artom Reason I'm asking is - without this, I don't see a way to func test NUMA LM meaningfully
00:27:11 artom melwitt, that'd be enough, I tihnk
00:27:19 dansmith melwitt: only if the values are read and cached at start
00:27:32 dansmith when I wrote the oschown thing, I chased that down
00:27:35 dansmith it's a huge problem
00:27:40 melwitt yeah, I think it won't work if the conf option is read later on
00:27:48 dansmith in that it's completely fundamentally global as heck forever
00:27:53 melwitt but I know I've done something like this before in func test where it was startup only
00:27:57 melwitt haha yeah
00:28:17 dansmith melwitt: right, if it's read at startup and ever again, and it does that before the start returns, then it'll work, but it's fragile
00:28:36 melwitt yeah. definitely not saying it's robust
00:28:40 artom Bleah, vpcu_pin_set is read after startup
00:28:48 melwitt it's the kind of janky thing I do in tests when I find them
00:29:01 melwitt after the desperation sets in
00:30:21 artom dansmith, so, we can follow up on ML, but I think that rules out NUMA LM func testing?
00:30:35 artom I don't see another way to "force a conflict", so to speak
00:31:02 dansmith artom: it means you have to mock something out, which we try to avoid in functional tests, but can't really avoid for hardware things (like virt driver stuff)
00:31:06 dansmith which is why functional is not enough
00:31:37 artom dansmith, mock to different values with 2 compute services running?
00:31:52 dansmith artom: mock somewhere other than config
00:32:07 dansmith artom: we have useful functional tests for other things that depend on global state
00:32:18 dansmith it's not trivial to do, but it's doable
00:32:34 artom dansmith, can I have an example? I'll use that as inspiration :)
00:33:12 dansmith artom: the cells stuff all depends on a completely global DB state
00:33:58 dansmith it's been a challenge to get that stuff working because it's so global, but like numa, it's hard to test multiple cells for real, so they're quite useful
00:34:32 artom dansmith, NUMA is a matter of hardware
00:34:46 dansmith what's your point
00:34:47 dansmith ?
00:34:54 artom Err, good question :)
00:35:12 dansmith it still requires a non-trivial environment to test for real, as does multiple cells
00:35:12 artom I guess you only need 1 (or 2, for migrations) NUMA machines
00:35:23 artom For real multi-cell you'd need... how much, actually?
00:35:42 dansmith you can do it all in one box, but it's not trivial to set up
00:35:43 dansmith either way,
00:36:24 dansmith you're drawing parallels that don't matter... it's a complicated thing that is hard to test for real, so extra work in making more-than-unit tests are worthwhile.. It all depends on some unfortunately turbo-global state, which make those hard
00:36:33 dansmith none of that points to "meh, it's hard, so just punt on tests" to me
00:37:42 artom That wasn't really the thinking
00:38:16 artom If func tests are super hard, I'd rather invest time and effort into setting up a real CI
00:38:22 dansmith I was going on this: [16:27:04] <artom>Reason I'm asking is - without this, I don't see a way to func test NUMA LM meaningfully
00:38:29 dansmith and
00:38:30 dansmith [16:30:21] <artom>dansmith, so, we can follow up on ML, but I think that rules out NUMA LM func testing?
00:40:20 artom dansmith, more in the sense of "I won't bother attempting it"
00:40:34 artom I spoke to the openlab guys a bit this morning
00:40:45 artom My request seemed to make sense for them
00:40:51 artom So I'd rather push on that
00:41:01 artom And if that turns out to be impossible, we can revisit func tests
00:52:22 alex_xu mriedem_away: thanks, let me go through the last around today
01:21:43 Kevin_Zheng dansmith: OK, I will check it now
01:53:57 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104
01:54:07 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106
01:54:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110
01:54:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113
01:54:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974
02:40:53 openstackgerrit Matt Riedemann proposed openstack/nova master: Move legacy-grenade-dsvm-neutron-multinode-live-migration in-tree https://review.openstack.org/640181
02:40:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Make nova-grenade-live-migration voting and gating https://review.openstack.org/640182
03:24:20 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311
03:24:34 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581
03:24:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017
03:25:10 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018
03:25:26 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019
04:00:15 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020
04:00:56 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027
04:01:10 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031
04:01:42 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299
04:02:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344
04:02:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673
04:55:07 openstackgerrit sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432
05:24:09 yonglihe mriedem: thanks.
05:32:20 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676
05:32:33 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689
05:32:51 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709
05:33:05 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712
06:09:02 openstackgerrit Yongli He proposed openstack/nova master: Add server sub-resource topology API https://review.openstack.org/621476
06:54:12 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Remove unnecessary if statement https://review.openstack.org/640266
07:12:10 openstackgerrit Chris Friesen proposed openstack/nova master: Add emulated TPM support to Nova https://review.openstack.org/631363
07:12:10 openstackgerrit Chris Friesen proposed openstack/nova master: Add support for resize and cold migration of emulated TPM files https://review.openstack.org/639934
08:26:12 openstackgerrit Boxiang Zhu proposed openstack/nova master: Raise error when force_raw_images and images_type are incompatible https://review.openstack.org/640271
08:32:57 kashyap gibi: Morning, when you get a quick minute: on something 'cosmetic': do you think my comment makes sense here: https://review.openstack.org/#/c/637834/4/nova/conf/libvirt.py
08:45:09 openstackgerrit Merged openstack/nova master: Adds the server group info into show server detail API. https://review.openstack.org/621474
08:47:56 tssurya yonglihe: ^^ finally :)
09:03:57 gibi kashyap: I agree with you and alex_xu on that review.
09:04:26 kashyap gibi: Also, afraid that patch is wrong on several levels
09:04:34 kashyap I'll review and comment with suggestions
09:04:54 gibi kashyap: thanks for helping that patch
09:05:46 kashyap gibi: Also, related is this important (IMHO) blueprint that needs to be addressed: https://blueprints.launchpad.net/nova/+spec/cpu-selection-with-hypervisor-consideration
09:06:00 kashyap I added it to the Train Etherpad.
09:07:30 gibi kashyap: is it something that is available for us as we bumped min libvirt and qemu versions?

Earlier   Later