| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-02 | |||
| 23:08:30 | dansmith | melwitt: working on tests now, but want to see a run of that ^ to make sure I've correctly guessed which of the ten BDM formats we have right there | |
| 23:10:15 | mriedem | edleafe: the @safe_connect decorator | |
| 23:10:26 | dansmith | if we had more than a couple hours I'd just rev the rpc api, but.. | |
| 23:10:41 | edleafe | mriedem: heh, I was just trying that out... | |
| 23:12:30 | mriedem | edleafe: although you might need to use the scheduler report client / placement fixture that bauzas used in his scheduler tests | |
| 23:12:53 | edleafe | mriedem: we'll see | |
| 23:15:15 | mriedem | dansmith: root_bdm() can return None | |
| 23:15:24 | mriedem | so that will likely explode for a bunch of tests | |
| 23:15:26 | dansmith | mriedem: I know | |
| 23:15:27 | dansmith | duh | |
| 23:15:29 | dansmith | sheesh | |
| 23:15:38 | dansmith | just wanted to make sure YOU knew | |
| 23:15:43 | dansmith | and 6 is the number of tests | |
| 23:17:47 | mriedem | plus | |
| 23:17:48 | mriedem | PLUS | |
| 23:17:57 | mriedem | according to https://github.com/openstack/nova/blob/master/nova/objects/block_device.py#L364 it has to be per-instance | |
| 23:18:11 | dansmith | mriedem: I don't think that applies here, | |
| 23:18:16 | mriedem | i meant tempest tests btw | |
| 23:18:17 | dansmith | because this is a BDM that we replicate for each, | |
| 23:18:26 | dansmith | not a set of bdms from multuple instances | |
| 23:18:30 | dansmith | multiple | |
| 23:18:53 | mriedem | oh right | |
| 23:19:00 | mriedem | copies the list, and then sets the instance uuid on each bdm in thelist | |
| 23:19:03 | dansmith | yar | |
| 23:19:28 | mriedem | multuple is py4 btw | |
| 23:19:37 | mriedem | which is an openstack goal for T | |
| 23:19:40 | dansmith | badumpum | |
| 23:20:59 | dansmith | ugh, requestspec is the new bdm | |
| 23:24:16 | dansmith | also I'm pretty sure we're serializing to legacy, then passing it to a method that unserializes it | |
| 23:24:21 | dansmith | but I don't even want to think about it right now | |
| 23:24:45 | melwitt | yeah, there's a small piece in between that can't yet handle objects, so it does that | |
| 23:24:50 | dansmith | no, | |
| 23:24:52 | dansmith | I think it's direct | |
| 23:24:56 | dansmith | lemme get links | |
| 23:25:18 | melwitt | oh. I know there's a thing where it serializes to pass to a specific method, then after it comes back it turns it back into an object. or something | |
| 23:25:24 | dansmith | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L865 | |
| 23:25:37 | dansmith | https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L595 | |
| 23:25:38 | dansmith | yeah | |
| 23:25:58 | openstackgerrit | Dan Smith proposed openstack/nova master: Request zero root disk for boot-from-volume instances https://review.openstack.org/428481 | |
| 23:26:05 | dansmith | mriedem: tests never failed if you push before jenkins finished | |
| 23:27:21 | melwitt | I wonder if I could bolt my sweet functional test onto that patch to further test it. or I could stack it over yours https://review.openstack.org/#/c/355091/8/nova/tests/functional/test_boot_from_volume.py | |
| 23:27:54 | dansmith | that is the worst test I've ever seen | |
| 23:28:47 | melwitt | I was about to be like *gasp* how could you say that! | |
| 23:28:55 | dansmith | heh | |
| 23:29:04 | dansmith | yeah, I say stack it on for now at least | |
| 23:29:39 | melwitt | cool. this is exciting | |
| 23:30:40 | melwitt | I feel like I'm the champion of boot from volume and root_gb = 0 at this point | |
| 23:31:34 | gmann | mriedem: alex_xu this one from kevin on release note (we should have this on etherpad) - https://review.openstack.org/#/c/427978/ | |
| 23:32:22 | mriedem | gmann: alex_xu split the release note out https://review.openstack.org/#/c/428285/ | |
| 23:32:28 | mriedem | i'm reviewing and cleaning it up now | |
| 23:32:39 | gmann | mriedem: cool, that also fine | |
| 23:32:59 | gmann | mriedem: i did not see doc patch update as per comments - https://review.openstack.org/#/c/421760/ | |
| 23:33:01 | mriedem | dansmith: is that like a 5 second rule? | |
| 23:33:17 | dansmith | mriedem: similar, but with less salmonella | |
| 23:33:17 | gmann | mriedem: if we are taking that too, i can work on that | |
| 23:33:40 | mriedem | gmann: api-ref can be in pike | |
| 23:33:41 | mriedem | imo | |
| 23:33:49 | mriedem | api-ref is built from master anyway | |
| 23:34:03 | gmann | yea, that makes no hurry | |
| 23:34:23 | melwitt | mriedem: that reminds me, the cells v2 step-by-step stuff is also not related to deadline right? since it's devref | |
| 23:37:39 | mriedem | melwitt: let's say yes | |
| 23:38:12 | melwitt | cools | |
| 23:39:01 | melwitt | my test didn't work -- NoValidHost. I wonder if I need to do something to enable placement in functional test | |
| 23:39:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add release note for filter/sort whitelist https://review.openstack.org/428285 | |
| 23:39:13 | mriedem | gmann: see how this looks ^ i touched up the wording and fancied it up a bit | |
| 23:39:27 | mriedem | melwitt: placement fixture? | |
| 23:39:46 | mriedem | https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1175 | |
| 23:40:11 | melwitt | thanks | |
| 23:40:21 | melwitt | I <3 fixtures | |
| 23:40:39 | jaypipes | mriedem: done. | |
| 23:41:21 | mriedem | thanks | |
| 23:41:58 | mriedem | oh also, i might just +W this myself if no one else does https://review.openstack.org/#/c/428344/ | |
| 23:42:11 | dansmith | mriedem: I'll get it | |
| 23:42:14 | mriedem | thanks | |
| 23:42:22 | dansmith | mriedem: we should also put the wsgi clarification in, I need to de-parent it | |
| 23:42:30 | mriedem | ok | |
| 23:42:43 | jaypipes | mriedem: lemme review real quick. | |
| 23:42:46 | mriedem | this is going to be the most gd docstastic release ever | |
| 23:42:52 | melwitt | mriedem: I looked at that earlier and wondered if you should note that [cells] options aren't required for cells v2 in the first blurb too | |
| 23:43:27 | mriedem | shrug | |
| 23:43:36 | mriedem | it's approved now so i have no incentive | |
| 23:43:37 | mriedem | :) | |
| 23:43:37 | openstackgerrit | Dan Smith proposed openstack/nova master: Clarify the language in the apache wsgi sample https://review.openstack.org/428417 | |
| 23:43:41 | dansmith | mriedem: ^ | |
| 23:43:59 | mriedem | wipped as bauzas would say | |
| 23:44:12 | dansmith | heh | |
| 23:44:55 | openstackgerrit | Ed Leafe proposed openstack/nova master: Delete a compute node's resource provider when node is deleted https://review.openstack.org/428375 | |
| 23:47:35 | edleafe | mriedem: jaypipes: ^^ Had to rebase this on https://review.openstack.org/#/c/404472 to get safe_connect | |
| 23:48:57 | melwitt | looks like it's still trying to claim the flavor root_gb | |
| 23:51:30 | dansmith | melwitt: in your test or somewhere else? | |
| 23:51:45 | dansmith | melwitt: or do you mean on the compute node? | |
| 23:52:10 | melwitt | dansmith: running my test I see it making the claim with the instance flavor root_gb on the compute host | |
| 23:52:25 | dansmith | melwitt: that's expected right? | |
| 23:52:31 | dansmith | the claim stuff knows nothing about this, | |
| 23:52:45 | melwitt | dansmith: yeah but it will fail because the compute host free disk figure will kick it out | |
| 23:52:49 | dansmith | but we should be reporting the right thing to placement, and not considering it on scheduling | |
| 23:53:11 | dansmith | until we remove that stuff, right? | |
| 23:53:13 | melwitt | so it can't schedule to a compute host that isn't reporting enough local disk to fit the flavor | |
| 23:53:22 | dansmith | so maybe we need the claims bit of your patch? | |
| 23:54:19 | dansmith | I wish we didn't though, since that's a bunch of extra pieces :/ | |