Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-02-02
23:32:59 gmann mriedem: i did not see doc patch update as per comments - https://review.openstack.org/#/c/421760/
23:33:01 mriedem dansmith: is that like a 5 second rule?
23:33:17 dansmith mriedem: similar, but with less salmonella
23:33:17 gmann mriedem: if we are taking that too, i can work on that
23:33:40 mriedem gmann: api-ref can be in pike
23:33:41 mriedem imo
23:33:49 mriedem api-ref is built from master anyway
23:34:03 gmann yea, that makes no hurry
23:34:23 melwitt mriedem: that reminds me, the cells v2 step-by-step stuff is also not related to deadline right? since it's devref
23:37:39 mriedem melwitt: let's say yes
23:38:12 melwitt cools
23:39:01 melwitt my test didn't work -- NoValidHost. I wonder if I need to do something to enable placement in functional test
23:39:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Add release note for filter/sort whitelist https://review.openstack.org/428285
23:39:13 mriedem gmann: see how this looks ^ i touched up the wording and fancied it up a bit
23:39:27 mriedem melwitt: placement fixture?
23:39:46 mriedem https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L1175
23:40:11 melwitt thanks
23:40:21 melwitt I <3 fixtures
23:40:39 jaypipes mriedem: done.
23:41:21 mriedem thanks
23:41:58 mriedem oh also, i might just +W this myself if no one else does https://review.openstack.org/#/c/428344/
23:42:11 dansmith mriedem: I'll get it
23:42:14 mriedem thanks
23:42:22 dansmith mriedem: we should also put the wsgi clarification in, I need to de-parent it
23:42:30 mriedem ok
23:42:43 jaypipes mriedem: lemme review real quick.
23:42:46 mriedem this is going to be the most gd docstastic release ever
23:42:52 melwitt mriedem: I looked at that earlier and wondered if you should note that [cells] options aren't required for cells v2 in the first blurb too
23:43:27 mriedem shrug
23:43:36 mriedem it's approved now so i have no incentive
23:43:37 mriedem :)
23:43:37 openstackgerrit Dan Smith proposed openstack/nova master: Clarify the language in the apache wsgi sample https://review.openstack.org/428417
23:43:41 dansmith mriedem: ^
23:43:59 mriedem wipped as bauzas would say
23:44:12 dansmith heh
23:44:55 openstackgerrit Ed Leafe proposed openstack/nova master: Delete a compute node's resource provider when node is deleted https://review.openstack.org/428375
23:47:35 edleafe mriedem: jaypipes: ^^ Had to rebase this on https://review.openstack.org/#/c/404472 to get safe_connect
23:48:57 melwitt looks like it's still trying to claim the flavor root_gb
23:51:30 dansmith melwitt: in your test or somewhere else?
23:51:45 dansmith melwitt: or do you mean on the compute node?
23:52:10 melwitt dansmith: running my test I see it making the claim with the instance flavor root_gb on the compute host
23:52:25 dansmith melwitt: that's expected right?
23:52:31 dansmith the claim stuff knows nothing about this,
23:52:45 melwitt dansmith: yeah but it will fail because the compute host free disk figure will kick it out
23:52:49 dansmith but we should be reporting the right thing to placement, and not considering it on scheduling
23:53:11 dansmith until we remove that stuff, right?
23:53:13 melwitt so it can't schedule to a compute host that isn't reporting enough local disk to fit the flavor
23:53:22 dansmith so maybe we need the claims bit of your patch?
23:54:19 dansmith I wish we didn't though, since that's a bunch of extra pieces :/
23:54:48 melwitt it appears so. it's pretty ugly though https://review.openstack.org/#/c/355091/8/nova/compute/resource_tracker.py@155
23:54:57 dansmith yeah
23:55:04 melwitt I dunno what resource providers plan is for fixing this
23:55:25 dansmith I don't know that we keep the claims stuff past ocata
23:55:30 dansmith I'm not sure though
23:55:45 dansmith melwitt: your stuff in claims all says "remove this after resource providers"
23:56:15 melwitt yeah, that wasn't based on knowing how it would be solved. my understanding was that RP fixes all the things
23:56:38 mriedem i'm going to go on a limb and say,
23:56:42 mriedem i really like joe walsh
23:56:51 dansmith well, when we get allocations in the scheduler it definitely goes away, AFAIK
23:57:35 melwitt okay. then I should change my TODOs to say that. I didn't know what specifically would make those changes obsolete in the future
23:58:30 dansmith man, that's a lot of copying the instance object every time we report resources
23:58:51 mriedem gmann: found a problem in the reno
23:58:52 mriedem fixing quick
#openstack-nova - 2017-02-03
00:00:05 melwitt dansmith: yeah, that was being maximally careful, not to pollute the db with any root_gb = 0
00:00:27 dansmith yeah, gotta do it, or change a bunch of RT code
00:00:30 mriedem edleafe: what do you mean to get safe_connect?
00:00:35 mriedem that's already in the report client
00:00:36 dansmith it's just -> :/
00:00:42 melwitt yeah
00:01:02 mriedem edleafe: if you're rebasing on https://review.openstack.org/#/c/404472/ then your fixes are effectively not making ocata
00:01:28 edleafe mriedem: hmmm... for some reason I thought we added it in that patch
00:01:37 edleafe mriedem: let me un-rebase it
00:02:06 gmann mriedem: oh, that huge list is really difficult tasks always :)
00:02:22 mriedem gmann: yeah i compared it one by one with the schema validation code
00:02:30 mriedem and now my eyes are bleeding
00:02:38 gmann mriedem: also we should mention internal attributes also along with joined table
00:03:14 gmann i am going to do "find and search" each one
00:03:34 mriedem gmann: these? https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/schemas/servers.py#L280
00:03:51 mriedem the joined table ones are a 400 error, ^ are just ignored
00:03:57 gmann no
00:03:58 gmann https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/schemas/servers.py#L365
00:04:26 gmann ignore for sort only but we changed 500 -> 400 in filter and same foe _*
00:04:35 gmann for
00:05:23 mriedem gmann: so mention anything with ^_.* in with this list https://review.openstack.org/#/c/428285/2/releasenotes/notes/add-whitelist-for-server-list-filter-sort-params-2ae766d03ba895e5.yaml@103 ?
00:05:30 mriedem gmann: i'm not going to actually go and hunt those down
00:05:37 gmann https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/servers.py#L234
00:05:49 mriedem i could just say, joined tables or internal data model attributes
00:06:03 gmann yea that is enough
00:06:13 mriedem ok
00:13:30 mriedem edleafe: i was wondering if that delete RP fix was a blocker but then i remembered again that ironic basically can't schedule if you're all upgraded and have one of those things lying around
00:13:34 mriedem so yeah i guess it's a blocker
00:14:33 edleafe mriedem:yeah, pretty much
00:14:53 edleafe mriedem: running tests locally on the un-rebased change
00:16:36 mriedem ok
00:16:50 mriedem i've gone through and marked everything with rc1, rc2 or defer https://etherpad.openstack.org/p/nova-ocata-rc1-todos
00:16:55 mriedem dansmith: melwitt: jaypipes: ^
00:16:59 jroll can't schedule? or may schedule to a thing that doesn't exist
00:17:07 mriedem schedule to a thing that blows up
00:17:12 jroll right
00:17:42 jroll a build failing here and there isn't the worst thing that could happen

Earlier   Later