| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-02 | |||
| 23:41:58 | mriedem | oh also, i might just +W this myself if no one else does https://review.openstack.org/#/c/428344/ | |
| 23:42:11 | dansmith | mriedem: I'll get it | |
| 23:42:14 | mriedem | thanks | |
| 23:42:22 | dansmith | mriedem: we should also put the wsgi clarification in, I need to de-parent it | |
| 23:42:30 | mriedem | ok | |
| 23:42:43 | jaypipes | mriedem: lemme review real quick. | |
| 23:42:46 | mriedem | this is going to be the most gd docstastic release ever | |
| 23:42:52 | melwitt | mriedem: I looked at that earlier and wondered if you should note that [cells] options aren't required for cells v2 in the first blurb too | |
| 23:43:27 | mriedem | shrug | |
| 23:43:36 | mriedem | it's approved now so i have no incentive | |
| 23:43:37 | mriedem | :) | |
| 23:43:37 | openstackgerrit | Dan Smith proposed openstack/nova master: Clarify the language in the apache wsgi sample https://review.openstack.org/428417 | |
| 23:43:41 | dansmith | mriedem: ^ | |
| 23:43:59 | mriedem | wipped as bauzas would say | |
| 23:44:12 | dansmith | heh | |
| 23:44:55 | openstackgerrit | Ed Leafe proposed openstack/nova master: Delete a compute node's resource provider when node is deleted https://review.openstack.org/428375 | |
| 23:47:35 | edleafe | mriedem: jaypipes: ^^ Had to rebase this on https://review.openstack.org/#/c/404472 to get safe_connect | |
| 23:48:57 | melwitt | looks like it's still trying to claim the flavor root_gb | |
| 23:51:30 | dansmith | melwitt: in your test or somewhere else? | |
| 23:51:45 | dansmith | melwitt: or do you mean on the compute node? | |
| 23:52:10 | melwitt | dansmith: running my test I see it making the claim with the instance flavor root_gb on the compute host | |
| 23:52:25 | dansmith | melwitt: that's expected right? | |
| 23:52:31 | dansmith | the claim stuff knows nothing about this, | |
| 23:52:45 | melwitt | dansmith: yeah but it will fail because the compute host free disk figure will kick it out | |
| 23:52:49 | dansmith | but we should be reporting the right thing to placement, and not considering it on scheduling | |
| 23:53:11 | dansmith | until we remove that stuff, right? | |
| 23:53:13 | melwitt | so it can't schedule to a compute host that isn't reporting enough local disk to fit the flavor | |
| 23:53:22 | dansmith | so maybe we need the claims bit of your patch? | |
| 23:54:19 | dansmith | I wish we didn't though, since that's a bunch of extra pieces :/ | |
| 23:54:48 | melwitt | it appears so. it's pretty ugly though https://review.openstack.org/#/c/355091/8/nova/compute/resource_tracker.py@155 | |
| 23:54:57 | dansmith | yeah | |
| 23:55:04 | melwitt | I dunno what resource providers plan is for fixing this | |
| 23:55:25 | dansmith | I don't know that we keep the claims stuff past ocata | |
| 23:55:30 | dansmith | I'm not sure though | |
| 23:55:45 | dansmith | melwitt: your stuff in claims all says "remove this after resource providers" | |
| 23:56:15 | melwitt | yeah, that wasn't based on knowing how it would be solved. my understanding was that RP fixes all the things | |
| 23:56:38 | mriedem | i'm going to go on a limb and say, | |
| 23:56:42 | mriedem | i really like joe walsh | |
| 23:56:51 | dansmith | well, when we get allocations in the scheduler it definitely goes away, AFAIK | |
| 23:57:35 | melwitt | okay. then I should change my TODOs to say that. I didn't know what specifically would make those changes obsolete in the future | |
| 23:58:30 | dansmith | man, that's a lot of copying the instance object every time we report resources | |
| 23:58:51 | mriedem | gmann: found a problem in the reno | |
| 23:58:52 | mriedem | fixing quick | |
| #openstack-nova - 2017-02-03 | |||
| 00:00:05 | melwitt | dansmith: yeah, that was being maximally careful, not to pollute the db with any root_gb = 0 | |
| 00:00:27 | dansmith | yeah, gotta do it, or change a bunch of RT code | |
| 00:00:30 | mriedem | edleafe: what do you mean to get safe_connect? | |
| 00:00:35 | mriedem | that's already in the report client | |
| 00:00:36 | dansmith | it's just -> :/ | |
| 00:00:42 | melwitt | yeah | |
| 00:01:02 | mriedem | edleafe: if you're rebasing on https://review.openstack.org/#/c/404472/ then your fixes are effectively not making ocata | |
| 00:01:28 | edleafe | mriedem: hmmm... for some reason I thought we added it in that patch | |
| 00:01:37 | edleafe | mriedem: let me un-rebase it | |
| 00:02:06 | gmann | mriedem: oh, that huge list is really difficult tasks always :) | |
| 00:02:22 | mriedem | gmann: yeah i compared it one by one with the schema validation code | |
| 00:02:30 | mriedem | and now my eyes are bleeding | |
| 00:02:38 | gmann | mriedem: also we should mention internal attributes also along with joined table | |
| 00:03:14 | gmann | i am going to do "find and search" each one | |
| 00:03:34 | mriedem | gmann: these? https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/schemas/servers.py#L280 | |
| 00:03:51 | mriedem | the joined table ones are a 400 error, ^ are just ignored | |
| 00:03:57 | gmann | no | |
| 00:03:58 | gmann | https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/schemas/servers.py#L365 | |
| 00:04:26 | gmann | ignore for sort only but we changed 500 -> 400 in filter and same foe _* | |
| 00:04:35 | gmann | for | |
| 00:05:23 | mriedem | gmann: so mention anything with ^_.* in with this list https://review.openstack.org/#/c/428285/2/releasenotes/notes/add-whitelist-for-server-list-filter-sort-params-2ae766d03ba895e5.yaml@103 ? | |
| 00:05:30 | mriedem | gmann: i'm not going to actually go and hunt those down | |
| 00:05:37 | gmann | https://github.com/openstack/nova/blob/c90acdbc55b743666baa9ef82c56a8e85475f739/nova/api/openstack/compute/servers.py#L234 | |
| 00:05:49 | mriedem | i could just say, joined tables or internal data model attributes | |
| 00:06:03 | gmann | yea that is enough | |
| 00:06:13 | mriedem | ok | |
| 00:13:30 | mriedem | edleafe: i was wondering if that delete RP fix was a blocker but then i remembered again that ironic basically can't schedule if you're all upgraded and have one of those things lying around | |
| 00:13:34 | mriedem | so yeah i guess it's a blocker | |
| 00:14:33 | edleafe | mriedem:yeah, pretty much | |
| 00:14:53 | edleafe | mriedem: running tests locally on the un-rebased change | |
| 00:16:36 | mriedem | ok | |
| 00:16:50 | mriedem | i've gone through and marked everything with rc1, rc2 or defer https://etherpad.openstack.org/p/nova-ocata-rc1-todos | |
| 00:16:55 | mriedem | dansmith: melwitt: jaypipes: ^ | |
| 00:16:59 | jroll | can't schedule? or may schedule to a thing that doesn't exist | |
| 00:17:07 | mriedem | schedule to a thing that blows up | |
| 00:17:12 | jroll | right | |
| 00:17:42 | jroll | a build failing here and there isn't the worst thing that could happen | |
| 00:17:48 | mriedem | i don't know how to talk about scheduling to ironic compute nodes when the nodes are deleted | |
| 00:17:53 | mriedem | or they are hosts, or wtf they are | |
| 00:17:54 | mriedem | it's ironic | |
| 00:18:02 | jroll | and how often to people actually delete machines from ironic | |
| 00:18:04 | jroll | s/to/do/ | |
| 00:18:05 | mriedem | jroll: does it retry in this case? | |
| 00:18:19 | jroll | mriedem: dunno, I didn't reproduce, I'm guessing not | |
| 00:18:56 | jroll | I guess I'm just thinking as long as this gets in rc2, it isn't a big deal if it's in rc1 | |
| 00:18:58 | jroll | I could be wrong ofc | |
| 00:19:30 | mriedem | jroll: i think it will reschedule https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2015 | |
| 00:20:18 | jroll | mriedem: maaaybe, that's a lot of except blocks | |
| 00:20:21 | mriedem | yeah we call spawn here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L1927 | |
| 00:20:27 | mriedem | ironicclient returns node not found | |
| 00:20:36 | mriedem | which gets handled here https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2008 | |
| 00:21:06 | jroll | huh, I swear it said something about not rescheduling in the bug | |
| 00:21:08 | jroll | I could be drunk | |
| 00:21:24 | mriedem | he said it didn't cleanup in a periodic run | |
| 00:21:29 | mriedem | but i could also be drunk | |
| 00:21:36 | jroll | yeah I guess not | |
| 00:22:06 | jroll | I think it's fine | |