Earlier  
Later
New Search
Posted Nick Remark
#openstack-cyborg - 2019-09-24
04:58:29 Sundar I am sure your code is good as cyborg-tempest passed
05:23:00 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: Fix v1 API. https://review.opendev.org/684193
06:49:29 openstackgerrit YumengBao proposed openstack/cyborg master: conductor writes device_profile update to db https://review.opendev.org/679406
06:57:17 openstackgerrit YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957
07:48:52 openstackgerrit YumengBao proposed openstack/cyborg master: remove rootwrap in cyborg https://review.opendev.org/684213
08:56:16 openstackgerrit wangzhh proposed openstack/cyborg master: Enable api v2 policy check https://review.opendev.org/678177
#openstack-cyborg - 2019-09-25
02:20:17 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: Fix v1 API. https://review.opendev.org/684193
02:22:24 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: Fix v1 API. https://review.opendev.org/684193
02:35:53 openstackgerrit wangzhh proposed openstack/cyborg master: Enable api v2 policy check https://review.opendev.org/678177
04:10:48 openstackgerrit wangzhh proposed openstack/cyborg master: Enable api v2 policy check https://review.opendev.org/678177
04:12:52 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: Install OPAE tools library. https://review.opendev.org/684456
04:57:59 openstackgerrit Merged openstack/cyborg master: [train][goal] Run 'cyborg-tempest-ipv6-only' job in gate https://review.opendev.org/682517
05:58:01 openstackgerrit chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565
06:00:14 openstackgerrit chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565
06:19:01 openstackgerrit chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565
06:50:28 openstackgerrit Merged openstack/cyborg master: remove rootwrap in cyborg https://review.opendev.org/684213
06:55:21 openstackgerrit Xinran WANG proposed openstack/cyborg master: Program FPGAs with oslo.privsep. https://review.opendev.org/683733
07:11:03 chenke Sundar Hi~
07:28:36 Sundar Hi chenke
07:29:30 chenke We can chat on this.
07:29:56 Sundar Sure. I think we all agreed.
07:29:56 chenke I am replying faster here than the phone.
07:30:03 chenke Ok.
07:30:30 chenke But you need to solve your merge confilct patches.
07:30:33 Sundar I will resolve merge conflicts in the Nova patches, update Yumeng's 670999 and put a dependency from 670999 to your patch
07:30:40 Sundar So you can remove the dependency
07:30:48 chenke Ok.
07:31:41 openstackgerrit chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565
07:36:36 openstackgerrit ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005
07:45:24 Sundar Done with Nova rebasing
09:26:22 openstackgerrit ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005
09:31:36 openstackgerrit ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005
11:27:17 openstackgerrit zhurong proposed openstack/cyborg master: Enable fake_driver by default https://review.opendev.org/684712
11:29:45 openstackgerrit Merged openstack/cyborg master: Enable api v2 policy check https://review.opendev.org/678177
18:20:14 openstackgerrit Sundar Nadathur proposed openstack/cyborg master: Program FPGAs with oslo.privsep. https://review.opendev.org/683733
#openstack-cyborg - 2019-09-26
02:15:08 openstackgerrit YumengBao proposed openstack/cyborg master: conductor writes device_profile update to db https://review.opendev.org/679406
02:22:26 openstackgerrit YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957
02:50:42 openstackgerrit chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565
03:01:34 Sundar #startmeeting openstack-cyborg
03:01:35 openstack Meeting started Thu Sep 26 03:01:33 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot.
03:01:36 openstack Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
03:01:38 openstack The meeting name has been set to 'openstack_cyborg'
03:01:41 Sundar Hi all
03:01:50 Sundar #topic Who's here
03:01:51 shaohe_feng good evening
03:01:57 Sundar o/
03:02:01 s_shogo Hi all
03:02:04 shaohe_feng o/
03:02:18 chenke o/
03:02:22 chenke Hi all.
03:02:50 Yumeng #info Yumeng
03:02:53 Yumeng hi all
03:03:10 xinranwang Hi all
03:03:16 xinranwang #info xinranwang
03:03:25 s_shogo #info s_shogo
03:03:39 Sundar Let's start with some good news. In Chenke's patch https://review.opendev.org/#/c/682565/, Eric asked to try 'strict_proxies=False'
03:03:47 Sundar I tried and it works for me at least :)
03:03:53 chenke Wow
03:03:59 chenke Sound great.
03:04:20 Sundar If chenke can resubmit with that change, I'll trigger the tempest check
03:04:39 chenke I had done it.
03:04:57 chenke And triggered the tempest check.
03:05:36 Sundar https://review.opendev.org/#/c/682565/15/cyborg/common/utils.py@149 still has i, right?
03:05:39 Sundar *it
03:06:00 Sundar I set that to False
03:06:44 chenke The eric's advice is to see it to False, pls see Line 130 the default value.
03:07:02 xinranwang I discussed with colleague who has experience on CI, there is no other solution except add "depend on" in each patch.
03:07:30 xinranwang it is better to merge nova patches as soon as possible.
03:08:12 Sundar chenke: I see.
03:08:31 Sundar Ok. Hope that does the trick.
03:08:39 chenke Hope so.
03:08:45 Yumeng agree with Xinran
03:08:57 Yumeng we have this to test related patches :https://review.opendev.org/#/c/670999/
03:09:17 Yumeng to test nova-cyborg-integration related patches
03:09:44 chenke Agree with Xinran. Now Yumengs' patch is a better solution so far.
03:09:44 Sundar It is not up to us to get Nova patches merged. There are challenge sin getting reviewer attention, not only for Cyborg, but for other subjects too.
03:10:59 Sundar Are we saying we should put Depends-On for a Nova patch in every Cyborg patch?
03:11:47 xinranwang yes
03:12:56 Sundar All agree?
03:12:59 chenke but this will have too many dependencies.
03:13:56 Sundar Too many dependencies on Nova code?
03:14:14 chenke Yes.
03:15:02 xinranwang 1. need keep nova patch updated all the time to avoid merge conflict.
03:15:02 xinranwang 2. need add "depend on" in every patch to trigger correct tempest test.
03:15:02 Sundar Yea. May be we can do it judiciously based on whether the patch has Nova interaction.
03:15:10 chenke But it is also a good way to fully test our cyborg code.
03:15:13 chenke Agree
03:16:23 Sundar I am the only one maintaining those patches. Nova moves fast and breakages happen often. I cannot commit to keep doing that all the time, unless we are getting Nova reviewers' attention.
03:16:48 shaohe_feng something wrong with my net
03:17:04 chenke welcome back.
03:17:11 xinranwang It's better to get nova folks attention.
03:17:28 xinranwang Longer we wait, more efforts it takes.
03:17:29 Sundar That's what we tried to do for entire Train cycle
03:17:36 Yumeng yes. so better to have a successful tempest test at nova side and get merg asap, then we add more features in cyborg
03:19:23 Yumeng Sundar: I can help to maintain and fix patches, if you need help.
03:21:08 Sundar Let's be clear. Now we put Depends-On *from* Nova to the Cyborg patch that we want to test, i..e. chenke's patch. We can't do that for every patch.
03:21:52 chenke Agree.
03:22:29 chenke just some special patch should do like this.
03:22:29 xinranwang +1
03:22:37 s_shogo +1

Earlier   Later