| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-09-26 | |||
| 03:21:08 | Sundar | Let's be clear. Now we put Depends-On *from* Nova to the Cyborg patch that we want to test, i..e. chenke's patch. We can't do that for every patch. | |
| 03:21:52 | chenke | Agree. | |
| 03:22:29 | chenke | just some special patch should do like this. | |
| 03:22:29 | xinranwang | +1 | |
| 03:22:37 | s_shogo | +1 | |
| 03:22:47 | Yumeng | +1 | |
| 03:24:16 | Sundar | Makes sense. Any patch that touches Nova or other services or any significant patch can be tested this way. If/when we get Nova reviews early in U, we can make it a common practice. | |
| 03:24:39 | Sundar | All good with that? | |
| 03:25:47 | Sundar | Ok, I'll take previous +1s as yes :) | |
| 03:26:04 | Sundar | #topic RC status | |
| 03:26:26 | Sundar | https://review.opendev.org/#/c/684056/1 has been filed | |
| 03:27:03 | Sundar | I am saying we have a few potential RC blockers. | |
| 03:27:21 | Sundar | •Privsep: https://review.opendev.org/673957 : affects security | |
| 03:27:28 | Sundar | •Privsep for FPGA prog: https://review.opendev.org/683733 : affects security | |
| 03:27:37 | Sundar | •V1 API: https://review.opendev.org/684193 : affects backwards compatibility | |
| 03:27:56 | Sundar | Others are important for us, and we should merge as much of them as we can. | |
| 03:28:04 | shaohe_feng | https://review.opendev.org/#/c/681005/ | |
| 03:28:32 | openstackgerrit | chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565 | |
| 03:29:20 | Sundar | shaohe_feng, an RC blocker has a high bar -- we have to explain why the entire release should be held up till we fix that | |
| 03:30:10 | Sundar | We should continue to review your patch and try to merge it. May be this RC may not be the last one. | |
| 03:30:19 | shaohe_feng | One questions about: sdk_adapter patch. I remember we did user sdk_adapter in V1, why we change it to connection | |
| 03:30:31 | shaohe_feng | and change back to sdk_adapter again? | |
| 03:31:40 | chenke | nova recommand us to use sdk now. | |
| 03:31:45 | Sundar | We used ksa_adapter in v1. We were asked to move to sdk_adapter as a new method and then to COnnection as the latest one. There are some bugs apparently, so we have settled on what works. | |
| 03:32:00 | Sundar | chenke: +1 | |
| 03:32:45 | shaohe_feng | what's the pron of sdk? | |
| 03:34:16 | shaohe_feng | O, I remember xinranwang use sdk_adapter ? | |
| 03:34:27 | shaohe_feng | why not give up? | |
| 03:34:39 | shaohe_feng | then sdk_adapter again? | |
| 03:35:42 | shaohe_feng | pros and cons? | |
| 03:36:16 | Sundar | You can ask Eric in that patch. Nova has some requirements and considerable interest in this area. | |
| 03:36:33 | shaohe_feng | OK. | |
| 03:37:16 | Sundar | Are there any other patches that are potential RC blockers, i.e, have security or critical implications, so we should hold up the release? | |
| 03:37:29 | shaohe_feng | maybe we can do more investigation on it. but not now | |
| 03:37:37 | shaohe_feng | now we have more things to do. | |
| 03:39:10 | Sundar | Sure. If nothing else, let us please focus on reviewing the ones above first, and as much of the rest as we can. It is possible that there may be future RCs, so they may still make it | |
| 03:40:00 | Sundar | Any other comments or thoughts? | |
| 03:40:01 | Yumeng | https://review.opendev.org/#/c/679406/ this one please | |
| 03:40:15 | Yumeng | conductor writes device_profile | |
| 03:40:33 | Sundar | Yumeng: sure. IMHO, it is mostly there. I'll try it out tonight and review it | |
| 03:40:46 | Yumeng | just updated. | |
| 03:40:55 | Yumeng | thanks! | |
| 03:41:33 | Sundar | Shaohe, have you tried your patch with the Nova patches? | |
| 03:41:49 | shaohe_feng | yes. | |
| 03:41:55 | Sundar | Great | |
| 03:41:59 | shaohe_feng | xinranwang also help to do it. | |
| 03:42:09 | Sundar | Thanks to both of you | |
| 03:42:28 | Sundar | Anything else, folks? | |
| 03:42:35 | shaohe_feng | actually, I did not change your code logical | |
| 03:42:51 | shaohe_feng | just put them in thread pool as async job. :) | |
| 03:43:10 | Sundar | Cool, np even if you changed it, as long as it works :) | |
| 03:43:23 | xinranwang | This patch is almost good for me | |
| 03:44:01 | Sundar | almost? | |
| 03:44:43 | Sundar | Anyway, we can continue the review in Gerrit. | |
| 03:44:55 | xinranwang | “Almost”means need other’s review as well | |
| 03:45:17 | chenke | About this patch:https://review.opendev.org/#/c/684193/ | |
| 03:45:33 | chenke | I agree with xinran's idea. | |
| 03:45:53 | Sundar | Do you want to see 6 endpoints with devstack? :) | |
| 03:46:05 | Sundar | v1 is end-of-life. | |
| 03:46:06 | chenke | no | |
| 03:46:11 | chenke | We don't need to enable v1. | |
| 03:46:14 | Sundar | After Train, we can remove it early in U | |
| 03:47:37 | Sundar | Can you explain further, chenke? v1 is deprecated but supported in this release. So, we do the bare minimum to keep it alive, but don't bother develoeprs with legacy endpoints | |
| 03:48:20 | Sundar | We can remove v1 altogether early in U, and even these devstack comments will go away | |
| 03:49:16 | Sundar | Anybody disagree? | |
| 03:49:16 | chenke | Sorry, I misunderstood this meaning. | |
| 03:49:24 | chenke | just go on. | |
| 03:49:35 | Sundar | You are ok with that patch as is? | |
| 03:50:34 | Sundar | Anyway, let's continue the review in Gerrit | |
| 03:50:39 | chenke | +1 | |
| 03:50:55 | Sundar | If nothing else, we can call it a day (or night or afternoon) | |
| 03:51:36 | Sundar | Have a good day, everyone! Bye for now. (I'll bother you on WeChat after this -- JK) | |
| 03:51:42 | Sundar | #endmeeting | |
| 03:51:44 | openstack | Meeting ended Thu Sep 26 03:51:42 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 03:51:45 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.html | |
| 03:51:46 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.txt | |
| 03:51:47 | openstack | Log: http://eavesdrop.openstack.org/meetings/openstack_cyborg/2019/openstack_cyborg.2019-09-26-03.01.log.html | |
| 03:52:37 | chenke | Bye~ all | |
| 03:54:20 | Sundar | chenke -- the latest tempest run failed too | |
| 03:54:36 | chenke | could you give me the address | |
| 03:54:47 | chenke | detail log address. | |
| 03:54:51 | Sundar | https://openstack.fortnebula.com:13808/v1/AUTH_e8fd161dc34c421a979a9e6421f823e9/zuul_opendev_logs_c00/670999/12/check/cyborg-tempest/c00ce63/controller/logs/screen-cyborg-api.txt.gz | |
| 03:55:28 | Sundar | Sep 25 14:33:08.765936 --- Server-side error: "Failed to create a working proxy for service compute: No valid endpoint was discoverable." | |
| 03:56:26 | chenke | Now time is ? | |
| 03:57:01 | chenke | I want to confirm if it is the latest log. | |
| 03:57:08 | Sundar | It is in UTC | |
| 03:57:32 | Sundar | I see, it could be old? | |
| 03:57:54 | chenke | I am not sure. | |
| 03:58:08 | Sundar | Seems like old one -- never mind, false alarm ;) | |
| 03:58:15 | chenke | Ok~ | |
| 03:58:24 | Sundar | I need to leave now, will be back in 30 min or so | |
| 03:58:31 | chenke | https://zuul.opendev.org/t/openstack/stream/fa3f4faccb0744cb9e019cae42b1102d?logfile=console.log | |
| 03:58:36 | chenke | this is new. | |
| 03:58:42 | chenke | Ok. the same to me. | |
| 03:58:52 | chenke | I will back after 90min. | |
| 06:12:03 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Program FPGAs with oslo.privsep. https://review.opendev.org/683733 | |
| 06:27:19 | openstackgerrit | zhurong proposed openstack/cyborg master: Fix delete arq 403 failed https://review.opendev.org/684947 | |
| 07:28:06 | openstackgerrit | Merged openstack/cyborg master: Enable fake_driver by default https://review.opendev.org/684712 | |
| 08:28:46 | openstackgerrit | chenker proposed openstack/cyborg master: Fix delete arq 403 failed https://review.opendev.org/684947 | |
| 09:00:31 | openstackgerrit | Merged openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | |