| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-cyborg - 2019-09-25 | |||
| 07:30:33 | Sundar | I will resolve merge conflicts in the Nova patches, update Yumeng's 670999 and put a dependency from 670999 to your patch | |
| 07:30:40 | Sundar | So you can remove the dependency | |
| 07:30:48 | chenke | Ok. | |
| 07:31:41 | openstackgerrit | chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565 | |
| 07:36:36 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| 07:45:24 | Sundar | Done with Nova rebasing | |
| 09:26:22 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| 09:31:36 | openstackgerrit | ShaoHe Feng proposed openstack/cyborg master: async job for bind https://review.opendev.org/681005 | |
| 11:27:17 | openstackgerrit | zhurong proposed openstack/cyborg master: Enable fake_driver by default https://review.opendev.org/684712 | |
| 11:29:45 | openstackgerrit | Merged openstack/cyborg master: Enable api v2 policy check https://review.opendev.org/678177 | |
| 18:20:14 | openstackgerrit | Sundar Nadathur proposed openstack/cyborg master: Program FPGAs with oslo.privsep. https://review.opendev.org/683733 | |
| #openstack-cyborg - 2019-09-26 | |||
| 02:15:08 | openstackgerrit | YumengBao proposed openstack/cyborg master: conductor writes device_profile update to db https://review.opendev.org/679406 | |
| 02:22:26 | openstackgerrit | YumengBao proposed openstack/cyborg master: Implement privsep boilerplate in cyborg. https://review.opendev.org/673957 | |
| 02:50:42 | openstackgerrit | chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565 | |
| 03:01:34 | Sundar | #startmeeting openstack-cyborg | |
| 03:01:35 | openstack | Meeting started Thu Sep 26 03:01:33 2019 UTC and is due to finish in 60 minutes. The chair is Sundar. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 03:01:36 | openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 03:01:38 | openstack | The meeting name has been set to 'openstack_cyborg' | |
| 03:01:41 | Sundar | Hi all | |
| 03:01:50 | Sundar | #topic Who's here | |
| 03:01:51 | shaohe_feng | good evening | |
| 03:01:57 | Sundar | o/ | |
| 03:02:01 | s_shogo | Hi all | |
| 03:02:04 | shaohe_feng | o/ | |
| 03:02:18 | chenke | o/ | |
| 03:02:22 | chenke | Hi all. | |
| 03:02:50 | Yumeng | #info Yumeng | |
| 03:02:53 | Yumeng | hi all | |
| 03:03:10 | xinranwang | Hi all | |
| 03:03:16 | xinranwang | #info xinranwang | |
| 03:03:25 | s_shogo | #info s_shogo | |
| 03:03:39 | Sundar | Let's start with some good news. In Chenke's patch https://review.opendev.org/#/c/682565/, Eric asked to try 'strict_proxies=False' | |
| 03:03:47 | Sundar | I tried and it works for me at least :) | |
| 03:03:53 | chenke | Wow | |
| 03:03:59 | chenke | Sound great. | |
| 03:04:20 | Sundar | If chenke can resubmit with that change, I'll trigger the tempest check | |
| 03:04:39 | chenke | I had done it. | |
| 03:04:57 | chenke | And triggered the tempest check. | |
| 03:05:36 | Sundar | https://review.opendev.org/#/c/682565/15/cyborg/common/utils.py@149 still has i, right? | |
| 03:05:39 | Sundar | *it | |
| 03:06:00 | Sundar | I set that to False | |
| 03:06:44 | chenke | The eric's advice is to see it to False, pls see Line 130 the default value. | |
| 03:07:02 | xinranwang | I discussed with colleague who has experience on CI, there is no other solution except add "depend on" in each patch. | |
| 03:07:30 | xinranwang | it is better to merge nova patches as soon as possible. | |
| 03:08:12 | Sundar | chenke: I see. | |
| 03:08:31 | Sundar | Ok. Hope that does the trick. | |
| 03:08:39 | chenke | Hope so. | |
| 03:08:45 | Yumeng | agree with Xinran | |
| 03:08:57 | Yumeng | we have this to test related patches :https://review.opendev.org/#/c/670999/ | |
| 03:09:17 | Yumeng | to test nova-cyborg-integration related patches | |
| 03:09:44 | chenke | Agree with Xinran. Now Yumengs' patch is a better solution so far. | |
| 03:09:44 | Sundar | It is not up to us to get Nova patches merged. There are challenge sin getting reviewer attention, not only for Cyborg, but for other subjects too. | |
| 03:10:59 | Sundar | Are we saying we should put Depends-On for a Nova patch in every Cyborg patch? | |
| 03:11:47 | xinranwang | yes | |
| 03:12:56 | Sundar | All agree? | |
| 03:12:59 | chenke | but this will have too many dependencies. | |
| 03:13:56 | Sundar | Too many dependencies on Nova code? | |
| 03:14:14 | chenke | Yes. | |
| 03:15:02 | xinranwang | 1. need keep nova patch updated all the time to avoid merge conflict. | |
| 03:15:02 | xinranwang | 2. need add "depend on" in every patch to trigger correct tempest test. | |
| 03:15:02 | Sundar | Yea. May be we can do it judiciously based on whether the patch has Nova interaction. | |
| 03:15:10 | chenke | But it is also a good way to fully test our cyborg code. | |
| 03:15:13 | chenke | Agree | |
| 03:16:23 | Sundar | I am the only one maintaining those patches. Nova moves fast and breakages happen often. I cannot commit to keep doing that all the time, unless we are getting Nova reviewers' attention. | |
| 03:16:48 | shaohe_feng | something wrong with my net | |
| 03:17:04 | chenke | welcome back. | |
| 03:17:11 | xinranwang | It's better to get nova folks attention. | |
| 03:17:28 | xinranwang | Longer we wait, more efforts it takes. | |
| 03:17:29 | Sundar | That's what we tried to do for entire Train cycle | |
| 03:17:36 | Yumeng | yes. so better to have a successful tempest test at nova side and get merg asap, then we add more features in cyborg | |
| 03:19:23 | Yumeng | Sundar: I can help to maintain and fix patches, if you need help. | |
| 03:21:08 | Sundar | Let's be clear. Now we put Depends-On *from* Nova to the Cyborg patch that we want to test, i..e. chenke's patch. We can't do that for every patch. | |
| 03:21:52 | chenke | Agree. | |
| 03:22:29 | chenke | just some special patch should do like this. | |
| 03:22:29 | xinranwang | +1 | |
| 03:22:37 | s_shogo | +1 | |
| 03:22:47 | Yumeng | +1 | |
| 03:24:16 | Sundar | Makes sense. Any patch that touches Nova or other services or any significant patch can be tested this way. If/when we get Nova reviews early in U, we can make it a common practice. | |
| 03:24:39 | Sundar | All good with that? | |
| 03:25:47 | Sundar | Ok, I'll take previous +1s as yes :) | |
| 03:26:04 | Sundar | #topic RC status | |
| 03:26:26 | Sundar | https://review.opendev.org/#/c/684056/1 has been filed | |
| 03:27:03 | Sundar | I am saying we have a few potential RC blockers. | |
| 03:27:21 | Sundar | •Privsep: https://review.opendev.org/673957 : affects security | |
| 03:27:28 | Sundar | •Privsep for FPGA prog: https://review.opendev.org/683733 : affects security | |
| 03:27:37 | Sundar | •V1 API: https://review.opendev.org/684193 : affects backwards compatibility | |
| 03:27:56 | Sundar | Others are important for us, and we should merge as much of them as we can. | |
| 03:28:04 | shaohe_feng | https://review.opendev.org/#/c/681005/ | |
| 03:28:32 | openstackgerrit | chenker proposed openstack/cyborg master: Fix the hardcoding of user role using sdk_adapter approach https://review.opendev.org/682565 | |
| 03:29:20 | Sundar | shaohe_feng, an RC blocker has a high bar -- we have to explain why the entire release should be held up till we fix that | |
| 03:30:10 | Sundar | We should continue to review your patch and try to merge it. May be this RC may not be the last one. | |
| 03:30:19 | shaohe_feng | One questions about: sdk_adapter patch. I remember we did user sdk_adapter in V1, why we change it to connection | |
| 03:30:31 | shaohe_feng | and change back to sdk_adapter again? | |
| 03:31:40 | chenke | nova recommand us to use sdk now. | |
| 03:31:45 | Sundar | We used ksa_adapter in v1. We were asked to move to sdk_adapter as a new method and then to COnnection as the latest one. There are some bugs apparently, so we have settled on what works. | |
| 03:32:00 | Sundar | chenke: +1 | |
| 03:32:45 | shaohe_feng | what's the pron of sdk? | |
| 03:34:16 | shaohe_feng | O, I remember xinranwang use sdk_adapter ? | |
| 03:34:27 | shaohe_feng | why not give up? | |
| 03:34:39 | shaohe_feng | then sdk_adapter again? | |