| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2023-05-27 | |||
| 13:04:05 | opendevreview | Vadym Markov proposed openstack/keystoneauth master: Keep request-id at redirect https://review.opendev.org/c/openstack/keystoneauth/+/864309 | |
| #openstack-sdks - 2023-05-29 | |||
| 09:14:05 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: docs: Replace/remove shade-specific docs https://review.opendev.org/c/openstack/openstacksdk/+/878644 | |
| 09:24:25 | opendevreview | suzhengwei proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 09:50:58 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: support notification vmoves for masakari https://review.opendev.org/c/openstack/openstacksdk/+/872080 | |
| 10:39:03 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Add image metadef_resource_type into the registry https://review.opendev.org/c/openstack/openstacksdk/+/884518 | |
| 13:14:39 | opendevreview | Merged openstack/openstacksdk stable/train: [stable-only] Use train-eol for heat and drop l-c job https://review.opendev.org/c/openstack/openstacksdk/+/884437 | |
| 15:39:03 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add aliases for common volume type props https://review.opendev.org/c/openstack/python-openstackclient/+/884635 | |
| 15:39:03 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: trivial: Make better use of argparse https://review.opendev.org/c/openstack/python-openstackclient/+/884636 | |
| #openstack-sdks - 2023-05-30 | |||
| 09:25:52 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add aliases for common volume type props https://review.opendev.org/c/openstack/python-openstackclient/+/884635 | |
| 09:25:52 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: trivial: Make better use of argparse https://review.opendev.org/c/openstack/python-openstackclient/+/884636 | |
| 09:25:53 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Allow filtering volume types by properties https://review.opendev.org/c/openstack/python-openstackclient/+/884665 | |
| 09:25:53 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Add alias for volume type AZs https://review.opendev.org/c/openstack/python-openstackclient/+/884666 | |
| 09:29:07 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: docs: Replace/remove shade-specific docs https://review.opendev.org/c/openstack/openstacksdk/+/878644 | |
| 11:22:58 | opendevreview | Merged openstack/openstacksdk master: Add image metadef_resource_type into the registry https://review.opendev.org/c/openstack/openstacksdk/+/884518 | |
| 11:54:25 | whoami-rajat | stephenfin, hey, I'm not sure if my approach in the SDK patch is correct (since this is my first proposal of a command), I know zuul-1 and WIP aren't good indicators to ask for reviews but can you take a look and let me know if there are any changes that are required in my approach | |
| 11:54:36 | whoami-rajat | stephenfin, it works but not sure it matches the SDK guidelines https://review.opendev.org/c/openstack/openstacksdk/+/884167 | |
| 15:16:48 | stephenfin | whoami-rajat: I'll take a look | |
| 16:08:58 | stephenfin | whoami-rajat: Done. Also, I tagged you in a few cinder PRs that you might be interested in https://review.opendev.org/c/openstack/python-openstackclient/+/884665 | |
| 16:09:02 | stephenfin | that's the first one | |
| 16:10:05 | opendevreview | Merged openstack/openstacksdk master: FWAAS: add Computed summary field to FirewallRule https://review.opendev.org/c/openstack/openstacksdk/+/883859 | |
| 17:20:08 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: WIP: Add attachment create, update, show support https://review.opendev.org/c/openstack/openstacksdk/+/884167 | |
| #openstack-sdks - 2023-05-31 | |||
| 16:39:17 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: tox: Disable E501 https://review.opendev.org/c/openstack/openstacksdk/+/884906 | |
| 16:40:10 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tox: Disable E501 https://review.opendev.org/c/openstack/python-openstackclient/+/884907 | |
| 16:42:46 | stephenfin | gtema: ^ | |
| 16:42:59 | gtema | yupp, noticed already. Great | |
| 16:50:42 | stephenfin | ty | |
| 16:54:30 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: WIP: Implement auto-code generation https://review.opendev.org/c/openstack/openstacksdk/+/882326 | |
| 16:54:30 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909 | |
| 21:21:27 | opendevreview | Douglas Mendizábal proposed openstack/python-openstackclient master: Fix Story # 2010775 https://review.opendev.org/c/openstack/python-openstackclient/+/884948 | |
| 21:21:27 | opendevreview | Douglas Mendizábal proposed openstack/python-openstackclient master: Fix Story # 2010775 https://review.opendev.org/c/openstack/python-openstackclient/+/884948 | |
| 21:55:17 | opendevreview | Merged openstack/openstacksdk master: tox: Disable E501 https://review.opendev.org/c/openstack/openstacksdk/+/884906 | |
| #openstack-sdks - 2023-06-01 | |||
| 07:55:02 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909 | |
| 07:55:02 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: WIP: Implement auto-code generation https://review.opendev.org/c/openstack/openstacksdk/+/882326 | |
| 10:22:52 | opendevreview | Mridula Joshi proposed openstack/python-openstackclient master: Adding ``image stores delete`` and ``image import info`` commands https://review.opendev.org/c/openstack/python-openstackclient/+/882086 | |
| 11:43:17 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Add volume attachment update command https://review.opendev.org/c/openstack/python-openstackclient/+/885036 | |
| 12:50:41 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909 | |
| 17:41:36 | opendevreview | Joker 234 proposed openstack/ansible-collections-openstack master: fix(inventory): bug when using clouds_yaml_path https://review.opendev.org/c/openstack/ansible-collections-openstack/+/885085 | |
| 20:30:19 | opendevreview | Douglas Mendizábal proposed openstack/python-openstackclient master: Fix Story # 2010775 https://review.opendev.org/c/openstack/python-openstackclient/+/884948 | |
| 20:41:50 | opendevreview | Douglas Mendizábal proposed openstack/python-openstackclient master: Fix Story # 2010775 https://review.opendev.org/c/openstack/python-openstackclient/+/884948 | |
| #openstack-sdks - 2023-06-02 | |||
| 12:00:38 | gtema | stephenfin, around? | |
| 12:02:11 | stephenfin | yup | |
| 12:02:55 | gtema | wrt new attribute properties (min_microversion and max_microversion). I now have a feeling they should be converted to min_version and max_version | |
| 12:03:25 | gtema | keystone is not supporting microversions as well, so also there having possibility to verify whether version is matching is better then only look at microversion | |
| 12:03:35 | stephenfin | hmm, version != microversion, at least from a service catalog perspective. I think we'd need both, tbh | |
| 12:03:50 | stephenfin | microversion for nova, cinder etc. version for glance, keystone, etc. | |
| 12:04:28 | gtema | yes, but: once you look at the api specs you normally see "added in version". | |
| 12:04:36 | gtema | so when service support MV we check mv | |
| 12:04:53 | gtema | when no MV support - verify that api_version is matching | |
| 12:05:16 | stephenfin | okay, so we'd treat it differently depending on whether the service supports microversions or not | |
| 12:05:19 | gtema | from the service pov I think it is still something like api version (whether MV or not MV) | |
| 12:05:43 | stephenfin | question is, should we do that automatically ("magically") or do it explicitly? | |
| 12:05:53 | stephenfin | I'd usually lean towards explicitness for this stuff | |
| 12:05:55 | gtema | yes, depending on the service catalog information treat it either as MV or as not MV | |
| 12:06:20 | gtema | I just do not want to have min_microversion and min_version property or the resource attribute | |
| 12:07:27 | stephenfin | okay, fair enough. I wouldn't personally munge them together but if you really care about it, I'll manage :) | |
| 12:08:04 | gtema | so the usecase to talk explicitly ;-) => compute.server.host requires MV 2.90, while identity.project.is_domain requires version 3.6 | |
| 12:09:10 | gtema | explicitness require resource to know the difference between MV and ver, while technically it is just a matter of different attrs of the endpoint discovery | |
| 12:10:13 | gtema | according to https://docs.openstack.org/api-guide/compute/microversions.html: when min_version is empty and max_version is empty => look at api_version, otherwise look at min_version&max_version | |
| 12:10:46 | stephenfin | okay, if you can document that in the docstrings for the variable then I'll be happy | |
| 12:10:57 | stephenfin | ideally with a link to that doc | |
| 12:11:09 | gtema | deal | |
| 12:12:33 | gtema | the change grows quite lot once I added verification logic for versions ;-) | |
| 12:12:46 | gtema | wlcm | |
| 12:12:54 | gtema | sorry, wrong window | |
| 13:35:16 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: volume: Add missing attributes to Extension https://review.opendev.org/c/openstack/openstacksdk/+/885132 | |
| 13:35:17 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Encode type of 'links' for Extension objects https://review.opendev.org/c/openstack/openstacksdk/+/885133 | |
| 13:35:17 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: volume: Add Extension to volume v2 API https://review.opendev.org/c/openstack/openstacksdk/+/885134 | |
| 13:37:43 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: network: Use SDK, not neutronclient, for AZ tests https://review.opendev.org/c/openstack/python-openstackclient/+/885135 | |
| 13:37:43 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'availablity zone list' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/885136 | |
| 13:37:44 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate 'availablity zone list' to SDK" https://review.opendev.org/c/openstack/python-openstackclient/+/885137 | |
| 13:37:44 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: tests: Use SDK for extensions tests https://review.opendev.org/c/openstack/python-openstackclient/+/885138 | |
| 13:37:45 | opendevreview | Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate 'extension list' to SDK" https://review.opendev.org/c/openstack/python-openstackclient/+/885139 | |
| 16:52:56 | opendevreview | Stephen Finucane proposed openstack/openstacksdk master: Remove unnecessary quotes https://review.opendev.org/c/openstack/openstacksdk/+/885153 | |
| 17:17:28 | opendevreview | Merged openstack/openstacksdk master: cloud: Remove '_ShadeAdapter' https://review.opendev.org/c/openstack/openstacksdk/+/846216 | |
| 17:17:30 | opendevreview | Merged openstack/openstacksdk master: cloud: Rename shade-specific method https://review.opendev.org/c/openstack/openstacksdk/+/884423 | |
| 17:17:32 | opendevreview | Merged openstack/openstacksdk master: cloud: Remove ClusteringCloudMixin https://review.opendev.org/c/openstack/openstacksdk/+/884493 | |
| 17:17:34 | opendevreview | Merged openstack/openstacksdk master: utils: Add 'supports_version' https://review.opendev.org/c/openstack/openstacksdk/+/884494 | |
| 17:17:36 | opendevreview | Merged openstack/openstacksdk master: cloud: Move identity-related helpers https://review.opendev.org/c/openstack/openstacksdk/+/884495 | |
| 17:17:38 | opendevreview | Merged openstack/openstacksdk master: docs: Replace/remove shade-specific docs https://review.opendev.org/c/openstack/openstacksdk/+/878644 | |
| 17:17:40 | opendevreview | Merged openstack/openstacksdk master: tests: Use uuid, not randint https://review.opendev.org/c/openstack/openstacksdk/+/884514 | |
| 17:17:42 | opendevreview | Merged openstack/openstacksdk master: Use custom warnings everywhere https://review.opendev.org/c/openstack/openstacksdk/+/884417 | |
| 17:17:45 | opendevreview | Merged openstack/openstacksdk master: tests: Ignore our own deprecation warnings https://review.opendev.org/c/openstack/openstacksdk/+/884418 | |
| 19:09:52 | opendevreview | Rajat Dhasmana proposed openstack/openstacksdk master: Add block storage summary support https://review.opendev.org/c/openstack/openstacksdk/+/884397 | |
| 19:23:20 | opendevreview | ribaudr proposed openstack/python-openstackclient master: WIP Add share commands to compute https://review.opendev.org/c/openstack/python-openstackclient/+/881540 | |
| 19:24:27 | opendevreview | ribaudr proposed openstack/openstacksdk master: Add shares API to compute https://review.opendev.org/c/openstack/openstacksdk/+/880056 | |
| 19:25:14 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate 'volume summary' command to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/884398 | |
| #openstack-sdks - 2023-06-05 | |||
| 05:29:29 | opendevreview | Mridula Joshi proposed openstack/python-openstackclient master: Adding ``image delete --store`` and ``image import info`` commands https://review.opendev.org/c/openstack/python-openstackclient/+/882086 | |
| 12:19:43 | dmendiza[m] | Hi friends! Looking for another review on https://review.opendev.org/c/openstack/python-openstackclient/+/884948 | |
| 16:03:17 | opendevreview | Douglas Mendizábal proposed openstack/python-openstackclient master: Fix "access rule" commands to only use ID https://review.opendev.org/c/openstack/python-openstackclient/+/884948 | |
| 16:03:17 | opendevreview | Douglas Mendizábal proposed openstack/python-openstackclient master: Fix "access rule" commands to only use ID https://review.opendev.org/c/openstack/python-openstackclient/+/884948 | |
| #openstack-sdks - 2023-06-06 | |||
| 08:35:03 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate 'volume summary' command to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/884398 | |
| 09:59:11 | opendevreview | Merged openstack/python-openstackclient master: Fix "access rule" commands to only use ID https://review.opendev.org/c/openstack/python-openstackclient/+/884948 | |
| 10:14:31 | opendevreview | Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate 'volume summary' command to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/884398 | |
| 10:59:26 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682 | |
| 10:59:26 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909 | |
| 11:09:26 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682 | |
| 11:09:26 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909 | |
| 11:11:44 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682 | |
| 11:11:45 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909 | |
| 13:26:30 | opendevreview | Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909 | |