Earlier  
Posted Nick Remark
#openstack-sdks - 2023-06-02
12:06:20 gtema I just do not want to have min_microversion and min_version property or the resource attribute
12:07:27 stephenfin okay, fair enough. I wouldn't personally munge them together but if you really care about it, I'll manage :)
12:08:04 gtema so the usecase to talk explicitly ;-) => compute.server.host requires MV 2.90, while identity.project.is_domain requires version 3.6
12:09:10 gtema explicitness require resource to know the difference between MV and ver, while technically it is just a matter of different attrs of the endpoint discovery
12:10:13 gtema according to https://docs.openstack.org/api-guide/compute/microversions.html: when min_version is empty and max_version is empty => look at api_version, otherwise look at min_version&max_version
12:10:46 stephenfin okay, if you can document that in the docstrings for the variable then I'll be happy
12:10:57 stephenfin ideally with a link to that doc
12:11:09 gtema deal
12:12:33 gtema the change grows quite lot once I added verification logic for versions ;-)
12:12:46 gtema wlcm
12:12:54 gtema sorry, wrong window
13:35:16 opendevreview Stephen Finucane proposed openstack/openstacksdk master: volume: Add missing attributes to Extension https://review.opendev.org/c/openstack/openstacksdk/+/885132
13:35:17 opendevreview Stephen Finucane proposed openstack/openstacksdk master: Encode type of 'links' for Extension objects https://review.opendev.org/c/openstack/openstacksdk/+/885133
13:35:17 opendevreview Stephen Finucane proposed openstack/openstacksdk master: volume: Add Extension to volume v2 API https://review.opendev.org/c/openstack/openstacksdk/+/885134
13:37:43 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: network: Use SDK, not neutronclient, for AZ tests https://review.opendev.org/c/openstack/python-openstackclient/+/885135
13:37:43 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: compute: Migrate 'availablity zone list' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/885136
13:37:44 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate 'availablity zone list' to SDK" https://review.opendev.org/c/openstack/python-openstackclient/+/885137
13:37:44 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: tests: Use SDK for extensions tests https://review.opendev.org/c/openstack/python-openstackclient/+/885138
13:37:45 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: volume: Migrate 'extension list' to SDK" https://review.opendev.org/c/openstack/python-openstackclient/+/885139
16:52:56 opendevreview Stephen Finucane proposed openstack/openstacksdk master: Remove unnecessary quotes https://review.opendev.org/c/openstack/openstacksdk/+/885153
17:17:28 opendevreview Merged openstack/openstacksdk master: cloud: Remove '_ShadeAdapter' https://review.opendev.org/c/openstack/openstacksdk/+/846216
17:17:30 opendevreview Merged openstack/openstacksdk master: cloud: Rename shade-specific method https://review.opendev.org/c/openstack/openstacksdk/+/884423
17:17:32 opendevreview Merged openstack/openstacksdk master: cloud: Remove ClusteringCloudMixin https://review.opendev.org/c/openstack/openstacksdk/+/884493
17:17:34 opendevreview Merged openstack/openstacksdk master: utils: Add 'supports_version' https://review.opendev.org/c/openstack/openstacksdk/+/884494
17:17:36 opendevreview Merged openstack/openstacksdk master: cloud: Move identity-related helpers https://review.opendev.org/c/openstack/openstacksdk/+/884495
17:17:38 opendevreview Merged openstack/openstacksdk master: docs: Replace/remove shade-specific docs https://review.opendev.org/c/openstack/openstacksdk/+/878644
17:17:40 opendevreview Merged openstack/openstacksdk master: tests: Use uuid, not randint https://review.opendev.org/c/openstack/openstacksdk/+/884514
17:17:42 opendevreview Merged openstack/openstacksdk master: Use custom warnings everywhere https://review.opendev.org/c/openstack/openstacksdk/+/884417
17:17:45 opendevreview Merged openstack/openstacksdk master: tests: Ignore our own deprecation warnings https://review.opendev.org/c/openstack/openstacksdk/+/884418
19:09:52 opendevreview Rajat Dhasmana proposed openstack/openstacksdk master: Add block storage summary support https://review.opendev.org/c/openstack/openstacksdk/+/884397
19:23:20 opendevreview ribaudr proposed openstack/python-openstackclient master: WIP Add share commands to compute https://review.opendev.org/c/openstack/python-openstackclient/+/881540
19:24:27 opendevreview ribaudr proposed openstack/openstacksdk master: Add shares API to compute https://review.opendev.org/c/openstack/openstacksdk/+/880056
19:25:14 opendevreview Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate 'volume summary' command to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/884398
#openstack-sdks - 2023-06-05
05:29:29 opendevreview Mridula Joshi proposed openstack/python-openstackclient master: Adding ``image delete --store`` and ``image import info`` commands https://review.opendev.org/c/openstack/python-openstackclient/+/882086
12:19:43 dmendiza[m] Hi friends! Looking for another review on https://review.opendev.org/c/openstack/python-openstackclient/+/884948
16:03:17 opendevreview Douglas Mendizábal proposed openstack/python-openstackclient master: Fix "access rule" commands to only use ID https://review.opendev.org/c/openstack/python-openstackclient/+/884948
16:03:17 opendevreview Douglas Mendizábal proposed openstack/python-openstackclient master: Fix "access rule" commands to only use ID https://review.opendev.org/c/openstack/python-openstackclient/+/884948
#openstack-sdks - 2023-06-06
08:35:03 opendevreview Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate 'volume summary' command to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/884398
09:59:11 opendevreview Merged openstack/python-openstackclient master: Fix "access rule" commands to only use ID https://review.opendev.org/c/openstack/python-openstackclient/+/884948
10:14:31 opendevreview Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate 'volume summary' command to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/884398
10:59:26 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682
10:59:26 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909
11:09:26 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682
11:09:26 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909
11:11:44 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682
11:11:45 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909
13:26:30 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909
16:53:45 opendevreview Antonia Gaete proposed openstack/python-openstackclient master: Add image metadef resource type association commands 'create', 'list', 'delete' https://review.opendev.org/c/openstack/python-openstackclient/+/885375
17:14:33 opendevreview Antonia Gaete proposed openstack/python-openstackclient master: Add image metadef resource type command 'list' https://review.opendev.org/c/openstack/python-openstackclient/+/883279
17:23:59 opendevreview Merged openstack/openstacksdk master: Remove unnecessary quotes https://review.opendev.org/c/openstack/openstacksdk/+/885153
17:24:00 opendevreview Merged openstack/python-openstackclient master: tox: Disable E501 https://review.opendev.org/c/openstack/python-openstackclient/+/884907
#openstack-sdks - 2023-06-07
07:21:59 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909
09:31:02 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Extend resource object https://review.opendev.org/c/openstack/openstacksdk/+/884909
11:29:29 gtema stephenfin: read_only attribute of a resource is not a bad idea, or is it? Explicitly when it is about resource.id
13:07:37 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682
13:43:55 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.aggregate https://review.opendev.org/c/openstack/python-openstackclient/+/885491
13:43:56 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_console https://review.opendev.org/c/openstack/python-openstackclient/+/885492
13:43:56 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_flavor https://review.opendev.org/c/openstack/python-openstackclient/+/885493
13:43:57 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_keypair https://review.opendev.org/c/openstack/python-openstackclient/+/885494
13:58:59 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_service https://review.opendev.org/c/openstack/python-openstackclient/+/885495
13:59:00 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_usage https://review.opendev.org/c/openstack/python-openstackclient/+/885496
14:17:47 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682
14:38:12 opendevreview Artem Goncharov proposed openstack/openstacksdk master: fix flavor.swap attribute type https://review.opendev.org/c/openstack/openstacksdk/+/885498
15:11:48 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_flavor https://review.opendev.org/c/openstack/python-openstackclient/+/885493
15:44:02 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_usage https://review.opendev.org/c/openstack/python-openstackclient/+/885517
16:22:35 gtema stephenfin, I updated fake generator and created series of changes in OSC to start using them. Surely till we land a change in SDK and release it half of tests on OSC would be failing, but you can see now tips ones are passing.
16:22:47 gtema care of having a look?
16:22:53 stephenfin Awesome, I'll take a look for sure
16:22:59 gtema great, thanks
16:59:25 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: Migrate 'availability zone list' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/885135
16:59:26 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: Migrate 'extension list' to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/885139
16:59:26 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: tests: Remove FakeNetworkV2Client https://review.opendev.org/c/openstack/python-openstackclient/+/885526
16:59:27 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: tests: Add network v2 FakeClientMixin https://review.opendev.org/c/openstack/python-openstackclient/+/885527
16:59:27 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: WIP: Fix project purge image commands https://review.opendev.org/c/openstack/python-openstackclient/+/885528
16:59:28 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: tests: Remove FakeImagev2Client https://review.opendev.org/c/openstack/python-openstackclient/+/885529
16:59:28 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: WIP: tests: Add image v1, v2 FakeClientMixin https://review.opendev.org/c/openstack/python-openstackclient/+/885530
#openstack-sdks - 2023-06-08
06:08:38 opendevreview Jake Yip proposed openstack/python-openstackclient master: Fix `project --remove-tag` behaviour https://review.opendev.org/c/openstack/python-openstackclient/+/885566
08:24:06 opendevreview Jake Yip proposed openstack/python-openstackclient master: Allow multiple `--remove-tag` in `project set` https://review.opendev.org/c/openstack/python-openstackclient/+/885566
13:18:15 opendevreview Mridula Joshi proposed openstack/python-openstackclient master: Adding openstack eqivalent for ``glance md-namespace-resource-type-list`` https://review.opendev.org/c/openstack/python-openstackclient/+/885583
13:24:28 opendevreview Mridula Joshi proposed openstack/python-openstackclient master: Adding OSC command for ``glance md-namespace-resource-type-list`` https://review.opendev.org/c/openstack/python-openstackclient/+/885583
#openstack-sdks - 2023-06-09
13:36:36 opendevreview Stephen Finucane proposed openstack/python-openstackclient master: tests: Use a new project for quota tests https://review.opendev.org/c/openstack/python-openstackclient/+/885761
13:40:41 opendevreview Rajat Dhasmana proposed openstack/python-openstackclient master: Migrate 'volume summary' command to SDK https://review.opendev.org/c/openstack/python-openstackclient/+/884398
15:51:06 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_hypervisor https://review.opendev.org/c/openstack/python-openstackclient/+/885517
15:51:07 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_server_group https://review.opendev.org/c/openstack/python-openstackclient/+/885766
16:01:07 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_server_volume https://review.opendev.org/c/openstack/python-openstackclient/+/885768
16:03:13 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_hypervisor https://review.opendev.org/c/openstack/python-openstackclient/+/885517
16:03:13 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_server_group https://review.opendev.org/c/openstack/python-openstackclient/+/885766
16:03:14 opendevreview Artem Goncharov proposed openstack/python-openstackclient master: Adopt sdk_fakes for compute.test_server_volume https://review.opendev.org/c/openstack/python-openstackclient/+/885768
16:41:55 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682
16:41:56 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Set image.properties type to dict https://review.opendev.org/c/openstack/openstacksdk/+/885791
17:19:46 opendevreview Stephen Finucane proposed openstack/openstacksdk master: Fix typo https://review.opendev.org/c/openstack/openstacksdk/+/885793
17:33:18 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682
#openstack-sdks - 2023-06-11
17:23:55 opendevreview Mridula Joshi proposed openstack/openstacksdk master: Add image metadef object operations https://review.opendev.org/c/openstack/openstacksdk/+/858350
#openstack-sdks - 2023-06-12
15:12:10 opendevreview Artem Goncharov proposed openstack/openstacksdk master: Add fake resources generator https://review.opendev.org/c/openstack/openstacksdk/+/882682
16:03:49 opendevreview Elod Illes proposed openstack/openstacksdk stable/wallaby: DNM: check CI health in zuul https://review.opendev.org/c/openstack/openstacksdk/+/885891
17:22:32 opendevreview Elod Illes proposed openstack/openstacksdk stable/wallaby: Do not pin openstacksdk to master https://review.opendev.org/c/openstack/openstacksdk/+/885898
18:52:34 opendevreview Elod Illes proposed openstack/openstacksdk stable/victoria: Do not pin openstacksdk to master https://review.opendev.org/c/openstack/openstacksdk/+/885901
#openstack-sdks - 2023-06-13
08:12:28 opendevreview Fabian Wiesel proposed openstack/openstacksdk master: Add support for targeting host in a cold-migration https://review.opendev.org/c/openstack/openstacksdk/+/881552
16:25:52 opendevreview Mahnoor Asghar proposed openstack/openstacksdk master: Adds support for node hardware inventory https://review.opendev.org/c/openstack/openstacksdk/+/886008
22:11:35 gtema slaweq, pls have a look at https://review.opendev.org/c/openstack/openstacksdk/+/882282

Earlier   Later