| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-09-02 | |||
| 11:55:48 | gtema | I will come back to you, maybe tomorrow, cause today afternoon I need to jump off | |
| 11:57:14 | thomasb06 | no bother, my phd is ending so it's a bit helter-skelter here too | |
| 11:57:24 | gtema | ok | |
| 11:58:39 | thomasb06 | initially, it was to be credible when applying for a job so as soon as I can write "contributing to OpenStack" and feel trustworthy it's ok | |
| 11:59:06 | gtema | :) | |
| 11:59:12 | gtema | yeah, that's a really bold statement | |
| 11:59:14 | thomasb06 | ;) | |
| 12:00:03 | thomasb06 | at the moment I'm preparing for LFCS and LFCE | |
| 12:00:46 | thomasb06 | but it wouldn't be enough for an OpenStack engineer position | |
| 12:01:42 | gtema | I would say that whoever ever tried to manage first initial contribution knows and correspondingly respects everyone who managed that | |
| 12:01:49 | gtema | (mean from employer pov) | |
| 12:03:08 | thomasb06 | then, I definitely need to keep going | |
| 12:03:36 | gtema | sure, cause also once you prove you did something useful - it becomes even more interesting | |
| 12:03:53 | gtema | no clue, though, which employers currently know what OpenStack actually is | |
| 12:05:29 | thomasb06 | all company in the DevOps environment mush have heard of OpenStack, so even if they don't use the platform it should be a plus on the CV | |
| 12:05:43 | gtema | hopefully | |
| 12:35:39 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Add Neutron Local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 13:36:55 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 13:36:59 | opendevreview | Lee Yarwood proposed openstack/python-openstackclient master: compute: Add support for microversion 2.89 https://review.opendev.org/c/openstack/python-openstackclient/+/804377 | |
| 13:40:21 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Add Neutron Local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 13:42:13 | opendevreview | Mamatisa Nurmatov proposed openstack/openstacksdk master: Add Neutron Local IP CRUD https://review.opendev.org/c/openstack/openstacksdk/+/804988 | |
| 13:52:42 | opendevreview | Merged openstack/ansible-collections-openstack master: Release 1.5.1 version https://review.opendev.org/c/openstack/ansible-collections-openstack/+/807099 | |
| 14:41:21 | opendevreview | Merged openstack/ansible-collections-openstack master: Don't run functional jobs on galaxy.yml change https://review.opendev.org/c/openstack/ansible-collections-openstack/+/807113 | |
| 14:54:00 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 15:56:53 | gtema | thomasb06: have task for you | |
| 15:57:00 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/resource.py#L630 | |
| 15:57:24 | gtema | this causes tons of debug messages like: `Attribute [] not found in [<openstack.resource._ComponentManager object at 0x7fc649c52520>]: ''.` | |
| 15:58:45 | gtema | you could make a change that changes it only to throw log if attribute was not empty | |
| 15:58:54 | gtema | and please - do this on feature/r1 branch | |
| 19:03:18 | opendevreview | Merged openstack/python-openstackclient master: compute: Add support for microversion 2.89 https://review.opendev.org/c/openstack/python-openstackclient/+/804377 | |
| 20:15:12 | opendevreview | Merged openstack/python-openstackclient master: compute: Add support for microversion 2.90 https://review.opendev.org/c/openstack/python-openstackclient/+/806921 | |
| #openstack-sdks - 2021-09-03 | |||
| 06:21:30 | thomasb06 | gtema: hello. Did you find something for me to do? (hehe...) | |
| 06:22:11 | gtema | Yes, yesterday evening I wrote here | |
| 06:22:22 | gtema | Can you see history? | |
| 06:23:25 | thomasb06 | arg, I haven't a bouncer yet... By the way, if you have a link on how to set up one, I'm interested | |
| 06:25:03 | gtema | https://meetings.opendev.org/irclogs/%23openstack-sdks/%23openstack-sdks.2021-09-02.log.html | |
| 06:25:51 | gtema | But generally - install matrix client (i.e. Element) and enter this room through irc bridge | |
| 06:25:59 | thomasb06 | got it, thank you | |
| 06:26:52 | gtema | https://github.com/matrix-org/matrix-appservice-irc/wiki/Bridged-IRC-networks | |
| 06:27:35 | gtema | This is really the best way for staying connected (for those not grown up in IRC age;-) | |
| 06:30:13 | thomasb06 | great, I'll give it a try | |
| 06:30:46 | gtema | Cool | |
| 06:42:10 | thomasb06 | what about https://x0.at/OYEh.txt ? | |
| 06:43:55 | gtema | almost | |
| 06:44:23 | gtema | you still should have exception handling block to prevent that the key (alternate_id) is known, but attribute is still missing | |
| 06:45:51 | gtema | we can potentially try elif ... return self._body.get(key) - this is kinda exception handling | |
| 06:46:49 | gtema | and also, I would potentially try to get _alternate_id() first not to invoke it 2 times | |
| 06:58:31 | thomasb06 | do we have a Walrus operator: https://x0.at/-qjT.txt | |
| 06:58:37 | thomasb06 | ? | |
| 08:14:38 | gtema | you can always try if you not sure | |
| 08:15:09 | gtema | our jobs will run all required tests with multiple py versions and you will see whether something is not working in particular py version | |
| 08:25:56 | thomasb06 | ok, this afternoon I'll commit the modification. What I need to do is clone the sdk repo and activate gerrit in it: https://opendev.org/openstack/openstacksdk.git ? | |
| 08:28:56 | gtema | yes, but please remember - try to make change for feature/r1 branch | |
| 08:29:35 | gtema | if doesn't work - do in master | |
| 08:35:53 | thomasb06 | if I remember well, the command to switch branch is `git checkout feature/r1` ? Option -b is when the branch doesn't exists but it's not the case: https://opendev.org/openstack/openstacksdk/src/branch/feature/r1 | |
| 08:36:33 | gtema | right. You might try to do `git checkout origin/feature/r1` | |
| 08:36:48 | gtema | I remember there was a challenge, but do not remember how exactly I managed this | |
| 08:38:34 | thomasb06 | it said: «HEAD is now at ed63ed6e Merge "Vpn ike policy resource" into feature/r1» | |
| 08:38:44 | gtema | good | |
| 08:51:04 | thomasb06 | sent: https://review.opendev.org/c/openstack/openstacksdk/+/807274 | |
| 08:51:53 | gtema | Good. Now you can sit and relay waiting for the results (up to 2 hours, since we have really lots of jobs) | |
| 08:52:23 | thomasb06 | cool. Time to go for my meal then | |
| 08:52:32 | gtema | and prepare to rework you change by changing commit message renaming it and giving reasonable description of the change | |
| 08:52:37 | gtema | enjoy | |
| 08:53:45 | thomasb06 | ah, of course... Until now, I've only made commits to training repos | |
| 08:53:53 | gtema | yupp | |
| 08:54:08 | gtema | remember to use `git commit --amend` not to produce new change | |
| 09:00:48 | thomasb06 | ok, I didn't now this command. The manual says it's like a reset and commit -c combined | |
| 09:01:25 | gtema | no - this is "rewrite last commit" | |
| 09:49:26 | opendevreview | Mamatisa Nurmatov proposed openstack/python-openstackclient master: Support Neutron Local IP CRUD https://review.opendev.org/c/openstack/python-openstackclient/+/805618 | |
| 21:05:41 | thomasb06 | gtema: the operator `:=` doesn't work but with a key it went well: https://review.opendev.org/c/openstack/openstacksdk/+/807334 | |
| #openstack-sdks - 2021-09-04 | |||
| 06:32:53 | opendevreview | JIHOJU proposed openstack/python-openstackclient master: Add more filter option of columns for server list -c COLUMN https://review.opendev.org/c/openstack/python-openstackclient/+/807420 | |
| 07:20:52 | thomasb06 | to go backward 3 commits, it's `git rebase -i HEAD~3`, then change pick by drop, then `git commit --amend` to change the commit message, and to end `git review`? | |
| 07:42:31 | gtema | Well, 2 options | |
| 07:42:56 | gtema | 1) in UI click rebase and select "to HEAD" | |
| 07:43:58 | gtema | 2) do "git review -d LAST_CHANGE" and "git rebase feature/R1" | |
| 07:45:01 | gtema | In any way important: last line of commit message is changeid, this is the identifier for Gerrit. Once this changes you produce new change | |
| 07:45:48 | gtema | And every time you do regular commit your local hooks tend to ensure there is changeid there | |
| 07:46:41 | gtema | Wrt 2) somehow I am not 100% sure it will work. It may decide to rebase whole change and not only the last change | |
| 07:46:53 | gtema | Thus option 1) is the easiest way | |
| 09:16:31 | thomasb06 | as I have no UI, I'll go for option 2). Monday I'm back on the computer that has the repo, I'll try to rebase there. If clone the repository again on another computer and commit other changes, it's going to be messy I guess? | |
| 09:37:41 | thomasb06 | from another computer: https://review.opendev.org/c/openstack/openstacksdk/+/807427 | |
| 09:38:08 | thomasb06 | branch is feature/r1 and it's one commit far from the Head | |
| 09:47:00 | gtema | Under UI I mean gerrit | |
| 10:42:33 | thomasb06 | Yes, I haven't installed the gerrit UI yet. What I did was to clone the repository on another computer and as the copy was clean redo the modifications straight from the Head. Monday, I'll need to clean the three failed commit but I'm not sure about how to do it. Maybe `git fetch --force`? | |
| 11:06:41 | gtema | You don't install it | |
| 11:06:57 | gtema | The link you posted - simply open it with browser | |
| #openstack-sdks - 2021-09-06 | |||
| 09:44:23 | thomasb06 | About the three commits I did wrong, would it be enough to click 'Abandon' in the UI? | |
| 09:44:47 | gtema | yes | |
| 09:54:36 | thomasb06 | Done, the new commit is: https://review.opendev.org/c/openstack/openstacksdk/+/807427 | |
| 09:56:57 | thomasb06 | Sorry about it. Next time, I'll be more carefull and use commit --amend. From 4pm to 6pm, I have another tiny timeframe if you would have another cleaning modification for me | |
| 10:12:53 | gtema | thomasb06: if you look at https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/tests/unit/block_storage/v3/test_proxy.py#L36 (pretty much the file as whole) | |
| 10:13:04 | gtema | you see there are multiple test classes | |
| 10:13:17 | gtema | which split test functions base on the "resource" we test | |
| 10:13:44 | gtema | similar is present in https://opendev.org/openstack/openstacksdk/src/branch/feature/r1/openstack/tests/unit/compute/v2/test_proxy.py | |
| 10:14:18 | gtema | so if you can apply the same pattern (splitting single test class into multiple) for all the other services it would be great | |
| 10:14:34 | gtema | basically openstacl/tests/unit//v/test_proxy.py | |
| 10:14:40 | gtema | * basically openstack/tests/unit//v/test_proxy.py | |
| 10:29:24 | thomasb06 | If I understood well you would need all the files `openstack/tests/unit/*/v/test_proxy.py` to be split into test classes as in `block_storage/v3/test_proxy.py` and `compute/v2/test_proxy.py` ? | |
| 10:30:42 | gtema | Yes | |