| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2021-05-06 | |||
| 14:31:42 | mordred | gtema: ^^ that looks great, but there's a weird collection of extraneous spaces | |
| 14:31:43 | mordred | gtema: ^^ that looks great, but there's a weird collection of extraneous spaces | |
| 14:32:25 | gtema | oh right - vim went crazy | |
| 14:32:25 | gtema | oh right - vim went crazy | |
| 14:32:49 | gtema | I tried to fix indent for the params (3 chars>2) and it touched something else | |
| 14:32:49 | gtema | I tried to fix indent for the params (3 chars>2) and it touched something else | |
| 14:34:56 | openstackgerrit | Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch to proxy layer of the SDK for project https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790076 | |
| 14:35:19 | gtema | ah, still not everything | |
| 14:35:19 | gtema | ah, still not everything | |
| 14:35:21 | gtema | argh | |
| 14:35:21 | gtema | argh | |
| 14:36:21 | openstackgerrit | Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch to proxy layer of the SDK for project https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790076 | |
| 14:37:12 | gtema | yeah, now looks correct | |
| 14:37:12 | gtema | yeah, now looks correct | |
| 14:53:39 | openstackgerrit | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add TripleO job on collections used in TripleO https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789818 | |
| 14:53:39 | openstackgerrit | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add TripleO job on collections used in TripleO https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789818 | |
| 15:26:00 | openstackgerrit | James Palmer proposed openstack/openstacksdk master: Add support for API Extensions https://review.opendev.org/c/openstack/openstacksdk/+/788568 | |
| 16:11:33 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add support for project options https://review.opendev.org/c/openstack/openstacksdk/+/790095 | |
| 16:11:33 | openstackgerrit | Artem Goncharov proposed openstack/openstacksdk master: Add support for project options https://review.opendev.org/c/openstack/openstacksdk/+/790095 | |
| 16:14:01 | openstackgerrit | Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch to proxy layer of the SDK for project https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790076 | |
| 16:14:01 | openstackgerrit | Artem Goncharov proposed openstack/ansible-collections-openstack master: Switch to proxy layer of the SDK for project https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790076 | |
| 16:28:56 | openstackgerrit | James Palmer proposed openstack/openstacksdk master: Add support for API Extensions https://review.opendev.org/c/openstack/openstacksdk/+/788568 | |
| 16:28:56 | openstackgerrit | James Palmer proposed openstack/openstacksdk master: Add support for API Extensions https://review.opendev.org/c/openstack/openstacksdk/+/788568 | |
| 21:07:51 | openstackgerrit | Merged openstack/ansible-collections-openstack master: Add TripleO job on collections used in TripleO https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789818 | |
| 21:07:51 | openstackgerrit | Merged openstack/ansible-collections-openstack master: Add TripleO job on collections used in TripleO https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789818 | |
| 21:12:46 | openstackgerrit | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793 | |
| 21:13:03 | openstackgerrit | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Switch to proxy layer of the SDK for project https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790076 | |
| 21:13:03 | openstackgerrit | Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Switch to proxy layer of the SDK for project https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790076 | |
| 21:22:49 | ianw | hi, could i get another eye on https://review.opendev.org/c/openstack/openstacksdk/+/788414 which is the last change for a job removal backported to stable/stein, thanks | |
| 21:22:49 | ianw | hi, could i get another eye on https://review.opendev.org/c/openstack/openstacksdk/+/788414 which is the last change for a job removal backported to stable/stein, thanks | |
| #openstack-sdks - 2021-05-07 | |||
| 00:19:15 | rm_work | eugh, the switch to SDK for image-v2 broke --tag lookup :( | |
| 00:19:15 | rm_work | eugh, the switch to SDK for image-v2 broke --tag lookup :( | |
| 00:19:16 | rm_work | https://github.com/openstack/python-openstackclient/commit/60e7c51df4cf061ebbb435a959ad63c7d3a296bf#diff-9c3c9b14e60641cabdf48b609e17c7f8244d4d6ccada0c13a690d05f96e992ea | |
| 00:19:17 | rm_work | https://github.com/openstack/python-openstackclient/commit/60e7c51df4cf061ebbb435a959ad63c7d3a296bf#diff-9c3c9b14e60641cabdf48b609e17c7f8244d4d6ccada0c13a690d05f96e992ea | |
| 00:22:01 | rm_work | http://paste.openstack.org/show/805014/ | |
| 00:22:01 | rm_work | http://paste.openstack.org/show/805014/ | |
| 00:23:26 | rm_work | ahhh I guess the actual issue is here: https://review.opendev.org/c/openstack/openstacksdk/+/789827 | |
| 00:23:26 | rm_work | ahhh I guess the actual issue is here: https://review.opendev.org/c/openstack/openstacksdk/+/789827 | |
| 00:25:23 | rm_work | so, need that merged, in the meantime SDK is broken for image tag lookup | |
| 00:25:23 | rm_work | so, need that merged, in the meantime SDK is broken for image tag lookup | |
| 00:38:31 | rm_work | oh right, I'm sdk core <_< | |
| 00:38:31 | rm_work | oh right, I'm sdk core <_< | |
| 03:57:02 | openstackgerrit | Merged openstack/openstacksdk master: Revert tags query_params back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827 | |
| 03:57:02 | openstackgerrit | Merged openstack/openstacksdk master: Revert tags query_params back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827 | |
| 05:07:11 | frickler | rm_work: noonedeadpunk: ^^ that patch still failed the osc job, but with a later failure iiuc https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2 | |
| 05:07:11 | frickler | rm_work: noonedeadpunk: ^^ that patch still failed the osc job, but with a later failure iiuc https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2 | |
| 05:07:29 | rm_work | hmmmm | |
| 05:07:29 | rm_work | hmmmm | |
| 05:07:31 | frickler | also I guess we'd still need a release in order to unblock osc | |
| 05:07:31 | frickler | also I guess we'd still need a release in order to unblock osc | |
| 05:07:37 | rm_work | it resolved the problem entirely in my testbed | |
| 05:07:37 | rm_work | it resolved the problem entirely in my testbed | |
| 05:09:02 | frickler | rm_work: there's also a related osc patch https://review.opendev.org/c/openstack/python-openstackclient/+/789838 | |
| 05:09:02 | frickler | rm_work: there's also a related osc patch https://review.opendev.org/c/openstack/python-openstackclient/+/789838 | |
| 05:14:24 | rm_work | ok | |
| 05:14:24 | rm_work | ok | |
| 05:14:38 | rm_work | that's probably good, though my concern was with resolving a regression ASAP | |
| 05:14:38 | rm_work | that's probably good, though my concern was with resolving a regression ASAP | |
| 05:14:49 | rm_work | since it was breaking pipelines | |
| 05:14:49 | rm_work | since it was breaking pipelines | |
| 05:15:14 | rm_work | (we have pipelines that run with the newest client from git, and used image selection by tag) | |
| 05:15:14 | rm_work | (we have pipelines that run with the newest client from git, and used image selection by tag) | |
| 05:37:57 | frickler | rm_work: yes, I'm all for fixing regression first, it's just that with that test result I'm not sure whether the fix is actually complete. hopefully the recheck I just did on the osc patch will show this in the tips job | |
| 05:37:57 | frickler | rm_work: yes, I'm all for fixing regression first, it's just that with that test result I'm not sure whether the fix is actually complete. hopefully the recheck I just did on the osc patch will show this in the tips job | |
| 06:43:25 | frickler | rm_work: noonedeadpunk: that error seems to persist, so to me the fix looks incomplete. b"tag unset failed, '01' is a nonexistent tag \nFailed to unset 1 of 1 tags.\n" https://zuul.opendev.org/t/openstack/build/2e3fef6b75dc47fc93a3368393aaf01e | |
| 06:43:25 | frickler | rm_work: noonedeadpunk: that error seems to persist, so to me the fix looks incomplete. b"tag unset failed, '01' is a nonexistent tag \nFailed to unset 1 of 1 tags.\n" https://zuul.opendev.org/t/openstack/build/2e3fef6b75dc47fc93a3368393aaf01e | |
| 07:56:45 | frickler | o.k., I can reproduce that error locally and now it really looks like a regression in glance to me, which returns 404 for the API call. we might want to improve on the error message, though | |
| 07:56:45 | frickler | o.k., I can reproduce that error locally and now it really looks like a regression in glance to me, which returns 404 for the API call. we might want to improve on the error message, though | |
| 07:59:57 | frickler | gtema: ^^ FYI still some issue remaining with the image tags after the sdk fix merged | |
| 07:59:57 | frickler | gtema: ^^ FYI still some issue remaining with the image tags after the sdk fix merged | |
| 08:00:19 | frickler | oh, actually the 404 is only on the second attempt, when the tag has indeed been removed already | |
| 08:00:19 | frickler | oh, actually the 404 is only on the second attempt, when the tag has indeed been removed already | |
| 08:00:37 | frickler | seems we interpret the 204 which we get on successful delete as error | |
| 08:00:37 | frickler | seems we interpret the 204 which we get on successful delete as error | |
| 08:01:01 | gtema | logs please | |
| 08:01:01 | gtema | logs please | |
| 08:01:06 | frickler | http://paste.openstack.org/show/805024/ | |
| 08:01:07 | frickler | http://paste.openstack.org/show/805024/ | |
| 08:01:16 | frickler | gtema: was already on it ;) | |
| 08:01:16 | frickler | gtema: was already on it ;) | |
| 08:02:48 | frickler | gtema: if you missed the earlier conversation, this is where noonedeadpunk's patch still failed the osc job https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2 | |
| 08:02:48 | frickler | gtema: if you missed the earlier conversation, this is where noonedeadpunk's patch still failed the osc job https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2 | |
| 08:12:24 | frickler | humm, the error is even weirder. "'NoneType' object has no attribute 'remove'" is what I get if I print the exception in https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1214 | |
| 08:12:24 | frickler | humm, the error is even weirder. "'NoneType' object has no attribute 'remove'" is what I get if I print the exception in https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1214 | |
| 08:14:02 | gtema | I do not see immediately a bug. 204 is not treated like an error. It looks like something else is throwing this exception. | |
| 08:14:02 | gtema | I do not see immediately a bug. 204 is not treated like an error. It looks like something else is throwing this exception. | |
| 08:14:21 | gtema | if you are on it - can you look on what the Exception https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1215 really is? | |
| 08:14:21 | gtema | if you are on it - can you look on what the Exception https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1215 really is? | |
| 08:17:50 | frickler | gtema: that's the full traceback I get http://paste.openstack.org/show/805025/ . I need to do some other stuff now, can hopefully continue later if needed | |
| 08:17:50 | frickler | gtema: that's the full traceback I get http://paste.openstack.org/show/805025/ . I need to do some other stuff now, can hopefully continue later if needed | |
| 11:00:23 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Fix import order in message and workflow unit tests https://review.opendev.org/c/openstack/openstacksdk/+/790219 | |
| 11:00:23 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Fix import order in message and workflow unit tests https://review.opendev.org/c/openstack/openstacksdk/+/790219 | |
| 11:49:17 | openstackgerrit | Dr. Jens Harbott proposed openstack/openstacksdk master: Revert overwriting tags for the imagev2 resource https://review.opendev.org/c/openstack/openstacksdk/+/790229 | |
| 11:49:17 | openstackgerrit | Dr. Jens Harbott proposed openstack/openstacksdk master: Revert overwriting tags for the imagev2 resource https://review.opendev.org/c/openstack/openstacksdk/+/790229 | |
| 11:50:04 | frickler | gtema: noonedeadpunk: ^^ that's what came out of my testing, not sure whether that is the correct way forward, but if fixes the test cases for me | |
| 11:50:04 | frickler | gtema: noonedeadpunk: ^^ that's what came out of my testing, not sure whether that is the correct way forward, but if fixes the test cases for me | |
| 11:50:17 | frickler | s/if/it | |
| 11:50:17 | frickler | s/if/it | |
| 11:51:51 | gtema | that's not correct way, since in this case fetching tags info will/may not properly work | |
| 11:51:51 | gtema | that's not correct way, since in this case fetching tags info will/may not properly work | |