Earlier  
Posted Nick Remark
#openstack-sdks - 2021-05-07
00:38:31 rm_work oh right, I'm sdk core <_<
00:38:31 rm_work oh right, I'm sdk core <_<
03:57:02 openstackgerrit Merged openstack/openstacksdk master: Revert tags query_params back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827
03:57:02 openstackgerrit Merged openstack/openstacksdk master: Revert tags query_params back to tag https://review.opendev.org/c/openstack/openstacksdk/+/789827
05:07:11 frickler rm_work: noonedeadpunk: ^^ that patch still failed the osc job, but with a later failure iiuc https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2
05:07:11 frickler rm_work: noonedeadpunk: ^^ that patch still failed the osc job, but with a later failure iiuc https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2
05:07:29 rm_work hmmmm
05:07:29 rm_work hmmmm
05:07:31 frickler also I guess we'd still need a release in order to unblock osc
05:07:31 frickler also I guess we'd still need a release in order to unblock osc
05:07:37 rm_work it resolved the problem entirely in my testbed
05:07:37 rm_work it resolved the problem entirely in my testbed
05:09:02 frickler rm_work: there's also a related osc patch https://review.opendev.org/c/openstack/python-openstackclient/+/789838
05:09:02 frickler rm_work: there's also a related osc patch https://review.opendev.org/c/openstack/python-openstackclient/+/789838
05:14:24 rm_work ok
05:14:24 rm_work ok
05:14:38 rm_work that's probably good, though my concern was with resolving a regression ASAP
05:14:38 rm_work that's probably good, though my concern was with resolving a regression ASAP
05:14:49 rm_work since it was breaking pipelines
05:14:49 rm_work since it was breaking pipelines
05:15:14 rm_work (we have pipelines that run with the newest client from git, and used image selection by tag)
05:15:14 rm_work (we have pipelines that run with the newest client from git, and used image selection by tag)
05:37:57 frickler rm_work: yes, I'm all for fixing regression first, it's just that with that test result I'm not sure whether the fix is actually complete. hopefully the recheck I just did on the osc patch will show this in the tips job
05:37:57 frickler rm_work: yes, I'm all for fixing regression first, it's just that with that test result I'm not sure whether the fix is actually complete. hopefully the recheck I just did on the osc patch will show this in the tips job
06:43:25 frickler rm_work: noonedeadpunk: that error seems to persist, so to me the fix looks incomplete. b"tag unset failed, '01' is a nonexistent tag \nFailed to unset 1 of 1 tags.\n" https://zuul.opendev.org/t/openstack/build/2e3fef6b75dc47fc93a3368393aaf01e
06:43:25 frickler rm_work: noonedeadpunk: that error seems to persist, so to me the fix looks incomplete. b"tag unset failed, '01' is a nonexistent tag \nFailed to unset 1 of 1 tags.\n" https://zuul.opendev.org/t/openstack/build/2e3fef6b75dc47fc93a3368393aaf01e
07:56:45 frickler o.k., I can reproduce that error locally and now it really looks like a regression in glance to me, which returns 404 for the API call. we might want to improve on the error message, though
07:56:45 frickler o.k., I can reproduce that error locally and now it really looks like a regression in glance to me, which returns 404 for the API call. we might want to improve on the error message, though
07:59:57 frickler gtema: ^^ FYI still some issue remaining with the image tags after the sdk fix merged
07:59:57 frickler gtema: ^^ FYI still some issue remaining with the image tags after the sdk fix merged
08:00:19 frickler oh, actually the 404 is only on the second attempt, when the tag has indeed been removed already
08:00:19 frickler oh, actually the 404 is only on the second attempt, when the tag has indeed been removed already
08:00:37 frickler seems we interpret the 204 which we get on successful delete as error
08:00:37 frickler seems we interpret the 204 which we get on successful delete as error
08:01:01 gtema logs please
08:01:01 gtema logs please
08:01:06 frickler http://paste.openstack.org/show/805024/
08:01:07 frickler http://paste.openstack.org/show/805024/
08:01:16 frickler gtema: was already on it ;)
08:01:16 frickler gtema: was already on it ;)
08:02:48 frickler gtema: if you missed the earlier conversation, this is where noonedeadpunk's patch still failed the osc job https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2
08:02:48 frickler gtema: if you missed the earlier conversation, this is where noonedeadpunk's patch still failed the osc job https://zuul.opendev.org/t/openstack/build/acbfd94f7a0148668356046f6f0a3be2
08:12:24 frickler humm, the error is even weirder. "'NoneType' object has no attribute 'remove'" is what I get if I print the exception in https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1214
08:12:24 frickler humm, the error is even weirder. "'NoneType' object has no attribute 'remove'" is what I get if I print the exception in https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1214
08:14:02 gtema I do not see immediately a bug. 204 is not treated like an error. It looks like something else is throwing this exception.
08:14:02 gtema I do not see immediately a bug. 204 is not treated like an error. It looks like something else is throwing this exception.
08:14:21 gtema if you are on it - can you look on what the Exception https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1215 really is?
08:14:21 gtema if you are on it - can you look on what the Exception https://opendev.org/openstack/python-openstackclient/src/branch/master/openstackclient/image/v2/image.py#L1215 really is?
08:17:50 frickler gtema: that's the full traceback I get http://paste.openstack.org/show/805025/ . I need to do some other stuff now, can hopefully continue later if needed
08:17:50 frickler gtema: that's the full traceback I get http://paste.openstack.org/show/805025/ . I need to do some other stuff now, can hopefully continue later if needed
11:00:23 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Fix import order in message and workflow unit tests https://review.opendev.org/c/openstack/openstacksdk/+/790219
11:00:23 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Fix import order in message and workflow unit tests https://review.opendev.org/c/openstack/openstacksdk/+/790219
11:49:17 openstackgerrit Dr. Jens Harbott proposed openstack/openstacksdk master: Revert overwriting tags for the imagev2 resource https://review.opendev.org/c/openstack/openstacksdk/+/790229
11:49:17 openstackgerrit Dr. Jens Harbott proposed openstack/openstacksdk master: Revert overwriting tags for the imagev2 resource https://review.opendev.org/c/openstack/openstacksdk/+/790229
11:50:04 frickler gtema: noonedeadpunk: ^^ that's what came out of my testing, not sure whether that is the correct way forward, but if fixes the test cases for me
11:50:04 frickler gtema: noonedeadpunk: ^^ that's what came out of my testing, not sure whether that is the correct way forward, but if fixes the test cases for me
11:50:17 frickler s/if/it
11:50:17 frickler s/if/it
11:51:51 gtema that's not correct way, since in this case fetching tags info will/may not properly work
11:51:51 gtema that's not correct way, since in this case fetching tags info will/may not properly work
11:54:26 gtema most likely https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L2058 should be copied into the https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/image/v2/image.py and https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L2076 (updating attribute) removed
11:54:26 gtema most likely https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L2058 should be copied into the https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/image/v2/image.py and https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/resource.py#L2076 (updating attribute) removed
11:54:49 gtema maybe even completely 2069-2078 removed
11:54:49 gtema maybe even completely 2069-2078 removed
11:55:54 frickler o.k., then someone else needs to take this over. the revert would at least unblock osc and consumers
11:55:54 frickler o.k., then someone else needs to take this over. the revert would at least unblock osc and consumers
11:56:21 gtema will try to find time in the upcoming days
11:56:22 gtema will try to find time in the upcoming days
19:26:33 openstackgerrit Polina Gubina proposed openstack/openstacksdk master: Add IPsecSiteConnection resource and proxy layer functionality for it https://review.opendev.org/c/openstack/openstacksdk/+/788474
19:33:03 openstackgerrit Polina Gubina proposed openstack/openstacksdk master: Add IPsecSiteConnection resource and proxy layer functionality for it https://review.opendev.org/c/openstack/openstacksdk/+/788474
#openstack-sdks - 2021-05-08
00:46:14 openstackgerrit Wenping Song proposed openstack/openstacksdk master: Remove references to 'sys.version_info' https://review.opendev.org/c/openstack/openstacksdk/+/788903
00:46:14 openstackgerrit Wenping Song proposed openstack/openstacksdk master: Remove references to 'sys.version_info' https://review.opendev.org/c/openstack/openstacksdk/+/788903
00:47:25 openstackgerrit Wenping Song proposed openstack/osc-lib master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/osc-lib/+/788727
00:47:25 openstackgerrit Wenping Song proposed openstack/osc-lib master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/osc-lib/+/788727
06:40:56 openstackgerrit Merged openstack/openstacksdk master: Remove references to 'sys.version_info' https://review.opendev.org/c/openstack/openstacksdk/+/788903
06:40:56 openstackgerrit Merged openstack/openstacksdk master: Remove references to 'sys.version_info' https://review.opendev.org/c/openstack/openstacksdk/+/788903
19:51:02 openstackgerrit Igor Tiunov proposed openstack/openstacksdk master: This change fixes the get_server_password method where a typo (or mistake) prevents making the actual proxy request. https://review.opendev.org/c/openstack/openstacksdk/+/790342
19:51:02 openstackgerrit Igor Tiunov proposed openstack/openstacksdk master: This change fixes the get_server_password method where a typo (or mistake) prevents making the actual proxy request. https://review.opendev.org/c/openstack/openstacksdk/+/790342
19:59:52 itd27m01 @mordred @gmann Hi Guys, I would like to suggest another small fix and need your help, see above.
19:59:52 itd27m01 @mordred @gmann Hi Guys, I would like to suggest another small fix and need your help, see above.
20:04:09 itd27m01 gtema (g_m_a_n_n was a mistake)
20:04:10 itd27m01 gtema (g_m_a_n_n was a mistake)
#openstack-sdks - 2021-05-10
06:39:58 ianw hi, if i could get one more eye on https://review.opendev.org/c/openstack/openstacksdk/+/788414 to backport a job removal to stable/stein that would be great, and unblock me removing the test in other projects
06:39:58 ianw hi, if i could get one more eye on https://review.opendev.org/c/openstack/openstacksdk/+/788414 to backport a job removal to stable/stein that would be great, and unblock me removing the test in other projects
07:43:56 frickler ianw: done
07:43:56 frickler ianw: done
08:39:33 ianw frickler: thanks!
08:39:33 ianw frickler: thanks!
10:00:34 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Fix MFA authorization https://review.opendev.org/c/openstack/openstacksdk/+/788989
10:07:53 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Extend functional test of image https://review.opendev.org/c/openstack/openstacksdk/+/790393
11:17:12 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Add non-voting train TripleO jobs https://review.opendev.org/c/openstack/ansible-collections-openstack/+/790417
11:30:14 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Extend functional test of image https://review.opendev.org/c/openstack/openstacksdk/+/790393
11:38:04 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793
12:09:02 openstackgerrit Polina Gubina proposed openstack/openstacksdk master: Add IPsecSiteConnection resource and proxy layer functionality for it https://review.opendev.org/c/openstack/openstacksdk/+/788474
12:27:37 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793
13:45:40 openstackgerrit Igor Tiunov proposed openstack/openstacksdk master: Fix get_server_password method https://review.opendev.org/c/openstack/openstacksdk/+/790342
13:45:40 openstackgerrit Igor Tiunov proposed openstack/openstacksdk master: Fix get_server_password method https://review.opendev.org/c/openstack/openstacksdk/+/790342
13:57:58 openstackgerrit Shnaidman Sagi (Sergey) proposed openstack/ansible-collections-openstack master: Switch project and project_info module to OpenStackModule https://review.opendev.org/c/openstack/ansible-collections-openstack/+/789793
13:59:45 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Fix MFA authorization https://review.opendev.org/c/openstack/openstacksdk/+/788989
13:59:45 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Fix MFA authorization https://review.opendev.org/c/openstack/openstacksdk/+/788989

Earlier   Later