Posted	Nick	Remark
#openstack-sdks - 2021-01-09
12:53:54	openstackgerrit	Dmitry Tantsur proposed openstack/ansible-collections-openstack master: ironic: stop putting meaningless values to properties https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770036
13:02:15	openstackgerrit	Merged openstack/ansible-collections-openstack master: Add support for new features https://review.opendev.org/c/openstack/ansible-collections-openstack/+/766776
13:05:46	openstackgerrit	Tosin Farai proposed openstack/ansible-collections-openstack master: Add node validation function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770037
15:21:06	openstackgerrit	Tosin Farai proposed openstack/ansible-collections-openstack master: Add node validation function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770037
15:47:03	openstackgerrit	Dmitry Tantsur proposed openstack/ansible-collections-openstack master: ironic: deprecate sub-options of driver_info https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770015
#openstack-sdks - 2021-01-11
10:40:48	openstackgerrit	Stephen Finucane proposed openstack/osc-lib master: Fix lower-constraints job https://review.opendev.org/c/openstack/osc-lib/+/770097
10:41:34	stephenfin	dtantsur, gtema: That'll fix lower-constraints for osc-lib, if either of you could look at it ^
10:42:21	gtema	sure, will have a look today
10:42:26	stephenfin	thanks :)
10:42:59	dtantsur	approved, assuming it passes the CI
10:43:12	stephenfin	awesome
10:43:16	dtantsur	but as a follow-up, should we consider dropping the l-c jobs as many projects do?
10:44:43	stephenfin	I was waiting on the discussion on the mailing list to die out before doing anything. It still seems to be quite active
10:44:53	stephenfin	("[all][tc] Dropping lower-constraints testing from all projects")
10:46:51	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Added shelve and unshelve as new server actions https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770098
11:33:00	nightmare_unreal	review.opendev has totally changed o.O , looks different
12:34:48	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Fixed check for None in os_port https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770115
12:46:08	openstackgerrit	Merged openstack/osc-lib master: Fix lower-constraints job https://review.opendev.org/c/openstack/osc-lib/+/770097
12:53:24	nightmare_unreal	hello can someone help me with this one : https://storyboard.openstack.org/#!/story/2007727
12:57:15	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Added shelve and unshelve as new server actions https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770119
13:05:06	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Allow to attach multiple floating ips to a server https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770120
13:10:52	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Only apply necessary changes to subnets https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770121
14:08:41	stephenfin	nightmare_unreal: I can. Are you able to work on the patch if I give you pointers to fix it?
14:09:00	stephenfin	nightmare_unreal: Before you do though, have you tested with master? There have been a lot of changes there recently
14:10:15	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Only add or remove router interfaces when needed https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770125
14:17:29	stephenfin	nightmare_unreal: Yeah, I already fixed that https://opendev.org/openstack/python-openstackclient/commit/ab0b1fe885ee0a210a58008b631521025be7f3eb
14:24:43	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Added shelve and unshelve as new server actions https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770119
14:25:45	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747 https://review.opendev.org/c/openstack/python-openstackclient/+/770128
14:26:35	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient stable/victoria: Validate 'server group create --policy' option https://review.opendev.org/c/openstack/python-openstackclient/+/770129
14:26:39	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient stable/victoria: Add reno for change Ic3c555226a220efd9b0f27edffccf6c4c95c2747 https://review.opendev.org/c/openstack/python-openstackclient/+/770130
14:29:40	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc https://review.opendev.org/c/openstack/python-openstackclient/+/770131
14:33:05	stephenfin	ralonsoh: If you have 2 mins, I address your comments on that address group PR from last week ^
14:33:15	stephenfin	no rush though
14:34:42	ralonsoh	stephenfin, sure, let me check
14:40:41	nightmare_unreal	stephenfin: so can I close this story then ? https://storyboard.openstack.org/#!/story/2007727
14:40:49	stephenfin	I think I just did?
#openstack-sdks - 2021-01-12
07:09:05	openstackgerrit	Simon Merrick proposed openstack/python-openstackclient master: Add functionality to list swift storage policies https://review.opendev.org/c/openstack/python-openstackclient/+/770238
07:32:08	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Added shelve and unshelve as new server actions https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770119
07:34:43	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Only add or remove router interfaces when needed https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770125
07:52:55	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Only apply necessary changes to subnets https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770121
08:41:48	openstackgerrit	Simon Merrick proposed openstack/python-openstackclient master: List swift storage policies https://review.opendev.org/c/openstack/python-openstackclient/+/770238
08:58:18	openstackgerrit	Simon Merrick proposed openstack/python-openstackclient master: List swift storage policies https://review.opendev.org/c/openstack/python-openstackclient/+/770238
09:15:51	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Added shelve and unshelve as new server actions https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770119
09:30:03	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Only apply necessary changes to subnets https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770121
09:39:24	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient stable/victoria: Fix lower-constraints job https://review.opendev.org/c/openstack/python-openstackclient/+/770254
09:39:34	stephenfin	dtantsur|afk, gtema: Another lower-constraints fix there ^
09:39:39	gtema	yupp
09:58:38	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Only add or remove router interfaces when needed https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770125
10:08:16	openstackgerrit	Stephen Finucane proposed openstack/python-openstackclient master: network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc https://review.opendev.org/c/openstack/python-openstackclient/+/770131
11:00:16	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
11:07:04	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Only apply necessary changes to subnets https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770121
11:24:23	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Only add or remove router interfaces when needed https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770125
12:13:31	openstackgerrit	Merged openstack/ansible-collections-openstack master: Update recordset docu https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770006
12:30:10	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
12:50:16	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
13:54:09	openstackgerrit	Merged openstack/python-openstackclient stable/victoria: Fix lower-constraints job https://review.opendev.org/c/openstack/python-openstackclient/+/770254
13:54:21	openstackgerrit	Merged openstack/python-openstackclient master: network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc https://review.opendev.org/c/openstack/python-openstackclient/+/770131
13:56:03	openstackgerrit	Merged openstack/ansible-collections-openstack master: Added shelve and unshelve as new server actions https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770119
15:53:57	openstackgerrit	Artem Goncharov proposed openstack/ansible-collections-openstack master: Add stack_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/769516
20:01:57	openstackgerrit	Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
20:08:34	openstackgerrit	Simon Merrick proposed openstack/python-openstackclient master: List swift storage policies https://review.opendev.org/c/openstack/python-openstackclient/+/770238
21:41:00	openstackgerrit	Tosin Farai proposed openstack/ansible-collections-openstack master: Add node validation function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770037
#openstack-sdks - 2021-01-13
02:19:21	openstackgerrit	wushiming proposed openstack/openstacksdk master: Drop lower-constraints job https://review.opendev.org/c/openstack/openstacksdk/+/770527
08:10:47	openstackgerrit	Takashi Kajinami proposed openstack/python-openstackclient master: Volume type: Update is_public attribute https://review.opendev.org/c/openstack/python-openstackclient/+/768800
09:19:53	stephenfin	gtema: Are you okay with me self-approving OSC compute-related patches that have +1s from nova cores?
09:20:04	gtema	yes
09:20:09	stephenfin	cool, thanks
09:20:24	gtema	thank you for taking care of that also
09:20:49	stephenfin	no problem at all
09:22:40	stephenfin	gtema: Oh, I do have one non-nova gate fix patch that needs attention though /o\ https://review.opendev.org/c/openstack/python-openstackclient/+/769980
09:23:03	stephenfin	(python-karborclient was removed from tracking in openstack/requirements so the requirements job is failing)
09:23:15	gtema	I thought I was approving it, weird
09:23:34	gtema	done
09:23:38	stephenfin	thanks
09:25:00	gtema	can you please have a look at https://review.opendev.org/c/openstack/openstacksdk/+/769484
09:25:08	gtema	I want to cut SDK release soon
09:25:12	stephenfin	sure, looking now
09:25:53	gtema	and complete this hypervisor patch
10:01:18	stephenfin	gtema: Done
10:01:32	gtema	cool, thks
10:02:07	stephenfin	It's a -1 btw. I think some of the methods from the TagMixin don't work. Apologies if I've misunderstood something
10:03:04	gtema	no problem. For image I (I guess) it was not a complete TagMixin (some methods are also not existing)
10:03:21	gtema	need to think whether to override functions to raise NotImplemented or what else
10:03:29	stephenfin	Maybe we could split it into two mixins?
10:03:44	gtema	would affect lot's of other services
10:04:15	stephenfin	Oh yeah, that's mixin is pretty widely spread
10:06:06	stephenfin	Could split the query and body parameters part of the mixin into a new e.g. TagBodyMixin and have the existing TagMixin subclass that and add the methods. You could then use TagBodyMixin here
10:06:22	stephenfin	We could audit existing uses of TagMixin to make sure they all make sense
10:06:29	stephenfin	later, that is
10:06:43	gtema	except of image others seem to implement tagging properly
10:07:04	stephenfin	Yeah, I know nova does that properly
10:07:07	stephenfin	at least
10:07:14	gtema	network also
10:08:06	stephenfin	Would a separate subclass work so? TagBodyMixin isn't a great name. Maybe MinimalTagMixin or something better again
10:08:50	gtema	you propose separate query params and attributes from methods?
10:09:19	openstackgerrit	Stephen Finucane proposed openstack/openstacksdk master: Demonstrate separate tag mixin https://review.opendev.org/c/openstack/openstacksdk/+/770565
10:09:23	stephenfin	yeah, like that ^
10:10:11	stephenfin	tbc I still don't like the name 'MinimalTagMixin' but I can't think of anything better right now, but you get the idea
10:10:36	gtema	I would say in that case it is easier to manually use query params and attribute without really using mixin
10:10:49	stephenfin	That's fair. It doesn't really give us a lot

Earlier   Later