Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2021-01-12
09:39:34 stephenfin dtantsur|afk, gtema: Another lower-constraints fix there ^
09:39:39 gtema yupp
09:58:38 openstackgerrit Jakob Meng proposed openstack/ansible-collections-openstack master: Only add or remove router interfaces when needed https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770125
10:08:16 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc https://review.opendev.org/c/openstack/python-openstackclient/+/770131
11:00:16 openstackgerrit Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
11:07:04 openstackgerrit Jakob Meng proposed openstack/ansible-collections-openstack master: Only apply necessary changes to subnets https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770121
11:24:23 openstackgerrit Jakob Meng proposed openstack/ansible-collections-openstack master: Only add or remove router interfaces when needed https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770125
12:13:31 openstackgerrit Merged openstack/ansible-collections-openstack master: Update recordset docu https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770006
12:30:10 openstackgerrit Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
12:50:16 openstackgerrit Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
13:54:09 openstackgerrit Merged openstack/python-openstackclient stable/victoria: Fix lower-constraints job https://review.opendev.org/c/openstack/python-openstackclient/+/770254
13:54:21 openstackgerrit Merged openstack/python-openstackclient master: network: Address nits for I3c313fc9329837dde67815901528a34dca98ebcc https://review.opendev.org/c/openstack/python-openstackclient/+/770131
13:56:03 openstackgerrit Merged openstack/ansible-collections-openstack master: Added shelve and unshelve as new server actions https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770119
15:53:57 openstackgerrit Artem Goncharov proposed openstack/ansible-collections-openstack master: Add stack_info module https://review.opendev.org/c/openstack/ansible-collections-openstack/+/769516
20:01:57 openstackgerrit Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
20:08:34 openstackgerrit Simon Merrick proposed openstack/python-openstackclient master: List swift storage policies https://review.opendev.org/c/openstack/python-openstackclient/+/770238
21:41:00 openstackgerrit Tosin Farai proposed openstack/ansible-collections-openstack master: Add node validation function https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770037
#openstack-sdks - 2021-01-13
02:19:21 openstackgerrit wushiming proposed openstack/openstacksdk master: Drop lower-constraints job https://review.opendev.org/c/openstack/openstacksdk/+/770527
08:10:47 openstackgerrit Takashi Kajinami proposed openstack/python-openstackclient master: Volume type: Update is_public attribute https://review.opendev.org/c/openstack/python-openstackclient/+/768800
09:19:53 stephenfin gtema: Are you okay with me self-approving OSC compute-related patches that have +1s from nova cores?
09:20:04 gtema yes
09:20:09 stephenfin cool, thanks
09:20:24 gtema thank you for taking care of that also
09:20:49 stephenfin no problem at all
09:22:40 stephenfin gtema: Oh, I do have one non-nova gate fix patch that needs attention though /o\ https://review.opendev.org/c/openstack/python-openstackclient/+/769980
09:23:03 stephenfin (python-karborclient was removed from tracking in openstack/requirements so the requirements job is failing)
09:23:15 gtema I thought I was approving it, weird
09:23:34 gtema done
09:23:38 stephenfin thanks
09:25:00 gtema can you please have a look at https://review.opendev.org/c/openstack/openstacksdk/+/769484
09:25:08 gtema I want to cut SDK release soon
09:25:12 stephenfin sure, looking now
09:25:53 gtema and complete this hypervisor patch
10:01:18 stephenfin gtema: Done
10:01:32 gtema cool, thks
10:02:07 stephenfin It's a -1 btw. I think some of the methods from the TagMixin don't work. Apologies if I've misunderstood something
10:03:04 gtema no problem. For image I (I guess) it was not a complete TagMixin (some methods are also not existing)
10:03:21 gtema need to think whether to override functions to raise NotImplemented or what else
10:03:29 stephenfin Maybe we could split it into two mixins?
10:03:44 gtema would affect lot's of other services
10:04:15 stephenfin Oh yeah, that's mixin is pretty widely spread
10:06:06 stephenfin Could split the query and body parameters part of the mixin into a new e.g. TagBodyMixin and have the existing TagMixin subclass that and add the methods. You could then use TagBodyMixin here
10:06:22 stephenfin We could audit existing uses of TagMixin to make sure they all make sense
10:06:29 stephenfin later, that is
10:06:43 gtema except of image others seem to implement tagging properly
10:07:04 stephenfin Yeah, I know nova does that properly
10:07:07 stephenfin at least
10:07:14 gtema network also
10:08:06 stephenfin Would a separate subclass work so? TagBodyMixin isn't a great name. Maybe MinimalTagMixin or something better again
10:08:50 gtema you propose separate query params and attributes from methods?
10:09:19 openstackgerrit Stephen Finucane proposed openstack/openstacksdk master: Demonstrate separate tag mixin https://review.opendev.org/c/openstack/openstacksdk/+/770565
10:09:23 stephenfin yeah, like that ^
10:10:11 stephenfin tbc I still don't like the name 'MinimalTagMixin' but I can't think of anything better right now, but you get the idea
10:10:36 gtema I would say in that case it is easier to manually use query params and attribute without really using mixin
10:10:49 stephenfin That's fair. It doesn't really give us a lot
10:17:14 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Add query parameters to listing heat stacks https://review.opendev.org/c/openstack/openstacksdk/+/769484
10:35:02 stephenfin gtema: Do we add release notes for this kind of change?
10:35:22 gtema not really
10:35:37 stephenfin ack, +2 so
10:35:41 stephenfin and +W
10:35:45 gtema thks
10:39:43 gtema what should we do with hypervisor patch and planned (2.88) changes?
10:40:05 stephenfin well they're no longer planned - they're now merged
10:40:15 gtema okay
10:40:38 stephenfin so we could merge this as-is and then do a follow-up for 2.88
10:40:40 stephenfin or fix now
10:40:42 stephenfin whatever suits you
10:41:11 gtema idea was to prepare SDK to finilaze OSC for hypervisors
10:41:25 gtema so I think we can then spend some more time making SDK proper
10:41:55 gtema I do not really like dropped functions
10:42:32 gtema and uptime handling becomes really terrbile
10:44:21 gtema I think we need to orient on 2.88 and drop things from OSC that are not there anymore
10:45:21 gtema so complete disk and memory info about hypervisor disappears, right?
10:45:35 stephenfin yes, all that info is gone
10:45:46 gtema but we show it in OSC now
10:46:15 gtema I would really just drop them from SDK/OSC not to have this mess
10:46:15 stephenfin yeah, we'll just have to drop those fields
10:46:21 stephenfin that's fine by me
10:46:27 stephenfin it's bad info
10:46:34 gtema yupp
10:47:24 gtema statistics go away also?
10:47:35 stephenfin yes, for the same reason (bad info)
10:47:40 gtema ok
10:47:52 gtema dropping code is fun from that perspective
10:50:38 gtema how do we want to treat uptime: fetch automatically if under 2.88 or leave it optionally to user?
10:51:28 stephenfin I think leave it optional
10:51:37 gtema ok, agree
11:19:39 openstackgerrit Stephen Finucane proposed openstack/os-client-config stable/train: Uncap jsonschema https://review.opendev.org/c/openstack/os-client-config/+/770598
11:19:56 stephenfin dtantsur: gtema: yet another pip 20.3 fix there ^
11:20:14 gtema done
11:20:20 stephenfin thanks
11:20:36 stephenfin we can recheck https://review.opendev.org/c/openstack/openstacksdk/+/767526 once that merges
11:20:41 gtema yes
11:22:24 openstackgerrit Stephen Finucane proposed openstack/os-client-config stable/stein: Uncap jsonschema https://review.opendev.org/c/openstack/os-client-config/+/770599
11:32:41 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions https://review.opendev.org/c/openstack/openstacksdk/+/763202
11:48:10 openstackgerrit Takashi Kajinami proposed openstack/python-openstackclient master: Volume type: Update is_public attribute https://review.opendev.org/c/openstack/python-openstackclient/+/768800
11:50:21 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions https://review.opendev.org/c/openstack/openstacksdk/+/763202
13:18:20 openstackgerrit Jakob Meng proposed openstack/ansible-collections-openstack master: Fix volume_info result for SDK < 0.19 https://review.opendev.org/c/openstack/ansible-collections-openstack/+/770267
15:00:04 gtema dtantsur, stephenfin, slaweq, what do you think of dropping support for compute networking from SDK now. I am reworking cloud layer networking functions and nova there is disturbing a lot
15:00:46 dtantsur has it been dropped from nova already?

Earlier   Later