Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-06-12
17:18:15 yoctozepto mordred: also started an etherpad for basic tracking https://etherpad.opendev.org/p/js-openstack-lib
17:19:46 mordred ++
17:21:34 yoctozepto mordred: seems it does not like new babel/webpack
17:23:03 mordred yoctozepto: weird - it's happy locally - let me see if i can reproduce locally
17:26:50 openstackgerrit Merged openstack/js-openstack-lib master: CI: New jobs https://review.opendev.org/702132
17:27:00 mordred yoctozepto: oh - I think the babel and the karma patches need to be squashed
17:28:33 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update babel, webpack, karma, jasmine and istanbul https://review.opendev.org/730639
17:28:41 mordred yoctozepto: ^^ there's still a failure locally - but it actually runs the tests
17:30:40 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update babel, webpack, karma, jasmine and istanbul https://review.opendev.org/730639
17:30:52 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
17:31:03 mordred ok. that's a smaller stack
17:33:55 mordred yoctozepto: I think it's that we're not fully doing the right thing WRT browser and non-broswer so it's trying to call non-browser fs. module from browser tests
17:38:29 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update babel, webpack, karma, jasmine and istanbul https://review.opendev.org/730639
17:39:47 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
17:39:48 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Re-enable browser tests https://review.opendev.org/735378
17:54:52 openstackgerrit Merged openstack/js-openstack-lib master: Update babel, webpack, karma, jasmine and istanbul https://review.opendev.org/730639
18:05:16 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
18:44:33 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
21:41:34 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
21:43:04 openstackgerrit Monty Taylor proposed openstack/cliff master: Remove cap on cmd2 https://review.opendev.org/735364
21:43:04 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
#openstack-sdks - 2020-06-13
01:24:59 openstackgerrit Merged openstack/cliff master: Remove cap on cmd2 https://review.opendev.org/735364
08:27:16 openstackgerrit Merged openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
14:45:17 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
14:45:46 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Defer plugin loading https://review.opendev.org/735430
14:46:04 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Defer plugin loading https://review.opendev.org/735431
14:48:57 mordred dtroyer, mnaser: ^^ the second two aren't really going to work yet - but I think maybe that's the general idea at least
14:49:26 mordred I'm gonna do one more osc patch to have it register in-tree modules as builtins rather than as plugins - and we should have the whole story and just be down to debugging
14:50:25 mordred the whole "load a plugin then do some stuff that will register additional plugins to load" is a lot of fun. thanks dtroyer ;)
15:07:19 mnaser mordred: it would be _really_ cool to see a before-after speed
15:07:26 mnaser i guess if someone wants to compare --help that' still going to be just as slow technically
15:09:25 mordred yeah - help isn't going to get any quicker
15:41:47 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Defer plugin loading https://review.opendev.org/735431
15:41:48 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Register base commands as builtins https://review.opendev.org/735434
16:34:07 openstackgerrit Merged openstack/ansible-collections-openstack master: Don't pass tenant_id for remote group https://review.opendev.org/730422
#openstack-sdks - 2020-06-14
13:59:11 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
13:59:11 openstackgerrit Monty Taylor proposed openstack/cliff master: Add method to load builtins by string https://review.opendev.org/735465
14:15:41 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Register base commands as builtins https://review.opendev.org/735434
22:26:50 openstackgerrit Steve Baker proposed openstack/keystoneauth master: Implement HTTP Basic client support in keystoneauth1 https://review.opendev.org/727562
#openstack-sdks - 2020-06-15
08:59:42 openstackgerrit jayaditya gupta proposed openstack/cliff master: Fix json output for security_groups property in "openstack server show -f json" command https://review.opendev.org/735128
14:28:14 openstackgerrit Harald Jensås proposed openstack/openstacksdk master: Add query parameter 'id' for security_groups https://review.opendev.org/735601
15:33:38 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
15:33:38 openstackgerrit Monty Taylor proposed openstack/cliff master: Add method to load builtins by string https://review.opendev.org/735465
15:36:28 openstackgerrit Monty Taylor proposed openstack/osc-lib master: WIP Add support for deferred plugin loading https://review.opendev.org/735430
15:41:20 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: WIP Use deferred plugin loading https://review.opendev.org/735431
15:41:20 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Register base commands as builtins https://review.opendev.org/735434
15:41:34 mordred gtema, mnaser: the osc/cliff/osc-lib patches above "work" locally for me. they're not done, but they're getting somewhere
15:44:35 openstackgerrit Harald Jensås proposed openstack/openstacksdk master: Add query parameter 'id' for security_groups https://review.opendev.org/735601
15:46:14 openstackgerrit subham rai proposed openstack/openstacksdk master: baremetal: support for volume connectors API https://review.opendev.org/718746
16:08:54 openstackgerrit subham rai proposed openstack/openstacksdk master: baremetal: support for volume connectors API https://review.opendev.org/718746
16:28:38 openstackgerrit subham rai proposed openstack/openstacksdk master: baremetal: support for volume connectors API https://review.opendev.org/718746
19:33:35 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Register base commands as builtins https://review.opendev.org/735434
#openstack-sdks - 2020-06-16
09:02:28 iurygregory openstacksdk-functional-devstack-networking is broken?
09:09:33 frickler iurygregory: ah, that's designate's fault, need to get https://review.opendev.org/735423 in, which needs fixed grenade in turn
09:09:56 iurygregory omg
09:09:59 iurygregory tks frickler
10:32:27 openstackgerrit Slawek Kaplonski proposed openstack/openstacksdk master: Remove neutron-fwaas from the jobs' required project https://review.opendev.org/735858
12:47:35 mordred slaweq: in https://review.opendev.org/#/c/717881 I left a comment that I believe the patch is unnecessary - but I wanted to check and make sure it's working as expected?
13:10:17 slaweq mordred: yes, it seems that You're right, we don't need that change in sdk
13:10:19 slaweq thx
13:11:25 mordred slaweq: cool
13:11:48 mordred slaweq: I didn't want to block any progress or anything :)
13:34:37 frickler mordred: pls don't approve stuff, gate is still broken
13:48:06 mordred frickler: kk
15:46:06 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949
16:05:49 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746
16:50:36 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949
16:55:29 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968
17:27:50 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Move action_group to runtime https://review.opendev.org/735977
18:53:43 mnaser mordred: does it make sense to add --host to openstack port list to filter based on binding_host_id ?
18:53:46 mnaser assuming the api allows us to filter..
18:54:23 mordred mnaser: if the api allows it - definitely. even if it doesn't - nothing stopping us from filtering client-side :)
18:54:52 mnaser mordred: true about #2 too
18:56:58 mnaser mordred: a little confused, the api says in the request: "binding:host_id (Optional)" => Filter the port list result by the ID of the host where the port resides.
18:57:08 mnaser i don't know if that should be binding_host_id or binding:host_id ...
18:59:23 mordred mnaser: I'd vote binding:host_id
18:59:41 mordred but I think we're already mapping that to binding_host_id on the port object - looking
19:00:23 mordred mnaser: it looks like we have binding:host_id in the query param list already
19:02:04 mnaser mordred: right, i've just never seen a param with a colon inside of it
19:02:45 mordred mnaser: maybe slaweq knows
19:03:03 mordred slaweq knows everything
19:03:06 mnaser i will test with curl
19:04:31 mnaser it is actually binding:host_id
19:04:33 mnaser interesting.
19:05:03 mordred mnaser: of course it is
19:31:59 openstackgerrit Mohammed Naser proposed openstack/python-openstackclient master: port: add --host to list command https://review.opendev.org/736005
19:32:06 mnaser mordred: ^ worked locally for me
19:33:08 mordred mnaser: lgtm
20:09:18 slaweq mordred: mnaser: hi
20:09:31 slaweq mordred: mnaser actual name of the field in neutron is binding:host_id
20:10:10 slaweq but in OSC we are using binding_host_id instead so IMO better for filtering would be binding_host_id to be consistent with column name on client's side
20:11:02 mordred oh - that's a good point
20:23:41 mnaser slaweq: does it actually make a difference? i mean, the code worked for me
20:33:33 slaweq mnaser: Your patch is fine as You are in fact sending binding:host_id to the neutron, so that's what neutron expects
20:34:26 slaweq I'm actually fine with each of those names for the variable, "--host" (or --host-id as haleyb suggested) is IMO good one as it's much more user friendly in OSC than "binding_host_id" or "binding:host_id" :)
20:41:43 openstackgerrit Mohammed Naser proposed openstack/python-openstackclient master: port: add --host to list command https://review.opendev.org/736005
20:42:01 mnaser mordred, slaweq, haleyb: see above :)
20:50:23 mordred mnaser: +A
20:52:15 mnaser thanks mordred
21:07:41 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add documentation about login with federation https://review.opendev.org/693232

Earlier   Later