Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-06-15
19:33:35 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Register base commands as builtins https://review.opendev.org/735434
#openstack-sdks - 2020-06-16
09:02:28 iurygregory openstacksdk-functional-devstack-networking is broken?
09:09:33 frickler iurygregory: ah, that's designate's fault, need to get https://review.opendev.org/735423 in, which needs fixed grenade in turn
09:09:56 iurygregory omg
09:09:59 iurygregory tks frickler
10:32:27 openstackgerrit Slawek Kaplonski proposed openstack/openstacksdk master: Remove neutron-fwaas from the jobs' required project https://review.opendev.org/735858
12:47:35 mordred slaweq: in https://review.opendev.org/#/c/717881 I left a comment that I believe the patch is unnecessary - but I wanted to check and make sure it's working as expected?
13:10:17 slaweq mordred: yes, it seems that You're right, we don't need that change in sdk
13:10:19 slaweq thx
13:11:25 mordred slaweq: cool
13:11:48 mordred slaweq: I didn't want to block any progress or anything :)
13:34:37 frickler mordred: pls don't approve stuff, gate is still broken
13:48:06 mordred frickler: kk
15:46:06 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949
16:05:49 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746
16:50:36 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949
16:55:29 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968
17:27:50 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Move action_group to runtime https://review.opendev.org/735977
18:53:43 mnaser mordred: does it make sense to add --host to openstack port list to filter based on binding_host_id ?
18:53:46 mnaser assuming the api allows us to filter..
18:54:23 mordred mnaser: if the api allows it - definitely. even if it doesn't - nothing stopping us from filtering client-side :)
18:54:52 mnaser mordred: true about #2 too
18:56:58 mnaser mordred: a little confused, the api says in the request: "binding:host_id (Optional)" => Filter the port list result by the ID of the host where the port resides.
18:57:08 mnaser i don't know if that should be binding_host_id or binding:host_id ...
18:59:23 mordred mnaser: I'd vote binding:host_id
18:59:41 mordred but I think we're already mapping that to binding_host_id on the port object - looking
19:00:23 mordred mnaser: it looks like we have binding:host_id in the query param list already
19:02:04 mnaser mordred: right, i've just never seen a param with a colon inside of it
19:02:45 mordred mnaser: maybe slaweq knows
19:03:03 mordred slaweq knows everything
19:03:06 mnaser i will test with curl
19:04:31 mnaser it is actually binding:host_id
19:04:33 mnaser interesting.
19:05:03 mordred mnaser: of course it is
19:31:59 openstackgerrit Mohammed Naser proposed openstack/python-openstackclient master: port: add --host to list command https://review.opendev.org/736005
19:32:06 mnaser mordred: ^ worked locally for me
19:33:08 mordred mnaser: lgtm
20:09:18 slaweq mordred: mnaser: hi
20:09:31 slaweq mordred: mnaser actual name of the field in neutron is binding:host_id
20:10:10 slaweq but in OSC we are using binding_host_id instead so IMO better for filtering would be binding_host_id to be consistent with column name on client's side
20:11:02 mordred oh - that's a good point
20:23:41 mnaser slaweq: does it actually make a difference? i mean, the code worked for me
20:33:33 slaweq mnaser: Your patch is fine as You are in fact sending binding:host_id to the neutron, so that's what neutron expects
20:34:26 slaweq I'm actually fine with each of those names for the variable, "--host" (or --host-id as haleyb suggested) is IMO good one as it's much more user friendly in OSC than "binding_host_id" or "binding:host_id" :)
20:41:43 openstackgerrit Mohammed Naser proposed openstack/python-openstackclient master: port: add --host to list command https://review.opendev.org/736005
20:42:01 mnaser mordred, slaweq, haleyb: see above :)
20:50:23 mordred mnaser: +A
20:52:15 mnaser thanks mordred
21:07:41 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add documentation about login with federation https://review.opendev.org/693232
21:18:09 openstackgerrit Pedro Henrique Pereira Martins proposed openstack/python-openstackclient master: Add documentation about login with federation https://review.opendev.org/693232
21:19:12 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968
22:05:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use unittest.mock instead of mock https://review.opendev.org/734455
22:05:14 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Drop python3.5 support https://review.opendev.org/736058
23:12:45 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add tox to requirements https://review.opendev.org/736062
23:13:06 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: DNM test jobs https://review.opendev.org/732100
#openstack-sdks - 2020-06-17
06:10:09 openstackgerrit Lewis Denny proposed openstack/python-openstackclient master: Add API check for server_groups.create https://review.opendev.org/736104
07:47:14 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Move action_group to runtime https://review.opendev.org/735977
08:06:01 openstackgerrit Takashi Kajinami proposed openstack/python-openstackclient master: Add API check for server_groups.create https://review.opendev.org/736104
09:14:23 nightmare_unreal can someone review this : https://review.opendev.org/#/c/735128/ Thanks
09:53:46 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Fix ansible-test errors https://review.opendev.org/736062
10:07:13 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Revert "Format location columns in network commands" https://review.opendev.org/736150
10:09:53 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Revert "Format location columns in network commands" https://review.opendev.org/736150
10:09:53 openstackgerrit Jens Harbott (frickler) proposed openstack/python-openstackclient master: Don't display Munch objects in the output https://review.opendev.org/679445
10:15:32 frickler dtroyer: mordred: ^^ added my reasoning to the revert, happy to discuss when you find some time
10:17:24 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Move action_group to runtime https://review.opendev.org/735977
10:35:28 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968
12:05:14 openstackgerrit Vishakha Agarwal proposed openstack/openstacksdk master: [WIP] Add domain config CRUD support https://review.opendev.org/736171
12:13:36 openstackgerrit Merged openstack/ansible-collections-openstack master: Fix ansible-test errors https://review.opendev.org/736062
12:29:13 openstackgerrit Merged openstack/ansible-collections-openstack master: Move action_group to runtime https://review.opendev.org/735977
12:36:08 openstackgerrit Merged openstack/ansible-collections-openstack master: Fixes for modules generation script https://review.opendev.org/735968
12:58:45 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add volume_info module https://review.opendev.org/735949
12:59:24 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746
14:03:18 openstackgerrit Riccardo Pittau proposed openstack/ansible-collections-openstack master: Remove tox from test-requirements https://review.opendev.org/736224
14:08:34 frickler mordred: this also needs some ensure-venv thing, if you have time https://658019d6165ae4c8eab6-597ff148d0ea9164d11e7cb764cf9b04.ssl.cf1.rackcdn.com/679445/2/check/openstackclient-check-plugins/c1f9a28/job-output.txt
16:14:03 openstackgerrit Monty Taylor proposed openstack/openstackclient master: Make sure virtualenv is installed for check plugins https://review.opendev.org/736290
16:33:36 openstackgerrit Mohammed Naser proposed openstack/python-openstackclient master: port: add --host to list command https://review.opendev.org/736005
17:17:10 openstackgerrit Merged openstack/openstackclient master: Make sure virtualenv is installed for check plugins https://review.opendev.org/736290
17:22:41 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Drop python3.5 support https://review.opendev.org/736058
17:22:42 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Use unittest.mock instead of mock https://review.opendev.org/734455
17:36:14 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Update author lines https://review.opendev.org/736307
17:50:21 openstackgerrit Sean McGinnis proposed openstack/openstacksdk master: Use unittest.mock instead of mock https://review.opendev.org/734455
18:45:18 openstackgerrit Merged openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746
22:08:56 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Update author lines https://review.opendev.org/736307
22:08:57 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add ansible 2.10 testing https://review.opendev.org/736393
22:14:59 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add ansible 2.10 testing https://review.opendev.org/736393
22:15:00 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Update author lines https://review.opendev.org/736307
22:15:01 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add ignore file for ansible-test sanity 2.11 https://review.opendev.org/736394
23:23:12 openstackgerrit Merged openstack/python-openstackclient master: Revert "Format location columns in network commands" https://review.opendev.org/736150
23:23:13 openstackgerrit Merged openstack/python-openstackclient master: Don't display Munch objects in the output https://review.opendev.org/679445
#openstack-sdks - 2020-06-18
06:45:30 openstackgerrit Merged openstack/openstacksdk master: Add query parameter 'id' for security_groups https://review.opendev.org/735601
11:36:46 openstackgerrit Pratik Raj proposed openstack/cliff master: optimize size and time using --no-cache-dir https://review.opendev.org/736641
12:07:20 openstackgerrit jayaditya gupta proposed openstack/cliff master: Output correct json for security groups in 'openstack server show' https://review.opendev.org/735128
12:13:12 mordred slaweq: see comment from frickler on https://review.opendev.org/#/c/736005/ - it's possible there is a neutron bug
12:13:30 slaweq mordred: looking
12:14:27 mordred slaweq: (it's possible it's not - but when I see "unintended information leak" ...)
12:34:09 slaweq mordred: I just opened https://bugs.launchpad.net/neutron/+bug/1884067
12:34:09 openstack Launchpad bug 1884067 in neutron "[API] Filtering by fields not allowed to see is possible for regular users" [High,Confirmed]
12:34:16 slaweq mordred: frickler thx for finding this
12:35:19 slaweq mordred: frickler I think we are not checking what fields are available for user during filtering, we are only removing such fields from the returned data
12:35:23 frickler slaweq: sorry, I wanted to ping you earlier about this but then got distracted, it just looked odd to me when testing mnaser's patch

Earlier   Later