Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-06-12
13:57:40 vkmc and we are a bit confused on the "--" usage
13:57:49 vkmc shouldn't double dashed params be optional params?
13:58:04 gtema vkmc - mostly
13:58:29 gtema but there are situation, where you have so many mandatory params that you simply can't do everything positional
13:59:08 vkmc well, yes, that makes sense
13:59:22 gtema so rule of a thumb - everything "important to breathe" is positional, everything else is "--"
13:59:43 vkmc concern came up in this patch set https://review.opendev.org/#/c/732991/
14:00:04 vkmc it's a command with very few params and both of them mandatory... openstack share resize <share> <size>
14:00:11 vkmc IMHO there shouldn't be dashes involved there
14:00:23 gtema agree
14:00:40 gtema share at least "must" be positional
14:00:53 gtema since this is a root element of the operation
14:01:18 gtema if there would be multiple props you can set on the share - they would be likely dashed-ones
14:01:32 gtema if it's a single one - it's ok to make it positional either
14:01:54 gtema but still - size is up to you how to name
14:02:31 vkmc ok, it's clearer now
14:03:07 vkmc thanks gtema :)
14:03:10 gtema welcome
14:05:33 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update babel and webpack https://review.opendev.org/730639
14:05:34 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update karma, jasmine and istanbul https://review.opendev.org/730640
14:05:35 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update yaml-loader and json-loader https://review.opendev.org/730643
14:05:36 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
14:05:37 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Remove jsdoc https://review.opendev.org/730678
14:09:53 yoctozepto hi mordred
14:10:06 yoctozepto must have lost this channel on failed irc client upgrade
14:12:01 mordred yoctozepto: it happens :)
14:17:33 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: CI: New jobs https://review.opendev.org/702132
14:17:34 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update babel and webpack https://review.opendev.org/730639
14:17:35 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update karma, jasmine and istanbul https://review.opendev.org/730640
14:17:36 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update yaml-loader and json-loader https://review.opendev.org/730643
14:17:37 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
14:17:38 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Remove jsdoc https://review.opendev.org/730678
14:17:39 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: WIP Re-add functional tests https://review.opendev.org/735344
14:28:32 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Fix the misspelling of "argument" https://review.opendev.org/629790
14:30:04 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Implement auth caching https://review.opendev.org/359489
14:51:46 dtroyer vkmc: I would encourage you to conider your command set as a whole and look for consistency. in some commands —size is optional as it can be inferred, like volume create with —image. User feedback has strongly valued the consistency of the OSc commands as a whole...
14:58:08 openstackgerrit Merged openstack/osc-lib master: Remove commandmanager subclass https://review.opendev.org/734000
15:02:23 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Cache auth token in keyring https://review.opendev.org/735352
15:02:58 mordred dtroyer: ^^ lookie - reviving the 2.5 year old jamielennox patch!
15:03:27 mordred (although gonna make a stab at doing it down in sdk so it's not just an osc thing)
15:41:56 dtroyer Woot!!
15:42:58 dtroyer I was hoping to look that up soon… the cloud I am blessed to use has Duo enabled so psuedo-mfa, we're leveraging interactive mode so we don't get auth pings on damn near every API call…that would be the real fix
15:43:11 dtroyer mordred: know anyone who can fix fog too? :)
15:44:13 mordred dtroyer: sure - just replace it with sdk and you should be fine ;)
15:44:53 dtroyer ah, right, the ole s/chef/anisble/ solution!
15:44:58 mordred :)
15:46:12 mordred dtroyer: I'm thinking - if we can get this token caching thing to work - we should/could use a similar mechanism to allow optional password storage - and add an 'openstack cloud login' command that would trigger the password prompt and then save it in your keyring for you - but in a way that if you do that with osc, then any sdk consumers for that cloud will be able to pull the password from your
15:46:14 mordred keyring
15:46:44 mordred I think gtema was asking about the ability to save passwords separately but not just in the secure.yaml file
15:47:07 mordred also - gtema - see 735352 :)
15:47:46 dtroyer mordred: that parallels the dreams I had about leveraging keychain/ssh-agent-type stuff
15:47:54 mordred yeah
15:49:02 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/cliff master: Remove cap on cmd2 https://review.opendev.org/735364
15:51:22 ralonsoh mordred, ^^
15:51:31 ralonsoh I think this will fix some problems in the CI
15:51:43 ralonsoh importing cliff in rally_openstack
15:51:44 ralonsoh https://4ca4d8620dc864739feb-f83d06667d580e000031601b82c71a43.ssl.cf5.rackcdn.com/735193/1/check/neutron-rally-task/acf1423/job-output.txt
15:53:06 openstackgerrit Merged openstack/osc-lib master: Revert "Add error message when occurrence Forbidden error" https://review.opendev.org/713595
16:05:31 mordred ralonsoh: awesome
16:08:29 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/cliff master: Remove cap on cmd2 https://review.opendev.org/735364
16:39:22 openstackgerrit Merged openstack/keystoneauth master: Remove mox3 from local upper-constraints https://review.opendev.org/734071
16:47:50 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
17:00:32 openstackgerrit Merged openstack/osc-lib master: Fix the misspelling of "argument" https://review.opendev.org/629790
17:06:31 openstackgerrit Radosław Piliszek proposed openstack/js-openstack-lib master: CI: New jobs https://review.opendev.org/702132
17:13:52 yoctozepto mordred: https://review.opendev.org/702132 - modified commit message and moved the functional to exp to save some CI cycles
17:14:12 yoctozepto mordred: we know it's broken for the time being, no need to "check"
17:14:31 yoctozepto mordred: I've written a tiny TODO note for the future
17:18:15 yoctozepto mordred: also started an etherpad for basic tracking https://etherpad.opendev.org/p/js-openstack-lib
17:19:46 mordred ++
17:21:34 yoctozepto mordred: seems it does not like new babel/webpack
17:23:03 mordred yoctozepto: weird - it's happy locally - let me see if i can reproduce locally
17:26:50 openstackgerrit Merged openstack/js-openstack-lib master: CI: New jobs https://review.opendev.org/702132
17:27:00 mordred yoctozepto: oh - I think the babel and the karma patches need to be squashed
17:28:33 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update babel, webpack, karma, jasmine and istanbul https://review.opendev.org/730639
17:28:41 mordred yoctozepto: ^^ there's still a failure locally - but it actually runs the tests
17:30:40 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update babel, webpack, karma, jasmine and istanbul https://review.opendev.org/730639
17:30:52 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
17:31:03 mordred ok. that's a smaller stack
17:33:55 mordred yoctozepto: I think it's that we're not fully doing the right thing WRT browser and non-broswer so it's trying to call non-browser fs. module from browser tests
17:38:29 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update babel, webpack, karma, jasmine and istanbul https://review.opendev.org/730639
17:39:47 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
17:39:48 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Re-enable browser tests https://review.opendev.org/735378
17:54:52 openstackgerrit Merged openstack/js-openstack-lib master: Update babel, webpack, karma, jasmine and istanbul https://review.opendev.org/730639
18:05:16 openstackgerrit Monty Taylor proposed openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
18:44:33 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
21:41:34 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
21:43:04 openstackgerrit Monty Taylor proposed openstack/cliff master: Remove cap on cmd2 https://review.opendev.org/735364
21:43:04 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
#openstack-sdks - 2020-06-13
01:24:59 openstackgerrit Merged openstack/cliff master: Remove cap on cmd2 https://review.opendev.org/735364
08:27:16 openstackgerrit Merged openstack/js-openstack-lib master: Update eslint and switch to standard https://review.opendev.org/730644
14:45:17 openstackgerrit Monty Taylor proposed openstack/cliff master: Add load_plugins option https://review.opendev.org/733961
14:45:46 openstackgerrit Monty Taylor proposed openstack/osc-lib master: Defer plugin loading https://review.opendev.org/735430
14:46:04 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Defer plugin loading https://review.opendev.org/735431
14:48:57 mordred dtroyer, mnaser: ^^ the second two aren't really going to work yet - but I think maybe that's the general idea at least
14:49:26 mordred I'm gonna do one more osc patch to have it register in-tree modules as builtins rather than as plugins - and we should have the whole story and just be down to debugging
14:50:25 mordred the whole "load a plugin then do some stuff that will register additional plugins to load" is a lot of fun. thanks dtroyer ;)
15:07:19 mnaser mordred: it would be _really_ cool to see a before-after speed
15:07:26 mnaser i guess if someone wants to compare --help that' still going to be just as slow technically
15:09:25 mordred yeah - help isn't going to get any quicker
15:41:47 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Defer plugin loading https://review.opendev.org/735431

Earlier   Later