Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-05-11
20:58:18 rm_work if you think that's looking correct on your side
21:11:08 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
21:11:09 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
21:11:10 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952
21:18:24 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952
21:18:25 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
21:18:26 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
21:54:10 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Redesign OpenstackModule class https://review.opendev.org/722283
22:05:46 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746
22:11:13 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Redesign OpenstackModule class https://review.opendev.org/722283
22:21:28 openstackgerrit Emilien Macchi proposed openstack/openstacksdk stable/ussuri: Don't error if clouds.yaml is not readable https://review.opendev.org/726962
22:21:40 openstackgerrit Emilien Macchi proposed openstack/openstacksdk stable/train: Don't error if clouds.yaml is not readable https://review.opendev.org/726963
22:27:03 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add OpenstackModule to os_server_action https://review.opendev.org/721746
22:34:23 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952
22:51:13 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952
23:13:10 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
23:13:16 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
#openstack-sdks - 2020-05-12
07:27:11 frickler donnyd: I didn't have any issue when I tested app creds some time ago, can you show your command in detail? do you use a clouds.yaml config or environment variables? in the latter case, make sure you don't have too many of them
08:06:29 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Extend statistics reporting https://review.opendev.org/727097
09:00:38 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Extend statistics reporting https://review.opendev.org/727097
09:06:50 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952
10:13:58 gtema what has happened to pep? Who made gods angry?
10:46:44 AJaeger gtema: see #openstack-qa, new release of flake8
10:53:34 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Extend statistics reporting https://review.opendev.org/727097
12:59:35 donnyd frickler: turns out I had some env variables set. It was a layer 8 problem
13:18:08 rm_work ah damn, sdk got hit by the flake8 thing
13:25:16 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
13:25:21 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
13:55:42 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
13:55:43 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
13:55:45 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: WIP Use stub modules for deprecated aliases https://review.opendev.org/727197
14:09:53 mordred gtema, AJaeger : patch on the way to fix the new flake8 issues
14:10:48 AJaeger mordred: there's a plan to release a new hacking version to cap flake8 - but fixing them is better ;) Thanks!
14:13:21 mordred AJaeger: yeah - these are all good errors
14:13:50 mordred like - this is literally the sort of thing flake8 should be checking
14:14:06 AJaeger then let's fix them ;)
14:15:15 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix issues found by latest flake8 https://review.opendev.org/727204
14:15:35 mordred gtema, mnaser, dtantsur: if you have a second - it's a quick patch but will unbreak the gate here: &&
14:15:41 mordred I meant ^^ :)
14:15:52 dtantsur mordred: FYI we're working on releasing a new hacking that caps flake8
14:16:02 mordred dtantsur: totally - but the errors are all good
14:16:05 mordred so we should fix them
14:16:23 dtantsur mordred: well, the nit-picking around "l" variables is so bad that we disabled that check in ironic
14:16:29 mordred I thnik it's great :)
14:16:59 dtantsur *shrug* telling people how to name variables in list/dist comprehensions
14:17:06 mordred yeah - sure
14:17:41 mordred I mean - I'm not going to argue the case broadly - just saying here it was 2 comprehensions in the hole code base, and I'd be happy if we never used single-letter variables for anything in sdk
14:17:56 mordred so I don't think it's an issue - but I can understand it being frustrating in other paces
14:18:11 mordred I care more about the unused format stuff - it actually caught an actual bug
14:18:17 dtantsur yep, the format check is awesome
14:18:31 dtantsur there will be a hacking release uncapping it again, so don't worry
14:18:44 mordred (we were passing an argument to the format that should have been an argument to the surrounding method)
14:18:53 dtantsur and note that it's not about single-letter variables, it's about "l is easy to confuse with I"
14:19:02 dtantsur aka "we don't know how to set up fonts" :)
14:19:22 mordred :)
14:20:00 dtantsur actually, I'm using the default Fedora fonts and l looks nothing alike I
14:20:02 dtantsur but dunno
14:20:39 mordred l and 1 are teh ones I've seen be more confusing on bad fonts
14:20:59 mordred I use the hack font - so it is not a problem for me
14:21:12 dtantsur okay, these ones are a bit alike, but not identical (and 1 cannot be a variable name)
14:48:15 gtema oh, after moving temporarily to another machine I do not get notifications from IRC.
14:53:00 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add template for generation of artibtrary module https://review.opendev.org/727216
15:02:21 noonedeadpunk hey folks. has a question - was there any recent issue related to nova client and instance filtering by project name?
15:03:35 mordred gtema: "awesome"
15:04:40 noonedeadpunk just have a horizon (and openstack) installation that while filtering instances by project name returns all available isntances.
15:05:20 noonedeadpunk I was told that most likely that panel don't do any filtering itsef but relies on client
15:05:41 noonedeadpunk so decided to ask if you probably heard about smth like this
15:20:19 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
15:20:20 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
15:20:21 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove incorrect os_ prefix in documentation https://review.opendev.org/727226
15:20:55 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
15:25:37 mordred noonedeadpunk: I haven't - but I try to stay as far away from python-*client as I can, so I'm not much help
15:32:07 noonedeadpunk mordred: ok, I see:) I didn't found anything there as well actualy:( so maybe it's in horizon...
15:35:15 mordred noonedeadpunk: we should add to our already-way-too-large-todo-list updating horizon to use sdk :)
15:36:03 noonedeadpunk that would be great... but tough:)
15:49:42 mordred noonedeadpunk: yeah. tell me about it
16:03:34 openstackgerrit Merged openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952
18:13:55 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
18:16:45 openstackgerrit Merged openstack/ansible-collections-openstack master: Remove incorrect os_ prefix in documentation https://review.opendev.org/727226
18:16:46 openstackgerrit Merged openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
18:24:34 openstackgerrit Merged openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
18:39:46 openstackgerrit Merged openstack/openstacksdk master: Fix issues found by latest flake8 https://review.opendev.org/727204
19:22:20 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
19:34:42 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Revert "Run linters in a temp dir instead of an install" https://review.opendev.org/727400
19:40:00 tremble mordred, baremetal_node_action (Ansible module) - We talked about fixing some of the 'bool's that are currently strings when I did the big batch of cleanup, technically right now we allow several values that aren't 'bool's (and aren't in the description as valid) would you rather a formal deprecation cycle, or just clean it up for v1 of the collection?
19:40:48 mordred tremble: I say just clean it up for v1 of the collection ... sshnaidm what do you think?
19:41:47 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
19:42:12 sshnaidm mordred, yeah, i think it's ok
19:43:11 tremble ok
19:52:13 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Improve ansible-test sanity for collection https://review.opendev.org/727411
19:54:52 AJaeger mordred: https://review.opendev.org/#/c/727352/ removes pbrx, hope that the jobs now passes. could you review later, please?
19:56:24 mordred AJaeger: oh thanks! yes - that looks good
19:58:33 AJaeger mordred: doesn't work, it's failing ;(
19:58:57 AJaeger do we need to remove the repos from the constraints list first?
20:01:02 tremble mordred, Do you happen to know the history of https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/modules/baremetal_node_action.py#L212 I think that's actually unreachable because of the preceding if statement
20:01:47 AJaeger mordred: yeah, this basically needs rewrite of the siblings role ;( should we keep pbrx or move it over?
20:02:11 mordred tremble: I don't - I think we'd want to ask dtantsur|afk or TheJulia
20:02:24 AJaeger mordred: we could also do some ansible magic...
20:02:50 mordred AJaeger: hrm
20:03:25 AJaeger cp constraitns-file and then iterate with lineinfile to remove the lines

Earlier   Later