Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-05-12
14:16:23 dtantsur mordred: well, the nit-picking around "l" variables is so bad that we disabled that check in ironic
14:16:29 mordred I thnik it's great :)
14:16:59 dtantsur *shrug* telling people how to name variables in list/dist comprehensions
14:17:06 mordred yeah - sure
14:17:41 mordred I mean - I'm not going to argue the case broadly - just saying here it was 2 comprehensions in the hole code base, and I'd be happy if we never used single-letter variables for anything in sdk
14:17:56 mordred so I don't think it's an issue - but I can understand it being frustrating in other paces
14:18:11 mordred I care more about the unused format stuff - it actually caught an actual bug
14:18:17 dtantsur yep, the format check is awesome
14:18:31 dtantsur there will be a hacking release uncapping it again, so don't worry
14:18:44 mordred (we were passing an argument to the format that should have been an argument to the surrounding method)
14:18:53 dtantsur and note that it's not about single-letter variables, it's about "l is easy to confuse with I"
14:19:02 dtantsur aka "we don't know how to set up fonts" :)
14:19:22 mordred :)
14:20:00 dtantsur actually, I'm using the default Fedora fonts and l looks nothing alike I
14:20:02 dtantsur but dunno
14:20:39 mordred l and 1 are teh ones I've seen be more confusing on bad fonts
14:20:59 mordred I use the hack font - so it is not a problem for me
14:21:12 dtantsur okay, these ones are a bit alike, but not identical (and 1 cannot be a variable name)
14:48:15 gtema oh, after moving temporarily to another machine I do not get notifications from IRC.
14:53:00 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add template for generation of artibtrary module https://review.opendev.org/727216
15:02:21 noonedeadpunk hey folks. has a question - was there any recent issue related to nova client and instance filtering by project name?
15:03:35 mordred gtema: "awesome"
15:04:40 noonedeadpunk just have a horizon (and openstack) installation that while filtering instances by project name returns all available isntances.
15:05:20 noonedeadpunk I was told that most likely that panel don't do any filtering itsef but relies on client
15:05:41 noonedeadpunk so decided to ask if you probably heard about smth like this
15:20:19 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
15:20:20 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
15:20:21 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Remove incorrect os_ prefix in documentation https://review.opendev.org/727226
15:20:55 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
15:25:37 mordred noonedeadpunk: I haven't - but I try to stay as far away from python-*client as I can, so I'm not much help
15:32:07 noonedeadpunk mordred: ok, I see:) I didn't found anything there as well actualy:( so maybe it's in horizon...
15:35:15 mordred noonedeadpunk: we should add to our already-way-too-large-todo-list updating horizon to use sdk :)
15:36:03 noonedeadpunk that would be great... but tough:)
15:49:42 mordred noonedeadpunk: yeah. tell me about it
16:03:34 openstackgerrit Merged openstack/ansible-collections-openstack master: Run linters in a temp dir instead of an install https://review.opendev.org/726952
18:13:55 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
18:16:45 openstackgerrit Merged openstack/ansible-collections-openstack master: Remove incorrect os_ prefix in documentation https://review.opendev.org/727226
18:16:46 openstackgerrit Merged openstack/ansible-collections-openstack master: Remove all of the os_ prefixes https://review.opendev.org/713056
18:24:34 openstackgerrit Merged openstack/ansible-collections-openstack master: Rename all of the modules https://review.opendev.org/726538
18:39:46 openstackgerrit Merged openstack/openstacksdk master: Fix issues found by latest flake8 https://review.opendev.org/727204
19:22:20 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
19:34:42 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Revert "Run linters in a temp dir instead of an install" https://review.opendev.org/727400
19:40:00 tremble mordred, baremetal_node_action (Ansible module) - We talked about fixing some of the 'bool's that are currently strings when I did the big batch of cleanup, technically right now we allow several values that aren't 'bool's (and aren't in the description as valid) would you rather a formal deprecation cycle, or just clean it up for v1 of the collection?
19:40:48 mordred tremble: I say just clean it up for v1 of the collection ... sshnaidm what do you think?
19:41:47 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
19:42:12 sshnaidm mordred, yeah, i think it's ok
19:43:11 tremble ok
19:52:13 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Improve ansible-test sanity for collection https://review.opendev.org/727411
19:54:52 AJaeger mordred: https://review.opendev.org/#/c/727352/ removes pbrx, hope that the jobs now passes. could you review later, please?
19:56:24 mordred AJaeger: oh thanks! yes - that looks good
19:58:33 AJaeger mordred: doesn't work, it's failing ;(
19:58:57 AJaeger do we need to remove the repos from the constraints list first?
20:01:02 tremble mordred, Do you happen to know the history of https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/modules/baremetal_node_action.py#L212 I think that's actually unreachable because of the preceding if statement
20:01:47 AJaeger mordred: yeah, this basically needs rewrite of the siblings role ;( should we keep pbrx or move it over?
20:02:11 mordred tremble: I don't - I think we'd want to ask dtantsur|afk or TheJulia
20:02:24 AJaeger mordred: we could also do some ansible magic...
20:02:50 mordred AJaeger: hrm
20:03:25 AJaeger cp constraitns-file and then iterate with lineinfile to remove the lines
20:04:41 tremble mordred, Ok, I'll try dtantsur|afk in our morning
20:08:44 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
20:09:07 AJaeger mordred: let's try again - if you have a better idea or a fix, feel free to take over. I'm signing off for today
20:09:22 mordred AJaeger: :) thank you!
20:10:26 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Improve ansible-test sanity for collection https://review.opendev.org/727411
20:20:59 TheJulia tremble: I have this fear I may have been on a third whiskey at a hotel bar in downtown seattle when I wrote that
20:21:24 tremble Think I just nuke the lines?
20:21:33 TheJulia I remember feeling inspired and working out such caseI feel like your likely safe doing so.
20:35:20 TheJulia tremble: may not be a bad idea. I can alloc brain cells tomorrow because the module was basically overloaded
20:43:33 mordred TheJulia: we might also be in a position now where we have some of this logic covered down in sdk but we never got around to nuking it from the modules
21:43:21 TheJulia mordred: yeah, I think a lot of it was to cover "you should try to do this and that at the same time" kind of stuff
21:53:08 openstackgerrit Merged openstack/openstacksdk master: Set BaseImageProxy.create_image validate_checksum default to False https://review.opendev.org/726465
#openstack-sdks - 2020-05-13
00:25:44 openstackgerrit Ghanshyam Mann proposed openstack/keystoneauth master: Fix hacking min version to 3.0.1 https://review.opendev.org/727498
01:37:42 openstackgerrit Steve Baker proposed openstack/keystoneauth master: Implement HTTP Basic client support in keystoneauth1 https://review.opendev.org/727562
04:10:06 iokiwi known issues with openstack clients on ubuntu 20.04? Running into a problem with openstack image save freezing after authenticating
04:11:48 iokiwi I can see it does keystone auth and gets a token and then tries to start downloading from glance, but it just gets stuck on the first GET. I can dive deeper I just wondered if anyone else had experienced something similar / could confirm the behavior
04:23:58 openstackgerrit Merged openstack/openstacksdk master: Remove some unneeded things from test-requirements https://review.opendev.org/715707
04:23:59 openstackgerrit Merged openstack/openstacksdk master: Remove uses of from six.moves https://review.opendev.org/715712
04:25:35 openstackgerrit Merged openstack/openstacksdk master: Remove use of six https://review.opendev.org/715713
05:22:51 openstackgerrit Pete Zaitcev proposed openstack/python-openstackclient master: Cleanup: remove a useless reference to "object" https://review.opendev.org/727632
05:54:05 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
05:54:42 openstackgerrit Merged openstack/openstacksdk master: Fix image owner field https://review.opendev.org/726627
05:54:43 openstackgerrit Merged openstack/openstacksdk stable/train: Don't error if clouds.yaml is not readable https://review.opendev.org/726963
06:12:53 iokiwi disregard my previous query I think I found my problem
06:14:01 iokiwi mem leak with openssl on client with whatever cipher / tls version negotiated with the API
06:28:42 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
06:30:51 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: DNM: Test openstackclient-check-plugins https://review.opendev.org/727637
06:44:47 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
06:47:37 AJaeger mordred: the above should be fine now - the test is failing on cloudkittyclient.v1.collector_cli (see https://zuul.opendev.org/t/openstack/build/ac3fbea5df684718956ebf2c3a79b7d1 )
06:54:23 AJaeger mordred: looking at 727637: That one passes. So, my test is not accurate since it tests too many libs, cloudkitty is not part of the requirements that we should test.
07:10:05 openstackgerrit Andreas Jaeger proposed openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
07:23:09 AJaeger mordred: yeah, passing now ^
10:28:51 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Improve ansible-test sanity for collection https://review.opendev.org/727411
10:31:40 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Improve ansible-test sanity for collection https://review.opendev.org/727411
11:05:48 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Add template for generation of artibtrary module https://review.opendev.org/727216
11:35:51 openstackgerrit Merged openstack/openstacksdk master: Stop subclassing object https://review.opendev.org/715714
12:13:00 openstackgerrit Sagi Shnaidman proposed openstack/ansible-collections-openstack master: Redesign OpenstackModule class https://review.opendev.org/722283
12:49:39 openstackgerrit Merged openstack/openstackclient master: Remove pbrx https://review.opendev.org/727352
13:02:27 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add Contributing file https://review.opendev.org/727752
13:07:04 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add contributing file https://review.opendev.org/727753
14:02:15 mordred AJaeger: thanks for following up on that! ^^ pbrx removal has been merged
14:02:33 AJaeger great, mordred ! That was the only blocker for pbrx retirement.

Earlier   Later