Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2020-03-02
18:33:24 Shrews but apparently for not all things :/
18:33:47 mordred Shrews: yeah, probably. I think you and dtantsur had the same thought
18:33:55 mordred it's almost like you value tests or something
18:34:01 dtantsur rm_work: +A then
18:34:10 rm_work whaaaaaaat, tests are important? who knew :D
18:34:12 Shrews mordred: we're such silly people folk
18:34:26 dtantsur can confirm ^^
18:34:54 rm_work Oh my, yes.</farnsworthy>
18:36:18 openstackgerrit Merged openstack/ansible-collections-openstack master: os_coe_cluster: Retrive id/uuid correctly https://review.opendev.org/709734
18:36:40 KeithMnemonic mordred: so is there anyway to get this merged or is it too late now? https://review.opendev.org/703683
19:26:38 mordred KeithMnemonic: there you go
19:28:58 KeithMnemonic thank you!!
19:40:39 KeithMnemonic mordred: while you are in the giving mood, care to also help on this one for train? https://review.opendev.org/#/c/701299/
19:41:44 mordred KeithMnemonic: done
20:01:59 openstackgerrit Merged openstack/openstacksdk master: Add availability_zone param to load balancer https://review.opendev.org/710452
21:19:43 openstackgerrit Merged openstack/python-openstackclient stable/train: Fix openstack server list --deleted --marker option https://review.opendev.org/701299
21:22:30 KeithMnemonic looking for review on this backport now that the train branch merged. thank you https://review.opendev.org/#/c/702260/4
#openstack-sdks - 2020-03-03
00:37:24 openstackgerrit Merged openstack/python-openstackclient stable/rocky: Fix functional tests for py3 https://review.opendev.org/703683
11:03:46 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Import generate_temp_url from swiftclient https://review.opendev.org/710973
12:41:32 openstackgerrit Bernard Cafarelli proposed openstack/openstacksdk stable/train: Handle HTTP errors in add/remove router interface calls https://review.opendev.org/710994
12:41:35 openstackgerrit Bernard Cafarelli proposed openstack/openstacksdk stable/train: Fix error handling on add/remove router iface calls https://review.opendev.org/710995
13:10:43 openstackgerrit Michał Dulko proposed openstack/openstacksdk stable/train: Fix error handling in network trunks operations https://review.opendev.org/711001
13:10:43 openstackgerrit Michał Dulko proposed openstack/openstacksdk stable/train: Fix error handling in network trunks operations https://review.opendev.org/711001
13:15:52 KeithMnemonic Could I also please get some reviews on this change https://review.opendev.org/#/c/701066/
14:46:31 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node https://review.opendev.org/711032
14:46:45 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add "fields" parameter to ListSecurityGroup query https://review.opendev.org/710825
14:50:52 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Deal with collection build modifying tree https://review.opendev.org/711033
14:54:35 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: Include "fields" to "SecurityGroup" query parameters https://review.opendev.org/710820
14:55:37 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Fix license metadata https://review.opendev.org/711035
14:57:11 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Clean up minor build quibbles https://review.opendev.org/711036
14:59:57 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node https://review.opendev.org/711032
15:27:16 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Add Openstack guidelines spec from Ansible https://review.opendev.org/704558
15:29:11 openstackgerrit Monty Taylor proposed openstack/ansible-collections-openstack master: Test with and assert support for python3 https://review.opendev.org/710641
15:30:00 mordred dtantsur: https://review.opendev.org/#/c/711032 has your name all over it
15:31:37 dtantsur done!
15:33:32 mordred dtantsur: also - looking at futurist (it does seem like a good idea to use it)
15:34:01 mordred dtantsur: I don't suppose we could drop the prettytable dependency ...
15:39:19 dtantsur mordred: I don't recall why we have it, honestly
15:40:13 dtantsur mordred: I would +2 a change making it optional, seems really used in one corner case
15:41:34 mordred dtantsur: https://review.opendev.org/711041 Make PrettyTable optional
15:42:24 mordred dtantsur: I think with that it's a great idea to use futurist in sdk - and if we do that global executor idea it should make it really nice for people instantiating a Connection in an eventlet service or similar
15:43:27 dtantsur mordred: one small suggestion inline, I remembered that this code path is often used by default
15:48:38 mordred dtantsur: updated - and good call
15:49:28 mordred smcginnis: ^^ have a second to be a second human?
15:50:23 dtantsur mordred: sorry if I seem nitpicking, I've left another idea
15:50:44 mordred dtantsur: I think in a project with zero other open changes it's worthwhile to nitpick
15:51:22 mordred dtantsur: ooh, that's nice.
15:56:41 smcginnis mordred: Will look in a bit.
15:56:46 smcginnis Maybe of interest - https://github.com/astanin/python-tabulate/commit/ba3c20364720421fccddb16bb6d9708fe89735b1
16:03:11 mordred dtantsur: how about "statistics not available, PrettyTable missing"
16:03:24 dtantsur mordred: ship it!
16:03:41 smcginnis +1
16:04:52 mordred dtantsur, smcginnis: k. there we go
16:05:35 dtantsur +2
16:05:48 mordred smcginnis: looks decent enough - but it's still one-more-dep for a single print function
16:06:06 smcginnis Yeah, for this case not useful.
16:06:22 smcginnis I have a feeling PrettyTable is going to start causing other problems soon though.
16:06:27 smcginnis Last release was ages ago.
16:06:30 mordred yeah
16:06:42 mordred smcginnis: although sometimes that's nice (/me looks at virtualenv)
16:06:58 smcginnis ;)
16:07:26 dtantsur :D
16:08:30 dtantsur honestly, I'd probably rewrite the statistics reporting to a simpler format. It's not exactly user-facing..
16:09:55 mordred yah
16:26:00 openstackgerrit Riccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node https://review.opendev.org/711032
16:38:47 openstackgerrit Merged openstack/ansible-collections-openstack master: Just use shutil.rmtree in build.py https://review.opendev.org/710640
16:55:53 openstackgerrit Monty Taylor proposed openstack/python-openstackclient master: Add bindep file https://review.opendev.org/711055
18:08:59 openstackgerrit Merged openstack/openstacksdk stable/train: Fix error handling in network trunks operations https://review.opendev.org/711001
18:09:03 openstackgerrit Merged openstack/openstacksdk master: Include user_id attribute in volume information https://review.opendev.org/710834
18:46:28 cmurphy mordred: could you review https://review.opendev.org/703707 for me? it's an easy one
18:57:15 mordred cmurphy: done!
18:58:57 cmurphy tyvm
20:22:49 mordred rm_work: ooh - the glance patches seem to work!
20:23:13 rm_work yeah they passed CI, haven't tested myself yet tho
20:23:32 rm_work wish i could take any credit for that XD
20:27:21 mordred rm_work: well, they were red last time
20:27:26 mordred then you rebased them and they were green
20:27:40 rm_work :D
20:27:52 rm_work magic!
20:27:57 mordred I should test them by trying to upload an image to rackspace
20:28:09 mordred since that would not work before this patch
20:41:23 rm_work I bet they were red because SDK hadn't released an update including the code it needed yet
20:41:34 rm_work but that was in december, and now it has
23:40:35 openstackgerrit Merged openstack/python-openstackclient master: Fix copypaste errors in access rule command https://review.opendev.org/703707
#openstack-sdks - 2020-03-04
09:55:03 openstackgerrit Slawek Kaplonski proposed openstack/openstacksdk master: Add description field to portforwarding NAT rules https://review.opendev.org/705038
11:56:17 openstackgerrit Hervé Beraud proposed openstack/python-openstackclient stable/train: Add parent project filter for listing projects https://review.opendev.org/711208
13:50:37 openstackgerrit Javier Peña proposed openstack/openstacksdk master: [TEST DO NOT MERGE] Replace assertItemsEqual with assertCountEqual https://review.opendev.org/711235
14:09:00 openstackgerrit Lajos Katona proposed openstack/openstacksdk master: Add port property: ip_allocation https://review.opendev.org/711237
14:15:14 openstackgerrit Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823
14:15:25 brtknr Shrews: ^^
14:15:31 brtknr also mordred ^
14:23:55 mordred brtknr: beautiful - thanks
14:26:13 mordred slaweq: https://review.opendev.org/#/c/711237/ look ok to you? also - I rechecked that description patch - it seems to just keep being unlucky
14:29:31 openstackgerrit Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823
14:29:57 brtknr mordred: sorry, i had to fix the brackets out of OCD
14:33:10 mordred brtknr: I agree with your fix :)
14:33:55 brtknr mordred: :D
14:38:04 Shrews brtknr: thank you for the tests!
14:38:24 brtknr Shrews: my pleasure
14:55:44 slaweq mordred: looking

Earlier   Later