| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-03-03 | |||
| 15:30:00 | mordred | dtantsur: https://review.opendev.org/#/c/711032 has your name all over it | |
| 15:31:37 | dtantsur | done! | |
| 15:33:32 | mordred | dtantsur: also - looking at futurist (it does seem like a good idea to use it) | |
| 15:34:01 | mordred | dtantsur: I don't suppose we could drop the prettytable dependency ... | |
| 15:39:19 | dtantsur | mordred: I don't recall why we have it, honestly | |
| 15:40:13 | dtantsur | mordred: I would +2 a change making it optional, seems really used in one corner case | |
| 15:41:34 | mordred | dtantsur: https://review.opendev.org/711041 Make PrettyTable optional | |
| 15:42:24 | mordred | dtantsur: I think with that it's a great idea to use futurist in sdk - and if we do that global executor idea it should make it really nice for people instantiating a Connection in an eventlet service or similar | |
| 15:43:27 | dtantsur | mordred: one small suggestion inline, I remembered that this code path is often used by default | |
| 15:48:38 | mordred | dtantsur: updated - and good call | |
| 15:49:28 | mordred | smcginnis: ^^ have a second to be a second human? | |
| 15:50:23 | dtantsur | mordred: sorry if I seem nitpicking, I've left another idea | |
| 15:50:44 | mordred | dtantsur: I think in a project with zero other open changes it's worthwhile to nitpick | |
| 15:51:22 | mordred | dtantsur: ooh, that's nice. | |
| 15:56:41 | smcginnis | mordred: Will look in a bit. | |
| 15:56:46 | smcginnis | Maybe of interest - https://github.com/astanin/python-tabulate/commit/ba3c20364720421fccddb16bb6d9708fe89735b1 | |
| 16:03:11 | mordred | dtantsur: how about "statistics not available, PrettyTable missing" | |
| 16:03:24 | dtantsur | mordred: ship it! | |
| 16:03:41 | smcginnis | +1 | |
| 16:04:52 | mordred | dtantsur, smcginnis: k. there we go | |
| 16:05:35 | dtantsur | +2 | |
| 16:05:48 | mordred | smcginnis: looks decent enough - but it's still one-more-dep for a single print function | |
| 16:06:06 | smcginnis | Yeah, for this case not useful. | |
| 16:06:22 | smcginnis | I have a feeling PrettyTable is going to start causing other problems soon though. | |
| 16:06:27 | smcginnis | Last release was ages ago. | |
| 16:06:30 | mordred | yeah | |
| 16:06:42 | mordred | smcginnis: although sometimes that's nice (/me looks at virtualenv) | |
| 16:06:58 | smcginnis | ;) | |
| 16:07:26 | dtantsur | :D | |
| 16:08:30 | dtantsur | honestly, I'd probably rewrite the statistics reporting to a simpler format. It's not exactly user-facing.. | |
| 16:09:55 | mordred | yah | |
| 16:26:00 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node https://review.opendev.org/711032 | |
| 16:38:47 | openstackgerrit | Merged openstack/ansible-collections-openstack master: Just use shutil.rmtree in build.py https://review.opendev.org/710640 | |
| 16:55:53 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Add bindep file https://review.opendev.org/711055 | |
| 18:08:59 | openstackgerrit | Merged openstack/openstacksdk stable/train: Fix error handling in network trunks operations https://review.opendev.org/711001 | |
| 18:09:03 | openstackgerrit | Merged openstack/openstacksdk master: Include user_id attribute in volume information https://review.opendev.org/710834 | |
| 18:46:28 | cmurphy | mordred: could you review https://review.opendev.org/703707 for me? it's an easy one | |
| 18:57:15 | mordred | cmurphy: done! | |
| 18:58:57 | cmurphy | tyvm | |
| 20:22:49 | mordred | rm_work: ooh - the glance patches seem to work! | |
| 20:23:13 | rm_work | yeah they passed CI, haven't tested myself yet tho | |
| 20:23:32 | rm_work | wish i could take any credit for that XD | |
| 20:27:21 | mordred | rm_work: well, they were red last time | |
| 20:27:26 | mordred | then you rebased them and they were green | |
| 20:27:40 | rm_work | :D | |
| 20:27:52 | rm_work | magic! | |
| 20:27:57 | mordred | I should test them by trying to upload an image to rackspace | |
| 20:28:09 | mordred | since that would not work before this patch | |
| 20:41:23 | rm_work | I bet they were red because SDK hadn't released an update including the code it needed yet | |
| 20:41:34 | rm_work | but that was in december, and now it has | |
| 23:40:35 | openstackgerrit | Merged openstack/python-openstackclient master: Fix copypaste errors in access rule command https://review.opendev.org/703707 | |
| #openstack-sdks - 2020-03-04 | |||
| 09:55:03 | openstackgerrit | Slawek Kaplonski proposed openstack/openstacksdk master: Add description field to portforwarding NAT rules https://review.opendev.org/705038 | |
| 11:56:17 | openstackgerrit | Hervé Beraud proposed openstack/python-openstackclient stable/train: Add parent project filter for listing projects https://review.opendev.org/711208 | |
| 13:50:37 | openstackgerrit | Javier Peña proposed openstack/openstacksdk master: [TEST DO NOT MERGE] Replace assertItemsEqual with assertCountEqual https://review.opendev.org/711235 | |
| 14:09:00 | openstackgerrit | Lajos Katona proposed openstack/openstacksdk master: Add port property: ip_allocation https://review.opendev.org/711237 | |
| 14:15:14 | openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | |
| 14:15:25 | brtknr | Shrews: ^^ | |
| 14:15:31 | brtknr | also mordred ^ | |
| 14:23:55 | mordred | brtknr: beautiful - thanks | |
| 14:26:13 | mordred | slaweq: https://review.opendev.org/#/c/711237/ look ok to you? also - I rechecked that description patch - it seems to just keep being unlucky | |
| 14:29:31 | openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | |
| 14:29:57 | brtknr | mordred: sorry, i had to fix the brackets out of OCD | |
| 14:33:10 | mordred | brtknr: I agree with your fix :) | |
| 14:33:55 | brtknr | mordred: :D | |
| 14:38:04 | Shrews | brtknr: thank you for the tests! | |
| 14:38:24 | brtknr | Shrews: my pleasure | |
| 14:55:44 | slaweq | mordred: looking | |
| 15:00:22 | slaweq | mordred: +2 this patch and thx for rechecking the other one :) | |
| 15:14:03 | openstackgerrit | Javier Peña proposed openstack/openstacksdk master: Replace assertItemsEqual with assertCountEqual https://review.opendev.org/711235 | |
| 15:16:59 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Build utility image for using osc https://review.opendev.org/711246 | |
| 16:15:10 | openstackgerrit | Monty Taylor proposed openstack/python-openstackclient master: Build utility image for using osc https://review.opendev.org/711246 | |
| 16:20:40 | openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | |
| 16:20:57 | openstackgerrit | Bharat Kunwar proposed openstack/openstacksdk master: Return uuid alias for coe_cluster in non strict mode https://review.opendev.org/710823 | |
| 16:21:09 | brtknr | mordred: Shrews: Sorry i should have run tox -e pep8 before submitting | |
| 16:21:41 | mordred | brtknr: hahahaha | |
| 17:03:16 | openstackgerrit | Clark Boylan proposed openstack/python-openstackclient master: Replace pkg_resources with importlib-metadata https://review.opendev.org/661856 | |
| 17:03:31 | smcginnis | Thanks mordred. Sad to see how many names are in the "no longer around" list. | |
| 17:03:47 | mordred | smcginnis: right? | |
| 17:04:07 | smcginnis | Just imagine if there were still that many cores working on things here. That OSC thread definitely wouldn't have been an issue. | |
| 17:04:18 | dtantsur | le sigh | |
| 17:04:38 | mordred | smcginnis: _seriously_ | |
| 17:08:06 | dtantsur | ... and I'm not even officially assigned to work on SDK ... | |
| 17:09:52 | smcginnis | Heh, I'm not even officially assigned to work on OpenStack. I just have a hard time moving on. :D | |
| 17:10:02 | dtantsur | oh wow | |
| 17:10:42 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node https://review.opendev.org/711032 | |
| 17:11:17 | openstackgerrit | Riccardo Pittau proposed openstack/openstacksdk master: Add retired and retired_reason fields to baremetal node https://review.opendev.org/711032 | |
| 17:20:58 | mordred | dtantsur: I've *never* been officially assigned to work on SDK ;) | |
| 17:21:05 | dtantsur | LOOOL | |
| 17:37:28 | umbSublime | Is it possible to specify microversion to use on openstack.proxy.Proxy calls. Or at least force one to be used by the proxy. I know I've asked this in the past, but it wasn't possible then. Maybe it is now ? | |
| 17:41:30 | umbSublime | I still get None on for example conn.compute.min_version and conn.compute.max_version yet information is there when inspecting: conn.compute.get_all_version_data() | |
| 17:43:43 | umbSublime | openstack.version.__version__ == 0.41.0, keystoneauth1.__version__ == 3.18.0 | |
| 17:44:17 | mordred | umbSublime: the intent is that as a user of the library you should never have to specify a microversion - let me look at the min_version / max_version thing ... what are you trying to do that isn't working? (other than specifying a microversion) | |
| 17:44:59 | mordred | (I believe we did add the ability for you to force one - but I'm more curious why you need to) | |
| 17:47:55 | umbSublime | Well say I cann conn.compute.hypervisors(), then the 'id' is an int while when using microversion 2.53 I get UUIDs. Same can be observed with openstackclient: `openstack hypervisor list` vs `openstack --os-compute-api-version 2.53 hypervisor list` | |
| 17:49:05 | umbSublime | I can force it with conn.compute.get('/os-hypervisors', microversion="2.53"). But it would be awesome if i could do conn.compute.hypervisors(microversion="2.53") | |
| 17:49:40 | mordred | should we not maybe just default to 2.53 if it's available in this case? | |
| 17:50:01 | umbSublime | yes or whatever the max_microversion is for the endpoint | |
| 17:51:26 | mordred | well - we have to pick max_microversion we can support- this doesn't sound like one we'd need to update anything else in the sdk to support, so it's pretty easy (sometimes thigs change key names or the liek and we need to add compat code to be able to safely provide them) | |
| 17:52:19 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Set max_microversion to 2.53 for hypervisors https://review.opendev.org/711294 | |
| 17:52:26 | umbSublime | so then each api call requiring a specific microversion should be hard-coded on sdk side ? | |