Earlier  
Posted Nick Remark
#openstack-sdks - 2020-01-09
16:17:38 sshnaidm next question - python 2/3 compatibility
16:17:49 sshnaidm Ansible supports from 2.6(?), but Openstack is moving to 3 completely. Should we stick to Ansible and support from 2.6/2.7?
16:18:18 dtantsur if openstacksdk drops python 2, we cannot support it
16:18:23 sshnaidm dtantsur, we can use it for this topic ^ )
16:18:30 dtantsur haha, let's try
16:18:44 dtantsur #startvote Should we let Python 2 live? Yes, No, OMG
16:18:45 openstack Begin voting on: Should we let Python 2 live? Valid vote options are Yes, No, OMG.
16:18:46 openstack Vote using '#vote OPTION'. Only your last vote counts.
16:18:54 sshnaidm OMG
16:19:01 sshnaidm #vote OMG
16:19:09 dtantsur #vote No
16:19:41 gtema #vote hehe
16:19:41 openstack gtema: hehe is not a valid option. Valid options are Yes, No, OMG.
16:19:42 sshnaidm interesting, what gundalow thinks about it, but we'll know that only next week
16:19:45 dtantsur To elaborate on my vote: we're planning something forward-looking, and Python 2 is dead today
16:19:48 gtema # vote no
16:19:53 gtema #vote no
16:20:18 dtantsur anyone else wants to play with the vote functionality? :)
16:20:42 gtema #vote again - no
16:20:43 openstack gtema: again - no is not a valid option. Valid options are Yes, No, OMG.
16:20:47 sshnaidm gtema, dtantsur made it case sensitive :o
16:20:56 dtantsur it's not case sensitive, but it requires a valid option
16:21:03 gtema doesn't looke like that
16:21:08 dtantsur #endvote
16:21:09 openstack Voted on "Should we let Python 2 live?" Results are
16:21:10 openstack OMG (1): sshnaidm
16:21:11 gtema simly "no" was accepted
16:21:12 openstack No (2): gtema, dtantsur
16:21:16 dtantsur as you see ^^
16:21:19 sshnaidm ah, worked
16:21:52 sshnaidm ok, I hope Ansible people won't be mad we break their 2.7 support..
16:22:02 mordred sorry - juggling two meetings - #vote no :)
16:22:14 gtema too late
16:22:27 sshnaidm too late, we decided no :)
16:22:30 mordred looks like there were no yes votes anyway :)
16:22:31 dtantsur #agreed Unless gundalow objects next week, we won't keep Python 2 support
16:22:36 mordred \o/
16:22:42 sshnaidm mordred, you just want to join the winning part!
16:22:44 mordred I mean - sdk isn't keeping python 2 support anyway
16:22:56 mordred so, you know, don't know that these modules have much choice :)
16:23:01 dtantsur :D
16:23:03 gtema yeah, but so far we haven't stripped it off
16:23:09 mordred this is true
16:23:14 mordred we *have* removed testing
16:23:35 gtema yes, that's true. But I explicitely was not starting to drop "six"
16:23:38 gtema hehe
16:23:39 dtantsur not tested == broken
16:23:52 sshnaidm very true ^
16:24:18 gtema you forgot "if" in a comparison
16:24:26 sshnaidm ok, I think we finished all topics from agenda, and now - open discussions
16:24:29 dtantsur it's a boolean expression
16:24:52 gtema then it should be a single "="
16:25:11 sshnaidm gtema, in boolean?
16:25:14 dtantsur gtema: I'm thinking in python :)
16:25:41 gtema open discussion - what is with jobs for proper testing and releasing?
16:26:07 sshnaidm gtema, good question
16:26:47 sshnaidm I configured a job that doesn't test anything for now
16:26:48 sshnaidm https://review.opendev.org/#/c/698085/
16:26:50 dtantsur on opendev writing jobs should be easier
16:27:09 sshnaidm it's a job that always was running in ansible patches
16:27:24 gtema everything is easy until you start doing that
16:27:32 sshnaidm so I'll configure it to run on current repo and it will be a start
16:28:06 sshnaidm we can run some tripleo jobs as well
16:28:12 gtema should we move func tests from SDK here, or link to SDK?
16:28:33 dtantsur I have a feeling that the new repo is a better place for tests
16:28:46 gtema and basically those SDK func tests must install collection first
16:28:54 gtema me too
16:29:03 gtema (not this "me too")
16:29:16 sshnaidm gtema, and apply a patch I suppose..
16:29:30 gtema well, you can install collection from local
16:29:50 sshnaidm gtema, yeah, I think you make a tarball and then install it, iirc
16:29:53 gtema so it's basically just "ansible-galaxy collection build && ansible-galaxy collection install"
16:29:59 gtema exactly
16:30:00 sshnaidm yep
16:30:40 dtantsur zuul applies patches for you
16:30:43 sshnaidm well, I think it will be more clear when we move it finally
16:31:06 sshnaidm I'm not familiar with SDK jobs
16:31:18 sshnaidm but do we have there something
16:31:26 sshnaidm that can be helpful for modules as well?
16:31:35 gtema there are tests for modules
16:31:56 sshnaidm I suppose we need installed Openstack to run modules that change it
16:32:05 sshnaidm devstack, tripleo, whatever
16:32:06 gtema https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/ansible
16:32:10 mordred yah - there is a module function test job that runs against devstack
16:32:24 mordred I totally agree, those should move into the collection repo once we've got it
16:32:35 mordred and we can still also trigger it from sdk for cross-testing
16:32:46 gtema sure
16:33:04 mordred essentially, it runs devstack and then runs the module tests against the api endpoint from the devstack
16:33:10 mordred it's not COMPREHENSIVE
16:33:16 mordred but it's a solid starting place
16:34:17 sshnaidm as I see there are test actions, but not verifications..? like in https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/ansible/roles/keystone_domain/tasks/main.yml
16:34:29 dtantsur ironic coverage can be provided by bifrost
16:34:33 gtema right
16:34:55 mordred sshnaidm: well, the verifications are a little implicit for now
16:35:25 mordred that update isn't going to work if the create didn't, etc ... but we can *definitely* improve these and make them better
16:35:29 mordred and should
16:35:46 mordred it's been harder to improve that with the modules in ansible/ansible and the tests in openstacksdk
16:36:09 sshnaidm yeah, maybe using molecule will be helpful too
16:36:34 mordred yah - maybe so - I hear you know something about that :)
16:36:34 sshnaidm for testing on various platforms for example

Earlier   Later