| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2020-01-09 | |||
| 16:22:30 | mordred | looks like there were no yes votes anyway :) | |
| 16:22:31 | dtantsur | #agreed Unless gundalow objects next week, we won't keep Python 2 support | |
| 16:22:36 | mordred | \o/ | |
| 16:22:42 | sshnaidm | mordred, you just want to join the winning part! | |
| 16:22:44 | mordred | I mean - sdk isn't keeping python 2 support anyway | |
| 16:22:56 | mordred | so, you know, don't know that these modules have much choice :) | |
| 16:23:01 | dtantsur | :D | |
| 16:23:03 | gtema | yeah, but so far we haven't stripped it off | |
| 16:23:09 | mordred | this is true | |
| 16:23:14 | mordred | we *have* removed testing | |
| 16:23:35 | gtema | yes, that's true. But I explicitely was not starting to drop "six" | |
| 16:23:38 | gtema | hehe | |
| 16:23:39 | dtantsur | not tested == broken | |
| 16:23:52 | sshnaidm | very true ^ | |
| 16:24:18 | gtema | you forgot "if" in a comparison | |
| 16:24:26 | sshnaidm | ok, I think we finished all topics from agenda, and now - open discussions | |
| 16:24:29 | dtantsur | it's a boolean expression | |
| 16:24:52 | gtema | then it should be a single "=" | |
| 16:25:11 | sshnaidm | gtema, in boolean? | |
| 16:25:14 | dtantsur | gtema: I'm thinking in python :) | |
| 16:25:41 | gtema | open discussion - what is with jobs for proper testing and releasing? | |
| 16:26:07 | sshnaidm | gtema, good question | |
| 16:26:47 | sshnaidm | I configured a job that doesn't test anything for now | |
| 16:26:48 | sshnaidm | https://review.opendev.org/#/c/698085/ | |
| 16:26:50 | dtantsur | on opendev writing jobs should be easier | |
| 16:27:09 | sshnaidm | it's a job that always was running in ansible patches | |
| 16:27:24 | gtema | everything is easy until you start doing that | |
| 16:27:32 | sshnaidm | so I'll configure it to run on current repo and it will be a start | |
| 16:28:06 | sshnaidm | we can run some tripleo jobs as well | |
| 16:28:12 | gtema | should we move func tests from SDK here, or link to SDK? | |
| 16:28:33 | dtantsur | I have a feeling that the new repo is a better place for tests | |
| 16:28:46 | gtema | and basically those SDK func tests must install collection first | |
| 16:28:54 | gtema | me too | |
| 16:29:03 | gtema | (not this "me too") | |
| 16:29:16 | sshnaidm | gtema, and apply a patch I suppose.. | |
| 16:29:30 | gtema | well, you can install collection from local | |
| 16:29:50 | sshnaidm | gtema, yeah, I think you make a tarball and then install it, iirc | |
| 16:29:53 | gtema | so it's basically just "ansible-galaxy collection build && ansible-galaxy collection install" | |
| 16:29:59 | gtema | exactly | |
| 16:30:00 | sshnaidm | yep | |
| 16:30:40 | dtantsur | zuul applies patches for you | |
| 16:30:43 | sshnaidm | well, I think it will be more clear when we move it finally | |
| 16:31:06 | sshnaidm | I'm not familiar with SDK jobs | |
| 16:31:18 | sshnaidm | but do we have there something | |
| 16:31:26 | sshnaidm | that can be helpful for modules as well? | |
| 16:31:35 | gtema | there are tests for modules | |
| 16:31:56 | sshnaidm | I suppose we need installed Openstack to run modules that change it | |
| 16:32:05 | sshnaidm | devstack, tripleo, whatever | |
| 16:32:06 | gtema | https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/ansible | |
| 16:32:10 | mordred | yah - there is a module function test job that runs against devstack | |
| 16:32:24 | mordred | I totally agree, those should move into the collection repo once we've got it | |
| 16:32:35 | mordred | and we can still also trigger it from sdk for cross-testing | |
| 16:32:46 | gtema | sure | |
| 16:33:04 | mordred | essentially, it runs devstack and then runs the module tests against the api endpoint from the devstack | |
| 16:33:10 | mordred | it's not COMPREHENSIVE | |
| 16:33:16 | mordred | but it's a solid starting place | |
| 16:34:17 | sshnaidm | as I see there are test actions, but not verifications..? like in https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/ansible/roles/keystone_domain/tasks/main.yml | |
| 16:34:29 | dtantsur | ironic coverage can be provided by bifrost | |
| 16:34:33 | gtema | right | |
| 16:34:55 | mordred | sshnaidm: well, the verifications are a little implicit for now | |
| 16:35:25 | mordred | that update isn't going to work if the create didn't, etc ... but we can *definitely* improve these and make them better | |
| 16:35:29 | mordred | and should | |
| 16:35:46 | mordred | it's been harder to improve that with the modules in ansible/ansible and the tests in openstacksdk | |
| 16:36:09 | sshnaidm | yeah, maybe using molecule will be helpful too | |
| 16:36:34 | mordred | yah - maybe so - I hear you know something about that :) | |
| 16:36:34 | sshnaidm | for testing on various platforms for example | |
| 16:36:43 | gtema | not definitely - you want to mess with devstack and molecule? | |
| 16:36:50 | sshnaidm | mordred, yeah, we use it heavily now | |
| 16:37:11 | sshnaidm | devstack is providing openstack cloud | |
| 16:37:28 | sshnaidm | but all tests can be wrapped in molecule | |
| 16:38:11 | sshnaidm | for last triple module I just used keystone container for testing | |
| 16:38:30 | sshnaidm | and running os_keystone_* tasks with it | |
| 16:38:42 | sshnaidm | not even whole openstack | |
| 16:38:59 | sshnaidm | the same tried with ironic dev container | |
| 16:39:30 | mordred | cool | |
| 16:40:07 | mordred | like - my brain doesn't necessarily know how that all hangs together, but I could imagine seeing some patches would bea . good learning experience all around | |
| 16:40:07 | sshnaidm | OK, I think we agreed to design a good testing for modules after a move | |
| 16:40:14 | mordred | ++ | |
| 16:40:55 | sshnaidm | anything else in your minds? | |
| 16:41:35 | sshnaidm | OK, I think we're good for today | |
| 16:41:44 | sshnaidm | and welcome back everyone | |
| 16:41:51 | mordred | happy new year! | |
| 16:42:01 | sshnaidm | +1 | |
| 16:42:09 | sshnaidm | #endmeeting | |
| 16:42:11 | openstack | Meeting ended Thu Jan 9 16:42:09 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | |
| 16:42:12 | openstack | Minutes: http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-09-16.00.html | |
| 16:42:13 | openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-09-16.00.txt | |
| 16:42:14 | openstack | Log: http://eavesdrop.openstack.org/meetings/api_sig/2020/api_sig.2020-01-09-16.00.log.html | |
| 17:10:27 | openstackgerrit | Sean McGinnis proposed openstack/os-client-config master: Add a release note for Python 2 support removal https://review.opendev.org/701761 | |
| 17:10:27 | openstackgerrit | Sean McGinnis proposed openstack/os-client-config master: Fix pep8 issue in o_c_c/__init__ https://review.opendev.org/701773 | |
| 17:19:53 | smcginnis | mordred and/or amotoki: Could you push through that stack? ^ | |
| 17:20:09 | smcginnis | Pretty trivial, then we can get a release request for milestone 1 updated and get that out. | |
| 17:21:33 | amotoki | smcginnis: I have no +2 right on os-client-config. we need to wait mordred | |
| 17:21:46 | smcginnis | amotoki: OK, thanks for reviewing! | |
| 17:21:53 | mordred | smcginnis: +A | |
| 17:22:09 | smcginnis | Awesome, thanks | |
| 17:27:07 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/openstacksdk master: "qos_network_policy_id" attribute added to port resource https://review.opendev.org/693247 | |
| 17:54:05 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/python-openstackclient master: Add qos_network_policy_id to network port https://review.opendev.org/701786 | |
| 17:56:11 | KeithMnemonic | any chance to please get these moving along? https://review.opendev.org/#/c/701293/ https://review.opendev.org/#/c/701378/ dtroyer, amotoki | |
| 17:58:38 | openstackgerrit | Merged openstack/openstacksdk master: Replace six.iteritems() with .items() https://review.opendev.org/701729 | |