| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-sdks - 2019-08-16 | |||
| 15:14:19 | efried | ugh https://github.com/openstack/heat/blob/master/heat/common/config.py#L550 -- they should really be using ks loading | |
| 15:14:30 | cmorpheus | yep :( | |
| 15:14:40 | efried | so | |
| 15:14:53 | mordred | this is just an attempt to nerdsnipe me in to rewriting this code in heat isn' tit? | |
| 15:15:05 | efried | rather than ask ksa to retrofit to support them doing stuff the old way, we should ask them to get with the times | |
| 15:15:10 | cmorpheus | mordred: is it working? | |
| 15:15:15 | mordred | cmorpheus: it's getting close | |
| 15:16:37 | efried | I would say -1 that patch and tell them to do ^ first, unless they can give some really good reason that's not viable. | |
| 15:18:28 | efried | If it helps, here's how nova does it: | |
| 15:18:28 | efried | get_ksa_adapter (uses load_adapter_from_conf_options): https://opendev.org/openstack/nova/src/branch/master/nova/utils.py#L1194 | |
| 15:18:28 | efried | _get_auth_and_session (uses load_{auth|session}_from_conf_options): https://opendev.org/openstack/nova/src/branch/master/nova/utils.py#L1176 | |
| 15:19:21 | cmorpheus | sweet, thanks for the input guys | |
| 15:20:42 | efried | and this stuff https://github.com/openstack/heat/blob/master/heat/common/config.py#L331-L367 | |
| 15:20:42 | efried | should be replaced by something more like https://opendev.org/openstack/nova/src/branch/master/nova/conf/utils.py#L58 | |
| 15:21:04 | efried | (ks_loading.register_*_conf_options ^ ) | |
| 16:07:18 | mordred | kmalloc: if you get a sec, would you look at https://review.opendev.org/#/c/675187/ and https://review.opendev.org/#/c/675130 - I think you've probably got more context on that than most people | |
| 16:10:10 | kmalloc | looking | |
| 16:10:42 | kmalloc | ooh those ones.. going to take me a few to review it, want to make sure the use is sane. | |
| 16:23:45 | mordred | kmalloc: yes please | |
| 18:50:12 | kmalloc | mordred: phew, this review is making my brain work :) | |
| 18:50:22 | kmalloc | mordred: because i need to keep looking at the fixture :P | |
| 18:50:30 | kmalloc | i *think* your changes are right. | |
| 19:06:27 | mordred | kmalloc: they seem to work at least ... | |
| 19:07:06 | mordred | kmalloc: the goal here is to pull all of the stuff you did with requests-mock into a fixture that provides catalogs and discovery documents and methods to manipulate those things based on the published ksa fixtures | |
| 19:07:11 | mordred | this was step one | |
| 19:07:23 | mordred | kmalloc: but yeah - it's ... right down deep in there | |
| 20:02:20 | kmalloc | yup | |
| 21:17:08 | kmalloc | mordred: added comment to https://review.opendev.org/#/c/675130/, it looks correct but I am confirming an assertion the test is making. | |
| #openstack-sdks - 2019-08-19 | |||
| 02:14:40 | openstackgerrit | Takashi Kajinami proposed openstack/python-openstackclient master: Add parent project filter for listing projects https://review.opendev.org/677103 | |
| 03:02:01 | openstackgerrit | Takashi Kajinami proposed openstack/python-openstackclient master: Add parent project filter for listing projects https://review.opendev.org/677103 | |
| 14:53:26 | kmalloc | mordred: +1 on both of those changes from late last week (cc Shrews ) | |
| 15:36:58 | mordred | kmalloc: sweet - thanks! | |
| 15:37:42 | kmalloc | mordred: yeah, took a bit longer than expected. but once i revisited with coffee in hand, the second one was way easier | |
| 15:38:00 | mordred | mmm. coffee | |
| 15:42:12 | kmalloc | mordred: next, deploying gitea locally to poke at lots of settings. | |
| 15:42:21 | kmalloc | thankfully, that is really easy | |
| 15:42:39 | kmalloc | mordred: so very much deathwish coffee. | |
| 15:42:52 | kmalloc | mordred: we pretty much drink exclusively valhalla java ;) | |
| 17:34:03 | tobiash | does openstacksdk support the sharing of images? | |
| 17:34:12 | tobiash | I didn't find it in the docs | |
| 17:40:41 | efried | tobiash: what do you mean "sharing of images"? | |
| 17:40:46 | efried | What API specifically? | |
| 17:41:05 | tobiash | efried: you can share an image with another tenant | |
| 17:41:23 | efried | a lot of the docs aren't really complete; they just front a particular API operation with generic passthrough arguments/payloads | |
| 17:41:25 | tobiash | efried: I mean this one: https://docs.openstack.org/image-guide/share-images.html | |
| 17:41:40 | efried | so the fact you can't find it in the docs doesn't mean it's not supported... but would take a sec to track down. Looking... | |
| 17:43:05 | efried | tobiash: So we're looking for support of these operations https://docs.openstack.org/api-ref/image/v2/index.html#sharing ? | |
| 17:44:39 | tobiash | efried: yes, what I'm currently doing is 'openstack image set --shared <id>', then 'openstack image add project <id>' and then the accept in the other project | |
| 17:44:53 | tobiash | and I wondered if that's directly possible using openstacksdk | |
| 17:45:17 | tobiash | I think that translates to those calls | |
| 17:45:23 | efried | tobiash: Well, it's certainly directly possible; if nothing else you could do it with Connection.image.get/.put/.post/etc. | |
| 17:46:26 | tobiash | efried: oh, I think I found it: https://docs.openstack.org/openstacksdk/latest/user/proxies/image_v2.html#member-operations | |
| 17:46:40 | efried | ...yup | |
| 17:46:44 | tobiash | I just looked for the wrong keywords | |
| 17:46:45 | efried | I was just getting there, but from code :) | |
| 17:46:47 | tobiash | thanks :) | |
| 17:47:15 | efried | tobiash: what would be useful is if links into the api-ref were added to those docstrings | |
| 17:47:37 | tobiash | yes | |
| 17:47:42 | efried | like this: | |
| 17:47:43 | efried | https://review.opendev.org/#/c/659068/ | |
| 17:47:58 | efried | ...especially for the ones where there's a generic **attrs etc. | |
| 17:49:04 | efried | If you want to propose something, I'd be delighted to review it. | |
| 17:50:06 | efried | tobiash: IMO it would also be neat if https://docs.openstack.org/image-guide/share-images.html linked into the API-ref, especially where it actually mentions API operations. | |
| 17:52:05 | efried | ...that appears to live in the openstack-manuals project | |
| 18:05:01 | openstackgerrit | Tobias Henkel proposed openstack/openstacksdk master: Add link to image sharing api docs https://review.opendev.org/677266 | |
| 18:05:08 | tobiash | efried: like this? ^ | |
| 18:07:51 | efried | tobiash: Yeah, that lgtm. | |
| 18:07:58 | tobiash | :) | |
| 18:08:24 | efried | tobiash: I think you're missing end backticks on your links tho | |
| 18:08:31 | tobiash | oops | |
| 18:09:11 | openstackgerrit | Tobias Henkel proposed openstack/openstacksdk master: Add link to image sharing api docs https://review.opendev.org/677266 | |
| 19:24:26 | openstackgerrit | Merged openstack/openstacksdk master: Add 'node' attribute to baremetal Allocation https://review.opendev.org/676521 | |
| 19:28:41 | efried | mordred: https://review.opendev.org/#/c/675130/ docs question in there. If I'm wrong, lmk and I'll +W | |
| 19:35:24 | openstackgerrit | Andreas Jaeger proposed openstack/shade master: Switch openSUSE job name https://review.opendev.org/677286 | |
| 20:49:27 | efried | mordred: ugh https://review.opendev.org/#/c/676837/ | |
| #openstack-sdks - 2019-08-20 | |||
| 12:21:05 | mordred | efried: ugh. also weird - because those UTs worked for me locally. I'll dig back in. | |
| 12:21:47 | mordred | efried: your comment is why I switched the test in the validation code to be for service_url ... that should be null if there was nothing found via discovery | |
| 12:39:10 | efried | mordred: aha, you mean EndpointData.service_url being None is a good indicator? | |
| 12:39:26 | efried | Cause right now the var we're calling service_url is actually an EndpointData | |
| 12:39:39 | efried | I can fix that... | |
| 12:41:01 | openstackgerrit | Eric Fried proposed openstack/openstacksdk master: Add strict_proxies option for Connection https://review.opendev.org/676837 | |
| 12:41:12 | efried | mordred: ^ thanks for the pointer. You make this seem easy | |
| 12:41:57 | mordred | efried: oh yeah - that should be much better | |
| 12:42:50 | mordred | efried: I feel like between the two of us we usually have at least 80% of a given topic paged in | |
| 12:42:59 | efried | heh | |
| 12:43:12 | efried | mordred: oh, did you see the comment on the endpoint_for patch? | |
| 12:44:11 | mordred | efried: yes - let me make a quick update | |
| 12:45:36 | efried | I assume one is allowed to apply "fast approve" rules in cases like this? (Assuming the update is trivial) | |
| 12:45:58 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog https://review.opendev.org/675130 | |
| 12:45:59 | openstackgerrit | Monty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187 | |
| 12:46:03 | mordred | efried: yup | |
| 12:46:17 | mordred | efried: generally speaking we don't stand on ceremony too much in these parts | |
| 12:46:32 | efried | it's the wild wild west | |
| 12:47:01 | efried | oh, that's a tilde? My wife will be so pleased. | |
| 12:47:12 | mordred | it is? | |
| 12:47:16 | mordred | wait - is it not? | |
| 12:47:24 | efried | ...um | |
| 12:47:35 | efried | not if it's going to be the same as the other examples in the project | |
| 12:48:59 | mordred | it should be a ~ - which says to elide the class/module information in the text and only print the method name, rather than the whole thing | |
| 12:49:01 | efried | I am quite unfamiliar with docs-built-from-docstrings, so following examples elsewhere in the project is all I have to go on. | |