Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-08-19
17:46:40 efried ...yup
17:46:44 tobiash I just looked for the wrong keywords
17:46:45 efried I was just getting there, but from code :)
17:46:47 tobiash thanks :)
17:47:15 efried tobiash: what would be useful is if links into the api-ref were added to those docstrings
17:47:37 tobiash yes
17:47:42 efried like this:
17:47:43 efried https://review.opendev.org/#/c/659068/
17:47:58 efried ...especially for the ones where there's a generic **attrs etc.
17:49:04 efried If you want to propose something, I'd be delighted to review it.
17:50:06 efried tobiash: IMO it would also be neat if https://docs.openstack.org/image-guide/share-images.html linked into the API-ref, especially where it actually mentions API operations.
17:52:05 efried ...that appears to live in the openstack-manuals project
18:05:01 openstackgerrit Tobias Henkel proposed openstack/openstacksdk master: Add link to image sharing api docs https://review.opendev.org/677266
18:05:08 tobiash efried: like this? ^
18:07:51 efried tobiash: Yeah, that lgtm.
18:07:58 tobiash :)
18:08:24 efried tobiash: I think you're missing end backticks on your links tho
18:08:31 tobiash oops
18:09:11 openstackgerrit Tobias Henkel proposed openstack/openstacksdk master: Add link to image sharing api docs https://review.opendev.org/677266
19:24:26 openstackgerrit Merged openstack/openstacksdk master: Add 'node' attribute to baremetal Allocation https://review.opendev.org/676521
19:28:41 efried mordred: https://review.opendev.org/#/c/675130/ docs question in there. If I'm wrong, lmk and I'll +W
19:35:24 openstackgerrit Andreas Jaeger proposed openstack/shade master: Switch openSUSE job name https://review.opendev.org/677286
20:49:27 efried mordred: ugh https://review.opendev.org/#/c/676837/
#openstack-sdks - 2019-08-20
12:21:05 mordred efried: ugh. also weird - because those UTs worked for me locally. I'll dig back in.
12:21:47 mordred efried: your comment is why I switched the test in the validation code to be for service_url ... that should be null if there was nothing found via discovery
12:39:10 efried mordred: aha, you mean EndpointData.service_url being None is a good indicator?
12:39:26 efried Cause right now the var we're calling service_url is actually an EndpointData
12:39:39 efried I can fix that...
12:41:01 openstackgerrit Eric Fried proposed openstack/openstacksdk master: Add strict_proxies option for Connection https://review.opendev.org/676837
12:41:12 efried mordred: ^ thanks for the pointer. You make this seem easy
12:41:57 mordred efried: oh yeah - that should be much better
12:42:50 mordred efried: I feel like between the two of us we usually have at least 80% of a given topic paged in
12:42:59 efried heh
12:43:12 efried mordred: oh, did you see the comment on the endpoint_for patch?
12:44:11 mordred efried: yes - let me make a quick update
12:45:36 efried I assume one is allowed to apply "fast approve" rules in cases like this? (Assuming the update is trivial)
12:45:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog https://review.opendev.org/675130
12:45:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
12:46:03 mordred efried: yup
12:46:17 mordred efried: generally speaking we don't stand on ceremony too much in these parts
12:46:32 efried it's the wild wild west
12:47:01 efried oh, that's a tilde? My wife will be so pleased.
12:47:12 mordred it is?
12:47:16 mordred wait - is it not?
12:47:24 efried ...um
12:47:35 efried not if it's going to be the same as the other examples in the project
12:48:59 mordred it should be a ~ - which says to elide the class/module information in the text and only print the method name, rather than the whole thing
12:49:01 efried I am quite unfamiliar with docs-built-from-docstrings, so following examples elsewhere in the project is all I have to go on.
12:49:07 mordred but I'm still on coffee #1
12:49:29 efried oic.
12:49:46 efried do we actually want to do that here?
12:50:00 mordred it's a good question - we do it a lot in other places ...
12:50:01 efried since they're in different classes?
12:50:22 mordred yeah
12:50:28 mordred git grep ':meth:..openstack' | wc -l ... 31
12:50:57 mordred I can't find any places where we say :meth:`openstack
12:51:48 efried uhm
12:51:58 efried this is a problem with my terminal font
12:52:11 efried My tilde looks like a hyphen
12:52:14 mordred you should get a different terminal font!
12:52:19 efried apparently
12:52:30 mordred I'm a big fan of https://sourcefoundry.org/hack/
12:52:33 efried browser/gerrit is okay
12:52:38 efried it's my xterm
12:53:07 efried if I put 'em right next to each other, the tilde is one pixel higher. But otherwise identical to the hyphen. That's not good.
12:53:25 mordred no - because they have very different meanings
12:54:39 efried I've never seen a tilde used in python before, so I guess I didn't care.
13:01:33 efried hack installed
13:01:54 efried that's a very clear font; I was able to reduce my font size significantly and thereby fit much more on a screen, which is a big deal for me.
13:05:47 mordred \o/
15:04:19 efried mordred, Shrews: https://review.opendev.org/676837 is passing zuul now.
15:39:00 openstackgerrit Matt Riedemann proposed openstack/python-openstackclient master: Document 2.53 behavior for compute service list/delete https://review.opendev.org/672807
15:40:02 mordred efried: woot!
16:25:11 openstackgerrit Merged openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog https://review.opendev.org/675130
17:53:34 openstackgerrit Merged openstack/python-openstackclient master: Fix compute service set handling for 2.53+ https://review.opendev.org/672577
17:58:31 openstackgerrit Merged openstack/python-openstackclient master: Support type=image with --block-device-mapping option https://review.opendev.org/673340
18:10:21 openstackgerrit Merged openstack/python-openstackclient master: Fix description for --block-device-mapping https://review.opendev.org/674105
18:10:22 openstackgerrit Merged openstack/python-openstackclient master: Add openstack server create --boot-from-volume option https://review.opendev.org/674111
18:12:21 openstackgerrit Merged openstack/python-openstackclient master: Add 'openstack server resize (confirm|revert)' commands https://review.opendev.org/665357
18:31:15 tobiash mordred: can it be that server creation in openstacksdk relies on listing images even if an image id is specified? I'm getting weird stack traces when trying to spawn new instances using a shared but not accepted (-> usable but not listed) image.
18:33:48 tobiash mordred: the stack trace is http://paste.openstack.org/show/760330/
18:34:06 tobiash when accepting the image before (thus it is listed in the image list) then it works
18:37:49 tobiash mordred: ah, if I give it the image object it also works without accepting
18:54:24 Shrews tobiash: iirc, an image lookup is always done to get the id, but don't recall atm
18:55:08 tobiash Shrews: k, thx I found a way :)
#openstack-sdks - 2019-08-21
06:33:53 openstackgerrit Rabi Mishra proposed openstack/keystoneauth master: Allow initializing session with connection retries https://review.opendev.org/676648
09:49:03 openstackgerrit Rabi Mishra proposed openstack/keystoneauth master: Allow initializing session with connection retries https://review.opendev.org/676648
10:46:17 openstackgerrit Maxim Babushkin proposed openstack/openstacksdk master: Add 'tag' support to compute with supported microversion https://review.opendev.org/675306
11:25:36 openstackgerrit Merged openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
12:54:37 mordred tobiash: yah - it'll do an image lookup if you just pass a string. if you pass an image object or a dict with id field, it'll know you're passing an id
12:58:18 openstackgerrit Ghislain Bourgeois proposed openstack/openstacksdk master: Fix AttributeError bug when creating nested stacks https://review.opendev.org/677718
17:37:42 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Remove token_endpoint auth type https://review.opendev.org/677795
20:34:20 efried Shrews: Would you mind giving this a look? https://review.opendev.org/#/c/676837/
20:36:07 efried Hm, I thought I was wanting that ^ and ... something else to get a new release cut, but now I'm not sure there's actually anything else I wanted.
23:26:00 openstackgerrit Merged openstack/openstacksdk master: Add 'tag' support to compute with supported microversion https://review.opendev.org/675306
#openstack-sdks - 2019-08-22
00:39:53 openstackgerrit Colleen Murphy proposed openstack/python-openstackclient master: Add support for app cred access rules https://review.opendev.org/677857
07:37:32 openstackgerrit Merged openstack/openstacksdk master: Fix AttributeError bug when creating nested stacks https://review.opendev.org/677718
08:48:47 openstackgerrit yanpuqing proposed openstack/openstacksdk master: Add a message explaining that OS_AUTH_TYPE is not set properly https://review.opendev.org/677940
10:52:31 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Bump hacking version https://review.opendev.org/665358
10:55:14 openstackgerrit Stephen Finucane proposed openstack/python-openstackclient master: Add 'openstack server migrate (confirm|revert)' commands https://review.opendev.org/664393

Earlier   Later