Earlier  
Later
New Search
Posted Nick Remark
#openstack-sdks - 2019-08-08
21:31:29 efried I mean, I'm happy having tested this live, BUT I only tested it with a nice clean default devstack service catalog and conf
21:31:31 mordred efried: oh - I don't know if you saw - patch one on on the path to getting you a reusable fixture is actually working now
21:31:43 efried nice
21:31:58 mordred efried: people use openstack in some configuration that isn't a nice clean default devstack?
21:32:20 efried ...I didn't put it through the paces of endpoint_override, weird service catalog entries, non-default interfaces, weird version requests....
21:35:00 mordred yeah. well - so - the nice thing here (and we should do all of those things) - but the nice thing about this patch is it basically says "if we don't know anything, just defer 100% to the existing and already tested elsewhere adapter creation logic"
21:35:26 mordred so all the other combos *should* be covered already
21:35:43 mordred but that's me rationalizing a scenario that clearly needs some coverage :)
21:47:48 Shrews mordred: i insist on a test for the test as well
#openstack-sdks - 2019-08-09
08:29:06 openstackgerrit Loan Harrouin proposed openstack/openstacksdk master: Add get_actions for server resource https://review.opendev.org/675113
08:45:44 openstackgerrit Brin Zhang proposed openstack/python-openstackclient master: Add server migration list CLI https://review.opendev.org/675304
09:48:45 openstackgerrit Loan Harrouin proposed openstack/openstacksdk master: Add get_actions for server resource https://review.opendev.org/675113
10:04:08 openstackgerrit Loan Harrouin proposed openstack/openstacksdk master: Add get_actions for server resource https://review.opendev.org/675113
10:54:50 frickler kmalloc: mordred: I've refreshed the logs on my devstack patch dropping the admin endpoint, this is the error in h-eng that I'm failing to resolve https://logs.opendev.org/92/651492/7/check/openstacksdk-functional-devstack/afeaec0/controller/logs/screen-h-eng.txt.gz#_Aug_09_08_44_55_817151
10:56:34 frickler the traceback looks slightly similar to what cmurphy fixed for https://review.opendev.org/651790
11:15:46 mordred frickler: yeah - I think it means the devstack patch should also add interface=public to the middleware config - maybe that's just a thing that needs to be done for heat?
11:28:28 frickler mordred: I tested that locally for all different heat config sections I have found, but it didn't seem to make any difference.
11:28:39 mordred frickler: boo
11:28:52 mordred frickler: maybe cmurphy will know the magical answers whence she awakens
11:56:47 openstackgerrit Merged openstack/openstacksdk master: Initalize pool_executor so close works https://review.opendev.org/675120
12:12:18 openstackgerrit Shubham Potale proposed openstack/openstacksdk master: Add support for nfv-orchestration service https://review.opendev.org/675604
12:17:40 openstackgerrit Shubham Potale proposed openstack/python-openstackclient master: Add python-openstackclient support to vnf package APIs https://review.opendev.org/675609
12:17:40 openstackgerrit Shubham Potale proposed openstack/python-openstackclient master: Add commands for create and delete vnfpackage APIs https://review.opendev.org/675610
12:17:41 openstackgerrit Shubham Potale proposed openstack/python-openstackclient master: Add commands for list and show vnf package API's https://review.opendev.org/675611
12:17:41 openstackgerrit Shubham Potale proposed openstack/python-openstackclient master: Add command for upload vnf package API https://review.opendev.org/675612
12:23:27 openstackgerrit Shubham Potale proposed openstack/python-openstackclient master: Add python-openstackclient support to vnf package APIs https://review.opendev.org/675609
12:23:27 openstackgerrit Shubham Potale proposed openstack/python-openstackclient master: Add commands for create and delete vnfpackage APIs https://review.opendev.org/675610
12:23:28 openstackgerrit Shubham Potale proposed openstack/python-openstackclient master: Add commands for list and show vnf package API's https://review.opendev.org/675611
12:23:28 openstackgerrit Shubham Potale proposed openstack/python-openstackclient master: Add command for upload vnf package API https://review.opendev.org/675612
12:59:47 openstackgerrit Bence Romsics proposed openstack/openstacksdk master: Add router add/remove route operations https://review.opendev.org/674324
13:01:55 openstackgerrit Bence Romsics proposed openstack/python-openstackclient master: fixup! Add command: router add/remove route --route https://review.opendev.org/675618
13:04:55 openstackgerrit Bence Romsics proposed openstack/python-openstackclient master: Add command: router add/remove route --route https://review.opendev.org/674325
13:53:59 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename cloud_config to cloud_region https://review.opendev.org/675627
13:54:07 mordred dtantsur: ^^ I did the variable renaming in a followup
14:03:13 dtantsur cool!
14:06:29 openstackgerrit Artem Goncharov proposed openstack/openstacksdk master: Rework statistics reporting https://review.opendev.org/659841
14:35:17 cmurphy mordred: frickler no idea
15:10:44 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
15:10:45 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove container-infra.example.com hack https://review.opendev.org/675378
15:10:46 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename cloud_config to cloud_region https://review.opendev.org/675627
15:28:15 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Skip most service_description for unknown services https://review.opendev.org/675135
15:28:27 mordred Shrews, efried, mriedem: ^^ this time with a test
15:28:39 mordred (which even tests that no warnings are thrown)
15:35:58 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Allow services to override proxy creation. https://review.opendev.org/674110
15:36:05 mordred that has a test now too
15:36:40 mordred Shrews: that one should avoid the annoying warnings we get from swift about not being able to talk to the root url
15:42:09 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Skip most service_description for unknown services https://review.opendev.org/675135
15:42:09 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Allow services to override proxy creation. https://review.opendev.org/674110
15:42:10 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Fix discovery cache sharing https://review.opendev.org/675121
15:42:10 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Add support for global_request_id https://review.opendev.org/674807
15:42:11 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rationalize endpoint_for and get_endpoint_from_catalog https://review.opendev.org/675130
15:42:11 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Validate that connect_as connects as the project https://review.opendev.org/675178
15:42:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Replace catalog-v3.json with keystoneauth fixture https://review.opendev.org/675187
15:42:12 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Remove container-infra.example.com hack https://review.opendev.org/675378
15:42:13 openstackgerrit Monty Taylor proposed openstack/openstacksdk master: Rename cloud_config to cloud_region https://review.opendev.org/675627
15:42:55 mordred rebased the stack
15:48:22 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add 'openstack server resize (confirm|revert)' commands https://review.opendev.org/665357
15:58:43 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Add openstack server create --boot-from-volume option https://review.opendev.org/674111
16:00:20 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Fix compute service set handling for 2.53+ https://review.opendev.org/672577
16:36:23 openstackgerrit Dean Troyer proposed openstack/python-openstackclient master: Support type=image with --block-device-mapping option https://review.opendev.org/673340
16:38:53 dtroyer mriedem: I've mucked about with your bdm series (release notes), and likely in the wrong order so a bit of rebasing may be necessary. This one ^^^ I wondered about including the vda bit in the release note, will leave it to your discretion.
16:42:10 mriedem dtroyer: replied
16:42:44 dtroyer mriedem: thanks, agreed
16:44:40 openstackgerrit Matt Riedemann proposed openstack/python-openstackclient master: Fix description for --block-device-mapping https://review.opendev.org/674105
16:44:47 openstackgerrit Matt Riedemann proposed openstack/python-openstackclient master: Add openstack server create --boot-from-volume option https://review.opendev.org/674111
16:45:12 mriedem $ openstack server create --image $IMAGE_ID --block-device-mapping vda=$IMAGE_ID:image:1:true --flavor m1.tiny --wait test-vol-backed-vm-from-image The volume cannot be assigned the same device name as the root device vda (HTTP 400) (Request-ID: req-b4569b5f-4415-4911-9119-7afd856e2714)
16:45:42 mriedem from my earlier testing
16:45:59 dtroyer yup, that's a pretty clear error message
17:23:25 Shrews mordred: Should we just delete the openstacksdk-functional-devstack-magnum test, or do you know a magnum expert who might want to fix it? It never passes.
17:24:37 mordred Shrews: wow, and it fails "has service magnum"
17:24:53 mordred Shrews: I'd say it's pretty useless currently
17:25:04 Shrews mordred: yeah. i had a quick glance at it but couldn't figure out what, exactly, was wrong
17:29:41 openstackgerrit Merged openstack/python-openstackclient master: Make configuration show not require auth https://review.opendev.org/673110
17:32:50 efried !SHAZAM!
17:32:51 openstack efried: Error: "SHAZAM!" is not a valid command.
17:36:20 mordred efried: it's so sad that !SHAZAM! isn't a valid command
17:36:52 efried Maybe it doesn't work for everyone
17:37:23 efried Because, you see, now I *look* like a superhero, but I'm still an immature kid on the inside.
17:39:39 Shrews that movie disappointed me, particularly the ending
17:41:41 efried I went in with expectations too high, because a friend told me he really liked it.
17:42:38 efried mordred, Shrews: This seems... wrong: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/proxy.py#L129
17:42:43 efried The *args part
17:43:07 efried I don't think there's a way you can call that such that `args` has anything in it.
17:43:27 efried (slightly surprising that python even lets you define a param list that way, but I've seen it before)
17:46:43 mordred efried: I *think* if you were to call it like Proxy(session, statsd_client, statsd_prefix, prometheus_counter, prometheus_historgram, foo) that foo would wind up in *args
17:47:12 efried mordred: But then the super() call would blow up, nah?
17:47:20 mordred yeah - totally.
17:47:38 mordred we should get rid of that *args - I don't think we want people calling things with positional args anyway tbh
17:47:55 efried I always ask people to name kwargs
17:47:57 efried even in unit tests
17:48:00 mordred ++
17:48:16 efried but it's not especially enforceable
17:48:31 mordred in 3.6 it is ... foo(self, *, bar=None)
17:48:41 mordred defines bar as a keyword only argument
17:48:59 mordred so once we drop 2.7 - bob's our uncle
17:49:05 efried neat.
17:49:14 efried I had *two* uncle Bobs.
17:50:58 mordred HA bob
17:52:46 efried well, one of them failed, and hasn't been replaced, so...
17:53:57 mordred :(

Earlier   Later